Re: Review Board 1.0 RC3 released

2009-06-16 Thread Vesterbaek

Got a few rb-site upgrade warnings that I usually do not see:

sudo rb-site upgrade /var/www/reviewboard
Rebuilding directory structure
Updating database. This may take a while.
/var/lib/python-support/python2.6/MySQLdb/__init__.py:34:
DeprecationWarning: the sets module is deprecated
  from sets import ImmutableSet
Upgrading Review Board from 1.0rc2 to 1.0rc3
There are unapplied evolutions for reviews.
There are unapplied evolutions for reviews.
Project signature has changed - an evolution is required
Project signature has changed - an evolution is required
Installing json fixture 'initial_data' from '/usr/local/lib/python2.6/
dist-packages/ReviewBoard-1.0rc3-py2.6.egg/reviewboard/scmtools/
fixtures'.
Installed 6 object(s) from 1 fixture(s)
Evolution could not be simulated, possibly due to raw SQL mutations
Evolution successful.

 ... but things seems to work fine.

Thanks
 -- Jeppe
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Review Board 1.0 RC3 released

2009-06-16 Thread Christian Hammond
Yep, those are harmless. Has to do with the types of evoltuions we're
applying. It'd be nice to be able to disable those..

Glad it's otherwise working!

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Tue, Jun 16, 2009 at 12:13 AM, Vesterbaek vesterb...@gmail.com wrote:


 Got a few rb-site upgrade warnings that I usually do not see:

 sudo rb-site upgrade /var/www/reviewboard
 Rebuilding directory structure
 Updating database. This may take a while.
 /var/lib/python-support/python2.6/MySQLdb/__init__.py:34:
 DeprecationWarning: the sets module is deprecated
  from sets import ImmutableSet
 Upgrading Review Board from 1.0rc2 to 1.0rc3
 There are unapplied evolutions for reviews.
 There are unapplied evolutions for reviews.
 Project signature has changed - an evolution is required
 Project signature has changed - an evolution is required
 Installing json fixture 'initial_data' from '/usr/local/lib/python2.6/
 dist-packages/ReviewBoard-1.0rc3-py2.6.egg/reviewboard/scmtools/
 fixtures'.
 Installed 6 object(s) from 1 fixture(s)
 Evolution could not be simulated, possibly due to raw SQL mutations
 Evolution successful.

  ... but things seems to work fine.

 Thanks
  -- Jeppe
 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Review Board 1.0 RC3 released

2009-06-16 Thread Sebastien Douche

On Mon, Jun 15, 2009 at 20:35, Christian Hammondchip...@chipx86.com wrote:
 I see: Added support for parent diffs for Mercurial. Patch by Colin
 Caughie. Why haven't you change initial screen (create a Hg review
 request)? It's not possible to create a review request with parent
 path.

 Pretty much because it wasn't in the patch that added this support. If you
 want to whip up a patch to do this (modify get_fields in scmtools/hg.py)
 then I'll get it in for 1.0.

Hi Christian,
surely I'm too stupid to do that, because I can't found the necessary
change: parent_diff_path / base_diff_path / ... don't work :(.

-- 
Sebastien Douche sdou...@gmail.com

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Review Board 1.0 RC3 released

2009-06-16 Thread Christian Hammond
Sorry, I was wrong. You should see the Parent Diff field when choosing
Upload Diff, but not New Review Request. This field was never added to
templates/new_review_request.html. If you add it, it should work. It should
be the parent_diff_path field. Copy/paste the diff_path and see if it
just works.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Tue, Jun 16, 2009 at 1:49 AM, Sebastien Douche sdou...@gmail.com wrote:


 On Mon, Jun 15, 2009 at 20:35, Christian Hammondchip...@chipx86.com
 wrote:
  I see: Added support for parent diffs for Mercurial. Patch by Colin
  Caughie. Why haven't you change initial screen (create a Hg review
  request)? It's not possible to create a review request with parent
  path.
 
  Pretty much because it wasn't in the patch that added this support. If
 you
  want to whip up a patch to do this (modify get_fields in scmtools/hg.py)
  then I'll get it in for 1.0.

 Hi Christian,
 surely I'm too stupid to do that, because I can't found the necessary
 change: parent_diff_path / base_diff_path / ... don't work :(.

 --
 Sebastien Douche sdou...@gmail.com

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Review Board 1.0 RC3 released

2009-06-16 Thread Sebastien Douche

On Tue, Jun 16, 2009 at 11:22, Christian Hammondchip...@chipx86.com wrote:
 Sorry, I was wrong. You should see the Parent Diff field when choosing
 Upload Diff, but not New Review Request. This field was never added to
 templates/new_review_request.html. If you add it, it should work. It should
 be the parent_diff_path field. Copy/paste the diff_path and see if it
 just works.

Awesome! Seems to work perfectly. Any chance to see this feature for 1.0?


-- 
Sebastien Douche sdou...@gmail.com

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Review Board 1.0 RC3 released

2009-06-15 Thread Sebastien Douche

On Sun, Jun 14, 2009 at 03:43, Christian Hammondchip...@chipx86.com wrote:

 I've just put out a release of 1.0 RC3, which should actually be the final
 RC as long as nothing else blows up. I plan to release 1.0 next weekend.

Upgrade (rc1-rc3) works fine.

 If people would test this release this week and make sure nothing is newly
 broken in your installs, it would REALLY help us out!

After 2 days, no problem here.

 Details on the release can be found at
 http://www.review-board.org/news/2009/06/13/review-board-10-rc3-released/

I see: Added support for parent diffs for Mercurial. Patch by Colin
Caughie. Why haven't you change initial screen (create a Hg review
request)? It's not possible to create a review request with parent
path.


-- 
Sebastien Douche sdou...@gmail.com

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Review Board 1.0 RC3 released

2009-06-15 Thread Christian Hammond
On Mon, Jun 15, 2009 at 8:07 AM, Sebastien Douche sdou...@gmail.com wrote:


 On Sun, Jun 14, 2009 at 03:43, Christian Hammondchip...@chipx86.com
 wrote:

  I've just put out a release of 1.0 RC3, which should actually be the
 final
  RC as long as nothing else blows up. I plan to release 1.0 next weekend.

 Upgrade (rc1-rc3) works fine.

  If people would test this release this week and make sure nothing is
 newly
  broken in your installs, it would REALLY help us out!

 After 2 days, no problem here.


Good to hear!




  Details on the release can be found at
 
 http://www.review-board.org/news/2009/06/13/review-board-10-rc3-released/

 I see: Added support for parent diffs for Mercurial. Patch by Colin
 Caughie. Why haven't you change initial screen (create a Hg review
 request)? It's not possible to create a review request with parent
 path.


Pretty much because it wasn't in the patch that added this support. If you
want to whip up a patch to do this (modify get_fields in scmtools/hg.py)
then I'll get it in for 1.0.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---