Re: Review Submitter Field Out of Whack

2011-05-25 Thread Ho-Hum-Chum
I wish I could offer a more detail explanation of how we got this
resolved, but it turns out it had something to do with the persistent
data left in each repo when the Reviewboard hook information was
established.  Something about a file being inside of each repo that
held some sort of authentication information, which was being used to
identify the submitter for each change for review.  Wish I could offer
more but I hope this helps someone.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Submitter Field Out of Whack

2011-05-11 Thread David Trowbridge
I don't know how hg postreview works, but at some point it calls post-review, 
correct? I think it would need to be modified to use --submit-as to suit your 
case.

- David

On May 10, 2011, at 4:40 PM, Jeffrey Reynolds 
jeffrey.james.reyno...@gmail.com wrote:

 Howdy all,
  
 I'm posting here because we are starting to use Review Board and find it a 
 very useful tool.  However we are having some issues with implementation.  We 
 have several Mecurial repos setup right now, all of which are set up with an 
 out of process (terminology?) incoming hook.  It's a script to validate the 
 user who made the push, and if the users isn't one of the core developers, a 
 review notification is posted to our ReviewBoard instance.  The validation 
 thing works fine, and only users who aren't amoung the core devs have review 
 submissions at review board.  However, ReviewBoard lists all of the 
 submitters as one particular user, never the user who actually made the push. 
  The hook calls hg postreview -i # -r # (which syntactically may be 
 incorrect, not 100%).  Apparently the postreview hg command doesn't have a 
 --submit-as option, but we have the username as a BASH variable in the 
 script.  Is there some special means that the submitting user has to be 
 specified when using hg postreview in an out of process hook?  Please let me 
 know if I shold specify anyhitng further, I'm far from a Mercurial pro so I 
 might need to refine my question.
  
 Thanks in advance,
  
 Ho-Hum
 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en