Re: Reviewboard table still show status flag as "P" pending for submitted changelist.
Great !! Thank you for the pointer. Thank you Christ. On Tue, Jan 20, 2015 at 12:37 PM, Nilesh Jaiswal wrote: > Thank you. Let me find this with perforce admin. > > Appreciated. > > On Tue, Jan 20, 2015 at 12:22 PM, Christian Hammond < > christ...@beanbaginc.com> wrote: > >> I may be misunderstanding, but review requests aren't automatically >> closed when pushing changes to Perforce. They need to be manually closed, >> or you need to write a post-commit hook in Perforce that closes the review >> request when submitting. >> >> Christian >> >> -- >> Christian Hammond - christ...@beanbaginc.com >> Review Board - https://www.reviewboard.org >> Beanbag, Inc. - https://www.beanbaginc.com >> >> -Original Message- >> From: Nilesh Jaiswal >> Reply: reviewboard@googlegroups.com > >> Date: January 19, 2015 at 10:49:40 PM >> To: reviewboard@googlegroups.com > >> Subject: Reviewboard table still show status flag as "P" pending for >> submitted changelist. >> >> > Hi All, >> > >> > I see some weird behavior with review board version 1.7.5. >> > >> > To one of the stream depot from perforce when changes are submitted >> after >> > being reviewed/Ship it done and table reviews_reviewrequest shows status >> > flag set *"P"*. Ideally once the changes are submitted/committed to >> > perforce flag should get change from P to *"S".* >> > >> > Can you please help me know what could be the cause of the issue why we >> see >> > such behavior. >> > >> > Please let me know if more information is needed. >> > >> > We are using stream depot. >> > >> > Any help would be appreciated. >> > >> > Regards, >> > Nilesh Jaiswal >> > >> > -- >> > Get the Review Board Power Pack at >> http://www.reviewboard.org/powerpack/ >> > --- >> > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >> > --- >> > Happy user? Let us know at http://www.reviewboard.org/users/ >> > --- >> > You received this message because you are subscribed to the Google >> Groups "reviewboard" >> > group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an email to reviewboard+unsubscr...@googlegroups.com. >> > For more options, visit https://groups.google.com/d/optout. >> > >> >> > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard table still show status flag as "P" pending for submitted changelist.
Thank you. Let me find this with perforce admin. Appreciated. On Tue, Jan 20, 2015 at 12:22 PM, Christian Hammond < christ...@beanbaginc.com> wrote: > I may be misunderstanding, but review requests aren't automatically closed > when pushing changes to Perforce. They need to be manually closed, or you > need to write a post-commit hook in Perforce that closes the review request > when submitting. > > Christian > > -- > Christian Hammond - christ...@beanbaginc.com > Review Board - https://www.reviewboard.org > Beanbag, Inc. - https://www.beanbaginc.com > > -Original Message- > From: Nilesh Jaiswal > Reply: reviewboard@googlegroups.com > > Date: January 19, 2015 at 10:49:40 PM > To: reviewboard@googlegroups.com > > Subject: Reviewboard table still show status flag as "P" pending for > submitted changelist. > > > Hi All, > > > > I see some weird behavior with review board version 1.7.5. > > > > To one of the stream depot from perforce when changes are submitted after > > being reviewed/Ship it done and table reviews_reviewrequest shows status > > flag set *"P"*. Ideally once the changes are submitted/committed to > > perforce flag should get change from P to *"S".* > > > > Can you please help me know what could be the cause of the issue why we > see > > such behavior. > > > > Please let me know if more information is needed. > > > > We are using stream depot. > > > > Any help would be appreciated. > > > > Regards, > > Nilesh Jaiswal > > > > -- > > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > > --- > > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > > --- > > Happy user? Let us know at http://www.reviewboard.org/users/ > > --- > > You received this message because you are subscribed to the Google > Groups "reviewboard" > > group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to reviewboard+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > > > > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard table still show status flag as "P" pending for submitted changelist.
I may be misunderstanding, but review requests aren't automatically closed when pushing changes to Perforce. They need to be manually closed, or you need to write a post-commit hook in Perforce that closes the review request when submitting. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Nilesh Jaiswal Reply: reviewboard@googlegroups.com > Date: January 19, 2015 at 10:49:40 PM To: reviewboard@googlegroups.com > Subject: Reviewboard table still show status flag as "P" pending for submitted changelist. > Hi All, > > I see some weird behavior with review board version 1.7.5. > > To one of the stream depot from perforce when changes are submitted after > being reviewed/Ship it done and table reviews_reviewrequest shows status > flag set *"P"*. Ideally once the changes are submitted/committed to > perforce flag should get change from P to *"S".* > > Can you please help me know what could be the cause of the issue why we see > such behavior. > > Please let me know if more information is needed. > > We are using stream depot. > > Any help would be appreciated. > > Regards, > Nilesh Jaiswal > > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" > group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
