Re: Revision selector

2010-08-20 Thread Geoffrey Zheng
Screenshot is uploaded as rb.png http://reviewboard.googlegroups.com/web/rb.png?gsc=iBqKOxYAAABgpEsrTenpw2OJ9ZY_yaTfM9KWFkvR1kwtm4g5T1-szg -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/

Re: Revision selector

2010-08-20 Thread Eduardo Felipe
Geoffrey, It was part of my Summer of Code to implement a similar (in concept at least) interface, and I ran into a question about how to do this properly, and I think a range selector is the best possible solution, but they are hard to implement, even when using jQuery UI's range selector, so

Re: Revision selector

2010-08-20 Thread Christian Hammond
When we first implemented this, we knew it was ugly, and had considered it a sort of temporary stop-gap. But then Review Board got popular and people had more pressing concerns, bug and feature-wise. So we never quite got around to it. What I've considered is a widget that shows all revisions and

Re: Revision selector

2010-08-20 Thread Eduardo Felipe
Christian, That's precisely the jQuery UI's widget that I mentioned. I can refactor the one I'm writing for the stacked patches (aka bundle), and put that in the trunk in time for 1.6. I'll work on this. Cheers, Eduardo. On Fri, Aug 20, 2010 at 3:46 PM, Christian Hammond chip...@chipx86.com

Re: Revision selector

2010-08-20 Thread Geoffrey Zheng
The slider could work and look more fancy, but two drags would be infinitely slower than one click. I would only use it if I can click on the numbers and the slider snaps to them. Regarding cumulative patch, maybe we're talking about different things. RB has always done it perfectly. I had a

Re: Revision selector

2010-08-20 Thread Christian Hammond
Of course now I realize I said almost exactly what Eduardo said. I meant to reply to Geoffrey's post directly, and hadn't read Eduardo's yet. Sorry Eduardo :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On