Re: SAML SSO always redirect to dashboard, even when next parameter is specified in the URL

[Minh Huy Vo]

Hi Christian,

I've updated our reviewboard to 5.0.5 and the bug is gone. 

Thank you for the fix. We appreciate it.
Huy

On Friday, April 28, 2023 at 2:30:11 PM UTC-4 Christian Hammond wrote:

> A fix is coming in 5.0.5, which we’ll have available in a couple weeks.
>
> If your company has a Premium Support contract with us, let me know. We’ll 
> get you custom builds as needed with this fix and for any other issues you 
> encounter as you prepare to launch.
>
> Christian
>
>
> On Fri, Apr 28, 2023 at 07:41 Minh Huy Vo  wrote:
>
>> I'm planning to announce the new reviewboard (5.0.4) for my company's 
>> usage soon. Is there any update on this?
>>
>> Huy
>>
>> On Saturday, April 15, 2023 at 9:03:52 PM UTC-4 Christian Hammond wrote:
>>
>>> Definitely a frustration. Some state’s getting lost in the SSO flow. 
>>> We’ll try to get a fix in soon.
>>>
>>> Christian
>>>
>>>
>>> On Mon, Apr 10, 2023 at 11:10 Stephen Morton  
>>> wrote:
>>>
 I'm running into this too. A user faces the following when they have to 
 log in. It is frustrating for them.

 - Clicks on a link to  https://reviewboard.example.com/r/161895/
 - Clicks on the "Login via SSO" button and gets redirected to SAML SSO
 - Gets redirected back to https://reviewboard.example.com/dashboard 
 <-- Not the actual review
 - Now has to go back to original link and re-click on it so get 
 properly to review 161895 


 Steve



 On Friday, March 31, 2023 at 6:17:35 PM UTC-4 Minh Huy Vo wrote:

> Hi,
>
> I've recently set up SAML SSO in reviewboard to conenct with my 
> company's internal SSO. One thing I get complained about is when users 
> receive email about a review, after they click the URL  and click the SSO 
> button to login, instead of being redirected to that review, they are 
> redirected to the dashboard. I've taken a look at reviewboard's source 
> code 
> and can see that users are always redirected back to dashboard when using 
> SSO (see  reviewboard/views.py at release-5.0.1 · 
> reviewboard/reviewboard · GitHub 
> ).
>  
> I'm using reviewboard-5.0.1, upgrade it to 5.0.4 doesn't seem to fix the 
> problem. 
>
> Has anyone raised this issue before? 
>
> Regards,
> Huy Vo.

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "Review Board Community" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/reviewboard/62b57fe0-311b-4449-887b-557f52430b31n%40googlegroups.com
  
 
 .

>>> -- 
>>> -- 
>>> Christian Hammond
>>> President/CEO of Beanbag
>>> Makers of Review Board
>>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com.
>>
> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/4e3bde94-0933-4510-a03e-29b85e0d6dcdn%40googlegroups.com
>>  
>> 
>> .
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/918c07b5-66a7-4b56-a37a-a75a6de78996n%40googlegroups.com.

Re: SAML SSO always redirect to dashboard, even when next parameter is specified in the URL

[Christian Hammond]

A fix is coming in 5.0.5, which we’ll have available in a couple weeks.

If your company has a Premium Support contract with us, let me know. We’ll
get you custom builds as needed with this fix and for any other issues you
encounter as you prepare to launch.

Christian


On Fri, Apr 28, 2023 at 07:41 Minh Huy Vo  wrote:

> I'm planning to announce the new reviewboard (5.0.4) for my company's
> usage soon. Is there any update on this?
>
> Huy
>
> On Saturday, April 15, 2023 at 9:03:52 PM UTC-4 Christian Hammond wrote:
>
>> Definitely a frustration. Some state’s getting lost in the SSO flow.
>> We’ll try to get a fix in soon.
>>
>> Christian
>>
>>
>> On Mon, Apr 10, 2023 at 11:10 Stephen Morton 
>> wrote:
>>
>>> I'm running into this too. A user faces the following when they have to
>>> log in. It is frustrating for them.
>>>
>>> - Clicks on a link to  https://reviewboard.example.com/r/161895/
>>> - Clicks on the "Login via SSO" button and gets redirected to SAML SSO
>>> - Gets redirected back to https://reviewboard.example.com/dashboard <--
>>> Not the actual review
>>> - Now has to go back to original link and re-click on it so get properly
>>> to review 161895
>>>
>>>
>>> Steve
>>>
>>>
>>>
>>> On Friday, March 31, 2023 at 6:17:35 PM UTC-4 Minh Huy Vo wrote:
>>>
 Hi,

 I've recently set up SAML SSO in reviewboard to conenct with my
 company's internal SSO. One thing I get complained about is when users
 receive email about a review, after they click the URL  and click the SSO
 button to login, instead of being redirected to that review, they are
 redirected to the dashboard. I've taken a look at reviewboard's source code
 and can see that users are always redirected back to dashboard when using
 SSO (see  reviewboard/views.py at release-5.0.1 ·
 reviewboard/reviewboard · GitHub
 ).
 I'm using reviewboard-5.0.1, upgrade it to 5.0.4 doesn't seem to fix the
 problem.

 Has anyone raised this issue before?

 Regards,
 Huy Vo.
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Review Board Community" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/reviewboard/62b57fe0-311b-4449-887b-557f52430b31n%40googlegroups.com
>>> 
>>> .
>>>
>> --
>> --
>> Christian Hammond
>> President/CEO of Beanbag
>> Makers of Review Board
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/4e3bde94-0933-4510-a03e-29b85e0d6dcdn%40googlegroups.com
> 
> .
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAE7Vnd%3DADeY%3DFDbSVTWK9OCkjvpmP1hQT8A49Q6fA5VfJGaE%2BQ%40mail.gmail.com.

Re: SAML SSO always redirect to dashboard, even when next parameter is specified in the URL

[Minh Huy Vo]

I'm planning to announce the new reviewboard (5.0.4) for my company's usage 
soon. Is there any update on this?

Huy

On Saturday, April 15, 2023 at 9:03:52 PM UTC-4 Christian Hammond wrote:

> Definitely a frustration. Some state’s getting lost in the SSO flow. We’ll 
> try to get a fix in soon.
>
> Christian
>
>
> On Mon, Apr 10, 2023 at 11:10 Stephen Morton  
> wrote:
>
>> I'm running into this too. A user faces the following when they have to 
>> log in. It is frustrating for them.
>>
>> - Clicks on a link to  https://reviewboard.example.com/r/161895/
>> - Clicks on the "Login via SSO" button and gets redirected to SAML SSO
>> - Gets redirected back to https://reviewboard.example.com/dashboard <-- 
>> Not the actual review
>> - Now has to go back to original link and re-click on it so get properly 
>> to review 161895 
>>
>>
>> Steve
>>
>>
>>
>> On Friday, March 31, 2023 at 6:17:35 PM UTC-4 Minh Huy Vo wrote:
>>
>>> Hi,
>>>
>>> I've recently set up SAML SSO in reviewboard to conenct with my 
>>> company's internal SSO. One thing I get complained about is when users 
>>> receive email about a review, after they click the URL  and click the SSO 
>>> button to login, instead of being redirected to that review, they are 
>>> redirected to the dashboard. I've taken a look at reviewboard's source code 
>>> and can see that users are always redirected back to dashboard when using 
>>> SSO (see  reviewboard/views.py at release-5.0.1 · 
>>> reviewboard/reviewboard · GitHub 
>>> ).
>>>  
>>> I'm using reviewboard-5.0.1, upgrade it to 5.0.4 doesn't seem to fix the 
>>> problem. 
>>>
>>> Has anyone raised this issue before? 
>>>
>>> Regards,
>>> Huy Vo.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/62b57fe0-311b-4449-887b-557f52430b31n%40googlegroups.com
>>  
>> 
>> .
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/4e3bde94-0933-4510-a03e-29b85e0d6dcdn%40googlegroups.com.

Re: SAML SSO always redirect to dashboard, even when next parameter is specified in the URL

[Christian Hammond]

Definitely a frustration. Some state’s getting lost in the SSO flow. We’ll
try to get a fix in soon.

Christian


On Mon, Apr 10, 2023 at 11:10 Stephen Morton 
wrote:

> I'm running into this too. A user faces the following when they have to
> log in. It is frustrating for them.
>
> - Clicks on a link to  https://reviewboard.example.com/r/161895/
> - Clicks on the "Login via SSO" button and gets redirected to SAML SSO
> - Gets redirected back to https://reviewboard.example.com/dashboard <--
> Not the actual review
> - Now has to go back to original link and re-click on it so get properly
> to review 161895
>
>
> Steve
>
>
>
> On Friday, March 31, 2023 at 6:17:35 PM UTC-4 Minh Huy Vo wrote:
>
>> Hi,
>>
>> I've recently set up SAML SSO in reviewboard to conenct with my company's
>> internal SSO. One thing I get complained about is when users receive email
>> about a review, after they click the URL  and click the SSO button to
>> login, instead of being redirected to that review, they are redirected to
>> the dashboard. I've taken a look at reviewboard's source code and can see
>> that users are always redirected back to dashboard when using SSO (see  
>> reviewboard/views.py
>> at release-5.0.1 · reviewboard/reviewboard · GitHub
>> ).
>> I'm using reviewboard-5.0.1, upgrade it to 5.0.4 doesn't seem to fix the
>> problem.
>>
>> Has anyone raised this issue before?
>>
>> Regards,
>> Huy Vo.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/62b57fe0-311b-4449-887b-557f52430b31n%40googlegroups.com
> 
> .
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAE7VndnHPqypAGeo84OD6MiHDTmnqMvV2U7Tphso8tTV_jY9MQ%40mail.gmail.com.

Re: SAML SSO always redirect to dashboard, even when next parameter is specified in the URL

[Stephen Morton]

I'm running into this too. A user faces the following when they have to log 
in. It is frustrating for them.

- Clicks on a link to  https://reviewboard.example.com/r/161895/
- Clicks on the "Login via SSO" button and gets redirected to SAML SSO
- Gets redirected back to https://reviewboard.example.com/dashboard <-- Not 
the actual review
- Now has to go back to original link and re-click on it so get properly to 
review 161895 


Steve



On Friday, March 31, 2023 at 6:17:35 PM UTC-4 Minh Huy Vo wrote:

> Hi,
>
> I've recently set up SAML SSO in reviewboard to conenct with my company's 
> internal SSO. One thing I get complained about is when users receive email 
> about a review, after they click the URL  and click the SSO button to 
> login, instead of being redirected to that review, they are redirected to 
> the dashboard. I've taken a look at reviewboard's source code and can see 
> that users are always redirected back to dashboard when using SSO (see  
> reviewboard/views.py 
> at release-5.0.1 · reviewboard/reviewboard · GitHub 
> ).
>  
> I'm using reviewboard-5.0.1, upgrade it to 5.0.4 doesn't seem to fix the 
> problem. 
>
> Has anyone raised this issue before? 
>
> Regards,
> Huy Vo.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/62b57fe0-311b-4449-887b-557f52430b31n%40googlegroups.com.