Re: See file context in 'view review'

2014-01-09 Thread Christian Hammond
It's something I'd like to add, but I know it won't happen for 2.0.

I do plan to add full file view/download in a 2.x. For now, you can get it
through the API at least.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Thu, Jan 9, 2014 at 10:36 AM, Matthew Woehlke
wrote:

> On 2014-01-09 08:24, Sven Sandberg wrote:
>
>> When the coder receives a review, there are two ways to view the review:
>>
>>1. 'view review'
>>2. 'view diff'
>>
>> In the first view, you only get to see the lines that the reviewer
>> commented on, which is usually not enough context to understand the
>> problem. So you often need the second view.
>>
>> However, in the second view, you cannot write a reply. If you try to
>> write a reply, it becomes an entirely new draft review with a new review
>> comment instead of a reply.
>>
>> It would be much more efficient if you could write a reply while looking
>> at the full diff (or even the full file, as is possible in the 'diff'
>> view). You can work around this by switching back and forth between the
>> views, but that is distracting.
>>
>
> There is a (very old) bug report¹ about this already. That said...
>
>
>  I think a very good way to fix this would be if you could expand hidden
>> rows in the 'review' view, similar to how you can expand hidden rows in the
>> 'diff' view. Would this be possible to add in a future version of
>> ReviewBoard?
>>
>
> ...this also sounds like an interesting idea.
>
> (¹ http://code.google.com/p/reviewboard/issues/detail?id=1426)
>
> --
> Matthew
>
>
> --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- You received this message because you are subscribed to the Google
> Groups "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: See file context in 'view review'

2014-01-09 Thread Matthew Woehlke

On 2014-01-09 08:24, Sven Sandberg wrote:

When the coder receives a review, there are two ways to view the review:

   1. 'view review'
   2. 'view diff'

In the first view, you only get to see the lines that the reviewer commented 
on, which is usually not enough context to understand the problem. So you often 
need the second view.

However, in the second view, you cannot write a reply. If you try to write a 
reply, it becomes an entirely new draft review with a new review comment 
instead of a reply.

It would be much more efficient if you could write a reply while looking at the 
full diff (or even the full file, as is possible in the 'diff' view). You can 
work around this by switching back and forth between the views, but that is 
distracting.


There is a (very old) bug report¹ about this already. That said...


I think a very good way to fix this would be if you could expand hidden rows in 
the 'review' view, similar to how you can expand hidden rows in the 'diff' 
view. Would this be possible to add in a future version of ReviewBoard?


...this also sounds like an interesting idea.

(¹ http://code.google.com/p/reviewboard/issues/detail?id=1426)

--
Matthew

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.