Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-18 Thread Christian Hammond
Sorry, we can't get you an early patch for this just yet. We'd have to do
some research and testing, and right now we're swamped with work for some
of our premium support customers. However, if your team wants to
investigate this and write a patch, we can review it on
https://reviews.reviewboard.org/.

In the meantime, please file a bug on
https://hellosplat.com/s/beanbag/tickets/ so we can track this.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Wed, Nov 18, 2015 at 3:02 PM, Wesly Chen  wrote:

> In the error message,
> 2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no lexer
> for filename u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v'
> found
>
> Review Board might need to add a filename check for CVS repository and
> remove the trailing ",v" then pass the filename without ",v" to
> "_apply_pygments".
>
> In a short term, could you pass me the patch or fix before release since
> we have an issue to upgrade from 2.0.20 to 2.5.11.
>
> Thanks,
>
> Wesly
>
> Wesly Chen於 2015年11月18日星期三 UTC-8下午2時36分02秒寫道:
>
>> Besides, the path in log
>> /home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl
>> 
>> ,v
>> is the path on CVS repository server filesystem.
>>
>> My local path is (on different host)
>> /home/wchen/CVS_work/OPS/nagios/libexec/check_mysql_multirow.pl
>>
>> Christian Hammond於 2015年11月18日星期三 UTC-8下午2時26分22秒寫道:
>>>
>>> How are you generating the diffs? I noticed that as well, and I don't
>>> believe it should be showing the ",v".
>>>
>>> Christian
>>>
>>> --
>>> Christian Hammond - chri...@beanbaginc.com
>>> Review Board - https://www.reviewboard.org
>>> Beanbag, Inc. - https://www.beanbaginc.com
>>>
>>> On Wed, Nov 18, 2015 at 2:25 PM, Wesly Chen  wrote:
>>>
 It seems to be related to CVS repository. In CVS repository, all the
 file will be trailed with ",v" and the content of CVS files are not similar
 with original one.
 However, "cvs diff" can parse and generate the diff file. So the review
 board Diff Viewer should check and parse the lexer based on the original
 filename instead of the one in CVS repository with ",v".

 Wesly Chen於 2015年11月17日星期二 UTC-8下午5時36分20秒寫道:

> 2015-11-18 01:34:33,284 - DEBUG - None - wchen -
> /reviews/r/114/diff/3/fragment/1876/ - Patching file
> check_mysql_multirow.pl took 0.042870 seconds
> 2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no
> lexer for filename u'/home/cvs/OPS/nagios/libexec/
> check_mysql_multirow.pl,v' found
> Traceback (most recent call last):
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
> line 231, in _get_chunks_uncached
> markup_a = self._apply_pygments(old or '', source_file)
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
> line 654, in _apply_pygments
> encoding='utf-8')
>   File
> "/usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg/pygments/lexers/__init__.py",
> line 149, in get_lexer_for_filename
> raise ClassNotFound('no lexer for filename %r found' % _fn)
> ClassNotFound: no lexer for filename u'/home/cvs/OPS/nagios/libexec/
> check_mysql_multirow.pl,v' found
> 2015-11-18 01:34:33,425 - DEBUG - None - wchen -
> /reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff chunks for
> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
> check_mysql_multirow.pl,v)
> 2015-11-18 01:34:33,432 - DEBUG - None - wchen -
> /reviews/r/114/diff/3/fragment/1876/ - End: Generating diff chunks for
> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
> check_mysql_multirow.pl,v)
> 2015-11-18 01:34:33,432 - DEBUG - None - wchen -
> /reviews/r/114/diff/3/fragment/1876/ - Generating diff chunks for
> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
> check_mysql_multirow.pl,v) took 0.006171 seconds
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-18 Thread Wesly Chen
OK, we did some patch for our own

ReviewBoard-2.0.20-py2.6.egg/reviewboard/scmtools/cvs.py

185a186,188
> def normalize_path_for_display(self, filename):
> return re.sub(",v$", "", filename)
> 

Basically, we add the following two lines after line 186 in 
ReviewBoard-2.0.20-py2.6.egg/reviewboard/scmtools/cvs.py

 def normalize_path_for_display(self, filename):
 return re.sub(",v$", "", filename)
--

And syntax highlighting in Diff Viewer works for me now.

Thanks Christian for helping on this issue.

Best wishes,

Wesly

Christian Hammond於 2015年11月18日星期三 UTC-8下午3時05分40秒寫道:
>
> Sorry, we can't get you an early patch for this just yet. We'd have to do 
> some research and testing, and right now we're swamped with work for some 
> of our premium support customers. However, if your team wants to 
> investigate this and write a patch, we can review it on 
> https://reviews.reviewboard.org/.
>
> In the meantime, please file a bug on 
> https://hellosplat.com/s/beanbag/tickets/ so we can track this.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Wed, Nov 18, 2015 at 3:02 PM, Wesly Chen  > wrote:
>
>> In the error message,
>> 2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no lexer 
>> for filename u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' 
>> found
>>
>> Review Board might need to add a filename check for CVS repository and 
>> remove the trailing ",v" then pass the filename without ",v" to 
>> "_apply_pygments".
>>
>> In a short term, could you pass me the patch or fix before release since 
>> we have an issue to upgrade from 2.0.20 to 2.5.11.
>>
>> Thanks,
>>
>> Wesly
>>
>> Wesly Chen於 2015年11月18日星期三 UTC-8下午2時36分02秒寫道:
>>
>>> Besides, the path in log
>>> /home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl 
>>> 
>>> ,v
>>> is the path on CVS repository server filesystem.
>>>
>>> My local path is (on different host)
>>> /home/wchen/CVS_work/OPS/nagios/libexec/check_mysql_multirow.pl
>>>
>>> Christian Hammond於 2015年11月18日星期三 UTC-8下午2時26分22秒寫道:

 How are you generating the diffs? I noticed that as well, and I don't 
 believe it should be showing the ",v".

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Wed, Nov 18, 2015 at 2:25 PM, Wesly Chen  wrote:

> It seems to be related to CVS repository. In CVS repository, all the 
> file will be trailed with ",v" and the content of CVS files are not 
> similar 
> with original one.
> However, "cvs diff" can parse and generate the diff file. So the 
> review board Diff Viewer should check and parse the lexer based on the 
> original filename instead of the one in CVS repository with ",v".  
>
> Wesly Chen於 2015年11月17日星期二 UTC-8下午5時36分20秒寫道:
>
>> 2015-11-18 01:34:33,284 - DEBUG - None - wchen - 
>> /reviews/r/114/diff/3/fragment/1876/ - Patching file 
>> check_mysql_multirow.pl took 0.042870 seconds
>> 2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no 
>> lexer for filename u'/home/cvs/OPS/nagios/libexec/
>> check_mysql_multirow.pl,v' found
>> Traceback (most recent call last):
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 231, in _get_chunks_uncached
>> markup_a = self._apply_pygments(old or '', source_file)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 654, in _apply_pygments
>> encoding='utf-8')
>>   File 
>> "/usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg/pygments/lexers/__init__.py",
>>  
>> line 149, in get_lexer_for_filename
>> raise ClassNotFound('no lexer for filename %r found' % _fn)
>> ClassNotFound: no lexer for filename u'/home/cvs/OPS/nagios/libexec/
>> check_mysql_multirow.pl,v' found
>> 2015-11-18 01:34:33,425 - DEBUG - None - wchen - 
>> /reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff chunks for 
>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>> check_mysql_multirow.pl,v)
>> 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
>> /reviews/r/114/diff/3/fragment/1876/ - End: Generating diff chunks for 
>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>> check_mysql_multirow.pl,v)
>> 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
>> /reviews/r/114/diff/3/fragment/1876/ - Generating diff chunks for 
>> self.filediff id 1876 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-18 Thread Christian Hammond
How are you generating the diffs? I noticed that as well, and I don't
believe it should be showing the ",v".

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Wed, Nov 18, 2015 at 2:25 PM, Wesly Chen  wrote:

> It seems to be related to CVS repository. In CVS repository, all the file
> will be trailed with ",v" and the content of CVS files are not similar with
> original one.
> However, "cvs diff" can parse and generate the diff file. So the review
> board Diff Viewer should check and parse the lexer based on the original
> filename instead of the one in CVS repository with ",v".
>
> Wesly Chen於 2015年11月17日星期二 UTC-8下午5時36分20秒寫道:
>
>> 2015-11-18 01:34:33,284 - DEBUG - None - wchen -
>> /reviews/r/114/diff/3/fragment/1876/ - Patching file
>> check_mysql_multirow.pl took 0.042870 seconds
>> 2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no lexer
>> for filename u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v'
>> found
>> Traceback (most recent call last):
>>   File
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>> line 231, in _get_chunks_uncached
>> markup_a = self._apply_pygments(old or '', source_file)
>>   File
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>> line 654, in _apply_pygments
>> encoding='utf-8')
>>   File
>> "/usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg/pygments/lexers/__init__.py",
>> line 149, in get_lexer_for_filename
>> raise ClassNotFound('no lexer for filename %r found' % _fn)
>> ClassNotFound: no lexer for filename u'/home/cvs/OPS/nagios/libexec/
>> check_mysql_multirow.pl,v' found
>> 2015-11-18 01:34:33,425 - DEBUG - None - wchen -
>> /reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff chunks for
>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>> check_mysql_multirow.pl,v)
>> 2015-11-18 01:34:33,432 - DEBUG - None - wchen -
>> /reviews/r/114/diff/3/fragment/1876/ - End: Generating diff chunks for
>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>> check_mysql_multirow.pl,v)
>> 2015-11-18 01:34:33,432 - DEBUG - None - wchen -
>> /reviews/r/114/diff/3/fragment/1876/ - Generating diff chunks for
>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>> check_mysql_multirow.pl,v) took 0.006171 seconds
>>
>>
>> Christian Hammond於 2015年11月17日星期二 UTC-8下午5時29分13秒寫道:
>>>
>>> Okay, you'll have to add 'import logging' to the line above the logging
>>> statement.
>>>
>>> Christian
>>>
>>> --
>>> Christian Hammond - chri...@beanbaginc.com
>>> Review Board - https://www.reviewboard.org
>>> Beanbag, Inc. - https://www.beanbaginc.com
>>>
>>> On Tue, Nov 17, 2015 at 5:09 PM, Wesly Chen  wrote:
>>>
 I modified
 --
 markup_b = self._apply_pygments(new or '', dest_file)
 except:
 pass
 
 to
 
 markup_b = self._apply_pygments(new or '', dest_file)
 except Exception as e:
 logging.exception('Failed to apply pygments: %s', e)
 --

 Then restarted memcached/httpd.
 loaded a diff file via rbt (rbt post -u -r 114 -I
 check_mysql_multirow.pl)
 and I got an error on UI
 
  There was an error displaying this diff.

 global name 'logging' is not defined

 Details:
 Traceback (most recent call last):
   File
 "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/views.py",
 line 265, in get
 response = renderer.render_to_response(request)
   File
 "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
 line 56, in render_to_response
 return HttpResponse(self.render_to_string(request))
   File
 "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
 line 74, in render_to_string
 large_data=True)
   File
 "/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
 line 111, in cache_memoize
 data = lookup_callable()
   File
 "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
 line 73, in 
 lambda: self.render_to_string_uncached(request),
   File
 "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
 line 87, in render_to_string_uncached
 request=request)
   File
 "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 line 422, in populate_diff_chunks
 chunks = generator.get_chunks()
   File
 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-18 Thread Wesly Chen
In the error message,
2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no lexer for 
filename u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' found

Review Board might need to add a filename check for CVS repository and 
remove the trailing ",v" then pass the filename without ",v" to 
"_apply_pygments".

In a short term, could you pass me the patch or fix before release since we 
have an issue to upgrade from 2.0.20 to 2.5.11.

Thanks,

Wesly

Wesly Chen於 2015年11月18日星期三 UTC-8下午2時36分02秒寫道:
>
> Besides, the path in log
> /home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl 
> 
> ,v
> is the path on CVS repository server filesystem.
>
> My local path is (on different host)
> /home/wchen/CVS_work/OPS/nagios/libexec/check_mysql_multirow.pl
>
> Christian Hammond於 2015年11月18日星期三 UTC-8下午2時26分22秒寫道:
>>
>> How are you generating the diffs? I noticed that as well, and I don't 
>> believe it should be showing the ",v".
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Wed, Nov 18, 2015 at 2:25 PM, Wesly Chen  wrote:
>>
>>> It seems to be related to CVS repository. In CVS repository, all the 
>>> file will be trailed with ",v" and the content of CVS files are not similar 
>>> with original one.
>>> However, "cvs diff" can parse and generate the diff file. So the review 
>>> board Diff Viewer should check and parse the lexer based on the original 
>>> filename instead of the one in CVS repository with ",v".  
>>>
>>> Wesly Chen於 2015年11月17日星期二 UTC-8下午5時36分20秒寫道:
>>>
 2015-11-18 01:34:33,284 - DEBUG - None - wchen - 
 /reviews/r/114/diff/3/fragment/1876/ - Patching file 
 check_mysql_multirow.pl took 0.042870 seconds
 2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no lexer 
 for filename u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' 
 found
 Traceback (most recent call last):
   File 
 "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
  
 line 231, in _get_chunks_uncached
 markup_a = self._apply_pygments(old or '', source_file)
   File 
 "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
  
 line 654, in _apply_pygments
 encoding='utf-8')
   File 
 "/usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg/pygments/lexers/__init__.py",
  
 line 149, in get_lexer_for_filename
 raise ClassNotFound('no lexer for filename %r found' % _fn)
 ClassNotFound: no lexer for filename u'/home/cvs/OPS/nagios/libexec/
 check_mysql_multirow.pl,v' found
 2015-11-18 01:34:33,425 - DEBUG - None - wchen - 
 /reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff chunks for 
 self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
 check_mysql_multirow.pl,v)
 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
 /reviews/r/114/diff/3/fragment/1876/ - End: Generating diff chunks for 
 self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
 check_mysql_multirow.pl,v)
 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
 /reviews/r/114/diff/3/fragment/1876/ - Generating diff chunks for 
 self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
 check_mysql_multirow.pl,v) took 0.006171 seconds



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-18 Thread Wesly Chen
Besides, the path in log
/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl 

,v
is the path on CVS repository server filesystem.

My local path is (on different host)
/home/wchen/CVS_work/OPS/nagios/libexec/check_mysql_multirow.pl

Christian Hammond於 2015年11月18日星期三 UTC-8下午2時26分22秒寫道:
>
> How are you generating the diffs? I noticed that as well, and I don't 
> believe it should be showing the ",v".
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Wed, Nov 18, 2015 at 2:25 PM, Wesly Chen  > wrote:
>
>> It seems to be related to CVS repository. In CVS repository, all the file 
>> will be trailed with ",v" and the content of CVS files are not similar with 
>> original one.
>> However, "cvs diff" can parse and generate the diff file. So the review 
>> board Diff Viewer should check and parse the lexer based on the original 
>> filename instead of the one in CVS repository with ",v".  
>>
>> Wesly Chen於 2015年11月17日星期二 UTC-8下午5時36分20秒寫道:
>>
>>> 2015-11-18 01:34:33,284 - DEBUG - None - wchen - 
>>> /reviews/r/114/diff/3/fragment/1876/ - Patching file 
>>> check_mysql_multirow.pl took 0.042870 seconds
>>> 2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no lexer 
>>> for filename u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' 
>>> found
>>> Traceback (most recent call last):
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>>  
>>> line 231, in _get_chunks_uncached
>>> markup_a = self._apply_pygments(old or '', source_file)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>>  
>>> line 654, in _apply_pygments
>>> encoding='utf-8')
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg/pygments/lexers/__init__.py",
>>>  
>>> line 149, in get_lexer_for_filename
>>> raise ClassNotFound('no lexer for filename %r found' % _fn)
>>> ClassNotFound: no lexer for filename u'/home/cvs/OPS/nagios/libexec/
>>> check_mysql_multirow.pl,v' found
>>> 2015-11-18 01:34:33,425 - DEBUG - None - wchen - 
>>> /reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff chunks for 
>>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>>> check_mysql_multirow.pl,v)
>>> 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
>>> /reviews/r/114/diff/3/fragment/1876/ - End: Generating diff chunks for 
>>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>>> check_mysql_multirow.pl,v)
>>> 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
>>> /reviews/r/114/diff/3/fragment/1876/ - Generating diff chunks for 
>>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>>> check_mysql_multirow.pl,v) took 0.006171 seconds
>>>
>>>
>>> Christian Hammond於 2015年11月17日星期二 UTC-8下午5時29分13秒寫道:

 Okay, you'll have to add 'import logging' to the line above the logging 
 statement.

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Tue, Nov 17, 2015 at 5:09 PM, Wesly Chen  wrote:

> I modified 
> --
> markup_b = self._apply_pygments(new or '', dest_file)
> except:
> pass
> 
> to
> 
> markup_b = self._apply_pygments(new or '', dest_file)
> except Exception as e:
> logging.exception('Failed to apply pygments: %s', e)
> --
>
> Then restarted memcached/httpd.
> loaded a diff file via rbt (rbt post -u -r 114 -I 
> check_mysql_multirow.pl)
> and I got an error on UI
> 
>  There was an error displaying this diff.
> 
> global name 'logging' is not defined
>
> Details:
> Traceback (most recent call last):
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/views.py",
>  
> line 265, in get
> response = renderer.render_to_response(request)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>  
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>  
> line 74, in render_to_string
> large_data=True)
>   File 
> "/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
>  
> line 111, in cache_memoize
> data = lookup_callable()
>   File 
> 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-18 Thread Wesly Chen
It seems to be related to CVS repository. In CVS repository, all the file 
will be trailed with ",v" and the content of CVS files are not similar with 
original one.
However, "cvs diff" can parse and generate the diff file. So the review 
board Diff Viewer should check and parse the lexer based on the original 
filename instead of the one in CVS repository with ",v".  

Wesly Chen於 2015年11月17日星期二 UTC-8下午5時36分20秒寫道:
>
> 2015-11-18 01:34:33,284 - DEBUG - None - wchen - 
> /reviews/r/114/diff/3/fragment/1876/ - Patching file 
> check_mysql_multirow.pl took 0.042870 seconds
> 2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no lexer 
> for filename u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' 
> found
> Traceback (most recent call last):
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 231, in _get_chunks_uncached
> markup_a = self._apply_pygments(old or '', source_file)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 654, in _apply_pygments
> encoding='utf-8')
>   File 
> "/usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg/pygments/lexers/__init__.py",
>  
> line 149, in get_lexer_for_filename
> raise ClassNotFound('no lexer for filename %r found' % _fn)
> ClassNotFound: no lexer for filename u'/home/cvs/OPS/nagios/libexec/
> check_mysql_multirow.pl,v' found
> 2015-11-18 01:34:33,425 - DEBUG - None - wchen - 
> /reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff chunks for 
> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
> check_mysql_multirow.pl,v)
> 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
> /reviews/r/114/diff/3/fragment/1876/ - End: Generating diff chunks for 
> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
> check_mysql_multirow.pl,v)
> 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
> /reviews/r/114/diff/3/fragment/1876/ - Generating diff chunks for 
> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
> check_mysql_multirow.pl,v) took 0.006171 seconds
>
>
> Christian Hammond於 2015年11月17日星期二 UTC-8下午5時29分13秒寫道:
>>
>> Okay, you'll have to add 'import logging' to the line above the logging 
>> statement.
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Tue, Nov 17, 2015 at 5:09 PM, Wesly Chen  wrote:
>>
>>> I modified 
>>> --
>>> markup_b = self._apply_pygments(new or '', dest_file)
>>> except:
>>> pass
>>> 
>>> to
>>> 
>>> markup_b = self._apply_pygments(new or '', dest_file)
>>> except Exception as e:
>>> logging.exception('Failed to apply pygments: %s', e)
>>> --
>>>
>>> Then restarted memcached/httpd.
>>> loaded a diff file via rbt (rbt post -u -r 114 -I 
>>> check_mysql_multirow.pl)
>>> and I got an error on UI
>>> 
>>>  There was an error displaying this diff.
>>> 
>>> global name 'logging' is not defined
>>>
>>> Details:
>>> Traceback (most recent call last):
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/views.py",
>>>  
>>> line 265, in get
>>> response = renderer.render_to_response(request)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>>>  
>>> line 56, in render_to_response
>>> return HttpResponse(self.render_to_string(request))
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>>>  
>>> line 74, in render_to_string
>>> large_data=True)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
>>>  
>>> line 111, in cache_memoize
>>> data = lookup_callable()
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>>>  
>>> line 73, in 
>>> lambda: self.render_to_string_uncached(request),
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>>>  
>>> line 87, in render_to_string_uncached
>>> request=request)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>>>  
>>> line 422, in populate_diff_chunks
>>> chunks = generator.get_chunks()
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>>  
>>> line 161, in get_chunks
>>> large_data=True)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
>>>  
>>> line 111, in cache_memoize
>>> data = lookup_callable()
>>>   File 
>>> 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-18 Thread Wesly Chen
Using "rbt post", full command as following:
--
rbt post -u -r 114 -I check_mysql_multirow.pl

And the rbt post reference my ~/.reviewboardrc setting
REPOSITORY = "CVS-prod"
which is defined in reviewboard.

rbt is using the local "cvs" command to generate the diff.



Christian Hammond於 2015年11月18日星期三 UTC-8下午2時26分22秒寫道:
>
> How are you generating the diffs? I noticed that as well, and I don't 
> believe it should be showing the ",v".
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Wed, Nov 18, 2015 at 2:25 PM, Wesly Chen  > wrote:
>
>> It seems to be related to CVS repository. In CVS repository, all the file 
>> will be trailed with ",v" and the content of CVS files are not similar with 
>> original one.
>> However, "cvs diff" can parse and generate the diff file. So the review 
>> board Diff Viewer should check and parse the lexer based on the original 
>> filename instead of the one in CVS repository with ",v".  
>>
>> Wesly Chen於 2015年11月17日星期二 UTC-8下午5時36分20秒寫道:
>>
>>> 2015-11-18 01:34:33,284 - DEBUG - None - wchen - 
>>> /reviews/r/114/diff/3/fragment/1876/ - Patching file 
>>> check_mysql_multirow.pl took 0.042870 seconds
>>> 2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no lexer 
>>> for filename u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' 
>>> found
>>> Traceback (most recent call last):
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>>  
>>> line 231, in _get_chunks_uncached
>>> markup_a = self._apply_pygments(old or '', source_file)
>>>   File 
>>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>>  
>>> line 654, in _apply_pygments
>>> encoding='utf-8')
>>>   File 
>>> "/usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg/pygments/lexers/__init__.py",
>>>  
>>> line 149, in get_lexer_for_filename
>>> raise ClassNotFound('no lexer for filename %r found' % _fn)
>>> ClassNotFound: no lexer for filename u'/home/cvs/OPS/nagios/libexec/
>>> check_mysql_multirow.pl,v' found
>>> 2015-11-18 01:34:33,425 - DEBUG - None - wchen - 
>>> /reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff chunks for 
>>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>>> check_mysql_multirow.pl,v)
>>> 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
>>> /reviews/r/114/diff/3/fragment/1876/ - End: Generating diff chunks for 
>>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>>> check_mysql_multirow.pl,v)
>>> 2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
>>> /reviews/r/114/diff/3/fragment/1876/ - Generating diff chunks for 
>>> self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/
>>> check_mysql_multirow.pl,v) took 0.006171 seconds
>>>
>>>
>>> Christian Hammond於 2015年11月17日星期二 UTC-8下午5時29分13秒寫道:

 Okay, you'll have to add 'import logging' to the line above the logging 
 statement.

 Christian

 -- 
 Christian Hammond - chri...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Tue, Nov 17, 2015 at 5:09 PM, Wesly Chen  wrote:

> I modified 
> --
> markup_b = self._apply_pygments(new or '', dest_file)
> except:
> pass
> 
> to
> 
> markup_b = self._apply_pygments(new or '', dest_file)
> except Exception as e:
> logging.exception('Failed to apply pygments: %s', e)
> --
>
> Then restarted memcached/httpd.
> loaded a diff file via rbt (rbt post -u -r 114 -I 
> check_mysql_multirow.pl)
> and I got an error on UI
> 
>  There was an error displaying this diff.
> 
> global name 'logging' is not defined
>
> Details:
> Traceback (most recent call last):
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/views.py",
>  
> line 265, in get
> response = renderer.render_to_response(request)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>  
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>  
> line 74, in render_to_string
> large_data=True)
>   File 
> "/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
>  
> line 111, in cache_memoize
> data = lookup_callable()
>   File 
> 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-17 Thread Wesly Chen
I modified 
--
markup_b = self._apply_pygments(new or '', dest_file)
except:
pass

to

markup_b = self._apply_pygments(new or '', dest_file)
except Exception as e:
logging.exception('Failed to apply pygments: %s', e)
--

Then restarted memcached/httpd.
loaded a diff file via rbt (rbt post -u -r 114 -I check_mysql_multirow.pl)
and I got an error on UI

 There was an error displaying this diff.

global name 'logging' is not defined

Details:
Traceback (most recent call last):
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/views.py",
 
line 265, in get
response = renderer.render_to_response(request)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string
large_data=True)
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
 
line 111, in cache_memoize
data = lookup_callable()
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in 
lambda: self.render_to_string_uncached(request),
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached
request=request)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 
line 422, in populate_diff_chunks
chunks = generator.get_chunks()
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 161, in get_chunks
large_data=True)
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
 
line 111, in cache_memoize
data = lookup_callable()
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 160, in 
lambda: list(self._get_chunks_uncached()),
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 236, in _get_chunks_uncached
logging.exception('Failed to apply pygments: %s', e)
NameError: global name 'logging' is not defined
-

Here is the reviewboard.log
--
2015-11-18 01:01:28,274 - DEBUG -  - DiffParser.parse: Beginning parse of 
diff, size = 748
2015-11-18 01:01:28,275 - DEBUG -  - DiffParser.parse: Finished parsing 
diff.
2015-11-18 01:01:36,063 - DEBUG -  - DiffParser.parse: Beginning parse of 
diff, size = 748
2015-11-18 01:01:36,063 - DEBUG -  - DiffParser.parse: Finished parsing 
diff.
2015-11-18 01:01:49,314 - DEBUG -  - Cache miss for key 
jsi18n-djangojs-reviewboard_djblets-en-1444348511.
2015-11-18 01:02:30,588 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
Generating diff viewer page for filediff id 405
2015-11-18 01:02:30,619 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
Begin: Generating diff file info for diffset id 405
2015-11-18 01:02:30,625 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
End: Generating diff file info for diffset id 405
2015-11-18 01:02:30,626 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
Generating diff file info for diffset id 405 took 0.005950 seconds
2015-11-18 01:02:30,630 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
Done generating diff viewer page for filediff id 405
2015-11-18 01:02:31,074 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff file info for 
diffset id 405, filediff 1876
2015-11-18 01:02:31,080 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - End: Generating diff file info for 
diffset id 405, filediff 1876
2015-11-18 01:02:31,081 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Generating diff file info for 
diffset id 405, filediff 1876 took 0.006040 seconds
2015-11-18 01:02:31,086 - DEBUG -  - Cache miss for key 
diffviewer/diff_file_fragment.html-0-3-1876-collapsed-highlighting-en-1444348487.
2015-11-18 01:02:31,087 - DEBUG -  - Cache miss for key 
diff-sidebyside-hl-1876-en.
2015-11-18 01:02:31,088 - DEBUG -  - Cache miss for key 
file:2:/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl%2Cv:1.1:.
2015-11-18 01:02:31,088 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Begin: Fetching file 
'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' r1.1 from CVS-prod
2015-11-18 01:02:33,822 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - End: Fetching file 
'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' r1.1 from CVS-prod
2015-11-18 01:02:33,824 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Fetching file 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-17 Thread Christian Hammond
Okay, you'll have to add 'import logging' to the line above the logging
statement.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Tue, Nov 17, 2015 at 5:09 PM, Wesly Chen  wrote:

> I modified
> --
> markup_b = self._apply_pygments(new or '', dest_file)
> except:
> pass
> 
> to
> 
> markup_b = self._apply_pygments(new or '', dest_file)
> except Exception as e:
> logging.exception('Failed to apply pygments: %s', e)
> --
>
> Then restarted memcached/httpd.
> loaded a diff file via rbt (rbt post -u -r 114 -I check_mysql_multirow.pl)
> and I got an error on UI
> 
>  There was an error displaying this diff.
>
> global name 'logging' is not defined
>
> Details:
> Traceback (most recent call last):
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/views.py",
> line 265, in get
> response = renderer.render_to_response(request)
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File
> "/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
> line 111, in cache_memoize
> data = lookup_callable()
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/diffutils.py",
> line 422, in populate_diff_chunks
> chunks = generator.get_chunks()
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
> line 161, in get_chunks
> large_data=True)
>   File
> "/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
> line 111, in cache_memoize
> data = lookup_callable()
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
> line 160, in 
> lambda: list(self._get_chunks_uncached()),
>   File
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
> line 236, in _get_chunks_uncached
> logging.exception('Failed to apply pygments: %s', e)
> NameError: global name 'logging' is not defined
> -
>
> Here is the reviewboard.log
> --
> 2015-11-18 01:01:28,274 - DEBUG -  - DiffParser.parse: Beginning parse of
> diff, size = 748
> 2015-11-18 01:01:28,275 - DEBUG -  - DiffParser.parse: Finished parsing
> diff.
> 2015-11-18 01:01:36,063 - DEBUG -  - DiffParser.parse: Beginning parse of
> diff, size = 748
> 2015-11-18 01:01:36,063 - DEBUG -  - DiffParser.parse: Finished parsing
> diff.
> 2015-11-18 01:01:49,314 - DEBUG -  - Cache miss for key
> jsi18n-djangojs-reviewboard_djblets-en-1444348511.
> 2015-11-18 01:02:30,588 - DEBUG - None - wchen - /reviews/r/114/diff/ -
> Generating diff viewer page for filediff id 405
> 2015-11-18 01:02:30,619 - DEBUG - None - wchen - /reviews/r/114/diff/ -
> Begin: Generating diff file info for diffset id 405
> 2015-11-18 01:02:30,625 - DEBUG - None - wchen - /reviews/r/114/diff/ -
> End: Generating diff file info for diffset id 405
> 2015-11-18 01:02:30,626 - DEBUG - None - wchen - /reviews/r/114/diff/ -
> Generating diff file info for diffset id 405 took 0.005950 seconds
> 2015-11-18 01:02:30,630 - DEBUG - None - wchen - /reviews/r/114/diff/ -
> Done generating diff viewer page for filediff id 405
> 2015-11-18 01:02:31,074 - DEBUG - None - wchen -
> /reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff file info for
> diffset id 405, filediff 1876
> 2015-11-18 01:02:31,080 - DEBUG - None - wchen -
> /reviews/r/114/diff/3/fragment/1876/ - End: Generating diff file info for
> diffset id 405, filediff 1876
> 2015-11-18 01:02:31,081 - DEBUG - None - wchen -
> /reviews/r/114/diff/3/fragment/1876/ - Generating diff file info for
> diffset id 405, filediff 1876 took 0.006040 seconds
> 2015-11-18 01:02:31,086 - DEBUG -  - Cache miss for key
> diffviewer/diff_file_fragment.html-0-3-1876-collapsed-highlighting-en-1444348487.
> 2015-11-18 01:02:31,087 - DEBUG -  - Cache miss for key
> diff-sidebyside-hl-1876-en.
> 2015-11-18 01:02:31,088 - DEBUG -  - Cache miss for key
> file:2:/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl%2Cv:1.1:.
> 2015-11-18 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-17 Thread Wesly Chen
2015-11-18 01:34:33,284 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Patching file 
check_mysql_multirow.pl took 0.042870 seconds
2015-11-18 01:34:33,409 - ERROR -  - Failed to apply pygments: no lexer for 
filename u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' found
Traceback (most recent call last):
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 231, in _get_chunks_uncached
markup_a = self._apply_pygments(old or '', source_file)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 654, in _apply_pygments
encoding='utf-8')
  File 
"/usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg/pygments/lexers/__init__.py",
 
line 149, in get_lexer_for_filename
raise ClassNotFound('no lexer for filename %r found' % _fn)
ClassNotFound: no lexer for filename 
u'/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v' found
2015-11-18 01:34:33,425 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff chunks for 
self.filediff id 1876 
(/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v)
2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - End: Generating diff chunks for 
self.filediff id 1876 
(/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v)
2015-11-18 01:34:33,432 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Generating diff chunks for 
self.filediff id 1876 
(/home/cvs/OPS/nagios/libexec/check_mysql_multirow.pl,v) took 0.006171 
seconds


Christian Hammond於 2015年11月17日星期二 UTC-8下午5時29分13秒寫道:
>
> Okay, you'll have to add 'import logging' to the line above the logging 
> statement.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Tue, Nov 17, 2015 at 5:09 PM, Wesly Chen  > wrote:
>
>> I modified 
>> --
>> markup_b = self._apply_pygments(new or '', dest_file)
>> except:
>> pass
>> 
>> to
>> 
>> markup_b = self._apply_pygments(new or '', dest_file)
>> except Exception as e:
>> logging.exception('Failed to apply pygments: %s', e)
>> --
>>
>> Then restarted memcached/httpd.
>> loaded a diff file via rbt (rbt post -u -r 114 -I check_mysql_multirow.pl
>> )
>> and I got an error on UI
>> 
>>  There was an error displaying this diff.
>> 
>> global name 'logging' is not defined
>>
>> Details:
>> Traceback (most recent call last):
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/views.py",
>>  
>> line 265, in get
>> response = renderer.render_to_response(request)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 56, in render_to_response
>> return HttpResponse(self.render_to_string(request))
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 74, in render_to_string
>> large_data=True)
>>   File 
>> "/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
>>  
>> line 111, in cache_memoize
>> data = lookup_callable()
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 73, in 
>> lambda: self.render_to_string_uncached(request),
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 87, in render_to_string_uncached
>> request=request)
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 422, in populate_diff_chunks
>> chunks = generator.get_chunks()
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 161, in get_chunks
>> large_data=True)
>>   File 
>> "/usr/lib/python2.6/site-packages/Djblets-0.8.22-py2.6.egg/djblets/cache/backend.py",
>>  
>> line 111, in cache_memoize
>> data = lookup_callable()
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 160, in 
>> lambda: list(self._get_chunks_uncached()),
>>   File 
>> "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 236, in _get_chunks_uncached
>> logging.exception('Failed to apply pygments: %s', e)
>> NameError: global name 'logging' is not defined
>> -
>>
>> Here is the reviewboard.log
>> --
>> 2015-11-18 01:01:28,274 - DEBUG -  - DiffParser.parse: Beginning parse of 
>> diff, size = 748
>> 2015-11-18 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-17 Thread Christian Hammond
They're part of the site_siteconfiguration table, but if it's showing as
checked, then that's fine. The issue you're hitting has not come up before,
that I've seen, so I expect it's something internal.

In that code block you pasted, there's this:

try:
# TODO: Try to figure out the right lexer for these files
#   once instead of twice.
if not source_file.endswith(self.STYLED_EXT_BLACKLIST):
markup_a = self._apply_pygments(old or '', source_file)

if not dest_file.endswith(self.STYLED_EXT_BLACKLIST):
markup_b = self._apply_pygments(new or '', dest_file)
except:
pass

Modify the last two lines to be:

except Exception as e:
logging.exception('Failed to apply pygments: %s', e)

Then restart, clear memcached, try loading a diff, and then check the logs
to see what it says.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Sun, Nov 15, 2015 at 9:45 AM, Wesly Chen  wrote:

> I can try.
> Could you tell me where are the following settings in MySQL database
> "reviewboard" so I can verify the setting is enabled in MySQL or not.
> 1. System setting => Diff Viewer settings => Show syntax highlighting  is
> checked.
> 2. Account settings " Enable syntax highlighting in the diff viewer" is
> checked.
>
> Thanks,
>
> Wesly
>
> Christian Hammond於 2015年11月15日星期日 UTC-8上午12時00分55秒寫道:
>>
>> Right. What were you looking to do with this file? Are you comfortable
>> debugging Python web applications?
>>
>> Christian
>>
>> --
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Sat, Nov 14, 2015 at 11:50 PM, Wesly Chen  wrote:
>>
>>> On my review board system, it is in
>>> /usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py
>>>   (not in diffutils.py)
>>> ---
>>> (started with line 219)
>>> if self._get_enable_syntax_highlighting(old, new, a, b):
>>> repository = self.filediff.diffset.repository
>>> tool = repository.get_scmtool()
>>> source_file = \
>>>
>>> tool.normalize_path_for_display(self.filediff.source_file)
>>> dest_file = \
>>> tool.normalize_path_for_display(self.filediff.dest_file)
>>>
>>> try:
>>> # TODO: Try to figure out the right lexer for these files
>>> #   once instead of twice.
>>> if not source_file.endswith(self.STYLED_EXT_BLACKLIST):
>>> markup_a = self._apply_pygments(old or '',
>>> source_file)
>>>
>>> if not dest_file.endswith(self.STYLED_EXT_BLACKLIST):
>>> markup_b = self._apply_pygments(new or '', dest_file)
>>> except:
>>> pass
>>> ...
>>> (line 646)
>>> def _apply_pygments(self, data, filename):
>>> """Applies Pygments syntax-highlighting to a file's contents.
>>>
>>> The resulting HTML will be returned as a list of lines.
>>> """
>>> lexer = get_lexer_for_filename(filename,
>>>stripnl=False,
>>>encoding='utf-8')
>>> lexer.add_filter('codetagify')
>>>
>>> return split_line_endings(
>>> highlight(data, lexer, NoWrapperHtmlFormatter()))
>>> ---
>>>
>>> Christian Hammond於 2015年11月14日星期六 UTC-8下午11時36分59秒寫道:

 It's in reviewboard/diffviewer/diffutils.py. Look for apply_pygments.

 Christian

 --
 Christian Hammond - chri...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Sat, Nov 14, 2015 at 11:35 PM, Wesly Chen 
 wrote:

> Could you point out which python files under
>
> /usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/
> is showing the syntax highlighting in Diff Viewer?
>
> Thanks,
>
> Wesly
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-15 Thread Christian Hammond
Right. What were you looking to do with this file? Are you comfortable
debugging Python web applications?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Sat, Nov 14, 2015 at 11:50 PM, Wesly Chen  wrote:

> On my review board system, it is in
> /usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py
>   (not in diffutils.py)
> ---
> (started with line 219)
> if self._get_enable_syntax_highlighting(old, new, a, b):
> repository = self.filediff.diffset.repository
> tool = repository.get_scmtool()
> source_file = \
> tool.normalize_path_for_display(self.filediff.source_file)
> dest_file = \
> tool.normalize_path_for_display(self.filediff.dest_file)
>
> try:
> # TODO: Try to figure out the right lexer for these files
> #   once instead of twice.
> if not source_file.endswith(self.STYLED_EXT_BLACKLIST):
> markup_a = self._apply_pygments(old or '', source_file)
>
> if not dest_file.endswith(self.STYLED_EXT_BLACKLIST):
> markup_b = self._apply_pygments(new or '', dest_file)
> except:
> pass
> ...
> (line 646)
> def _apply_pygments(self, data, filename):
> """Applies Pygments syntax-highlighting to a file's contents.
>
> The resulting HTML will be returned as a list of lines.
> """
> lexer = get_lexer_for_filename(filename,
>stripnl=False,
>encoding='utf-8')
> lexer.add_filter('codetagify')
>
> return split_line_endings(
> highlight(data, lexer, NoWrapperHtmlFormatter()))
> ---
>
> Christian Hammond於 2015年11月14日星期六 UTC-8下午11時36分59秒寫道:
>>
>> It's in reviewboard/diffviewer/diffutils.py. Look for apply_pygments.
>>
>> Christian
>>
>> --
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Sat, Nov 14, 2015 at 11:35 PM, Wesly Chen  wrote:
>>
>>> Could you point out which python files under
>>>
>>> /usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/
>>> is showing the syntax highlighting in Diff Viewer?
>>>
>>> Thanks,
>>>
>>> Wesly
>>>
>>> Christian Hammond於 2015年11月14日星期六 UTC-8下午11時09分49秒寫道:

 There's no file or configuration to check. This stuff is built to work
 in Review Board. The only option I can offer right now is to check a file
 that's having problems on our end to see if it's a regression in Review
 Board.

 Christian

 --
 Christian Hammond - chri...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Sat, Nov 14, 2015 at 11:08 PM, Wesly Chen 
 wrote:

> Here is the python modules on the system. Which file I should check
> for the configuration? I'm not familiar with python.
>
> # ls -lg /usr/lib/python2.6/site-packages/*ygment*
> /usr/lib/python2.6/site-packages/pygments:
> total 1080
> -rw-r--r-- 1 root  13055 Sep 15  2009 cmdline.py
> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyc
> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyo
> -rw-r--r-- 1 root   1850 Sep 15  2009 console.py
> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyc
> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyo
> -rw-r--r-- 1 root   2071 Sep 15  2009 filter.py
> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyc
> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyo
> drwxr-xr-x 2 root   4096 Aug 12 23:28 filters
> -rw-r--r-- 1 root   2790 Sep 15  2009 formatter.py
> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyc
> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyo
> drwxr-xr-x 2 root   4096 Aug 12 23:28 formatters
> -rw-r--r-- 1 root   2935 Sep 15  2009 __init__.py
> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyc
> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyo
> -rw-r--r-- 1 root  22625 Sep 15  2009 lexer.py
> -rw-r--r-- 1 root  20971 Aug 16  2010 lexer.pyc
> -rw-r--r-- 1 root  20204 Aug 16  2010 lexer.pyo
> drwxr-xr-x 2 root   4096 Aug 12 23:28 lexers
> -rw-r--r-- 1 root   1862 Sep 15  2009 plugin.py
> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyc
> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyo
> -rw-r--r-- 1 root   3114 Sep 15  2009 scanner.py
> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyc
> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyo
> -rw-r--r-- 1 root   3745 Sep 15  2009 style.py
> -rw-r--r-- 1 root   3943 Aug 16  2010 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-15 Thread Wesly Chen
I can try.
Could you tell me where are the following settings in MySQL database 
"reviewboard" so I can verify the setting is enabled in MySQL or not.
1. System setting => Diff Viewer settings => Show syntax highlighting  is 
checked.
2. Account settings " Enable syntax highlighting in the diff viewer" is 
checked.

Thanks,

Wesly

Christian Hammond於 2015年11月15日星期日 UTC-8上午12時00分55秒寫道:
>
> Right. What were you looking to do with this file? Are you comfortable 
> debugging Python web applications?
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Sat, Nov 14, 2015 at 11:50 PM, Wesly Chen  > wrote:
>
>> On my review board system, it is in 
>> /usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py
>>  
>>   (not in diffutils.py)
>> ---
>> (started with line 219) 
>> if self._get_enable_syntax_highlighting(old, new, a, b):
>> repository = self.filediff.diffset.repository
>> tool = repository.get_scmtool()
>> source_file = \
>> tool.normalize_path_for_display(self.filediff.source_file)
>> dest_file = \
>> tool.normalize_path_for_display(self.filediff.dest_file)
>>
>> try:
>> # TODO: Try to figure out the right lexer for these files
>> #   once instead of twice.
>> if not source_file.endswith(self.STYLED_EXT_BLACKLIST):
>> markup_a = self._apply_pygments(old or '', 
>> source_file)
>>
>> if not dest_file.endswith(self.STYLED_EXT_BLACKLIST):
>> markup_b = self._apply_pygments(new or '', dest_file)
>> except:
>> pass
>> ...
>> (line 646)
>> def _apply_pygments(self, data, filename):
>> """Applies Pygments syntax-highlighting to a file's contents.
>>
>> The resulting HTML will be returned as a list of lines.
>> """
>> lexer = get_lexer_for_filename(filename,
>>stripnl=False,
>>encoding='utf-8')
>> lexer.add_filter('codetagify')
>>
>> return split_line_endings(
>> highlight(data, lexer, NoWrapperHtmlFormatter()))
>> ---
>>
>> Christian Hammond於 2015年11月14日星期六 UTC-8下午11時36分59秒寫道:
>>>
>>> It's in reviewboard/diffviewer/diffutils.py. Look for apply_pygments.
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chri...@beanbaginc.com
>>> Review Board - https://www.reviewboard.org
>>> Beanbag, Inc. - https://www.beanbaginc.com
>>>
>>> On Sat, Nov 14, 2015 at 11:35 PM, Wesly Chen  wrote:
>>>
 Could you point out which python files under 

 /usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/ 
 is showing the syntax highlighting in Diff Viewer?

 Thanks,

 Wesly 



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Christian Hammond
I'll need that information to be able to diagnose the issue. As it is, I
have no insight into what could be going wrong, and would have to run tests
here.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Sat, Nov 14, 2015 at 10:49 PM, Wesly Chen  wrote:

> All the diff upload by "rbt post" doesn't show syntax highlight in Diff
> Viewer. However, "syntax highlighting" with attached file (java), just not
> in Diff Viewer.
>
> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:
>>
>> Can you check if there's anything in the logs?
>>
>> Do you have a file you can send that reproduces the problem?
>>
>> Christian
>>
>> --
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  wrote:
>>
>>> Here is some python package information
>>>
>>> #  ls -1 /usr/lib/python2.6/site-packages/
>>>
>>> argparse-1.2.1-py2.6.egg-info
>>> argparse.py
>>> argparse.pyc
>>> argparse.pyo
>>> asciidocapi.py
>>> asciidocapi.pyc
>>> asciidocapi.pyo
>>> dateutil
>>> dbus
>>> dbus_bindings.py
>>> dbus_bindings.pyc
>>> dbus_bindings.pyo
>>> distribute-0.6.10-py2.6.egg-info
>>> django
>>> Django-1.4.21-py2.6.egg-info
>>> Django-1.6.11-py2.6.egg
>>> django_evolution
>>> django_evolution-0.6.9-py2.6.egg-info
>>> django_evolution-0.7.5-py2.6.egg
>>> django_haystack-2.4.0-py2.6.egg
>>> django_pipeline-1.2.24-py2.6.egg-info
>>> django_pipeline-1.3.27-py2.6.egg
>>> djblets
>>> Djblets-0.7.30-py2.6.egg-info
>>> Djblets-0.8.22-py2.6.egg
>>> docutils
>>> docutils-0.6-py2.6.egg-info
>>> easy-install.pth
>>> easy_install.py
>>> easy_install.pyc
>>> easy_install.pyo
>>> ecdsa-0.13-py2.6.egg
>>> feedparser-5.1.2-py2.6.egg-info
>>> feedparser.py
>>> feedparser.pyc
>>> feedparser.pyo
>>> flup
>>> flup-1.0.2-py2.6.egg-info
>>> futures-3.0.3-py2.6.egg
>>> iniparse
>>> iniparse-0.3.1-py2.6.egg-info
>>> libproxy.py
>>> libproxy.pyc
>>> libproxy.pyo
>>> markdown
>>> Markdown-2.0.1-py2.6.egg-info
>>> Markdown-2.4.1-py2.6.egg
>>> memcache.py
>>> memcache.pyc
>>> memcache.pyo
>>> mimeparse-0.1.3-py2.6.egg
>>> mimeparse.py
>>> mimeparse.pyc
>>> mimeparse.pyo
>>> nose
>>> nose-0.10.4-py2.6.egg-info
>>> odict
>>> odict-1.5.0-py2.6.egg-info
>>> paramiko
>>> paramiko-1.15.3-py2.6.egg
>>> paramiko-1.7.5-py2.6.egg-info
>>> pillowfight-0.2-py2.6.egg
>>> pipeline
>>> pkg_resources.py
>>> pkg_resources.pyc
>>> pkg_resources.pyo
>>> ply
>>> ply-3.4-py2.6.egg-info
>>> pycrypto-2.6.1-py2.6-linux-x86_64.egg
>>> pygments
>>> Pygments-1.1.1-py2.6.egg-info
>>> Pygments-2.0.2-py2.6.egg
>>> python_dateutil-1.4.1-py2.6.egg-info
>>> python_dateutil-1.5-py2.6.egg
>>> python_memcached-1.43-py2.6.egg-info
>>> python_mimeparse-0.1.4-py2.6.egg-info
>>> pytz
>>> pytz-2010h-py2.6.egg-info
>>> RBTools-0.8alpha0.dev-py2.6.egg
>>> recaptcha
>>> recaptcha_client-1.0.6-py2.6.egg-info
>>> recaptcha_client-1.0.6-py2.6-nspkg.pth
>>> reviewboard
>>> ReviewBoard-1.7.27-py2.6.egg-info
>>> ReviewBoard-2.0.20-py2.6.egg
>>> roman.py
>>> roman.pyc
>>> roman.pyo
>>> rpmUtils
>>> setuptools
>>> setuptools-0.6c11-py2.6.egg-info
>>> setuptools.pth
>>> site.py
>>> site.pyc
>>> site.pyo
>>> six-1.9.0-py2.6.egg
>>> slimit
>>> slimit-0.8.1-py2.6.egg-info
>>> sos
>>> urlgrabber
>>> urlgrabber-3.9.1-py2.6.egg-info
>>> webtests
>>> Whoosh-2.7.0-py2.6.egg
>>> yum
>>> yumutils
>>>
>>>
>>> Wesly Chen於 2015年11月14日星期六 UTC-8下午3時22分01秒寫道:
>>>
 1. System setting => Diff Viewer settings => Show syntax highlighting
  is checked.
 2. Account settings " Enable syntax highlighting in the diff viewer"
 is checked.

 My system is CentOS 6.5 64-bit with MySQL 5.1.

 Any information needed for this issue?


 --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Christian Hammond
Can you check if there's anything in the logs?

Do you have a file you can send that reproduces the problem?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  wrote:

> Here is some python package information
>
> #  ls -1 /usr/lib/python2.6/site-packages/
>
> argparse-1.2.1-py2.6.egg-info
> argparse.py
> argparse.pyc
> argparse.pyo
> asciidocapi.py
> asciidocapi.pyc
> asciidocapi.pyo
> dateutil
> dbus
> dbus_bindings.py
> dbus_bindings.pyc
> dbus_bindings.pyo
> distribute-0.6.10-py2.6.egg-info
> django
> Django-1.4.21-py2.6.egg-info
> Django-1.6.11-py2.6.egg
> django_evolution
> django_evolution-0.6.9-py2.6.egg-info
> django_evolution-0.7.5-py2.6.egg
> django_haystack-2.4.0-py2.6.egg
> django_pipeline-1.2.24-py2.6.egg-info
> django_pipeline-1.3.27-py2.6.egg
> djblets
> Djblets-0.7.30-py2.6.egg-info
> Djblets-0.8.22-py2.6.egg
> docutils
> docutils-0.6-py2.6.egg-info
> easy-install.pth
> easy_install.py
> easy_install.pyc
> easy_install.pyo
> ecdsa-0.13-py2.6.egg
> feedparser-5.1.2-py2.6.egg-info
> feedparser.py
> feedparser.pyc
> feedparser.pyo
> flup
> flup-1.0.2-py2.6.egg-info
> futures-3.0.3-py2.6.egg
> iniparse
> iniparse-0.3.1-py2.6.egg-info
> libproxy.py
> libproxy.pyc
> libproxy.pyo
> markdown
> Markdown-2.0.1-py2.6.egg-info
> Markdown-2.4.1-py2.6.egg
> memcache.py
> memcache.pyc
> memcache.pyo
> mimeparse-0.1.3-py2.6.egg
> mimeparse.py
> mimeparse.pyc
> mimeparse.pyo
> nose
> nose-0.10.4-py2.6.egg-info
> odict
> odict-1.5.0-py2.6.egg-info
> paramiko
> paramiko-1.15.3-py2.6.egg
> paramiko-1.7.5-py2.6.egg-info
> pillowfight-0.2-py2.6.egg
> pipeline
> pkg_resources.py
> pkg_resources.pyc
> pkg_resources.pyo
> ply
> ply-3.4-py2.6.egg-info
> pycrypto-2.6.1-py2.6-linux-x86_64.egg
> pygments
> Pygments-1.1.1-py2.6.egg-info
> Pygments-2.0.2-py2.6.egg
> python_dateutil-1.4.1-py2.6.egg-info
> python_dateutil-1.5-py2.6.egg
> python_memcached-1.43-py2.6.egg-info
> python_mimeparse-0.1.4-py2.6.egg-info
> pytz
> pytz-2010h-py2.6.egg-info
> RBTools-0.8alpha0.dev-py2.6.egg
> recaptcha
> recaptcha_client-1.0.6-py2.6.egg-info
> recaptcha_client-1.0.6-py2.6-nspkg.pth
> reviewboard
> ReviewBoard-1.7.27-py2.6.egg-info
> ReviewBoard-2.0.20-py2.6.egg
> roman.py
> roman.pyc
> roman.pyo
> rpmUtils
> setuptools
> setuptools-0.6c11-py2.6.egg-info
> setuptools.pth
> site.py
> site.pyc
> site.pyo
> six-1.9.0-py2.6.egg
> slimit
> slimit-0.8.1-py2.6.egg-info
> sos
> urlgrabber
> urlgrabber-3.9.1-py2.6.egg-info
> webtests
> Whoosh-2.7.0-py2.6.egg
> yum
> yumutils
>
>
> Wesly Chen於 2015年11月14日星期六 UTC-8下午3時22分01秒寫道:
>
>> 1. System setting => Diff Viewer settings => Show syntax highlighting
>>  is checked.
>> 2. Account settings " Enable syntax highlighting in the diff viewer" is
>> checked.
>>
>> My system is CentOS 6.5 64-bit with MySQL 5.1.
>>
>> Any information needed for this issue?
>>
>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Wesly Chen
All the diff upload by "rbt post" doesn't show syntax highlight in Diff 
Viewer. However, "syntax highlighting" with attached file (java), just not 
in Diff Viewer.

Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:
>
> Can you check if there's anything in the logs?
>
> Do you have a file you can send that reproduces the problem?
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  > wrote:
>
>> Here is some python package information
>>
>> #  ls -1 /usr/lib/python2.6/site-packages/
>>
>> argparse-1.2.1-py2.6.egg-info
>> argparse.py
>> argparse.pyc
>> argparse.pyo
>> asciidocapi.py
>> asciidocapi.pyc
>> asciidocapi.pyo
>> dateutil
>> dbus
>> dbus_bindings.py
>> dbus_bindings.pyc
>> dbus_bindings.pyo
>> distribute-0.6.10-py2.6.egg-info
>> django
>> Django-1.4.21-py2.6.egg-info
>> Django-1.6.11-py2.6.egg
>> django_evolution
>> django_evolution-0.6.9-py2.6.egg-info
>> django_evolution-0.7.5-py2.6.egg
>> django_haystack-2.4.0-py2.6.egg
>> django_pipeline-1.2.24-py2.6.egg-info
>> django_pipeline-1.3.27-py2.6.egg
>> djblets
>> Djblets-0.7.30-py2.6.egg-info
>> Djblets-0.8.22-py2.6.egg
>> docutils
>> docutils-0.6-py2.6.egg-info
>> easy-install.pth
>> easy_install.py
>> easy_install.pyc
>> easy_install.pyo
>> ecdsa-0.13-py2.6.egg
>> feedparser-5.1.2-py2.6.egg-info
>> feedparser.py
>> feedparser.pyc
>> feedparser.pyo
>> flup
>> flup-1.0.2-py2.6.egg-info
>> futures-3.0.3-py2.6.egg
>> iniparse
>> iniparse-0.3.1-py2.6.egg-info
>> libproxy.py
>> libproxy.pyc
>> libproxy.pyo
>> markdown
>> Markdown-2.0.1-py2.6.egg-info
>> Markdown-2.4.1-py2.6.egg
>> memcache.py
>> memcache.pyc
>> memcache.pyo
>> mimeparse-0.1.3-py2.6.egg
>> mimeparse.py
>> mimeparse.pyc
>> mimeparse.pyo
>> nose
>> nose-0.10.4-py2.6.egg-info
>> odict
>> odict-1.5.0-py2.6.egg-info
>> paramiko
>> paramiko-1.15.3-py2.6.egg
>> paramiko-1.7.5-py2.6.egg-info
>> pillowfight-0.2-py2.6.egg
>> pipeline
>> pkg_resources.py
>> pkg_resources.pyc
>> pkg_resources.pyo
>> ply
>> ply-3.4-py2.6.egg-info
>> pycrypto-2.6.1-py2.6-linux-x86_64.egg
>> pygments
>> Pygments-1.1.1-py2.6.egg-info
>> Pygments-2.0.2-py2.6.egg
>> python_dateutil-1.4.1-py2.6.egg-info
>> python_dateutil-1.5-py2.6.egg
>> python_memcached-1.43-py2.6.egg-info
>> python_mimeparse-0.1.4-py2.6.egg-info
>> pytz
>> pytz-2010h-py2.6.egg-info
>> RBTools-0.8alpha0.dev-py2.6.egg
>> recaptcha
>> recaptcha_client-1.0.6-py2.6.egg-info
>> recaptcha_client-1.0.6-py2.6-nspkg.pth
>> reviewboard
>> ReviewBoard-1.7.27-py2.6.egg-info
>> ReviewBoard-2.0.20-py2.6.egg
>> roman.py
>> roman.pyc
>> roman.pyo
>> rpmUtils
>> setuptools
>> setuptools-0.6c11-py2.6.egg-info
>> setuptools.pth
>> site.py
>> site.pyc
>> site.pyo
>> six-1.9.0-py2.6.egg
>> slimit
>> slimit-0.8.1-py2.6.egg-info
>> sos
>> urlgrabber
>> urlgrabber-3.9.1-py2.6.egg-info
>> webtests
>> Whoosh-2.7.0-py2.6.egg
>> yum
>> yumutils
>>
>>
>> Wesly Chen於 2015年11月14日星期六 UTC-8下午3時22分01秒寫道:
>>
>>> 1. System setting => Diff Viewer settings => Show syntax highlighting 
>>>  is checked.
>>> 2. Account settings " Enable syntax highlighting in the diff viewer" is 
>>> checked.
>>>
>>> My system is CentOS 6.5 64-bit with MySQL 5.1.
>>>
>>> Any information needed for this issue?
>>>
>>>
>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Wesly Chen
I uploaded portion of the java file as the screenshot show. 
We use CVS as repository.

Christian Hammond於 2015年11月14日星期六 UTC-8下午10時50分48秒寫道:
>
> I'll need that information to be able to diagnose the issue. As it is, I 
> have no insight into what could be going wrong, and would have to run tests 
> here.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Sat, Nov 14, 2015 at 10:49 PM, Wesly Chen  > wrote:
>
>> All the diff upload by "rbt post" doesn't show syntax highlight in Diff 
>> Viewer. However, "syntax highlighting" with attached file (java), just not 
>> in Diff Viewer.
>>
>> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:
>>>
>>> Can you check if there's anything in the logs?
>>>
>>> Do you have a file you can send that reproduces the problem?
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chri...@beanbaginc.com
>>> Review Board - https://www.reviewboard.org
>>> Beanbag, Inc. - https://www.beanbaginc.com
>>>
>>> On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  wrote:
>>>
 Here is some python package information

 #  ls -1 /usr/lib/python2.6/site-packages/

 argparse-1.2.1-py2.6.egg-info
 argparse.py
 argparse.pyc
 argparse.pyo
 asciidocapi.py
 asciidocapi.pyc
 asciidocapi.pyo
 dateutil
 dbus
 dbus_bindings.py
 dbus_bindings.pyc
 dbus_bindings.pyo
 distribute-0.6.10-py2.6.egg-info
 django
 Django-1.4.21-py2.6.egg-info
 Django-1.6.11-py2.6.egg
 django_evolution
 django_evolution-0.6.9-py2.6.egg-info
 django_evolution-0.7.5-py2.6.egg
 django_haystack-2.4.0-py2.6.egg
 django_pipeline-1.2.24-py2.6.egg-info
 django_pipeline-1.3.27-py2.6.egg
 djblets
 Djblets-0.7.30-py2.6.egg-info
 Djblets-0.8.22-py2.6.egg
 docutils
 docutils-0.6-py2.6.egg-info
 easy-install.pth
 easy_install.py
 easy_install.pyc
 easy_install.pyo
 ecdsa-0.13-py2.6.egg
 feedparser-5.1.2-py2.6.egg-info
 feedparser.py
 feedparser.pyc
 feedparser.pyo
 flup
 flup-1.0.2-py2.6.egg-info
 futures-3.0.3-py2.6.egg
 iniparse
 iniparse-0.3.1-py2.6.egg-info
 libproxy.py
 libproxy.pyc
 libproxy.pyo
 markdown
 Markdown-2.0.1-py2.6.egg-info
 Markdown-2.4.1-py2.6.egg
 memcache.py
 memcache.pyc
 memcache.pyo
 mimeparse-0.1.3-py2.6.egg
 mimeparse.py
 mimeparse.pyc
 mimeparse.pyo
 nose
 nose-0.10.4-py2.6.egg-info
 odict
 odict-1.5.0-py2.6.egg-info
 paramiko
 paramiko-1.15.3-py2.6.egg
 paramiko-1.7.5-py2.6.egg-info
 pillowfight-0.2-py2.6.egg
 pipeline
 pkg_resources.py
 pkg_resources.pyc
 pkg_resources.pyo
 ply
 ply-3.4-py2.6.egg-info
 pycrypto-2.6.1-py2.6-linux-x86_64.egg
 pygments
 Pygments-1.1.1-py2.6.egg-info
 Pygments-2.0.2-py2.6.egg
 python_dateutil-1.4.1-py2.6.egg-info
 python_dateutil-1.5-py2.6.egg
 python_memcached-1.43-py2.6.egg-info
 python_mimeparse-0.1.4-py2.6.egg-info
 pytz
 pytz-2010h-py2.6.egg-info
 RBTools-0.8alpha0.dev-py2.6.egg
 recaptcha
 recaptcha_client-1.0.6-py2.6.egg-info
 recaptcha_client-1.0.6-py2.6-nspkg.pth
 reviewboard
 ReviewBoard-1.7.27-py2.6.egg-info
 ReviewBoard-2.0.20-py2.6.egg
 roman.py
 roman.pyc
 roman.pyo
 rpmUtils
 setuptools
 setuptools-0.6c11-py2.6.egg-info
 setuptools.pth
 site.py
 site.pyc
 site.pyo
 six-1.9.0-py2.6.egg
 slimit
 slimit-0.8.1-py2.6.egg-info
 sos
 urlgrabber
 urlgrabber-3.9.1-py2.6.egg-info
 webtests
 Whoosh-2.7.0-py2.6.egg
 yum
 yumutils


 Wesly Chen於 2015年11月14日星期六 UTC-8下午3時22分01秒寫道:

> 1. System setting => Diff Viewer settings => Show syntax highlighting 
>  is checked.
> 2. Account settings " Enable syntax highlighting in the diff viewer" 
> is checked.
>
> My system is CentOS 6.5 64-bit with MySQL 5.1.
>
> Any information needed for this issue?
>
>
> -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Christian Hammond
It's in reviewboard/diffviewer/diffutils.py. Look for apply_pygments.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Sat, Nov 14, 2015 at 11:35 PM, Wesly Chen  wrote:

> Could you point out which python files under
> /usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/
> is showing the syntax highlighting in Diff Viewer?
>
> Thanks,
>
> Wesly
>
> Christian Hammond於 2015年11月14日星期六 UTC-8下午11時09分49秒寫道:
>>
>> There's no file or configuration to check. This stuff is built to work in
>> Review Board. The only option I can offer right now is to check a file
>> that's having problems on our end to see if it's a regression in Review
>> Board.
>>
>> Christian
>>
>> --
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Sat, Nov 14, 2015 at 11:08 PM, Wesly Chen  wrote:
>>
>>> Here is the python modules on the system. Which file I should check for
>>> the configuration? I'm not familiar with python.
>>>
>>> # ls -lg /usr/lib/python2.6/site-packages/*ygment*
>>> /usr/lib/python2.6/site-packages/pygments:
>>> total 1080
>>> -rw-r--r-- 1 root  13055 Sep 15  2009 cmdline.py
>>> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyc
>>> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyo
>>> -rw-r--r-- 1 root   1850 Sep 15  2009 console.py
>>> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyc
>>> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyo
>>> -rw-r--r-- 1 root   2071 Sep 15  2009 filter.py
>>> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyc
>>> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyo
>>> drwxr-xr-x 2 root   4096 Aug 12 23:28 filters
>>> -rw-r--r-- 1 root   2790 Sep 15  2009 formatter.py
>>> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyc
>>> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyo
>>> drwxr-xr-x 2 root   4096 Aug 12 23:28 formatters
>>> -rw-r--r-- 1 root   2935 Sep 15  2009 __init__.py
>>> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyc
>>> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyo
>>> -rw-r--r-- 1 root  22625 Sep 15  2009 lexer.py
>>> -rw-r--r-- 1 root  20971 Aug 16  2010 lexer.pyc
>>> -rw-r--r-- 1 root  20204 Aug 16  2010 lexer.pyo
>>> drwxr-xr-x 2 root   4096 Aug 12 23:28 lexers
>>> -rw-r--r-- 1 root   1862 Sep 15  2009 plugin.py
>>> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyc
>>> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyo
>>> -rw-r--r-- 1 root   3114 Sep 15  2009 scanner.py
>>> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyc
>>> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyo
>>> -rw-r--r-- 1 root   3745 Sep 15  2009 style.py
>>> -rw-r--r-- 1 root   3943 Aug 16  2010 style.pyc
>>> -rw-r--r-- 1 root   3867 Aug 16  2010 style.pyo
>>> drwxr-xr-x 2 root   4096 Aug 12 23:28 styles
>>> -rw-r--r-- 1 root   5784 Sep 15  2009 token.py
>>> -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyc
>>> -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyo
>>> -rw-r--r-- 1 root 404249 Sep 15  2009 unistring.py
>>> -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyc
>>> -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyo
>>> -rw-r--r-- 1 root   6431 Sep 15  2009 util.py
>>> -rw-r--r-- 2 root   7706 Aug 16  2010 util.pyc
>>> -rw-r--r-- 2 root   7706 Aug 16  2010 util.pyo
>>>
>>> /usr/lib/python2.6/site-packages/Pygments-1.1.1-py2.6.egg-info:
>>> total 24
>>> -rw-r--r-- 1 root1 Aug 16  2010 dependency_links.txt
>>> -rw-r--r-- 1 root1 Feb  6  2009 not-zip-safe
>>> -rw-r--r-- 1 root 1831 Aug 16  2010 PKG-INFO
>>> -rw-r--r-- 1 root 7520 Aug 16  2010 SOURCES.txt
>>> -rw-r--r-- 1 root9 Aug 16  2010 top_level.txt
>>>
>>> /usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg:
>>> total 8
>>> drwxr-xr-x 2 root 4096 Oct  8 23:54 EGG-INFO
>>> drwxr-xr-x 6 root 4096 Oct  8 23:54 pygments
>>>
>>>
>>> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時54分38秒寫道:

 We use Pygments for syntax highlighting.

 We changed how we do syntax highlighting in 2.5, and it may have an
 issue with your files.

 Christian

 --
 Christian Hammond - chri...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Sat, Nov 14, 2015 at 10:52 PM, Wesly Chen 
 wrote:

> Which python modules or libraries are used for syntax highlighting? I
> would like to check those modules or libraries to see if some 
> configuration
> run or file corruption.
>
> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:
>>
>> Can you check if there's anything in the logs?
>>
>> Do you have a file you can send that reproduces the problem?
>>
>> Christian
>>
>> --
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Wesly Chen
I tried to upgrade to 2.5.11 and failed (at another thread),

Here is my log (reviewboard.log), no error.

2015-11-15 07:22:07,902 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Begin: Fetching file 
'/home/cvs/OPS/nagios/libexec/check_mysql_rows.pl,v' r1.1 from CVS-prod
2015-11-15 07:22:10,202 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - End: Fetching file 
'/home/cvs/OPS/nagios/libexec/check_mysql_rows.pl,v' r1.1 from CVS-prod
2015-11-15 07:22:10,203 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Fetching file 
'/home/cvs/OPS/nagios/libexec/check_mysql_rows.pl,v' r1.1 from CVS-prod 
took 2.299647 seconds
2015-11-15 07:22:10,212 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Begin: Patching file 
check_mysql_rows.pl
2015-11-15 07:22:10,243 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - End: Patching file 
check_mysql_rows.pl
2015-11-15 07:22:10,244 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Patching file check_mysql_rows.pl 
took 0.030828 seconds
2015-11-15 07:22:10,252 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Begin: Generating diff chunks for 
self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/check_mysql_rows.pl,v)
2015-11-15 07:22:10,256 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - End: Generating diff chunks for 
self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/check_mysql_rows.pl,v)
2015-11-15 07:22:10,256 - DEBUG - None - wchen - 
/reviews/r/114/diff/3/fragment/1876/ - Generating diff chunks for 
self.filediff id 1876 (/home/cvs/OPS/nagios/libexec/check_mysql_rows.pl,v) 
took 0.003941 seconds
2015-11-15 07:22:40,971 - DEBUG - None - wchen - /reviews/r/114/diff/3/ - 
Generating diff viewer page for filediff id 405
2015-11-15 07:22:40,994 - DEBUG - None - wchen - /reviews/r/114/diff/3/ - 
Begin: Generating diff file info for diffset id 405
2015-11-15 07:22:41,001 - DEBUG - None - wchen - /reviews/r/114/diff/3/ - 
End: Generating diff file info for diffset id 405
2015-11-15 07:22:41,001 - DEBUG - None - wchen - /reviews/r/114/diff/3/ - 
Generating diff file info for diffset id 405 took 0.006689 seconds
2015-11-15 07:22:41,006 - DEBUG - None - wchen - /reviews/r/114/diff/3/ - 
Done generating diff viewer page for filediff id 405
2015-11-15 07:25:31,015 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
Generating diff viewer page for filediff id 405
2015-11-15 07:25:31,044 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
Begin: Generating diff file info for diffset id 405
2015-11-15 07:25:31,050 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
End: Generating diff file info for diffset id 405
2015-11-15 07:25:31,050 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
Generating diff file info for diffset id 405 took 0.005544 seconds
2015-11-15 07:25:31,056 - DEBUG - None - wchen - /reviews/r/114/diff/ - 
Done generating diff viewer page for filediff id 405


Christian Hammond於 2015年11月14日星期六 UTC-8下午11時34分55秒寫道:
>
> For some reason I had thought you were using Review Board 2.5, I think 
> because of the other support e-mails. So it's not a regression after all.
>
> Can you check the Review Board log file, see if there are any errors when 
> viewing a review request?
>
> Christian
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Christian Hammond
There's no file or configuration to check. This stuff is built to work in
Review Board. The only option I can offer right now is to check a file
that's having problems on our end to see if it's a regression in Review
Board.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Sat, Nov 14, 2015 at 11:08 PM, Wesly Chen  wrote:

> Here is the python modules on the system. Which file I should check for
> the configuration? I'm not familiar with python.
>
> # ls -lg /usr/lib/python2.6/site-packages/*ygment*
> /usr/lib/python2.6/site-packages/pygments:
> total 1080
> -rw-r--r-- 1 root  13055 Sep 15  2009 cmdline.py
> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyc
> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyo
> -rw-r--r-- 1 root   1850 Sep 15  2009 console.py
> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyc
> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyo
> -rw-r--r-- 1 root   2071 Sep 15  2009 filter.py
> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyc
> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyo
> drwxr-xr-x 2 root   4096 Aug 12 23:28 filters
> -rw-r--r-- 1 root   2790 Sep 15  2009 formatter.py
> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyc
> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyo
> drwxr-xr-x 2 root   4096 Aug 12 23:28 formatters
> -rw-r--r-- 1 root   2935 Sep 15  2009 __init__.py
> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyc
> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyo
> -rw-r--r-- 1 root  22625 Sep 15  2009 lexer.py
> -rw-r--r-- 1 root  20971 Aug 16  2010 lexer.pyc
> -rw-r--r-- 1 root  20204 Aug 16  2010 lexer.pyo
> drwxr-xr-x 2 root   4096 Aug 12 23:28 lexers
> -rw-r--r-- 1 root   1862 Sep 15  2009 plugin.py
> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyc
> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyo
> -rw-r--r-- 1 root   3114 Sep 15  2009 scanner.py
> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyc
> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyo
> -rw-r--r-- 1 root   3745 Sep 15  2009 style.py
> -rw-r--r-- 1 root   3943 Aug 16  2010 style.pyc
> -rw-r--r-- 1 root   3867 Aug 16  2010 style.pyo
> drwxr-xr-x 2 root   4096 Aug 12 23:28 styles
> -rw-r--r-- 1 root   5784 Sep 15  2009 token.py
> -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyc
> -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyo
> -rw-r--r-- 1 root 404249 Sep 15  2009 unistring.py
> -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyc
> -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyo
> -rw-r--r-- 1 root   6431 Sep 15  2009 util.py
> -rw-r--r-- 2 root   7706 Aug 16  2010 util.pyc
> -rw-r--r-- 2 root   7706 Aug 16  2010 util.pyo
>
> /usr/lib/python2.6/site-packages/Pygments-1.1.1-py2.6.egg-info:
> total 24
> -rw-r--r-- 1 root1 Aug 16  2010 dependency_links.txt
> -rw-r--r-- 1 root1 Feb  6  2009 not-zip-safe
> -rw-r--r-- 1 root 1831 Aug 16  2010 PKG-INFO
> -rw-r--r-- 1 root 7520 Aug 16  2010 SOURCES.txt
> -rw-r--r-- 1 root9 Aug 16  2010 top_level.txt
>
> /usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg:
> total 8
> drwxr-xr-x 2 root 4096 Oct  8 23:54 EGG-INFO
> drwxr-xr-x 6 root 4096 Oct  8 23:54 pygments
>
>
> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時54分38秒寫道:
>>
>> We use Pygments for syntax highlighting.
>>
>> We changed how we do syntax highlighting in 2.5, and it may have an issue
>> with your files.
>>
>> Christian
>>
>> --
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Sat, Nov 14, 2015 at 10:52 PM, Wesly Chen  wrote:
>>
>>> Which python modules or libraries are used for syntax highlighting? I
>>> would like to check those modules or libraries to see if some configuration
>>> run or file corruption.
>>>
>>> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:

 Can you check if there's anything in the logs?

 Do you have a file you can send that reproduces the problem?

 Christian

 --
 Christian Hammond - chri...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  wrote:

> Here is some python package information
>
> #  ls -1 /usr/lib/python2.6/site-packages/
>
> argparse-1.2.1-py2.6.egg-info
> argparse.py
> argparse.pyc
> argparse.pyo
> asciidocapi.py
> asciidocapi.pyc
> asciidocapi.pyo
> dateutil
> dbus
> dbus_bindings.py
> dbus_bindings.pyc
> dbus_bindings.pyo
> distribute-0.6.10-py2.6.egg-info
> django
> Django-1.4.21-py2.6.egg-info
> Django-1.6.11-py2.6.egg
> django_evolution
> django_evolution-0.6.9-py2.6.egg-info
> django_evolution-0.7.5-py2.6.egg
> django_haystack-2.4.0-py2.6.egg
> django_pipeline-1.2.24-py2.6.egg-info
> 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Christian Hammond
We use Pygments for syntax highlighting.

We changed how we do syntax highlighting in 2.5, and it may have an issue
with your files.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Sat, Nov 14, 2015 at 10:52 PM, Wesly Chen  wrote:

> Which python modules or libraries are used for syntax highlighting? I
> would like to check those modules or libraries to see if some configuration
> run or file corruption.
>
> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:
>>
>> Can you check if there's anything in the logs?
>>
>> Do you have a file you can send that reproduces the problem?
>>
>> Christian
>>
>> --
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  wrote:
>>
>>> Here is some python package information
>>>
>>> #  ls -1 /usr/lib/python2.6/site-packages/
>>>
>>> argparse-1.2.1-py2.6.egg-info
>>> argparse.py
>>> argparse.pyc
>>> argparse.pyo
>>> asciidocapi.py
>>> asciidocapi.pyc
>>> asciidocapi.pyo
>>> dateutil
>>> dbus
>>> dbus_bindings.py
>>> dbus_bindings.pyc
>>> dbus_bindings.pyo
>>> distribute-0.6.10-py2.6.egg-info
>>> django
>>> Django-1.4.21-py2.6.egg-info
>>> Django-1.6.11-py2.6.egg
>>> django_evolution
>>> django_evolution-0.6.9-py2.6.egg-info
>>> django_evolution-0.7.5-py2.6.egg
>>> django_haystack-2.4.0-py2.6.egg
>>> django_pipeline-1.2.24-py2.6.egg-info
>>> django_pipeline-1.3.27-py2.6.egg
>>> djblets
>>> Djblets-0.7.30-py2.6.egg-info
>>> Djblets-0.8.22-py2.6.egg
>>> docutils
>>> docutils-0.6-py2.6.egg-info
>>> easy-install.pth
>>> easy_install.py
>>> easy_install.pyc
>>> easy_install.pyo
>>> ecdsa-0.13-py2.6.egg
>>> feedparser-5.1.2-py2.6.egg-info
>>> feedparser.py
>>> feedparser.pyc
>>> feedparser.pyo
>>> flup
>>> flup-1.0.2-py2.6.egg-info
>>> futures-3.0.3-py2.6.egg
>>> iniparse
>>> iniparse-0.3.1-py2.6.egg-info
>>> libproxy.py
>>> libproxy.pyc
>>> libproxy.pyo
>>> markdown
>>> Markdown-2.0.1-py2.6.egg-info
>>> Markdown-2.4.1-py2.6.egg
>>> memcache.py
>>> memcache.pyc
>>> memcache.pyo
>>> mimeparse-0.1.3-py2.6.egg
>>> mimeparse.py
>>> mimeparse.pyc
>>> mimeparse.pyo
>>> nose
>>> nose-0.10.4-py2.6.egg-info
>>> odict
>>> odict-1.5.0-py2.6.egg-info
>>> paramiko
>>> paramiko-1.15.3-py2.6.egg
>>> paramiko-1.7.5-py2.6.egg-info
>>> pillowfight-0.2-py2.6.egg
>>> pipeline
>>> pkg_resources.py
>>> pkg_resources.pyc
>>> pkg_resources.pyo
>>> ply
>>> ply-3.4-py2.6.egg-info
>>> pycrypto-2.6.1-py2.6-linux-x86_64.egg
>>> pygments
>>> Pygments-1.1.1-py2.6.egg-info
>>> Pygments-2.0.2-py2.6.egg
>>> python_dateutil-1.4.1-py2.6.egg-info
>>> python_dateutil-1.5-py2.6.egg
>>> python_memcached-1.43-py2.6.egg-info
>>> python_mimeparse-0.1.4-py2.6.egg-info
>>> pytz
>>> pytz-2010h-py2.6.egg-info
>>> RBTools-0.8alpha0.dev-py2.6.egg
>>> recaptcha
>>> recaptcha_client-1.0.6-py2.6.egg-info
>>> recaptcha_client-1.0.6-py2.6-nspkg.pth
>>> reviewboard
>>> ReviewBoard-1.7.27-py2.6.egg-info
>>> ReviewBoard-2.0.20-py2.6.egg
>>> roman.py
>>> roman.pyc
>>> roman.pyo
>>> rpmUtils
>>> setuptools
>>> setuptools-0.6c11-py2.6.egg-info
>>> setuptools.pth
>>> site.py
>>> site.pyc
>>> site.pyo
>>> six-1.9.0-py2.6.egg
>>> slimit
>>> slimit-0.8.1-py2.6.egg-info
>>> sos
>>> urlgrabber
>>> urlgrabber-3.9.1-py2.6.egg-info
>>> webtests
>>> Whoosh-2.7.0-py2.6.egg
>>> yum
>>> yumutils
>>>
>>>
>>> Wesly Chen於 2015年11月14日星期六 UTC-8下午3時22分01秒寫道:
>>>
 1. System setting => Diff Viewer settings => Show syntax highlighting
  is checked.
 2. Account settings " Enable syntax highlighting in the diff viewer"
 is checked.

 My system is CentOS 6.5 64-bit with MySQL 5.1.

 Any information needed for this issue?


 --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Wesly Chen
Which python modules or libraries are used for syntax highlighting? I would 
like to check those modules or libraries to see if some configuration run 
or file corruption.

Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:
>
> Can you check if there's anything in the logs?
>
> Do you have a file you can send that reproduces the problem?
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  > wrote:
>
>> Here is some python package information
>>
>> #  ls -1 /usr/lib/python2.6/site-packages/
>>
>> argparse-1.2.1-py2.6.egg-info
>> argparse.py
>> argparse.pyc
>> argparse.pyo
>> asciidocapi.py
>> asciidocapi.pyc
>> asciidocapi.pyo
>> dateutil
>> dbus
>> dbus_bindings.py
>> dbus_bindings.pyc
>> dbus_bindings.pyo
>> distribute-0.6.10-py2.6.egg-info
>> django
>> Django-1.4.21-py2.6.egg-info
>> Django-1.6.11-py2.6.egg
>> django_evolution
>> django_evolution-0.6.9-py2.6.egg-info
>> django_evolution-0.7.5-py2.6.egg
>> django_haystack-2.4.0-py2.6.egg
>> django_pipeline-1.2.24-py2.6.egg-info
>> django_pipeline-1.3.27-py2.6.egg
>> djblets
>> Djblets-0.7.30-py2.6.egg-info
>> Djblets-0.8.22-py2.6.egg
>> docutils
>> docutils-0.6-py2.6.egg-info
>> easy-install.pth
>> easy_install.py
>> easy_install.pyc
>> easy_install.pyo
>> ecdsa-0.13-py2.6.egg
>> feedparser-5.1.2-py2.6.egg-info
>> feedparser.py
>> feedparser.pyc
>> feedparser.pyo
>> flup
>> flup-1.0.2-py2.6.egg-info
>> futures-3.0.3-py2.6.egg
>> iniparse
>> iniparse-0.3.1-py2.6.egg-info
>> libproxy.py
>> libproxy.pyc
>> libproxy.pyo
>> markdown
>> Markdown-2.0.1-py2.6.egg-info
>> Markdown-2.4.1-py2.6.egg
>> memcache.py
>> memcache.pyc
>> memcache.pyo
>> mimeparse-0.1.3-py2.6.egg
>> mimeparse.py
>> mimeparse.pyc
>> mimeparse.pyo
>> nose
>> nose-0.10.4-py2.6.egg-info
>> odict
>> odict-1.5.0-py2.6.egg-info
>> paramiko
>> paramiko-1.15.3-py2.6.egg
>> paramiko-1.7.5-py2.6.egg-info
>> pillowfight-0.2-py2.6.egg
>> pipeline
>> pkg_resources.py
>> pkg_resources.pyc
>> pkg_resources.pyo
>> ply
>> ply-3.4-py2.6.egg-info
>> pycrypto-2.6.1-py2.6-linux-x86_64.egg
>> pygments
>> Pygments-1.1.1-py2.6.egg-info
>> Pygments-2.0.2-py2.6.egg
>> python_dateutil-1.4.1-py2.6.egg-info
>> python_dateutil-1.5-py2.6.egg
>> python_memcached-1.43-py2.6.egg-info
>> python_mimeparse-0.1.4-py2.6.egg-info
>> pytz
>> pytz-2010h-py2.6.egg-info
>> RBTools-0.8alpha0.dev-py2.6.egg
>> recaptcha
>> recaptcha_client-1.0.6-py2.6.egg-info
>> recaptcha_client-1.0.6-py2.6-nspkg.pth
>> reviewboard
>> ReviewBoard-1.7.27-py2.6.egg-info
>> ReviewBoard-2.0.20-py2.6.egg
>> roman.py
>> roman.pyc
>> roman.pyo
>> rpmUtils
>> setuptools
>> setuptools-0.6c11-py2.6.egg-info
>> setuptools.pth
>> site.py
>> site.pyc
>> site.pyo
>> six-1.9.0-py2.6.egg
>> slimit
>> slimit-0.8.1-py2.6.egg-info
>> sos
>> urlgrabber
>> urlgrabber-3.9.1-py2.6.egg-info
>> webtests
>> Whoosh-2.7.0-py2.6.egg
>> yum
>> yumutils
>>
>>
>> Wesly Chen於 2015年11月14日星期六 UTC-8下午3時22分01秒寫道:
>>
>>> 1. System setting => Diff Viewer settings => Show syntax highlighting 
>>>  is checked.
>>> 2. Account settings " Enable syntax highlighting in the diff viewer" is 
>>> checked.
>>>
>>> My system is CentOS 6.5 64-bit with MySQL 5.1.
>>>
>>> Any information needed for this issue?
>>>
>>>
>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Wesly Chen
Here is the python modules on the system. Which file I should check for the 
configuration? I'm not familiar with python.

# ls -lg /usr/lib/python2.6/site-packages/*ygment*
/usr/lib/python2.6/site-packages/pygments:
total 1080
-rw-r--r-- 1 root  13055 Sep 15  2009 cmdline.py
-rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyc
-rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyo
-rw-r--r-- 1 root   1850 Sep 15  2009 console.py
-rw-r--r-- 2 root   2340 Aug 16  2010 console.pyc
-rw-r--r-- 2 root   2340 Aug 16  2010 console.pyo
-rw-r--r-- 1 root   2071 Sep 15  2009 filter.py
-rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyc
-rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyo
drwxr-xr-x 2 root   4096 Aug 12 23:28 filters
-rw-r--r-- 1 root   2790 Sep 15  2009 formatter.py
-rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyc
-rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyo
drwxr-xr-x 2 root   4096 Aug 12 23:28 formatters
-rw-r--r-- 1 root   2935 Sep 15  2009 __init__.py
-rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyc
-rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyo
-rw-r--r-- 1 root  22625 Sep 15  2009 lexer.py
-rw-r--r-- 1 root  20971 Aug 16  2010 lexer.pyc
-rw-r--r-- 1 root  20204 Aug 16  2010 lexer.pyo
drwxr-xr-x 2 root   4096 Aug 12 23:28 lexers
-rw-r--r-- 1 root   1862 Sep 15  2009 plugin.py
-rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyc
-rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyo
-rw-r--r-- 1 root   3114 Sep 15  2009 scanner.py
-rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyc
-rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyo
-rw-r--r-- 1 root   3745 Sep 15  2009 style.py
-rw-r--r-- 1 root   3943 Aug 16  2010 style.pyc
-rw-r--r-- 1 root   3867 Aug 16  2010 style.pyo
drwxr-xr-x 2 root   4096 Aug 12 23:28 styles
-rw-r--r-- 1 root   5784 Sep 15  2009 token.py
-rw-r--r-- 2 root   5408 Aug 16  2010 token.pyc
-rw-r--r-- 2 root   5408 Aug 16  2010 token.pyo
-rw-r--r-- 1 root 404249 Sep 15  2009 unistring.py
-rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyc
-rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyo
-rw-r--r-- 1 root   6431 Sep 15  2009 util.py
-rw-r--r-- 2 root   7706 Aug 16  2010 util.pyc
-rw-r--r-- 2 root   7706 Aug 16  2010 util.pyo

/usr/lib/python2.6/site-packages/Pygments-1.1.1-py2.6.egg-info:
total 24
-rw-r--r-- 1 root1 Aug 16  2010 dependency_links.txt
-rw-r--r-- 1 root1 Feb  6  2009 not-zip-safe
-rw-r--r-- 1 root 1831 Aug 16  2010 PKG-INFO
-rw-r--r-- 1 root 7520 Aug 16  2010 SOURCES.txt
-rw-r--r-- 1 root9 Aug 16  2010 top_level.txt

/usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg:
total 8
drwxr-xr-x 2 root 4096 Oct  8 23:54 EGG-INFO
drwxr-xr-x 6 root 4096 Oct  8 23:54 pygments


Christian Hammond於 2015年11月14日星期六 UTC-8下午10時54分38秒寫道:
>
> We use Pygments for syntax highlighting.
>
> We changed how we do syntax highlighting in 2.5, and it may have an issue 
> with your files.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Sat, Nov 14, 2015 at 10:52 PM, Wesly Chen  > wrote:
>
>> Which python modules or libraries are used for syntax highlighting? I 
>> would like to check those modules or libraries to see if some configuration 
>> run or file corruption.
>>
>> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:
>>>
>>> Can you check if there's anything in the logs?
>>>
>>> Do you have a file you can send that reproduces the problem?
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chri...@beanbaginc.com
>>> Review Board - https://www.reviewboard.org
>>> Beanbag, Inc. - https://www.beanbaginc.com
>>>
>>> On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  wrote:
>>>
 Here is some python package information

 #  ls -1 /usr/lib/python2.6/site-packages/

 argparse-1.2.1-py2.6.egg-info
 argparse.py
 argparse.pyc
 argparse.pyo
 asciidocapi.py
 asciidocapi.pyc
 asciidocapi.pyo
 dateutil
 dbus
 dbus_bindings.py
 dbus_bindings.pyc
 dbus_bindings.pyo
 distribute-0.6.10-py2.6.egg-info
 django
 Django-1.4.21-py2.6.egg-info
 Django-1.6.11-py2.6.egg
 django_evolution
 django_evolution-0.6.9-py2.6.egg-info
 django_evolution-0.7.5-py2.6.egg
 django_haystack-2.4.0-py2.6.egg
 django_pipeline-1.2.24-py2.6.egg-info
 django_pipeline-1.3.27-py2.6.egg
 djblets
 Djblets-0.7.30-py2.6.egg-info
 Djblets-0.8.22-py2.6.egg
 docutils
 docutils-0.6-py2.6.egg-info
 easy-install.pth
 easy_install.py
 easy_install.pyc
 easy_install.pyo
 ecdsa-0.13-py2.6.egg
 feedparser-5.1.2-py2.6.egg-info
 feedparser.py
 feedparser.pyc
 feedparser.pyo
 flup
 flup-1.0.2-py2.6.egg-info
 futures-3.0.3-py2.6.egg
 iniparse
 iniparse-0.3.1-py2.6.egg-info
 libproxy.py
 libproxy.pyc
 libproxy.pyo
 markdown
 Markdown-2.0.1-py2.6.egg-info
 Markdown-2.4.1-py2.6.egg
 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Christian Hammond
Thanks, though unfortunately, the middle of a file won't be sufficient to
reproduce this. I'm actually going to need the first 50 lines or so of a
file, at least. Ideally, an entire file. You could try creating a dummy
file to add to a review request, see if it's still failing, and then you
could send that along.

Please note that anything posted here is public, and we can't take it down.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Sat, Nov 14, 2015 at 11:02 PM, Wesly Chen  wrote:

> I uploaded portion of the java file as the screenshot show.
> We use CVS as repository.
>
> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時50分48秒寫道:
>>
>> I'll need that information to be able to diagnose the issue. As it is, I
>> have no insight into what could be going wrong, and would have to run tests
>> here.
>>
>> Christian
>>
>> --
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Sat, Nov 14, 2015 at 10:49 PM, Wesly Chen  wrote:
>>
>>> All the diff upload by "rbt post" doesn't show syntax highlight in Diff
>>> Viewer. However, "syntax highlighting" with attached file (java), just not
>>> in Diff Viewer.
>>>
>>> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:

 Can you check if there's anything in the logs?

 Do you have a file you can send that reproduces the problem?

 Christian

 --
 Christian Hammond - chri...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  wrote:

> Here is some python package information
>
> #  ls -1 /usr/lib/python2.6/site-packages/
>
> argparse-1.2.1-py2.6.egg-info
> argparse.py
> argparse.pyc
> argparse.pyo
> asciidocapi.py
> asciidocapi.pyc
> asciidocapi.pyo
> dateutil
> dbus
> dbus_bindings.py
> dbus_bindings.pyc
> dbus_bindings.pyo
> distribute-0.6.10-py2.6.egg-info
> django
> Django-1.4.21-py2.6.egg-info
> Django-1.6.11-py2.6.egg
> django_evolution
> django_evolution-0.6.9-py2.6.egg-info
> django_evolution-0.7.5-py2.6.egg
> django_haystack-2.4.0-py2.6.egg
> django_pipeline-1.2.24-py2.6.egg-info
> django_pipeline-1.3.27-py2.6.egg
> djblets
> Djblets-0.7.30-py2.6.egg-info
> Djblets-0.8.22-py2.6.egg
> docutils
> docutils-0.6-py2.6.egg-info
> easy-install.pth
> easy_install.py
> easy_install.pyc
> easy_install.pyo
> ecdsa-0.13-py2.6.egg
> feedparser-5.1.2-py2.6.egg-info
> feedparser.py
> feedparser.pyc
> feedparser.pyo
> flup
> flup-1.0.2-py2.6.egg-info
> futures-3.0.3-py2.6.egg
> iniparse
> iniparse-0.3.1-py2.6.egg-info
> libproxy.py
> libproxy.pyc
> libproxy.pyo
> markdown
> Markdown-2.0.1-py2.6.egg-info
> Markdown-2.4.1-py2.6.egg
> memcache.py
> memcache.pyc
> memcache.pyo
> mimeparse-0.1.3-py2.6.egg
> mimeparse.py
> mimeparse.pyc
> mimeparse.pyo
> nose
> nose-0.10.4-py2.6.egg-info
> odict
> odict-1.5.0-py2.6.egg-info
> paramiko
> paramiko-1.15.3-py2.6.egg
> paramiko-1.7.5-py2.6.egg-info
> pillowfight-0.2-py2.6.egg
> pipeline
> pkg_resources.py
> pkg_resources.pyc
> pkg_resources.pyo
> ply
> ply-3.4-py2.6.egg-info
> pycrypto-2.6.1-py2.6-linux-x86_64.egg
> pygments
> Pygments-1.1.1-py2.6.egg-info
> Pygments-2.0.2-py2.6.egg
> python_dateutil-1.4.1-py2.6.egg-info
> python_dateutil-1.5-py2.6.egg
> python_memcached-1.43-py2.6.egg-info
> python_mimeparse-0.1.4-py2.6.egg-info
> pytz
> pytz-2010h-py2.6.egg-info
> RBTools-0.8alpha0.dev-py2.6.egg
> recaptcha
> recaptcha_client-1.0.6-py2.6.egg-info
> recaptcha_client-1.0.6-py2.6-nspkg.pth
> reviewboard
> ReviewBoard-1.7.27-py2.6.egg-info
> ReviewBoard-2.0.20-py2.6.egg
> roman.py
> roman.pyc
> roman.pyo
> rpmUtils
> setuptools
> setuptools-0.6c11-py2.6.egg-info
> setuptools.pth
> site.py
> site.pyc
> site.pyo
> six-1.9.0-py2.6.egg
> slimit
> slimit-0.8.1-py2.6.egg-info
> sos
> urlgrabber
> urlgrabber-3.9.1-py2.6.egg-info
> webtests
> Whoosh-2.7.0-py2.6.egg
> yum
> yumutils
>
>
> Wesly Chen於 2015年11月14日星期六 UTC-8下午3時22分01秒寫道:
>
>> 1. System setting => Diff Viewer settings => Show syntax
>> highlighting  is checked.
>> 2. Account settings " Enable syntax highlighting in the diff viewer"
>> is checked.
>>
>> My system is CentOS 6.5 64-bit with MySQL 5.1.
>>
>> Any information needed for this issue?
>>
>>
>> --
> Supercharge your Review Board with 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Wesly Chen
Could you point out which python files under 
/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/ 
is showing the syntax highlighting in Diff Viewer?

Thanks,

Wesly 

Christian Hammond於 2015年11月14日星期六 UTC-8下午11時09分49秒寫道:
>
> There's no file or configuration to check. This stuff is built to work in 
> Review Board. The only option I can offer right now is to check a file 
> that's having problems on our end to see if it's a regression in Review 
> Board.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Sat, Nov 14, 2015 at 11:08 PM, Wesly Chen  > wrote:
>
>> Here is the python modules on the system. Which file I should check for 
>> the configuration? I'm not familiar with python.
>>
>> # ls -lg /usr/lib/python2.6/site-packages/*ygment*
>> /usr/lib/python2.6/site-packages/pygments:
>> total 1080
>> -rw-r--r-- 1 root  13055 Sep 15  2009 cmdline.py
>> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyc
>> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyo
>> -rw-r--r-- 1 root   1850 Sep 15  2009 console.py
>> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyc
>> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyo
>> -rw-r--r-- 1 root   2071 Sep 15  2009 filter.py
>> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyc
>> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyo
>> drwxr-xr-x 2 root   4096 Aug 12 23:28 filters
>> -rw-r--r-- 1 root   2790 Sep 15  2009 formatter.py
>> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyc
>> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyo
>> drwxr-xr-x 2 root   4096 Aug 12 23:28 formatters
>> -rw-r--r-- 1 root   2935 Sep 15  2009 __init__.py
>> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyc
>> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyo
>> -rw-r--r-- 1 root  22625 Sep 15  2009 lexer.py
>> -rw-r--r-- 1 root  20971 Aug 16  2010 lexer.pyc
>> -rw-r--r-- 1 root  20204 Aug 16  2010 lexer.pyo
>> drwxr-xr-x 2 root   4096 Aug 12 23:28 lexers
>> -rw-r--r-- 1 root   1862 Sep 15  2009 plugin.py
>> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyc
>> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyo
>> -rw-r--r-- 1 root   3114 Sep 15  2009 scanner.py
>> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyc
>> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyo
>> -rw-r--r-- 1 root   3745 Sep 15  2009 style.py
>> -rw-r--r-- 1 root   3943 Aug 16  2010 style.pyc
>> -rw-r--r-- 1 root   3867 Aug 16  2010 style.pyo
>> drwxr-xr-x 2 root   4096 Aug 12 23:28 styles
>> -rw-r--r-- 1 root   5784 Sep 15  2009 token.py
>> -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyc
>> -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyo
>> -rw-r--r-- 1 root 404249 Sep 15  2009 unistring.py
>> -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyc
>> -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyo
>> -rw-r--r-- 1 root   6431 Sep 15  2009 util.py
>> -rw-r--r-- 2 root   7706 Aug 16  2010 util.pyc
>> -rw-r--r-- 2 root   7706 Aug 16  2010 util.pyo
>>
>> /usr/lib/python2.6/site-packages/Pygments-1.1.1-py2.6.egg-info:
>> total 24
>> -rw-r--r-- 1 root1 Aug 16  2010 dependency_links.txt
>> -rw-r--r-- 1 root1 Feb  6  2009 not-zip-safe
>> -rw-r--r-- 1 root 1831 Aug 16  2010 PKG-INFO
>> -rw-r--r-- 1 root 7520 Aug 16  2010 SOURCES.txt
>> -rw-r--r-- 1 root9 Aug 16  2010 top_level.txt
>>
>> /usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg:
>> total 8
>> drwxr-xr-x 2 root 4096 Oct  8 23:54 EGG-INFO
>> drwxr-xr-x 6 root 4096 Oct  8 23:54 pygments
>>
>>
>> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時54分38秒寫道:
>>>
>>> We use Pygments for syntax highlighting.
>>>
>>> We changed how we do syntax highlighting in 2.5, and it may have an 
>>> issue with your files.
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chri...@beanbaginc.com
>>> Review Board - https://www.reviewboard.org
>>> Beanbag, Inc. - https://www.beanbaginc.com
>>>
>>> On Sat, Nov 14, 2015 at 10:52 PM, Wesly Chen  wrote:
>>>
 Which python modules or libraries are used for syntax highlighting? I 
 would like to check those modules or libraries to see if some 
 configuration 
 run or file corruption.

 Christian Hammond於 2015年11月14日星期六 UTC-8下午10時25分20秒寫道:
>
> Can you check if there's anything in the logs?
>
> Do you have a file you can send that reproduces the problem?
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Sat, Nov 14, 2015 at 3:28 PM, Wesly Chen  
> wrote:
>
>> Here is some python package information
>>
>> #  ls -1 /usr/lib/python2.6/site-packages/
>>
>> argparse-1.2.1-py2.6.egg-info
>> argparse.py
>> argparse.pyc
>> argparse.pyo
>> asciidocapi.py
>> asciidocapi.pyc
>> asciidocapi.pyo
>> dateutil

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Christian Hammond
For some reason I had thought you were using Review Board 2.5, I think
because of the other support e-mails. So it's not a regression after all.

Can you check the Review Board log file, see if there are any errors when
viewing a review request?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Sat, Nov 14, 2015 at 11:31 PM, Wesly Chen  wrote:

> Actually, all the files in Diff Viewer is not showing "syntax
> highlighting" on my Review Board.
>
> I attached
> 1. old file in CVS  : check_mysql_rows.pl
> 2. Modified file on local : check_mysql_rows-new.pl  (added 3 comments)
> 3. screeshot of file viewer in reviewboard uploaded by UI :
> screenshot-upload-via-rb-ui.jpg , syntax highlight work for line 1, 7, 12,
> 17  in different color)
> 4. screenshot of Diff Viewer : screenshot-diff-viewer.jpg
>
>
> Christian Hammond於 2015年11月14日星期六 UTC-8下午11時09分49秒寫道:
>>
>> There's no file or configuration to check. This stuff is built to work in
>> Review Board. The only option I can offer right now is to check a file
>> that's having problems on our end to see if it's a regression in Review
>> Board.
>>
>> Christian
>>
>> --
>> Christian Hammond - chri...@beanbaginc.com
>> Review Board - https://www.reviewboard.org
>> Beanbag, Inc. - https://www.beanbaginc.com
>>
>> On Sat, Nov 14, 2015 at 11:08 PM, Wesly Chen  wrote:
>>
>>> Here is the python modules on the system. Which file I should check for
>>> the configuration? I'm not familiar with python.
>>>
>>> # ls -lg /usr/lib/python2.6/site-packages/*ygment*
>>> /usr/lib/python2.6/site-packages/pygments:
>>> total 1080
>>> -rw-r--r-- 1 root  13055 Sep 15  2009 cmdline.py
>>> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyc
>>> -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyo
>>> -rw-r--r-- 1 root   1850 Sep 15  2009 console.py
>>> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyc
>>> -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyo
>>> -rw-r--r-- 1 root   2071 Sep 15  2009 filter.py
>>> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyc
>>> -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyo
>>> drwxr-xr-x 2 root   4096 Aug 12 23:28 filters
>>> -rw-r--r-- 1 root   2790 Sep 15  2009 formatter.py
>>> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyc
>>> -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyo
>>> drwxr-xr-x 2 root   4096 Aug 12 23:28 formatters
>>> -rw-r--r-- 1 root   2935 Sep 15  2009 __init__.py
>>> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyc
>>> -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyo
>>> -rw-r--r-- 1 root  22625 Sep 15  2009 lexer.py
>>> -rw-r--r-- 1 root  20971 Aug 16  2010 lexer.pyc
>>> -rw-r--r-- 1 root  20204 Aug 16  2010 lexer.pyo
>>> drwxr-xr-x 2 root   4096 Aug 12 23:28 lexers
>>> -rw-r--r-- 1 root   1862 Sep 15  2009 plugin.py
>>> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyc
>>> -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyo
>>> -rw-r--r-- 1 root   3114 Sep 15  2009 scanner.py
>>> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyc
>>> -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyo
>>> -rw-r--r-- 1 root   3745 Sep 15  2009 style.py
>>> -rw-r--r-- 1 root   3943 Aug 16  2010 style.pyc
>>> -rw-r--r-- 1 root   3867 Aug 16  2010 style.pyo
>>> drwxr-xr-x 2 root   4096 Aug 12 23:28 styles
>>> -rw-r--r-- 1 root   5784 Sep 15  2009 token.py
>>> -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyc
>>> -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyo
>>> -rw-r--r-- 1 root 404249 Sep 15  2009 unistring.py
>>> -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyc
>>> -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyo
>>> -rw-r--r-- 1 root   6431 Sep 15  2009 util.py
>>> -rw-r--r-- 2 root   7706 Aug 16  2010 util.pyc
>>> -rw-r--r-- 2 root   7706 Aug 16  2010 util.pyo
>>>
>>> /usr/lib/python2.6/site-packages/Pygments-1.1.1-py2.6.egg-info:
>>> total 24
>>> -rw-r--r-- 1 root1 Aug 16  2010 dependency_links.txt
>>> -rw-r--r-- 1 root1 Feb  6  2009 not-zip-safe
>>> -rw-r--r-- 1 root 1831 Aug 16  2010 PKG-INFO
>>> -rw-r--r-- 1 root 7520 Aug 16  2010 SOURCES.txt
>>> -rw-r--r-- 1 root9 Aug 16  2010 top_level.txt
>>>
>>> /usr/lib/python2.6/site-packages/Pygments-2.0.2-py2.6.egg:
>>> total 8
>>> drwxr-xr-x 2 root 4096 Oct  8 23:54 EGG-INFO
>>> drwxr-xr-x 6 root 4096 Oct  8 23:54 pygments
>>>
>>>
>>> Christian Hammond於 2015年11月14日星期六 UTC-8下午10時54分38秒寫道:

 We use Pygments for syntax highlighting.

 We changed how we do syntax highlighting in 2.5, and it may have an
 issue with your files.

 Christian

 --
 Christian Hammond - chri...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Sat, Nov 14, 2015 at 10:52 PM, Wesly Chen 
 wrote:

> Which python modules or libraries are used for syntax highlighting? I
> would like to check those modules or libraries to 

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Wesly Chen
On my review board system, it is in 
/usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/diffviewer/chunk_generator.py
 
  (not in diffutils.py)
---
(started with line 219) 
if self._get_enable_syntax_highlighting(old, new, a, b):
repository = self.filediff.diffset.repository
tool = repository.get_scmtool()
source_file = \
tool.normalize_path_for_display(self.filediff.source_file)
dest_file = \
tool.normalize_path_for_display(self.filediff.dest_file)

try:
# TODO: Try to figure out the right lexer for these files
#   once instead of twice.
if not source_file.endswith(self.STYLED_EXT_BLACKLIST):
markup_a = self._apply_pygments(old or '', source_file)

if not dest_file.endswith(self.STYLED_EXT_BLACKLIST):
markup_b = self._apply_pygments(new or '', dest_file)
except:
pass
...
(line 646)
def _apply_pygments(self, data, filename):
"""Applies Pygments syntax-highlighting to a file's contents.

The resulting HTML will be returned as a list of lines.
"""
lexer = get_lexer_for_filename(filename,
   stripnl=False,
   encoding='utf-8')
lexer.add_filter('codetagify')

return split_line_endings(
highlight(data, lexer, NoWrapperHtmlFormatter()))
---

Christian Hammond於 2015年11月14日星期六 UTC-8下午11時36分59秒寫道:
>
> It's in reviewboard/diffviewer/diffutils.py. Look for apply_pygments.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Sat, Nov 14, 2015 at 11:35 PM, Wesly Chen  > wrote:
>
>> Could you point out which python files under 
>>
>> /usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/ 
>> is showing the syntax highlighting in Diff Viewer?
>>
>> Thanks,
>>
>> Wesly 
>>
>> Christian Hammond於 2015年11月14日星期六 UTC-8下午11時09分49秒寫道:
>>>
>>> There's no file or configuration to check. This stuff is built to work 
>>> in Review Board. The only option I can offer right now is to check a file 
>>> that's having problems on our end to see if it's a regression in Review 
>>> Board.
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chri...@beanbaginc.com
>>> Review Board - https://www.reviewboard.org
>>> Beanbag, Inc. - https://www.beanbaginc.com
>>>
>>> On Sat, Nov 14, 2015 at 11:08 PM, Wesly Chen  wrote:
>>>
 Here is the python modules on the system. Which file I should check for 
 the configuration? I'm not familiar with python.

 # ls -lg /usr/lib/python2.6/site-packages/*ygment*
 /usr/lib/python2.6/site-packages/pygments:
 total 1080
 -rw-r--r-- 1 root  13055 Sep 15  2009 cmdline.py
 -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyc
 -rw-r--r-- 2 root  10443 Aug 16  2010 cmdline.pyo
 -rw-r--r-- 1 root   1850 Sep 15  2009 console.py
 -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyc
 -rw-r--r-- 2 root   2340 Aug 16  2010 console.pyo
 -rw-r--r-- 1 root   2071 Sep 15  2009 filter.py
 -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyc
 -rw-r--r-- 2 root   3184 Aug 16  2010 filter.pyo
 drwxr-xr-x 2 root   4096 Aug 12 23:28 filters
 -rw-r--r-- 1 root   2790 Sep 15  2009 formatter.py
 -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyc
 -rw-r--r-- 2 root   3344 Aug 16  2010 formatter.pyo
 drwxr-xr-x 2 root   4096 Aug 12 23:28 formatters
 -rw-r--r-- 1 root   2935 Sep 15  2009 __init__.py
 -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyc
 -rw-r--r-- 2 root   3334 Aug 16  2010 __init__.pyo
 -rw-r--r-- 1 root  22625 Sep 15  2009 lexer.py
 -rw-r--r-- 1 root  20971 Aug 16  2010 lexer.pyc
 -rw-r--r-- 1 root  20204 Aug 16  2010 lexer.pyo
 drwxr-xr-x 2 root   4096 Aug 12 23:28 lexers
 -rw-r--r-- 1 root   1862 Sep 15  2009 plugin.py
 -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyc
 -rw-r--r-- 2 root   2373 Aug 16  2010 plugin.pyo
 -rw-r--r-- 1 root   3114 Sep 15  2009 scanner.py
 -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyc
 -rw-r--r-- 2 root   4174 Aug 16  2010 scanner.pyo
 -rw-r--r-- 1 root   3745 Sep 15  2009 style.py
 -rw-r--r-- 1 root   3943 Aug 16  2010 style.pyc
 -rw-r--r-- 1 root   3867 Aug 16  2010 style.pyo
 drwxr-xr-x 2 root   4096 Aug 12 23:28 styles
 -rw-r--r-- 1 root   5784 Sep 15  2009 token.py
 -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyc
 -rw-r--r-- 2 root   5408 Aug 16  2010 token.pyo
 -rw-r--r-- 1 root 404249 Sep 15  2009 unistring.py
 -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyc
 -rw-r--r-- 2 root 208515 Aug 16  2010 unistring.pyo
 -rw-r--r-- 1 root   

Re: Syntax highlighting in Diff Viewer doesn't work after upgrade from 1.7.27 to 2.0.20

2015-11-14 Thread Wesly Chen
Here is some python package information

#  ls -1 /usr/lib/python2.6/site-packages/

argparse-1.2.1-py2.6.egg-info
argparse.py
argparse.pyc
argparse.pyo
asciidocapi.py
asciidocapi.pyc
asciidocapi.pyo
dateutil
dbus
dbus_bindings.py
dbus_bindings.pyc
dbus_bindings.pyo
distribute-0.6.10-py2.6.egg-info
django
Django-1.4.21-py2.6.egg-info
Django-1.6.11-py2.6.egg
django_evolution
django_evolution-0.6.9-py2.6.egg-info
django_evolution-0.7.5-py2.6.egg
django_haystack-2.4.0-py2.6.egg
django_pipeline-1.2.24-py2.6.egg-info
django_pipeline-1.3.27-py2.6.egg
djblets
Djblets-0.7.30-py2.6.egg-info
Djblets-0.8.22-py2.6.egg
docutils
docutils-0.6-py2.6.egg-info
easy-install.pth
easy_install.py
easy_install.pyc
easy_install.pyo
ecdsa-0.13-py2.6.egg
feedparser-5.1.2-py2.6.egg-info
feedparser.py
feedparser.pyc
feedparser.pyo
flup
flup-1.0.2-py2.6.egg-info
futures-3.0.3-py2.6.egg
iniparse
iniparse-0.3.1-py2.6.egg-info
libproxy.py
libproxy.pyc
libproxy.pyo
markdown
Markdown-2.0.1-py2.6.egg-info
Markdown-2.4.1-py2.6.egg
memcache.py
memcache.pyc
memcache.pyo
mimeparse-0.1.3-py2.6.egg
mimeparse.py
mimeparse.pyc
mimeparse.pyo
nose
nose-0.10.4-py2.6.egg-info
odict
odict-1.5.0-py2.6.egg-info
paramiko
paramiko-1.15.3-py2.6.egg
paramiko-1.7.5-py2.6.egg-info
pillowfight-0.2-py2.6.egg
pipeline
pkg_resources.py
pkg_resources.pyc
pkg_resources.pyo
ply
ply-3.4-py2.6.egg-info
pycrypto-2.6.1-py2.6-linux-x86_64.egg
pygments
Pygments-1.1.1-py2.6.egg-info
Pygments-2.0.2-py2.6.egg
python_dateutil-1.4.1-py2.6.egg-info
python_dateutil-1.5-py2.6.egg
python_memcached-1.43-py2.6.egg-info
python_mimeparse-0.1.4-py2.6.egg-info
pytz
pytz-2010h-py2.6.egg-info
RBTools-0.8alpha0.dev-py2.6.egg
recaptcha
recaptcha_client-1.0.6-py2.6.egg-info
recaptcha_client-1.0.6-py2.6-nspkg.pth
reviewboard
ReviewBoard-1.7.27-py2.6.egg-info
ReviewBoard-2.0.20-py2.6.egg
roman.py
roman.pyc
roman.pyo
rpmUtils
setuptools
setuptools-0.6c11-py2.6.egg-info
setuptools.pth
site.py
site.pyc
site.pyo
six-1.9.0-py2.6.egg
slimit
slimit-0.8.1-py2.6.egg-info
sos
urlgrabber
urlgrabber-3.9.1-py2.6.egg-info
webtests
Whoosh-2.7.0-py2.6.egg
yum
yumutils


Wesly Chen於 2015年11月14日星期六 UTC-8下午3時22分01秒寫道:
>
> 1. System setting => Diff Viewer settings => Show syntax highlighting  is 
> checked.
> 2. Account settings " Enable syntax highlighting in the diff viewer" is 
> checked.
>
> My system is CentOS 6.5 64-bit with MySQL 5.1.
>
> Any information needed for this issue?
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting for Template toolkit (.tt file format) in ReviewBoard is incorrect

2015-10-26 Thread Christian Hammond
Hi,

We use a third-party library, Pygments, for syntax highlighting. It appears
to have no knowledge of Perl Template Toolkit files, and thinks *.tt files
are Treetop files.

We have some new logic coming in 2.0.21 and 2.5, which will be smarter
about what type of file it's processing, but the best-case scenario is that
it'll decide it's plain text, since it won't know about Perl Template
Toolkit files.

You can file a feature request to handle these files in some form over at
http://pygments.org/.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Mon, Oct 26, 2015 at 12:45 AM, Premkumar Pasumpon 
wrote:

> Hi All,
>
> The syntax highlighting in ReviewBoard for our .tt files doesn't look right
>
> All the code in .tt files has red boxes around it. Probably ReviewBoard
> thinks .tt is a different type of file than a Perl Template Toolkit file,
> and is treating everything as a syntax error.
>
> Would it be possible to add the correct syntax highlighting, as it's
> rather hard to read otherwise.
>
> Better highlighting could treat the files as any of these (in order of
> preference):
> 1. Perl Template Toolkit (i.e. HTML + Perl combined)
> 2. HTML
> 3. No highlighting at all - this would still be better than red boxes
>
> Looking forward for your response
>
> Regards,
> Prem
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Syntax highlighting

2010-04-21 Thread Dan Savilonis
I've added support for changing the syntax highlighting scheme, if
that will help with your disappointment in the highlighting. It's
working, but it needs some better integration for installation. Right
now you have to hack up the pygments generated styles with a script.

http://github.com/djs/reviewboard/tree/pygments

For the Obj-C issue, RB is currently using get_lexer_for_filename, but
there is also a guess_lexer API that presumably would yield better
results...

Dan



On Apr 20, 3:41 pm, Christian Hammond chip...@chipx86.com wrote:
 Hi Tim,

 We use a Python module called Pygments (http://www.pygments.org/) for the
 syntax highlighting, so we basically support whatever they do.

 The lack of Obj-C highlighting is certainly an annoyance that I've dealt
 with too. It's due to Pygments giving preference to I think Matlab files or
 something, over Obj-C. This is something I'd love to see them fix.

 There's a chance we may get support down the road for adding customizable
 highlighting (as in, being able to say that this file extension will use
 that type of highlighter). You wouldn't be able to add new syntax
 highlighting rules with this, but it's something at least, and would fix the
 Obj-C situation. However, I think the person who was working on this support
 has been too busy to finish it up, so I'm not sure which release will end up
 with it.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

 On Tue, Apr 20, 2010 at 12:33 PM, Tim Hollingsworth 





 timhollingswo...@gmail.com wrote:
  Hello,

  Firstly I just started using Review Board and have had a very positive
  experience so far, thanks!

  Is there some place to find out what syntax highlighting is
  available?  Is it pluggable or standardized?

  I'm using C++ and objective-c.  The C++ has some highlighting, but not
  very meaningful - it colors comments and import statements differently
  but no real highlighting in the code.  In objective-c there is not
  highlighting at all.

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr 
  oups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today 
 athttp://www.reviewboard.org/donate/
 Happy user? Let us know athttp://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group 
 athttp://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Syntax highlighting

2010-04-21 Thread Christian Hammond
We used to use get_lexer and saw some serious performance problems with it,
which is why we switched to get_lexer_for_filename.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Apr 21, 2010 at 8:45 AM, Dan Savilonis d...@n-cube.org wrote:

 I've added support for changing the syntax highlighting scheme, if
 that will help with your disappointment in the highlighting. It's
 working, but it needs some better integration for installation. Right
 now you have to hack up the pygments generated styles with a script.

 http://github.com/djs/reviewboard/tree/pygments

 For the Obj-C issue, RB is currently using get_lexer_for_filename, but
 there is also a guess_lexer API that presumably would yield better
 results...

 Dan



 On Apr 20, 3:41 pm, Christian Hammond chip...@chipx86.com wrote:
  Hi Tim,
 
  We use a Python module called Pygments (http://www.pygments.org/) for
 the
  syntax highlighting, so we basically support whatever they do.
 
  The lack of Obj-C highlighting is certainly an annoyance that I've dealt
  with too. It's due to Pygments giving preference to I think Matlab files
 or
  something, over Obj-C. This is something I'd love to see them fix.
 
  There's a chance we may get support down the road for adding customizable
  highlighting (as in, being able to say that this file extension will use
  that type of highlighter). You wouldn't be able to add new syntax
  highlighting rules with this, but it's something at least, and would fix
 the
  Obj-C situation. However, I think the person who was working on this
 support
  has been too busy to finish it up, so I'm not sure which release will end
 up
  with it.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.reviewboard.org
  VMware, Inc. -http://www.vmware.com
 
  On Tue, Apr 20, 2010 at 12:33 PM, Tim Hollingsworth 
 
 
 
 
 
  timhollingswo...@gmail.com wrote:
   Hello,
 
   Firstly I just started using Review Board and have had a very positive
   experience so far, thanks!
 
   Is there some place to find out what syntax highlighting is
   available?  Is it pluggable or standardized?
 
   I'm using C++ and objective-c.  The C++ has some highlighting, but not
   very meaningful - it colors comments and import statements differently
   but no real highlighting in the code.  In objective-c there is not
   highlighting at all.
 
   --
   Want to help the Review Board project? Donate today at
  http://www.reviewboard.org/donate/
   Happy user? Let us know athttp://www.reviewboard.org/users/
   -~--~~~~--~~--~--~---
   To unsubscribe from this group, send email to
   reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 reviewboard%2bunsubscr...@googlegr oups.com
   For more options, visit this group at
  http://groups.google.com/group/reviewboard?hl=en
 
  --
  Want to help the Review Board project? Donate today athttp://
 www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
  For more options, visit this group athttp://
 groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Syntax highlighting

2010-04-21 Thread Tim Hollingsworth
Thanks for the response, I'll take a look at pygment and try out your fix
Dan.

On Wed, Apr 21, 2010 at 12:17 PM, Christian Hammond chip...@chipx86.comwrote:

 We used to use get_lexer and saw some serious performance problems with it,
 which is why we switched to get_lexer_for_filename.

 Christian

 --
 Christian Hammond - chip...@chipx86.com

 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Wed, Apr 21, 2010 at 8:45 AM, Dan Savilonis d...@n-cube.org wrote:

 I've added support for changing the syntax highlighting scheme, if
 that will help with your disappointment in the highlighting. It's
 working, but it needs some better integration for installation. Right
 now you have to hack up the pygments generated styles with a script.

 http://github.com/djs/reviewboard/tree/pygments

 For the Obj-C issue, RB is currently using get_lexer_for_filename, but
 there is also a guess_lexer API that presumably would yield better
 results...

 Dan



 On Apr 20, 3:41 pm, Christian Hammond chip...@chipx86.com wrote:
  Hi Tim,
 
  We use a Python module called Pygments (http://www.pygments.org/) for
 the
  syntax highlighting, so we basically support whatever they do.
 
  The lack of Obj-C highlighting is certainly an annoyance that I've dealt
  with too. It's due to Pygments giving preference to I think Matlab files
 or
  something, over Obj-C. This is something I'd love to see them fix.
 
  There's a chance we may get support down the road for adding
 customizable
  highlighting (as in, being able to say that this file extension will use
  that type of highlighter). You wouldn't be able to add new syntax
  highlighting rules with this, but it's something at least, and would fix
 the
  Obj-C situation. However, I think the person who was working on this
 support
  has been too busy to finish it up, so I'm not sure which release will
 end up
  with it.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.reviewboard.org
  VMware, Inc. -http://www.vmware.com
 
  On Tue, Apr 20, 2010 at 12:33 PM, Tim Hollingsworth 
 
 
 
 
 
  timhollingswo...@gmail.com wrote:
   Hello,
 
   Firstly I just started using Review Board and have had a very positive
   experience so far, thanks!
 
   Is there some place to find out what syntax highlighting is
   available?  Is it pluggable or standardized?
 
   I'm using C++ and objective-c.  The C++ has some highlighting, but not
   very meaningful - it colors comments and import statements differently
   but no real highlighting in the code.  In objective-c there is not
   highlighting at all.
 
   --
   Want to help the Review Board project? Donate today at
  http://www.reviewboard.org/donate/
   Happy user? Let us know athttp://www.reviewboard.org/users/
   -~--~~~~--~~--~--~---
   To unsubscribe from this group, send email to
   reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 reviewboard%2bunsubscr...@googlegr oups.com
   For more options, visit this group at
  http://groups.google.com/group/reviewboard?hl=en
 
  --
  Want to help the Review Board project? Donate today athttp://
 www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
  For more options, visit this group athttp://
 groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Syntax highlighting

2010-04-21 Thread Dan Savilonis
That's what I thought. But I'm sure we can come up with some solution.
Presumably we only have to have a one-time performance penalty per
file, if we're intelligent about it. Also, have you considered any
alternatives to pygments?

Dan

On Apr 21, 3:17 pm, Christian Hammond chip...@chipx86.com wrote:
 We used to use get_lexer and saw some serious performance problems with it,
 which is why we switched to get_lexer_for_filename.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com





 On Wed, Apr 21, 2010 at 8:45 AM, Dan Savilonis d...@n-cube.org wrote:
  I've added support for changing the syntax highlighting scheme, if
  that will help with your disappointment in the highlighting. It's
  working, but it needs some better integration for installation. Right
  now you have to hack up the pygments generated styles with a script.

 http://github.com/djs/reviewboard/tree/pygments

  For the Obj-C issue, RB is currently using get_lexer_for_filename, but
  there is also a guess_lexer API that presumably would yield better
  results...

  Dan

  On Apr 20, 3:41 pm, Christian Hammond chip...@chipx86.com wrote:
   Hi Tim,

   We use a Python module called Pygments (http://www.pygments.org/) for
  the
   syntax highlighting, so we basically support whatever they do.

   The lack of Obj-C highlighting is certainly an annoyance that I've dealt
   with too. It's due to Pygments giving preference to I think Matlab files
  or
   something, over Obj-C. This is something I'd love to see them fix.

   There's a chance we may get support down the road for adding customizable
   highlighting (as in, being able to say that this file extension will use
   that type of highlighter). You wouldn't be able to add new syntax
   highlighting rules with this, but it's something at least, and would fix
  the
   Obj-C situation. However, I think the person who was working on this
  support
   has been too busy to finish it up, so I'm not sure which release will end
  up
   with it.

   Christian

   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.reviewboard.org
   VMware, Inc. -http://www.vmware.com

   On Tue, Apr 20, 2010 at 12:33 PM, Tim Hollingsworth 

   timhollingswo...@gmail.com wrote:
Hello,

Firstly I just started using Review Board and have had a very positive
experience so far, thanks!

Is there some place to find out what syntax highlighting is
available?  Is it pluggable or standardized?

I'm using C++ and objective-c.  The C++ has some highlighting, but not
very meaningful - it colors comments and import statements differently
but no real highlighting in the code.  In objective-c there is not
highlighting at all.

--
Want to help the Review Board project? Donate today at
   http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr
 oups.com
  reviewboard%2bunsubscr...@googlegr oups.com
For more options, visit this group at
   http://groups.google.com/group/reviewboard?hl=en

   --
   Want to help the Review Board project? Donate today athttp://
 www.reviewboard.org/donate/
   Happy user? Let us know athttp://www.reviewboard.org/users/
   -~--~~~~--~~--~--~---
   To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr 
  oups.com
   For more options, visit this group athttp://
  groups.google.com/group/reviewboard?hl=en

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr 
  oups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today 
 athttp://www.reviewboard.org/donate/
 Happy user? Let us know athttp://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group 
 athttp://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Syntax highlighting

2010-04-20 Thread Christian Hammond
Hi Tim,

We use a Python module called Pygments (http://www.pygments.org/) for the
syntax highlighting, so we basically support whatever they do.

The lack of Obj-C highlighting is certainly an annoyance that I've dealt
with too. It's due to Pygments giving preference to I think Matlab files or
something, over Obj-C. This is something I'd love to see them fix.

There's a chance we may get support down the road for adding customizable
highlighting (as in, being able to say that this file extension will use
that type of highlighter). You wouldn't be able to add new syntax
highlighting rules with this, but it's something at least, and would fix the
Obj-C situation. However, I think the person who was working on this support
has been too busy to finish it up, so I'm not sure which release will end up
with it.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Apr 20, 2010 at 12:33 PM, Tim Hollingsworth 
timhollingswo...@gmail.com wrote:

 Hello,

 Firstly I just started using Review Board and have had a very positive
 experience so far, thanks!

 Is there some place to find out what syntax highlighting is
 available?  Is it pluggable or standardized?

 I'm using C++ and objective-c.  The C++ has some highlighting, but not
 very meaningful - it colors comments and import statements differently
 but no real highlighting in the code.  In objective-c there is not
 highlighting at all.

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Syntax highlighting

2009-06-16 Thread MStruzak

Ok, here is the diff to be applied to ReviewBoard-1.0rc3-py2.5.egg/
reviewboard/diffviewer/diffutils.py:

--- diffutils.py2009/06/16 21:37:54 1.1
+++ diffutils.py2009/06/16 21:58:24
@@ -9,6 +9,7 @@
 try:
 import pygments
 from pygments.lexers import get_lexer_for_filename
+from pygments.lexers import get_lexer_by_name
 # from pygments.lexers import guess_lexer_for_filename
 from pygments.formatters import HtmlFormatter
 except ImportError:
@@ -291,9 +292,10 @@
 # XXX Guessing is preferable but really slow, especially on
XML
 # files.
 #if filename.endswith(.xml):
-lexer = get_lexer_for_filename(filename, stripnl=False)
+#lexer = get_lexer_for_filename(filename, stripnl=False)
 #else:
 #lexer = guess_lexer_for_filename(filename, data,
stripnl=False)
+lexer = get_lexer_by_name('html+php', stripnl=False)

 try:
 # This is only available in 0.7 and higher

Run pygmentize -L for the list of lexers.  This obviously will not
work for projects with mixed languages.

--Marcin
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Syntax highlighting

2009-06-15 Thread Christian Hammond
Hi Marcin,

There's no setting for this yet, but I know someone was working on one. It's
too late to get it into 1.0, but it's possible we can encourage him to get
it ready for 1.1 :)

This is really an issue in Pygments, the third-party library we use for
syntax highlighting. They hard-code the extensions for certain file types.
While we can override in the future, it really would be ideal if they had a
way of customizing this better. Right now it requires modifying some files
in the Pygments tree directly and running a script (I don't remember the
details on how that works off-hand).

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 15, 2009 at 2:51 PM, MStruzak mar...@pbanker.com wrote:


 Hi --

 I apologize if this has been answered elsewhere.  I see strange
 artifacts when displaying diffs of PHP code.  Essentially all my $ @ !
 and ' get a red box around them.  I use .inc extensions on my files.
 Is there a setting (more specific than on/off on the admin page) where
 I could indicate what extension uses what language?  (I am pretty sure
 that ReviewBoard treats my files as something else, maybe Pascal?).

 Thanks!

 --Marcin

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---