Re: Unable to get post-review to recognise a P4 repository

2012-03-27 Thread Lee Winder
I don't have SVN installed in any form (command line, TortoiseSVN etc.) so 'svn info' just generates what I'd expect. 'svn' is not recognized as an internal or external command, operable program or batch file. The only other VC system I have installed is Hg, and I'm as far away as possible

Re: Unable to get post-review to recognise a P4 repository

2012-03-27 Thread Lee Winder
I don't have SVN installed in any form (command line, TortoiseSVN etc.) so 'svn info' just generates what I'd expect. 'svn' is not recognized as an internal or external command, operable program or batch file. The only other VC system I have installed is Hg, and I'm as far away as possible

Re: Unable to get post-review to recognise a P4 repository

2012-03-27 Thread Christian Hammond
Hey Lee, Ah, looks like that error message got copy/pasted for Perforce. So it is likely getting to your Perforce check, but it's not seeing diff. Specifically, it's running diff --version and checking that GNU diffutils is in the output. Can you run those steps on your system and see what it

Re: Unable to get post-review to recognise a P4 repository

2012-03-27 Thread Matthew Waddilove
I think that this is similar to a problem that I've come across, or might be the same tbh. :) I had all sorts of issues as we're both using a perforce proxy and reviewboard at a remote location so had to do some fiddling to get it all to work, both configuring reviewboard, and poking ssh

Re: Unable to get post-review to recognise a P4 repository

2012-03-27 Thread Lee Winder
Ah, copy/paste errors, we've all been there - my bad for not rooting around in the source code a bit more :) I didn't have the the diffutils installed (it's a pretty new PC set up) but now I have, the reviews are being posted as expected, thanks for the assist. Now I just need to get it set up

Re: Unable to get post-review to recognise a P4 repository

2012-03-26 Thread Christian Hammond
Hey Lee, Yeah, it looks like it's seeing Subversion and trying that first, and never even reaching the Perforce attempt. Basically, post-review will try a number of tools in order to find out what the repository and type is. First one to report a valid repo wins. Sounds like Subversion is doing