Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Christian Hammond
Hi Rujia, This might be fixed in the nightlies. Can you try a nightly build from http://downloads.review-board.org/nightlies/ and see if this fixes the problem? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Rujia Liu
Hi! Thanks, Christian. I've updated to the newest nightly build. Now I have found the reason. Thanks to the -d option, I saw the last command that post-review has executed: svn diff --diff-cmd=diff http://mysvnserver/@xxx http://mysvnserver/@HEAD I manually executed it and it asked me for the

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Christian Hammond
Hi Rujia, You can get more detailed debugging information by setting DEBUG = True in Review Board's conf/settings_local.py. Then restart the web server and try again. You'll get an HTML error dump with a backtrace. We can take a look at the error dump if the problem isn't obvious. It would be

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Rujia Liu
Hi! Oops, I didn't realize that ReviewBoard sent me an email. Notice that I'm NOT using the nightly built ReviewBoard (I just used easy_install ReviewBoard). Is that because attribute target_groups has been renamed? - Rujia = Email begins == Title: [Django] Error (EXTERNAL

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Christian Hammond
Looks like we're not properly checking whether there's an error and assuming it's a draft. Certainly a bug. If you can file this backtrace in a bug report, that would be helpful. The problem is that the user specified doesn't have permission to modify that review request. The code that checks

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Rujia Liu
Hi! Finally it worked. I've carefully read the automatingpost-review section, but I misunderstood some permission. I still don't think I understand it now, but at least, when I assign everything to the logged user (who submits on be half of another user), it worked. Some suggestions: 1. The