Hi, as far as I know it is the latter. Since the default workflow design for ReviewBoard is to review the code before it is committed, clicking on "ship it!" means to tell the author: "Yes, I agree to your changes: Ship it!" At this, "to ship" has the meaning of sending or committing the suggested changes to the VCS.
Regards, Ruben From: "深圳手机 (王)" <825772...@qq.com<mailto:825772...@qq.com>> Reply-To: <reviewboard@googlegroups.com<mailto:reviewboard@googlegroups.com>> Date: Tue, 14 Feb 2012 17:33:18 +0800 To: reviewboard <reviewboard@googlegroups.com<mailto:reviewboard@googlegroups.com>> Subject: What's the mean of "ship it!"? What's the mean of "ship it!"? I am puzzled for this question for some time. Remind the people don't forget to review the code? or the reviewer accept the result? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com<mailto:reviewboard+unsubscr...@googlegroups.com> For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
