Re: diff viewer does not work after GitLab update, reviewboard version 1.7.27

2016-04-06 Thread Christian Hammond 
Also, what version of Review Board are you using?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Wed, Apr 6, 2016 at 11:52 AM, Christian Hammond  wrote:

> Hi Ralf,
>
> Sounds like they made a backwards-incompatible change to their API. We'll
> need to investigate and likely work on a patch for the next release.
>
> Would you be able to file a bug on
> https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard and,
> after filing, privately attach the contents of the temp directory? You can
> do so by uploading each file and clicking the lock icon on the update box
> on Splat.
>
> Christian
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Tue, Apr 5, 2016 at 5:13 AM, Ralf Mueller 
> wrote:
>
>> Hi,
>>
>> we recently update our GitLab to 8.6.1 and now the 'View Diff' does not
>> work anymore. It produces an error message like:
>> Error: The patch to 'README' didn't apply cleanly. The temporary files
>> have been left in '/tmp/reviewboard.2YSn1I' for debugging purposes. `patch`
>> returned: patching file /tmp/reviewboard.2YSn1I/tmp2kVGGw-new (read from
>> /tmp/reviewboard.2YSn1I/tmp2kVGGw) Hunk #1 FAILED at 3. 1 out of 1 hunk
>> FAILED -- saving rejects to file /tmp/reviewboard.2YSn1I/tmp2kVGGw-new.rej
>>
>>
>> The result is similar to all review request in the system, which have
>> worked before the update.
>>
>> There are no visible error on the ReviewBoard log neither on GitLab. I
>> have check the content of the temporary files from the RB error message and
>> it look that the 'old' and the 'new' file contain the same blob. It's also
>> visible from the GitLab side that there are to requests and the answer is
>> the same.
>>
>> Any idea what happened here? Is it correct that the blob are identical?
>>
>> If you need any further information, please let me know.
>>
>> BR
>> Ralf
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: diff viewer does not work after GitLab update, reviewboard version 1.7.27

2016-04-06 Thread Christian Hammond 
Hi Ralf,

Sounds like they made a backwards-incompatible change to their API. We'll
need to investigate and likely work on a patch for the next release.

Would you be able to file a bug on
https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard and,
after filing, privately attach the contents of the temp directory? You can
do so by uploading each file and clicking the lock icon on the update box
on Splat.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Tue, Apr 5, 2016 at 5:13 AM, Ralf Mueller  wrote:

> Hi,
>
> we recently update our GitLab to 8.6.1 and now the 'View Diff' does not
> work anymore. It produces an error message like:
> Error: The patch to 'README' didn't apply cleanly. The temporary files
> have been left in '/tmp/reviewboard.2YSn1I' for debugging purposes. `patch`
> returned: patching file /tmp/reviewboard.2YSn1I/tmp2kVGGw-new (read from
> /tmp/reviewboard.2YSn1I/tmp2kVGGw) Hunk #1 FAILED at 3. 1 out of 1 hunk
> FAILED -- saving rejects to file /tmp/reviewboard.2YSn1I/tmp2kVGGw-new.rej
>
>
> The result is similar to all review request in the system, which have
> worked before the update.
>
> There are no visible error on the ReviewBoard log neither on GitLab. I
> have check the content of the temporary files from the RB error message and
> it look that the 'old' and the 'new' file contain the same blob. It's also
> visible from the GitLab side that there are to requests and the answer is
> the same.
>
> Any idea what happened here? Is it correct that the blob are identical?
>
> If you need any further information, please let me know.
>
> BR
> Ralf
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.