Hi Damien, The diff viewer was moved into its own app very early on for the purpose of organization, but there aren't any plans to actually split it off into its own third-party module short-term. It would increase our maintenance burden a bit, and it depends too much on other modules within Review Board (such as the scmtools and accounts modules).
That being said, with some changes to make the diffviewer's dependencies on the accounts module a bit more flexible, you could potentially just depend on the reviewboard codebase and use the diffviewer module directly from that. It does, however, mean pulling in more code than you might prefer. If you did want to make use of it, it would require some code changes. You'd need to look at every import in scmtools/*.py and diffviewer/*.py and see what other parts of reviewboard is required. You'd then need to work on factoring those out in some way. If it's clean and doesn't increase our maintenance burden, we'll take a patch for it. You'd need to then include diffviewer and scmtools in your INSTALLED_APPS in settings.py. There may be more, but not having had to do this, I'm not sure off-hand. I'm not completely opposed to having this module as its own third-party module, but it does make life a bit harder for us and our users, as we now would have to match up versions and test various combinations. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jan 28, 2010 at 2:47 PM, damdoum <damien.no...@gmail.com> wrote: > Hello, > > I have questions about the diffviewer feature of reviewboard. > Is it going to be forked off reviewboard and become a separate MIT- > licensed django app? I could see that the code was moved around a bit > to make it a separate app, but it that the direction it is taking? > My second question would be how easy would it be to use that > diffviewer feature on its own? > - changing the settings.py? > - a view that accepts post data / MIME multi-part? > - use of URI to point to source / diff? > > thank you! > > Damien. > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
