Re: post-review --revision-range perforce
Hi,
Again thanks for your quick response.
I did try that command
22 C% c:\Python25\Scripts\post-review --server=http://
ambia.scm.na.mscsoftware.com //motws/dev/tier1/@222,@246
but got following traceback...
Traceback (most recent call last):
File c:\Python25\Scripts\post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta2.dev-20090713', 'post-
review')
File C:\Python25\Lib\site-packages\pkg_resources.py, line 448, in
run_script
self.require(requires)[0].run_script(script_name, ns)
File C:\Python25\Lib\site-packages\pkg_resources.py, line 1173, in
run_scrip
t
exec script_code in namespace, namespace
File c:\Python25\Scripts\post-review, line 2497, in module
File c:\Python25\Scripts\post-review, line 2468, in main
File c:\Python25\Scripts\post-review, line 1355, in diff
File c:\Python25\Scripts\post-review, line 1465, in _path_diff
File c:\Python25\Scripts\post-review, line 1666, in _do_diff
IndexError: list index out of range
Using the -debug flag I received lots for output with following
lines at the very end.
Writing //motws/dev/tier1/examples/geometry/plate_grid/plate.mnf#2 to
c:\docume~1\ronak\locals~1\temp\tmpqtihaw
p4 print -o c:\docume~1\ronak\locals~1\temp\tmpqtihaw -q
//motws/dev/tier1/examples/geometry/plate_grid/plate.mnf#2
diff -urNp c:\docume~1\ronak\locals~1\temp\tmpdqr4ib
c:\docume~1\ronak\locals~1\temp\tmpqtihaw
Traceback (most recent call last):
File c:\Python25\Scripts\post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta2.dev-20090713', 'post-
review')
File C:\Python25\Lib\site-packages\pkg_resources.py, line 448, in
run_script
self.require(requires)[0].run_script(script_name, ns)
File C:\Python25\Lib\site-packages\pkg_resources.py, line 1173, in
run_scrip
t
exec script_code in namespace, namespace
File c:\Python25\Scripts\post-review, line 2497, in module
File c:\Python25\Scripts\post-review, line 2468, in main
File c:\Python25\Scripts\post-review, line 1355, in diff
File c:\Python25\Scripts\post-review, line 1465, in _path_diff
File c:\Python25\Scripts\post-review, line 1666, in _do_diff
IndexError: list index out of range
I did try running the last diff command manually and got not error
diff -urNp c:\docume~1\ronak\locals~1\temp\tmpdqr4ib
c:\docume~1\ronak\locals~1\temp\tmpqtihaw
Files c:\docume~1\ronak\locals~1\temp\tmpdqr4ib and c:\docume~1\ronak
\locals~1\temp\tmpqtihaw differ
I will now reduce the diff from @222,@246 to @222,@223 and see what I
get.
If you have other ideas please let me know.
Once again thanks for your help,
Ronak
On Jul 13, 1:14 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
You don't want to use revision-range with this. The path replaces revision
range, and contains the range within it. In your case, you'd use:
c:\Python25\Scripts\post-review
--server=http://ambia.scm.na.mscsoftware.com//motws/dev/tier1/@222,@246
--debug
Or #222,#246, depending on whether we're talking file revisions or change
numbers.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Mon, Jul 13, 2009 at 11:13 AM, Ronak ronakdotpa...@gmail.com wrote:
Hi Christian,
Thanks for your quick response. I did as you suggested but still no
luck.
== c:\Python25\Scripts\post-review --server=http://
ambia.scm.na.mscsoftware.com --revision-range=222:246 //motws/dev/
tier1/... --debug
hg root
p4 info
repository info: Path: ooty.mscsoftware.com:1666, Base path: None,
Supports changesets: True
Looking for 'ambia.scm.na.mscsoftware.com /' cookie in C:\Documents
and Settings\ronak\Local Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing to
http://ambia.scm.na.mscsoftware.com/api/json/reviewrequests/new/:
{'repository_path': 'ooty.mscsoftware.com:1666'}
Review request created
Traceback (most recent call last):
File c:\Python25\Scripts\post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta2.dev-20090713', 'post-
review')
File C:\Python25\Lib\site-packages\pkg_resources.py, line 448, in
run_script
self.require(requires)[0].run_script(script_name, ns)
File C:\Python25\Lib\site-packages\pkg_resources.py, line 1173, in
run_scrip
t
exec script_code in namespace, namespace
File c:\Python25\Scripts\post-review, line 2497, in module
File c:\Python25\Scripts\post-review, line 2479, in main
File c:\Python25\Scripts\post-review, line 2211, in tempt_fate
File c:\Python25\Scripts\post-review, line 439, in upload_diff
TypeError: object of type 'NoneType' has no len()
Thanks,
Ronak
On Jul 10, 6:57 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Ronak,
I believe this support is only in the nightlies (available athttp://
Re: post-review --revision-range perforce
Christian, Thanks a lot for your quick response. I will try it today and let you know. Ronak On Jul 10, 6:57 pm, Christian Hammond chip...@chipx86.com wrote: Hi Ronak, I believe this support is only in the nightlies (available athttp://downloads.review-board.org/nightlies/). I hope to do a formal release soon, but for now you can grab the latest RBTools .egg from there and easy_install that. The //path/to/whatever isn't part of revision-range, I don't think. I believe you just pass it to post-review. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Jul 10, 2009 at 6:39 PM, Ronak ronakdotpa...@gmail.com wrote: Hi, I am trying to use test out some code review tools to use in our company and one of the tools that I came across is reviewboard. It is really a good tool and I would like to implement it at our site. I had one question related to posting already submitted change sets. I am using on my client machine (windows) WinXP SP2, Perforce (2008.2), Post-review (0.2beta1), GnuWin32Diff Server (linux) is configured with RH Linux, Perforce (2008.2), ReviewBoard 1.0, Django and other required modules I am looked at following url http://www.review-board.org/docs/manual/dev/users/tools/post-review/ Section of interest is Posting Committed Code I was able to submit one changelist that was submitted to perforce by just providing the changenum as input. For example = %post-review 32 --server=http://10.16.50.150 Review request #29 posted. http://10.16.50.150/r/29 == Now I was trying to post review for all changes on a branch, is this possible? I would prefer to post a range if possible. I have tried following commands but no luck. %post-review --server=http://10.16.50.150--revision-range=30:31 You must include a change set number %post-review --server=http://10.16.50.150\\depot\dev\dev \tier1\SConscript (path to a file) You must include a change set number %post-review --server=http://10.16.50.150--revision-range=//depot/dev/ tier1/SConscript#2,#3 You must include a change set number %post-review --server=http://10.16.50.150--revision-range=//depot/dev/ tier1/@222,@246 tier1 Unable to accesshttp://10.16.50.150/api/json/reviewrequests/new/. The host path may be invalid HTTP Error 500: Internal Server Error Can someone please help? I would like to work on a development branch for couple of days and once I am done post reviews for all the changelists on that branch. Next step I am going to try to do is turn on debug information for ReviewBoard. This is in the server logs. 172.16.56.200 - - [10/Jul/2009:18:36:34 -0700] POST /api/json/ reviewrequests/new/ HTTP/1.1 500 105461 - post-review/0.8 Thanks for your help. Ronak- Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review --revision-range perforce
Hi Christian,
Thanks for your quick response. I did as you suggested but still no
luck.
== c:\Python25\Scripts\post-review --server=http://
ambia.scm.na.mscsoftware.com --revision-range=222:246 //motws/dev/
tier1/... --debug
hg root
p4 info
repository info: Path: ooty.mscsoftware.com:1666, Base path: None, Supports
changesets: True
Looking for 'ambia.scm.na.mscsoftware.com /' cookie in C:\Documents and
Settings\ronak\Local Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing to
http://ambia.scm.na.mscsoftware.com/api/json/reviewrequests/new/:
{'repository_path': 'ooty.mscsoftware.com:1666'}
Review request created
Traceback (most recent call last):
File c:\Python25\Scripts\post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta2.dev-20090713', 'post-
review')
File C:\Python25\Lib\site-packages\pkg_resources.py, line 448, in
run_script
self.require(requires)[0].run_script(script_name, ns)
File C:\Python25\Lib\site-packages\pkg_resources.py, line 1173, in
run_scrip
t
exec script_code in namespace, namespace
File c:\Python25\Scripts\post-review, line 2497, in module
File c:\Python25\Scripts\post-review, line 2479, in main
File c:\Python25\Scripts\post-review, line 2211, in tempt_fate
File c:\Python25\Scripts\post-review, line 439, in upload_diff
TypeError: object of type 'NoneType' has no len()
Thanks,
Ronak
On Jul 10, 6:57 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Ronak,
I believe this support is only in the nightlies (available
athttp://downloads.review-board.org/nightlies/). I hope to do a formal release
soon, but for now you can grab the latest RBTools .egg from there and
easy_install that.
The //path/to/whatever isn't part of revision-range, I don't think. I
believe you just pass it to post-review.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Fri, Jul 10, 2009 at 6:39 PM, Ronak ronakdotpa...@gmail.com wrote:
Hi,
I am trying to use test out some code review tools to use in our
company and one of the tools that I came across is reviewboard. It is
really a good tool and I would like to implement it at our site. I
had one question related to posting already submitted change sets.
I am using on my client machine (windows)
WinXP SP2, Perforce (2008.2), Post-review (0.2beta1), GnuWin32Diff
Server (linux) is configured with
RH Linux, Perforce (2008.2), ReviewBoard 1.0, Django and other
required modules
I am looked at following url
http://www.review-board.org/docs/manual/dev/users/tools/post-review/
Section of interest is Posting Committed Code
I was able to submit one changelist that was submitted to perforce by
just providing the changenum as input. For example
=
%post-review 32 --server=http://10.16.50.150
Review request #29 posted.
http://10.16.50.150/r/29
==
Now I was trying to post review for all changes on a branch, is this
possible?
I would prefer to post a range if possible. I have tried following
commands but no luck.
%post-review --server=http://10.16.50.150--revision-range=30:31
You must include a change set number
%post-review --server=http://10.16.50.150\\depot\dev\dev
\tier1\SConscript (path to a file)
You must include a change set number
%post-review --server=http://10.16.50.150--revision-range=//depot/dev/
tier1/SConscript#2,#3
You must include a change set number
%post-review --server=http://10.16.50.150--revision-range=//depot/dev/
tier1/@222,@246 tier1
Unable to accesshttp://10.16.50.150/api/json/reviewrequests/new/. The
host path may be invalid
HTTP Error 500: Internal Server Error
Can someone please help? I would like to work on a development branch
for couple of days and once I am done post reviews for all the
changelists on that branch.
Next step I am going to try to do is turn on debug information for
ReviewBoard. This is in the server logs.
172.16.56.200 - - [10/Jul/2009:18:36:34 -0700] POST /api/json/
reviewrequests/new/ HTTP/1.1 500 105461 - post-review/0.8
Thanks for your help.
Ronak- Hide quoted text -
- Show quoted text -
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: post-review --revision-range perforce
Hi Ronak, I believe this support is only in the nightlies (available at http://downloads.review-board.org/nightlies/). I hope to do a formal release soon, but for now you can grab the latest RBTools .egg from there and easy_install that. The //path/to/whatever isn't part of revision-range, I don't think. I believe you just pass it to post-review. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Jul 10, 2009 at 6:39 PM, Ronak ronakdotpa...@gmail.com wrote: Hi, I am trying to use test out some code review tools to use in our company and one of the tools that I came across is reviewboard. It is really a good tool and I would like to implement it at our site. I had one question related to posting already submitted change sets. I am using on my client machine (windows) WinXP SP2, Perforce (2008.2), Post-review (0.2beta1), GnuWin32Diff Server (linux) is configured with RH Linux, Perforce (2008.2), ReviewBoard 1.0, Django and other required modules I am looked at following url http://www.review-board.org/docs/manual/dev/users/tools/post-review/ Section of interest is Posting Committed Code I was able to submit one changelist that was submitted to perforce by just providing the changenum as input. For example = %post-review 32 --server=http://10.16.50.150 Review request #29 posted. http://10.16.50.150/r/29 == Now I was trying to post review for all changes on a branch, is this possible? I would prefer to post a range if possible. I have tried following commands but no luck. %post-review --server=http://10.16.50.150 --revision-range=30:31 You must include a change set number %post-review --server=http://10.16.50.150 \\depot\dev\dev \tier1\SConscript (path to a file) You must include a change set number %post-review --server=http://10.16.50.150 --revision-range=//depot/dev/ tier1/SConscript#2,#3 You must include a change set number %post-review --server=http://10.16.50.150 --revision-range=//depot/dev/ tier1/@222,@246 tier1 Unable to access http://10.16.50.150/api/json/reviewrequests/new/. The host path may be invalid HTTP Error 500: Internal Server Error Can someone please help? I would like to work on a development branch for couple of days and once I am done post reviews for all the changelists on that branch. Next step I am going to try to do is turn on debug information for ReviewBoard. This is in the server logs. 172.16.56.200 - - [10/Jul/2009:18:36:34 -0700] POST /api/json/ reviewrequests/new/ HTTP/1.1 500 105461 - post-review/0.8 Thanks for your help. Ronak --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
