Re: post-review login issue

2009-09-23 Thread Christian Hammond
Strange. This is not an issue I've seen before. I can't tell if the error is
just overly escaping the \ or if the filename is invalid.

Do you know exactly what line is causing that error in the code?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Tue, Sep 22, 2009 at 10:39 PM, Hui Lin hui@bankofamerica.com wrote:


 Uploading the diff works now after fixing some perforce registry
 issues.

 However, when I click the View Diff button in the request details
 page, I got this error:
[Errno 2] No such file or directory: 'c:\\winnt\\temp\
 \reviewboard.jyl6y5\\tmpsx6zut-new'

 The patched new file isn't there. I turned on the debug, and saw the
 output of the patch command:
Hmm...  I can't seem to find a patch in there anywhere.

 I tweaked the code of diffutils.py by first saving the diff data
 into a file, and then run the patch command:
patch -d c:\winnt\temp\reviewboard.jyl6y5 -i tmpsx6zut-diff -o
 tmpsx6zut-new tmpsx6zut

 But still not working. This command worked fine when executed in the
 DOS console.

 It also works fine when executed in python runtime interactively:
 command = 'patch -d c:\winnt\temp\reviewboard.jyl6y5 -i
 tmpsx6zut-diff -o tmpsx6zut-new tmpsx6zut'
 import subprocess
 p = subprocess.Popen(command, stdin=subprocess.PIPE,
 stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
 p.stdout.read()
'patching file c:\\winnt\\temp\\reviewboard.zug54j\\tmp-wkiqd\r\n'

 What could be wrong?

 I am using the GnuWin32 patch version 2.5.9.


 On Sep 22, 6:45 pm, Lacoste, Dana (TSG Software San Diego)
 dana.laco...@hp.com wrote:
  OK, that makes sense.
 
  I was just hoping for a quicker solution to the give me the whole file
 problem ☺
 
  I'll see what I can provide in the realm of support for coding that ☺
 
  Dana
 
  From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com]
 On Behalf Of Christian Hammond
  Sent: Tuesday, September 22, 2009 4:38 PM
  To: reviewboard@googlegroups.com
  Subject: Re: post-review login issue
 
  Hi Dana,
 
  We specifically avoid this for a few reasons.
 
  1) It's much more efficient to store a diff in the database instead of a
 full file.
 
  2) We need both an original, unmodified file along with the patched file.
 This means that either we still need to do a server fetch, or we now need
 both files uploaded and stored in the database.
 
  3) It actually limits us. By having the diff, future extensions to Review
 Board may be able to do things like track a patch's freshness (useful for
 contributed patches to open source projects) by periodically attempting to
 apply the patch to the latest version in a codebase. If we use full files,
 we can't build this kind of extensibility.
 
  4) Review Board now needs to know how to generate every kind of diff we
 could possibly need for every revision control system when the user clicks
 Download Diff. We want to preserve the diffs uploaded. For example, A Git
 diff may contain some author and description information embedded in the
 diff. We can't reproduce this.
 
  There's no reason today why we can't build the functionality to download
 the modified files. It's just a matter of looking up the list of files
 associated with a change and calling our existing function to grab the
 patched version of the file from the repository, then assemble them into a
 zip or something for download.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: post-review login issue

2009-09-23 Thread Hui Lin

I resolved the patch issue by running Apache as a normal Windows
application, not a service. Not sure exactly why, but suspect that the
different user accounts for running Windows services (SYSTEM) and
running user applications (Current User Login) may be the reason.

Now diff view is working great.


On Sep 23, 12:00 pm, Hui Lin hui@bankofamerica.com wrote:
 Hi, Dana:

 I saw your posts are rendered at full length each line, but mine are
 wrapped at 70-80 characters, which makes them look quite different
 from what I originally posted.

 What is the trick?

 Thanks

 On Sep 23, 11:28 am, Hui Lin hui@bankofamerica.com wrote:



  The issue started from line 107 of diffutils.py. This is how the
  patch is executed:
      p = subprocess.Popen(['patch', '-o', newfile, oldfile],
                           stdin=subprocess.PIPE,
  stdout=subprocess.PIPE,
                           stderr=subprocess.STDOUT)

  The subsequent error checking isn't adequent, as in this case, p.wait
  () returns false, but the patch_output indicates that it actually
  failed.
      patch_output = p.stdout.read()
      failure = p.wait()

      if failure:
          ...

  On Sep 23, 1:00 am, Christian Hammond chip...@chipx86.com wrote:

   Strange. This is not an issue I've seen before. I can't tell if the error 
   is
   just overly escaping the \ or if the filename is invalid.

   Do you know exactly what line is causing that error in the code?

   Christian

   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.review-board.org
   VMware, Inc. -http://www.vmware.com

   On Tue, Sep 22, 2009 at 10:39 PM, Hui Lin hui@bankofamerica.com 
   wrote:

Uploading the diff works now after fixing some perforce registry
issues.

However, when I click the View Diff button in the request details
page, I got this error:
   [Errno 2] No such file or directory: 'c:\\winnt\\temp\
\reviewboard.jyl6y5\\tmpsx6zut-new'

The patched new file isn't there. I turned on the debug, and saw the
output of the patch command:
   Hmm...  I can't seem to find a patch in there anywhere.

I tweaked the code of diffutils.py by first saving the diff data
into a file, and then run the patch command:
   patch -d c:\winnt\temp\reviewboard.jyl6y5 -i tmpsx6zut-diff -o
tmpsx6zut-new tmpsx6zut

But still not working. This command worked fine when executed in the
DOS console.

It also works fine when executed in python runtime interactively:
    command = 'patch -d c:\winnt\temp\reviewboard.jyl6y5 -i
tmpsx6zut-diff -o tmpsx6zut-new tmpsx6zut'
    import subprocess
    p = subprocess.Popen(command, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
    p.stdout.read()
   'patching file c:\\winnt\\temp\\reviewboard.zug54j\\tmp-wkiqd\r\n'

What could be wrong?

I am using the GnuWin32 patch version 2.5.9.

On Sep 22, 6:45 pm, Lacoste, Dana (TSG Software San Diego)
dana.laco...@hp.com wrote:
 OK, that makes sense.

 I was just hoping for a quicker solution to the give me the whole 
 file
problem ☺

 I'll see what I can provide in the realm of support for coding that ☺

 Dana

 From: reviewboard@googlegroups.com 
 [mailto:reviewbo...@googlegroups.com]
On Behalf Of Christian Hammond
 Sent: Tuesday, September 22, 2009 4:38 PM
 To: reviewboard@googlegroups.com
 Subject: Re: post-review login issue

 Hi Dana,

 We specifically avoid this for a few reasons.

 1) It's much more efficient to store a diff in the database instead 
 of a
full file.

 2) We need both an original, unmodified file along with the patched 
 file.
This means that either we still need to do a server fetch, or we now 
need
both files uploaded and stored in the database.

 3) It actually limits us. By having the diff, future extensions to 
 Review
Board may be able to do things like track a patch's freshness (useful 
for
contributed patches to open source projects) by periodically attempting 
to
apply the patch to the latest version in a codebase. If we use full 
files,
we can't build this kind of extensibility.

 4) Review Board now needs to know how to generate every kind of diff 
 we
could possibly need for every revision control system when the user 
clicks
Download Diff. We want to preserve the diffs uploaded. For example, A 
Git
diff may contain some author and description information embedded in the
diff. We can't reproduce this.

 There's no reason today why we can't build the functionality to 
 download
the modified files. It's just a matter of looking up the list of files
associated with a change and calling our existing function to grab the
patched version of the file from the repository, then assemble them 
into a
zip or something for download

Re: post-review login issue

2009-09-23 Thread Christian Hammond
Ahh, that very well may be. Glad it's finally working though.

Most of our development and testing is done on Linux. Some of our
dependencies are hard to install on Windows, and there's some other gotchas
like this that we're still only finding out about. I'm personally hoping to
find someone who wants to maintain our Windows support. What we've been
recommending to a lot of people is to use Linux in a VM and install on
there.

Thanks for being patient with us and with this whole process. I know issues
like this can be infuriating. The feedback is useful though.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Wed, Sep 23, 2009 at 6:23 PM, Hui Lin hui@bankofamerica.com wrote:


 I resolved the patch issue by running Apache as a normal Windows
 application, not a service. Not sure exactly why, but suspect that the
 different user accounts for running Windows services (SYSTEM) and
 running user applications (Current User Login) may be the reason.

 Now diff view is working great.


 On Sep 23, 12:00 pm, Hui Lin hui@bankofamerica.com wrote:
  Hi, Dana:
 
  I saw your posts are rendered at full length each line, but mine are
  wrapped at 70-80 characters, which makes them look quite different
  from what I originally posted.
 
  What is the trick?
 
  Thanks
 
  On Sep 23, 11:28 am, Hui Lin hui@bankofamerica.com wrote:
 
 
 
   The issue started from line 107 of diffutils.py. This is how the
   patch is executed:
   p = subprocess.Popen(['patch', '-o', newfile, oldfile],
stdin=subprocess.PIPE,
   stdout=subprocess.PIPE,
stderr=subprocess.STDOUT)
 
   The subsequent error checking isn't adequent, as in this case, p.wait
   () returns false, but the patch_output indicates that it actually
   failed.
   patch_output = p.stdout.read()
   failure = p.wait()
 
   if failure:
   ...
 
   On Sep 23, 1:00 am, Christian Hammond chip...@chipx86.com wrote:
 
Strange. This is not an issue I've seen before. I can't tell if the
 error is
just overly escaping the \ or if the filename is invalid.
 
Do you know exactly what line is causing that error in the code?
 
Christian
 
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
 
On Tue, Sep 22, 2009 at 10:39 PM, Hui Lin hui@bankofamerica.com
 wrote:
 
 Uploading the diff works now after fixing some perforce registry
 issues.
 
 However, when I click the View Diff button in the request details
 page, I got this error:
[Errno 2] No such file or directory: 'c:\\winnt\\temp\
 \reviewboard.jyl6y5\\tmpsx6zut-new'
 
 The patched new file isn't there. I turned on the debug, and saw
 the
 output of the patch command:
Hmm...  I can't seem to find a patch in there anywhere.
 
 I tweaked the code of diffutils.py by first saving the diff data
 into a file, and then run the patch command:
patch -d c:\winnt\temp\reviewboard.jyl6y5 -i tmpsx6zut-diff -o
 tmpsx6zut-new tmpsx6zut
 
 But still not working. This command worked fine when executed in
 the
 DOS console.
 
 It also works fine when executed in python runtime interactively:
 command = 'patch -d c:\winnt\temp\reviewboard.jyl6y5 -i
 tmpsx6zut-diff -o tmpsx6zut-new tmpsx6zut'
 import subprocess
 p = subprocess.Popen(command, stdin=subprocess.PIPE,
 stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
 p.stdout.read()
'patching file
 c:\\winnt\\temp\\reviewboard.zug54j\\tmp-wkiqd\r\n'
 
 What could be wrong?
 
 I am using the GnuWin32 patch version 2.5.9.
 
 On Sep 22, 6:45 pm, Lacoste, Dana (TSG Software San Diego)
 dana.laco...@hp.com wrote:
  OK, that makes sense.
 
  I was just hoping for a quicker solution to the give me the
 whole file
 problem ☺
 
  I'll see what I can provide in the realm of support for coding
 that ☺
 
  Dana
 
  From: reviewboard@googlegroups.com [mailto:
 reviewbo...@googlegroups.com]
 On Behalf Of Christian Hammond
  Sent: Tuesday, September 22, 2009 4:38 PM
  To: reviewboard@googlegroups.com
  Subject: Re: post-review login issue
 
  Hi Dana,
 
  We specifically avoid this for a few reasons.
 
  1) It's much more efficient to store a diff in the database
 instead of a
 full file.
 
  2) We need both an original, unmodified file along with the
 patched file.
 This means that either we still need to do a server fetch, or we
 now need
 both files uploaded and stored in the database.
 
  3) It actually limits us. By having the diff, future extensions
 to Review
 Board may be able to do things like track a patch's freshness
 (useful for
 contributed patches to open source projects) by periodically
 attempting

Re: post-review login issue

2009-09-22 Thread Hui Lin

I am confused here. What does the diff uploading performed by the post-
review script actually do? Does the script post the diff it generated
to the review board server? If so, what's the use of the posted diff,
if the diff display still needs to fetch everything from perforce?

Also, how could I verify that the diff is loaded into review board
server?


On Sep 21, 10:58 pm, Christian Hammond chip...@chipx86.com wrote:
 We verify the files server-side on upload, and this requires pulling them
 from the repository. Due to some bug with p4python or something (I don't
 remember the exact cause) we directly call p4 to fetch the file. We then use
 p4 later on to fetch the files for side-by-side display in the diff viewer.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Mon, Sep 21, 2009 at 8:55 PM, Hui Lin hui@bankofamerica.com wrote:

  I believe uploading the diff is just a reviewer board function, which
  doesn't seem to have anything to do with to p4.

  On Sep 21, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
   Hi,

   I don't personally have a good answer to the P4PASSWD issue, but there
  are
   several good Perforce administrators on this list who can probably share
   some advice for this.

   As for the error during posting, this is likely due to not having p4.exe
   installed in the path where the web server can see it. There's a bug open
   for catching this during repository configuration so it's not so
  confusing.
   We're planning to add that for 1.1. For now, though, just put p4.exe some
   place where the web server can see it in the PATH and it should work.

   Christian

   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.review-board.org
   VMware, Inc. -http://www.vmware.com

   On Mon, Sep 21, 2009 at 2:14 PM, Hui Lin hui@bankofamerica.com
  wrote:

Yes, I solved this issue by putting what returned from p4 info
exactly to the repository setup. My local p4 was using an alias of
what from p4 info.

Then, I bumped against another issue Perforce password (P4PASSWD)
invalid or unset.. Fortunately, I got the answer from the web:

 http://www.mail-archive.com/reviewboard@googlegroups.com/msg00183.html

It worked. However, I don't feel quite comfortable of this approach,
as the ticket expires in 12 hours. Is there a better solution?

Now, everything works until post-review tries to upload the diff,
which would fail with the error:
    Uploading diff, size: 9777
    HTTP POSTing to
   http://b002481234dc0/api/json/reviewrequests/7/diff/new/:
{}
   Error uploading diff: One or more fields had errors (105)
    {'fields': {'path': ['[Error 2] The system cannot find the
file specified']}, 'stat': 'fail', 'err': {'msg': 'One or more fields
had errors', 'code': 105}}
   Your review request still exists, but the diff is not attached.

I am using the diffutil from GnuWin32.

On Sep 21, 2:50 pm, Christian Hammond chip...@chipx86.com wrote:
 Yeah, it's a pain. I really do want to improve our repository
  comparison
 code. Right now we use a direct look-up for efficiency reasons, but
  if we
 cached the results and allowed each repository backend to do its own
 comparison, we could remove some of these complications.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San
  Diego)


 dana.laco...@hp.com wrote:
   Yeah, this one got me.

  Particularly because what I set for my $P4PORT was NOT what the
server
  returned in `p4 info` (I used an IP address because I've had DNS
  issues
in
  the past, but the server returned its hostname.)

  J

  Dana Lacoste

  *From:* reviewboard@googlegroups.com [mailto:
reviewbo...@googlegroups.com]
  *On Behalf Of *Christian Hammond
  *Sent:* Monday, September 21, 2009 12:31 PM
  *To:* reviewboard@googlegroups.com
  *Subject:* Re: post-review login issue

  Make sure that the repository Path field matches *exactly* what you
  see
  when running 'p4 info'. We do a literal string comparison.

  Christian

  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com

   On Mon, Sep 21, 2009 at 10:55 AM, Hui Lin 
  hui@bankofamerica.com
  wrote:

  Thanks Christian. I resolved the issue by install the 1.0.3 version
  and re-create the site.

  Now post-review is able to logon the reviewer board server, but
  gets
  problem of understanding the repository_path of the SCM
  (Perforce):
      Attempting to create review request for 388600
      HTTP POSTing
tohttp://b002481234dc0/api

Re: post-review login issue

2009-09-22 Thread Tom Sakkos
http://www.mail-archive.com/reviewboard@googlegroups.com/msg02548.htmldescribes
the solution the P4PASSWORD issue.  I'm not sure if it got much
further than that...

-Tom


On Tue, Sep 22, 2009 at 2:29 PM, Hui Lin hui@bankofamerica.com wrote:


 I am confused here. What does the diff uploading performed by the post-
 review script actually do? Does the script post the diff it generated
 to the review board server? If so, what's the use of the posted diff,
 if the diff display still needs to fetch everything from perforce?

 Also, how could I verify that the diff is loaded into review board
 server?


 On Sep 21, 10:58 pm, Christian Hammond chip...@chipx86.com wrote:
  We verify the files server-side on upload, and this requires pulling them
  from the repository. Due to some bug with p4python or something (I don't
  remember the exact cause) we directly call p4 to fetch the file. We then
 use
  p4 later on to fetch the files for side-by-side display in the diff
 viewer.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Mon, Sep 21, 2009 at 8:55 PM, Hui Lin hui@bankofamerica.com
 wrote:
 
   I believe uploading the diff is just a reviewer board function, which
   doesn't seem to have anything to do with to p4.
 
   On Sep 21, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
 
I don't personally have a good answer to the P4PASSWD issue, but
 there
   are
several good Perforce administrators on this list who can probably
 share
some advice for this.
 
As for the error during posting, this is likely due to not having
 p4.exe
installed in the path where the web server can see it. There's a bug
 open
for catching this during repository configuration so it's not so
   confusing.
We're planning to add that for 1.1. For now, though, just put p4.exe
 some
place where the web server can see it in the PATH and it should work.
 
Christian
 
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
 
On Mon, Sep 21, 2009 at 2:14 PM, Hui Lin hui@bankofamerica.com
   wrote:
 
 Yes, I solved this issue by putting what returned from p4 info
 exactly to the repository setup. My local p4 was using an alias of
 what from p4 info.
 
 Then, I bumped against another issue Perforce password (P4PASSWD)
 invalid or unset.. Fortunately, I got the answer from the web:
 
  http://www.mail-archive.com/reviewboard@googlegroups.com/msg00183.html
 
 It worked. However, I don't feel quite comfortable of this
 approach,
 as the ticket expires in 12 hours. Is there a better solution?
 
 Now, everything works until post-review tries to upload the diff,
 which would fail with the error:
 Uploading diff, size: 9777
 HTTP POSTing to
http://b002481234dc0/api/json/reviewrequests/7/diff/new/:
 {}
Error uploading diff: One or more fields had errors (105)
 {'fields': {'path': ['[Error 2] The system cannot find the
 file specified']}, 'stat': 'fail', 'err': {'msg': 'One or more
 fields
 had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
 
 I am using the diffutil from GnuWin32.
 
 On Sep 21, 2:50 pm, Christian Hammond chip...@chipx86.com wrote:
  Yeah, it's a pain. I really do want to improve our repository
   comparison
  code. Right now we use a direct look-up for efficiency reasons,
 but
   if we
  cached the results and allowed each repository backend to do its
 own
  comparison, we could remove some of these complications.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San
   Diego)
 
 
  dana.laco...@hp.com wrote:
Yeah, this one got me.
 
   Particularly because what I set for my $P4PORT was NOT what
 the
 server
   returned in `p4 info` (I used an IP address because I've had
 DNS
   issues
 in
   the past, but the server returned its hostname.)
 
   J
 
   Dana Lacoste
 
   *From:* reviewboard@googlegroups.com [mailto:
 reviewbo...@googlegroups.com]
   *On Behalf Of *Christian Hammond
   *Sent:* Monday, September 21, 2009 12:31 PM
   *To:* reviewboard@googlegroups.com
   *Subject:* Re: post-review login issue
 
   Make sure that the repository Path field matches *exactly* what
 you
   see
   when running 'p4 info'. We do a literal string comparison.
 
   Christian
 
   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.review-board.org
   VMware, Inc. -http://www.vmware.com
 
On Mon, Sep 21, 2009 at 10:55 AM, Hui Lin 
   hui

Re: post-review login issue

2009-09-22 Thread Christian Hammond
 
  On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San
   Diego)
 
 
  dana.laco...@hp.com wrote:
Yeah, this one got me.
 
   Particularly because what I set for my $P4PORT was NOT what
 the
 server
   returned in `p4 info` (I used an IP address because I've had
 DNS
   issues
 in
   the past, but the server returned its hostname.)
 
   J
 
   Dana Lacoste
 
   *From:* reviewboard@googlegroups.com [mailto:
 reviewbo...@googlegroups.com]
   *On Behalf Of *Christian Hammond
   *Sent:* Monday, September 21, 2009 12:31 PM
   *To:* reviewboard@googlegroups.com
   *Subject:* Re: post-review login issue
 
   Make sure that the repository Path field matches *exactly* what
 you
   see
   when running 'p4 info'. We do a literal string comparison.
 
   Christian
 
   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.review-board.org
   VMware, Inc. -http://www.vmware.com
 
On Mon, Sep 21, 2009 at 10:55 AM, Hui Lin 
   hui@bankofamerica.com
   wrote:
 
   Thanks Christian. I resolved the issue by install the 1.0.3
 version
   and re-create the site.
 
   Now post-review is able to logon the reviewer board server, but
   gets
   problem of understanding the repository_path of the SCM
   (Perforce):
   Attempting to create review request for 388600
   HTTP POSTing
 tohttp://b002481234dc0/api/json/reviewrequests/new/:
   {'repository_path': 'chigfxldwb32:1667', 'changenum': '388600'}
  Error creating review request: The repository path specified
 is
   not in the list of known repositories (code 206)
 
   chigfxldwb32:1667 is the Perforce port, which I have no
 trouble
   to
   connect to it through either the p4 command or the P4V GUI
 client.
 
   What else should be in the repository path for Perforce other
   than
   the port information? Is there a way to find out what
 Perforce
   command has been executed by the reviewer board server?
 
   On Sep 20, 10:41 pm, Christian Hammond chip...@chipx86.com
   wrote:
Depends. You may just have logging turned off. Go in the
 Administration
   UI
- Settings - Logging and make sure it's enabled and being
 store
   in
 a
directory writable by the web server.
 
Christian
 
--
 
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
 
On Sun, Sep 20, 2009 at 5:57 PM, Hui Lin 
   hui@bankofamerica.com
   wrote:
 
 The apache server was installed to just host the review
 board
 server,
 so I doubt there is another vhost serviced by it. I noticed
   that
 the
 logs directory of review board is empty. Is that strange?
 
 On Sep 20, 7:23 pm, Christian Hammond chip...@chipx86.com
 
   wrote:
  Okay, so Review Board itself is correct. However,
 post-review
   is
   somehow
 not
  accessing the same server. This may be a configuration
 error
   on
 the
   web
  server. How many other virtual hosts is that server
 serving?
   It
 may
   be
 worth
  checking the log files of the other vhosts to find out
 which
   site
 is
  actually serving that. I suspect it's not the Review
 Board
   one.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Sun, Sep 20, 2009 at 5:18 PM, Hui Lin 
 hui@bankofamerica.com
 wrote:
 
   http://b00237d4f5dc7/reviews/vtm/; redirect me to the
 dashboard.
   Going to 
  http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/;
   in the browser returns an empty page.
 
   On Sep 20, 6:17 pm, Christian Hammond 
 chip...@chipx86.com
 
 wrote:
It sounds like the server isn't configured at that
 URL
 correctly,
   or
post-review is hitting the wrong IP address/server.
 
   Doeshttp://b00237d4f5dc7/reviews/vtm/redirectyoutothedashboard
 or
 
 login
page in your browser? What happens when going
 
 tohttp://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/inthe
 browser?
 
Christian
 
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
 
On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin 
   hui@bankofamerica.com
   wrote:
 
 I was trying to create a post review request with
 the
 command
   on
 Windows:
post-review 388600
 
 388600 is the changelist # of perforce.
 
 The script was able

Re: post-review login issue

2009-09-21 Thread Christian Hammond
Yeah, it's a pain. I really do want to improve our repository comparison
code. Right now we use a direct look-up for efficiency reasons, but if we
cached the results and allowed each repository backend to do its own
comparison, we could remove some of these complications.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San Diego) 
dana.laco...@hp.com wrote:

  Yeah, this one got me.



 Particularly because what I set for my $P4PORT was NOT what the server
 returned in `p4 info` (I used an IP address because I've had DNS issues in
 the past, but the server returned its hostname.)



 J



 Dana Lacoste



 *From:* reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com]
 *On Behalf Of *Christian Hammond
 *Sent:* Monday, September 21, 2009 12:31 PM
 *To:* reviewboard@googlegroups.com
 *Subject:* Re: post-review login issue



 Make sure that the repository Path field matches *exactly* what you see
 when running 'p4 info'. We do a literal string comparison.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com

  On Mon, Sep 21, 2009 at 10:55 AM, Hui Lin hui@bankofamerica.com
 wrote:


 Thanks Christian. I resolved the issue by install the 1.0.3 version
 and re-create the site.

 Now post-review is able to logon the reviewer board server, but gets
 problem of understanding the repository_path of the SCM (Perforce):
 Attempting to create review request for 388600
 HTTP POSTing to http://b002481234dc0/api/json/reviewrequests/new/:
 {'repository_path': 'chigfxldwb32:1667', 'changenum': '388600'}
Error creating review request: The repository path specified is
 not in the list of known repositories (code 206)

 chigfxldwb32:1667 is the Perforce port, which I have no trouble to
 connect to it through either the p4 command or the P4V GUI client.

 What else should be in the repository path for Perforce other than
 the port information? Is there a way to find out what Perforce
 command has been executed by the reviewer board server?




 On Sep 20, 10:41 pm, Christian Hammond chip...@chipx86.com wrote:
  Depends. You may just have logging turned off. Go in the Administration
 UI
  - Settings - Logging and make sure it's enabled and being store in a
  directory writable by the web server.
 
  Christian
 
  --

  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 

  On Sun, Sep 20, 2009 at 5:57 PM, Hui Lin hui@bankofamerica.com
 wrote:
 
   The apache server was installed to just host the review board server,
   so I doubt there is another vhost serviced by it. I noticed that the
   logs directory of review board is empty. Is that strange?
 
   On Sep 20, 7:23 pm, Christian Hammond chip...@chipx86.com wrote:
Okay, so Review Board itself is correct. However, post-review is
 somehow
   not
accessing the same server. This may be a configuration error on the
 web
server. How many other virtual hosts is that server serving? It may
 be
   worth
checking the log files of the other vhosts to find out which site is
actually serving that. I suspect it's not the Review Board one.
 
Christian
 
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
 
On Sun, Sep 20, 2009 at 5:18 PM, Hui Lin hui@bankofamerica.com
   wrote:
 
 http://b00237d4f5dc7/reviews/vtm/; redirect me to the dashboard.
 Going to 
 http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/;
 in the browser returns an empty page.
 
 On Sep 20, 6:17 pm, Christian Hammond chip...@chipx86.com wrote:
  It sounds like the server isn't configured at that URL correctly,
 or
  post-review is hitting the wrong IP address/server.

 Doeshttp://b00237d4f5dc7/reviews/vtm/redirectyouto the dashboard or

   login
  page in your browser? What happens when going
 tohttp://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/inthe
   browser?
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin 
 hui@bankofamerica.com
 wrote:
 
   I was trying to create a post review request with the command
 on
   Windows:
  post-review 388600
 
   388600 is the changelist # of perforce.
 
   The script was able generate the diff but failed on logon the
   review
   board server, its url is:
  http://b00237d4f5dc7/reviews/vtm/
 
   The error message showing was:
  Unable to access
  http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/.
   The host path may be invalid
  HTTP Error 404

Re: post-review login issue

2009-09-21 Thread Hui Lin

Yes, I solved this issue by putting what returned from p4 info
exactly to the repository setup. My local p4 was using an alias of
what from p4 info.

Then, I bumped against another issue Perforce password (P4PASSWD)
invalid or unset.. Fortunately, I got the answer from the web:
http://www.mail-archive.com/reviewboard@googlegroups.com/msg00183.html

It worked. However, I don't feel quite comfortable of this approach,
as the ticket expires in 12 hours. Is there a better solution?

Now, everything works until post-review tries to upload the diff,
which would fail with the error:
 Uploading diff, size: 9777
 HTTP POSTing to 
http://b002481234dc0/api/json/reviewrequests/7/diff/new/:
{}
Error uploading diff: One or more fields had errors (105)
 {'fields': {'path': ['[Error 2] The system cannot find the
file specified']}, 'stat': 'fail', 'err': {'msg': 'One or more fields
had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.

I am using the diffutil from GnuWin32.

On Sep 21, 2:50 pm, Christian Hammond chip...@chipx86.com wrote:
 Yeah, it's a pain. I really do want to improve our repository comparison
 code. Right now we use a direct look-up for efficiency reasons, but if we
 cached the results and allowed each repository backend to do its own
 comparison, we could remove some of these complications.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San Diego) 

 dana.laco...@hp.com wrote:
   Yeah, this one got me.

  Particularly because what I set for my $P4PORT was NOT what the server
  returned in `p4 info` (I used an IP address because I've had DNS issues in
  the past, but the server returned its hostname.)

  J

  Dana Lacoste

  *From:* reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com]
  *On Behalf Of *Christian Hammond
  *Sent:* Monday, September 21, 2009 12:31 PM
  *To:* reviewboard@googlegroups.com
  *Subject:* Re: post-review login issue

  Make sure that the repository Path field matches *exactly* what you see
  when running 'p4 info'. We do a literal string comparison.

  Christian

  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com

   On Mon, Sep 21, 2009 at 10:55 AM, Hui Lin hui@bankofamerica.com
  wrote:

  Thanks Christian. I resolved the issue by install the 1.0.3 version
  and re-create the site.

  Now post-review is able to logon the reviewer board server, but gets
  problem of understanding the repository_path of the SCM (Perforce):
      Attempting to create review request for 388600
      HTTP POSTing tohttp://b002481234dc0/api/json/reviewrequests/new/:
  {'repository_path': 'chigfxldwb32:1667', 'changenum': '388600'}
     Error creating review request: The repository path specified is
  not in the list of known repositories (code 206)

  chigfxldwb32:1667 is the Perforce port, which I have no trouble to
  connect to it through either the p4 command or the P4V GUI client.

  What else should be in the repository path for Perforce other than
  the port information? Is there a way to find out what Perforce
  command has been executed by the reviewer board server?

  On Sep 20, 10:41 pm, Christian Hammond chip...@chipx86.com wrote:
   Depends. You may just have logging turned off. Go in the Administration
  UI
   - Settings - Logging and make sure it's enabled and being store in a
   directory writable by the web server.

   Christian

   --

   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.review-board.org
   VMware, Inc. -http://www.vmware.com

   On Sun, Sep 20, 2009 at 5:57 PM, Hui Lin hui@bankofamerica.com
  wrote:

The apache server was installed to just host the review board server,
so I doubt there is another vhost serviced by it. I noticed that the
logs directory of review board is empty. Is that strange?

On Sep 20, 7:23 pm, Christian Hammond chip...@chipx86.com wrote:
 Okay, so Review Board itself is correct. However, post-review is
  somehow
not
 accessing the same server. This may be a configuration error on the
  web
 server. How many other virtual hosts is that server serving? It may
  be
worth
 checking the log files of the other vhosts to find out which site is
 actually serving that. I suspect it's not the Review Board one.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Sun, Sep 20, 2009 at 5:18 PM, Hui Lin hui@bankofamerica.com
wrote:

  http://b00237d4f5dc7/reviews/vtm/; redirect me to the dashboard.
  Going to 
 http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/;
  in the browser returns an empty page.

  On Sep 20, 6:17 pm, Christian Hammond

Re: post-review login issue

2009-09-21 Thread Christian Hammond
Hi,

I don't personally have a good answer to the P4PASSWD issue, but there are
several good Perforce administrators on this list who can probably share
some advice for this.

As for the error during posting, this is likely due to not having p4.exe
installed in the path where the web server can see it. There's a bug open
for catching this during repository configuration so it's not so confusing.
We're planning to add that for 1.1. For now, though, just put p4.exe some
place where the web server can see it in the PATH and it should work.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Sep 21, 2009 at 2:14 PM, Hui Lin hui@bankofamerica.com wrote:


 Yes, I solved this issue by putting what returned from p4 info
 exactly to the repository setup. My local p4 was using an alias of
 what from p4 info.

 Then, I bumped against another issue Perforce password (P4PASSWD)
 invalid or unset.. Fortunately, I got the answer from the web:
http://www.mail-archive.com/reviewboard@googlegroups.com/msg00183.html

 It worked. However, I don't feel quite comfortable of this approach,
 as the ticket expires in 12 hours. Is there a better solution?

 Now, everything works until post-review tries to upload the diff,
 which would fail with the error:
 Uploading diff, size: 9777
 HTTP POSTing to
 http://b002481234dc0/api/json/reviewrequests/7/diff/new/:
 {}
Error uploading diff: One or more fields had errors (105)
 {'fields': {'path': ['[Error 2] The system cannot find the
 file specified']}, 'stat': 'fail', 'err': {'msg': 'One or more fields
 had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.

 I am using the diffutil from GnuWin32.

 On Sep 21, 2:50 pm, Christian Hammond chip...@chipx86.com wrote:
  Yeah, it's a pain. I really do want to improve our repository comparison
  code. Right now we use a direct look-up for efficiency reasons, but if we
  cached the results and allowed each repository backend to do its own
  comparison, we could remove some of these complications.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San Diego)
 
 
  dana.laco...@hp.com wrote:
Yeah, this one got me.
 
   Particularly because what I set for my $P4PORT was NOT what the
 server
   returned in `p4 info` (I used an IP address because I've had DNS issues
 in
   the past, but the server returned its hostname.)
 
   J
 
   Dana Lacoste
 
   *From:* reviewboard@googlegroups.com [mailto:
 reviewbo...@googlegroups.com]
   *On Behalf Of *Christian Hammond
   *Sent:* Monday, September 21, 2009 12:31 PM
   *To:* reviewboard@googlegroups.com
   *Subject:* Re: post-review login issue
 
   Make sure that the repository Path field matches *exactly* what you see
   when running 'p4 info'. We do a literal string comparison.
 
   Christian
 
   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.review-board.org
   VMware, Inc. -http://www.vmware.com
 
On Mon, Sep 21, 2009 at 10:55 AM, Hui Lin hui@bankofamerica.com
   wrote:
 
   Thanks Christian. I resolved the issue by install the 1.0.3 version
   and re-create the site.
 
   Now post-review is able to logon the reviewer board server, but gets
   problem of understanding the repository_path of the SCM (Perforce):
   Attempting to create review request for 388600
   HTTP POSTing
 tohttp://b002481234dc0/api/json/reviewrequests/new/:
   {'repository_path': 'chigfxldwb32:1667', 'changenum': '388600'}
  Error creating review request: The repository path specified is
   not in the list of known repositories (code 206)
 
   chigfxldwb32:1667 is the Perforce port, which I have no trouble to
   connect to it through either the p4 command or the P4V GUI client.
 
   What else should be in the repository path for Perforce other than
   the port information? Is there a way to find out what Perforce
   command has been executed by the reviewer board server?
 
   On Sep 20, 10:41 pm, Christian Hammond chip...@chipx86.com wrote:
Depends. You may just have logging turned off. Go in the
 Administration
   UI
- Settings - Logging and make sure it's enabled and being store in
 a
directory writable by the web server.
 
Christian
 
--
 
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
 
On Sun, Sep 20, 2009 at 5:57 PM, Hui Lin hui@bankofamerica.com
   wrote:
 
 The apache server was installed to just host the review board
 server,
 so I doubt there is another vhost serviced by it. I noticed that
 the
 logs directory of review board is empty. Is that strange?
 
 On Sep 20, 7:23 pm, Christian Hammond chip...@chipx86.com wrote:
  Okay, so

Re: post-review login issue

2009-09-21 Thread Hui Lin

I believe uploading the diff is just a reviewer board function, which
doesn't seem to have anything to do with to p4.

On Sep 21, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
 Hi,

 I don't personally have a good answer to the P4PASSWD issue, but there are
 several good Perforce administrators on this list who can probably share
 some advice for this.

 As for the error during posting, this is likely due to not having p4.exe
 installed in the path where the web server can see it. There's a bug open
 for catching this during repository configuration so it's not so confusing.
 We're planning to add that for 1.1. For now, though, just put p4.exe some
 place where the web server can see it in the PATH and it should work.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com



 On Mon, Sep 21, 2009 at 2:14 PM, Hui Lin hui@bankofamerica.com wrote:

  Yes, I solved this issue by putting what returned from p4 info
  exactly to the repository setup. My local p4 was using an alias of
  what from p4 info.

  Then, I bumped against another issue Perforce password (P4PASSWD)
  invalid or unset.. Fortunately, I got the answer from the web:
     http://www.mail-archive.com/reviewboard@googlegroups.com/msg00183.html

  It worked. However, I don't feel quite comfortable of this approach,
  as the ticket expires in 12 hours. Is there a better solution?

  Now, everything works until post-review tries to upload the diff,
  which would fail with the error:
      Uploading diff, size: 9777
      HTTP POSTing to
 http://b002481234dc0/api/json/reviewrequests/7/diff/new/:
  {}
     Error uploading diff: One or more fields had errors (105)
      {'fields': {'path': ['[Error 2] The system cannot find the
  file specified']}, 'stat': 'fail', 'err': {'msg': 'One or more fields
  had errors', 'code': 105}}
     Your review request still exists, but the diff is not attached.

  I am using the diffutil from GnuWin32.

  On Sep 21, 2:50 pm, Christian Hammond chip...@chipx86.com wrote:
   Yeah, it's a pain. I really do want to improve our repository comparison
   code. Right now we use a direct look-up for efficiency reasons, but if we
   cached the results and allowed each repository backend to do its own
   comparison, we could remove some of these complications.

   Christian

   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.review-board.org
   VMware, Inc. -http://www.vmware.com

   On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San Diego)
  

   dana.laco...@hp.com wrote:
 Yeah, this one got me.

Particularly because what I set for my $P4PORT was NOT what the
  server
returned in `p4 info` (I used an IP address because I've had DNS issues
  in
the past, but the server returned its hostname.)

J

Dana Lacoste

*From:* reviewboard@googlegroups.com [mailto:
  reviewbo...@googlegroups.com]
*On Behalf Of *Christian Hammond
*Sent:* Monday, September 21, 2009 12:31 PM
*To:* reviewboard@googlegroups.com
*Subject:* Re: post-review login issue

Make sure that the repository Path field matches *exactly* what you see
when running 'p4 info'. We do a literal string comparison.

Christian

--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com

 On Mon, Sep 21, 2009 at 10:55 AM, Hui Lin hui@bankofamerica.com
wrote:

Thanks Christian. I resolved the issue by install the 1.0.3 version
and re-create the site.

Now post-review is able to logon the reviewer board server, but gets
problem of understanding the repository_path of the SCM (Perforce):
    Attempting to create review request for 388600
    HTTP POSTing
  tohttp://b002481234dc0/api/json/reviewrequests/new/:
{'repository_path': 'chigfxldwb32:1667', 'changenum': '388600'}
   Error creating review request: The repository path specified is
not in the list of known repositories (code 206)

chigfxldwb32:1667 is the Perforce port, which I have no trouble to
connect to it through either the p4 command or the P4V GUI client.

What else should be in the repository path for Perforce other than
the port information? Is there a way to find out what Perforce
command has been executed by the reviewer board server?

On Sep 20, 10:41 pm, Christian Hammond chip...@chipx86.com wrote:
 Depends. You may just have logging turned off. Go in the
  Administration
UI
 - Settings - Logging and make sure it's enabled and being store in
  a
 directory writable by the web server.

 Christian

 --

 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Sun, Sep 20, 2009 at 5:57 PM, Hui Lin hui@bankofamerica.com
wrote:

  The apache server was installed

Re: post-review login issue

2009-09-21 Thread Christian Hammond
We verify the files server-side on upload, and this requires pulling them
from the repository. Due to some bug with p4python or something (I don't
remember the exact cause) we directly call p4 to fetch the file. We then use
p4 later on to fetch the files for side-by-side display in the diff viewer.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Sep 21, 2009 at 8:55 PM, Hui Lin hui@bankofamerica.com wrote:


 I believe uploading the diff is just a reviewer board function, which
 doesn't seem to have anything to do with to p4.

 On Sep 21, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
  Hi,
 
  I don't personally have a good answer to the P4PASSWD issue, but there
 are
  several good Perforce administrators on this list who can probably share
  some advice for this.
 
  As for the error during posting, this is likely due to not having p4.exe
  installed in the path where the web server can see it. There's a bug open
  for catching this during repository configuration so it's not so
 confusing.
  We're planning to add that for 1.1. For now, though, just put p4.exe some
  place where the web server can see it in the PATH and it should work.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
 
 
  On Mon, Sep 21, 2009 at 2:14 PM, Hui Lin hui@bankofamerica.com
 wrote:
 
   Yes, I solved this issue by putting what returned from p4 info
   exactly to the repository setup. My local p4 was using an alias of
   what from p4 info.
 
   Then, I bumped against another issue Perforce password (P4PASSWD)
   invalid or unset.. Fortunately, I got the answer from the web:
  
 http://www.mail-archive.com/reviewboard@googlegroups.com/msg00183.html
 
   It worked. However, I don't feel quite comfortable of this approach,
   as the ticket expires in 12 hours. Is there a better solution?
 
   Now, everything works until post-review tries to upload the diff,
   which would fail with the error:
   Uploading diff, size: 9777
   HTTP POSTing to
  http://b002481234dc0/api/json/reviewrequests/7/diff/new/:
   {}
  Error uploading diff: One or more fields had errors (105)
   {'fields': {'path': ['[Error 2] The system cannot find the
   file specified']}, 'stat': 'fail', 'err': {'msg': 'One or more fields
   had errors', 'code': 105}}
  Your review request still exists, but the diff is not attached.
 
   I am using the diffutil from GnuWin32.
 
   On Sep 21, 2:50 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, it's a pain. I really do want to improve our repository
 comparison
code. Right now we use a direct look-up for efficiency reasons, but
 if we
cached the results and allowed each repository backend to do its own
comparison, we could remove some of these complications.
 
Christian
 
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
 
On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San
 Diego)
   
 
dana.laco...@hp.com wrote:
  Yeah, this one got me.
 
 Particularly because what I set for my $P4PORT was NOT what the
   server
 returned in `p4 info` (I used an IP address because I've had DNS
 issues
   in
 the past, but the server returned its hostname.)
 
 J
 
 Dana Lacoste
 
 *From:* reviewboard@googlegroups.com [mailto:
   reviewbo...@googlegroups.com]
 *On Behalf Of *Christian Hammond
 *Sent:* Monday, September 21, 2009 12:31 PM
 *To:* reviewboard@googlegroups.com
 *Subject:* Re: post-review login issue
 
 Make sure that the repository Path field matches *exactly* what you
 see
 when running 'p4 info'. We do a literal string comparison.
 
 Christian
 
 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com
 
  On Mon, Sep 21, 2009 at 10:55 AM, Hui Lin 
 hui@bankofamerica.com
 wrote:
 
 Thanks Christian. I resolved the issue by install the 1.0.3 version
 and re-create the site.
 
 Now post-review is able to logon the reviewer board server, but
 gets
 problem of understanding the repository_path of the SCM
 (Perforce):
 Attempting to create review request for 388600
 HTTP POSTing
   tohttp://b002481234dc0/api/json/reviewrequests/new/:
 {'repository_path': 'chigfxldwb32:1667', 'changenum': '388600'}
Error creating review request: The repository path specified is
 not in the list of known repositories (code 206)
 
 chigfxldwb32:1667 is the Perforce port, which I have no trouble
 to
 connect to it through either the p4 command or the P4V GUI client.
 
 What else should be in the repository path for Perforce other
 than
 the port information? Is there a way

Re: post-review login issue

2009-09-20 Thread Christian Hammond
It sounds like the server isn't configured at that URL correctly, or
post-review is hitting the wrong IP address/server. Does
http://b00237d4f5dc7/reviews/vtm/ redirect you to the dashboard or login
page in your browser? What happens when going to
http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/ in the browser?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin hui@bankofamerica.com wrote:


 I was trying to create a post review request with the command on
 Windows:
post-review 388600

 388600 is the changelist # of perforce.

 The script was able generate the diff but failed on logon the review
 board server, its url is:
http://b00237d4f5dc7/reviews/vtm/

 The error message showing was:
Unable to access
 http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/.
 The host path may be invalid
HTTP Error 404: Not Found

 I tried to enter the username / password at the prompts, as well as
 putting them into parameters --username and --password, but
 neither way worked. I have no trouble logon with the same account on
 the web page.

 What could be wrong?

 Thanks for the help in advance.

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: post-review login issue

2009-09-20 Thread Hui Lin

http://b00237d4f5dc7/reviews/vtm/; redirect me to the dashboard.
Going to http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/;
in the browser returns an empty page.


On Sep 20, 6:17 pm, Christian Hammond chip...@chipx86.com wrote:
 It sounds like the server isn't configured at that URL correctly, or
 post-review is hitting the wrong IP address/server. 
 Doeshttp://b00237d4f5dc7/reviews/vtm/redirect you to the dashboard or login
 page in your browser? What happens when going 
 tohttp://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/in the browser?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin hui@bankofamerica.com wrote:

  I was trying to create a post review request with the command on
  Windows:
     post-review 388600

  388600 is the changelist # of perforce.

  The script was able generate the diff but failed on logon the review
  board server, its url is:
     http://b00237d4f5dc7/reviews/vtm/

  The error message showing was:
     Unable to access
 http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/.
  The host path may be invalid
     HTTP Error 404: Not Found

  I tried to enter the username / password at the prompts, as well as
  putting them into parameters --username and --password, but
  neither way worked. I have no trouble logon with the same account on
  the web page.

  What could be wrong?

  Thanks for the help in advance.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: post-review login issue

2009-09-20 Thread Christian Hammond
Okay, so Review Board itself is correct. However, post-review is somehow not
accessing the same server. This may be a configuration error on the web
server. How many other virtual hosts is that server serving? It may be worth
checking the log files of the other vhosts to find out which site is
actually serving that. I suspect it's not the Review Board one.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Sun, Sep 20, 2009 at 5:18 PM, Hui Lin hui@bankofamerica.com wrote:


 http://b00237d4f5dc7/reviews/vtm/; redirect me to the dashboard.
 Going to http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/;
 in the browser returns an empty page.


 On Sep 20, 6:17 pm, Christian Hammond chip...@chipx86.com wrote:
  It sounds like the server isn't configured at that URL correctly, or
  post-review is hitting the wrong IP address/server.
 Doeshttp://b00237d4f5dc7/reviews/vtm/redirect you to the dashboard or login
  page in your browser? What happens when going
 tohttp://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/in the browser?
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin hui@bankofamerica.com
 wrote:
 
   I was trying to create a post review request with the command on
   Windows:
  post-review 388600
 
   388600 is the changelist # of perforce.
 
   The script was able generate the diff but failed on logon the review
   board server, its url is:
  http://b00237d4f5dc7/reviews/vtm/
 
   The error message showing was:
  Unable to access
  http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/.
   The host path may be invalid
  HTTP Error 404: Not Found
 
   I tried to enter the username / password at the prompts, as well as
   putting them into parameters --username and --password, but
   neither way worked. I have no trouble logon with the same account on
   the web page.
 
   What could be wrong?
 
   Thanks for the help in advance.

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: post-review login issue

2009-09-20 Thread Hui Lin

Is there a debug flag on the review board server which can be turned
on to trace what is happening?


On Sep 20, 7:18 pm, Hui Lin hui@bankofamerica.com wrote:
 http://b00237d4f5dc7/reviews/vtm/; redirect me to the dashboard.
 Going to http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/;
 in the browser returns an empty page.

 On Sep 20, 6:17 pm, Christian Hammond chip...@chipx86.com wrote:

  It sounds like the server isn't configured at that URL correctly, or
  post-review is hitting the wrong IP address/server. 
  Doeshttp://b00237d4f5dc7/reviews/vtm/redirectyou to the dashboard or login
  page in your browser? What happens when going 
  tohttp://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/inthe browser?

  Christian

  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com

  On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin hui@bankofamerica.com wrote:

   I was trying to create a post review request with the command on
   Windows:
      post-review 388600

   388600 is the changelist # of perforce.

   The script was able generate the diff but failed on logon the review
   board server, its url is:
      http://b00237d4f5dc7/reviews/vtm/

   The error message showing was:
      Unable to access
  http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/.
   The host path may be invalid
      HTTP Error 404: Not Found

   I tried to enter the username / password at the prompts, as well as
   putting them into parameters --username and --password, but
   neither way worked. I have no trouble logon with the same account on
   the web page.

   What could be wrong?

   Thanks for the help in advance.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: post-review login issue

2009-09-20 Thread Hui Lin

The apache server was installed to just host the review board server,
so I doubt there is another vhost serviced by it. I noticed that the
logs directory of review board is empty. Is that strange?

On Sep 20, 7:23 pm, Christian Hammond chip...@chipx86.com wrote:
 Okay, so Review Board itself is correct. However, post-review is somehow not
 accessing the same server. This may be a configuration error on the web
 server. How many other virtual hosts is that server serving? It may be worth
 checking the log files of the other vhosts to find out which site is
 actually serving that. I suspect it's not the Review Board one.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Sun, Sep 20, 2009 at 5:18 PM, Hui Lin hui@bankofamerica.com wrote:

  http://b00237d4f5dc7/reviews/vtm/; redirect me to the dashboard.
  Going to http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/;
  in the browser returns an empty page.

  On Sep 20, 6:17 pm, Christian Hammond chip...@chipx86.com wrote:
   It sounds like the server isn't configured at that URL correctly, or
   post-review is hitting the wrong IP address/server.
  Doeshttp://b00237d4f5dc7/reviews/vtm/redirectyou to the dashboard or login
   page in your browser? What happens when going
  tohttp://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/inthe browser?

   Christian

   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.review-board.org
   VMware, Inc. -http://www.vmware.com

   On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin hui@bankofamerica.com
  wrote:

I was trying to create a post review request with the command on
Windows:
   post-review 388600

388600 is the changelist # of perforce.

The script was able generate the diff but failed on logon the review
board server, its url is:
   http://b00237d4f5dc7/reviews/vtm/

The error message showing was:
   Unable to access
   http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/.
The host path may be invalid
   HTTP Error 404: Not Found

I tried to enter the username / password at the prompts, as well as
putting them into parameters --username and --password, but
neither way worked. I have no trouble logon with the same account on
the web page.

What could be wrong?

Thanks for the help in advance.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: post-review login issue

2009-09-20 Thread Christian Hammond
Depends. You may just have logging turned off. Go in the Administration UI
- Settings - Logging and make sure it's enabled and being store in a
directory writable by the web server.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Sun, Sep 20, 2009 at 5:57 PM, Hui Lin hui@bankofamerica.com wrote:


 The apache server was installed to just host the review board server,
 so I doubt there is another vhost serviced by it. I noticed that the
 logs directory of review board is empty. Is that strange?

 On Sep 20, 7:23 pm, Christian Hammond chip...@chipx86.com wrote:
  Okay, so Review Board itself is correct. However, post-review is somehow
 not
  accessing the same server. This may be a configuration error on the web
  server. How many other virtual hosts is that server serving? It may be
 worth
  checking the log files of the other vhosts to find out which site is
  actually serving that. I suspect it's not the Review Board one.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Sun, Sep 20, 2009 at 5:18 PM, Hui Lin hui@bankofamerica.com
 wrote:
 
   http://b00237d4f5dc7/reviews/vtm/; redirect me to the dashboard.
   Going to http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/;
   in the browser returns an empty page.
 
   On Sep 20, 6:17 pm, Christian Hammond chip...@chipx86.com wrote:
It sounds like the server isn't configured at that URL correctly, or
post-review is hitting the wrong IP address/server.
   Doeshttp://b00237d4f5dc7/reviews/vtm/redirectyou to the dashboard or
 login
page in your browser? What happens when going
   tohttp://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/inthe
 browser?
 
Christian
 
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
 
On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin hui@bankofamerica.com
   wrote:
 
 I was trying to create a post review request with the command on
 Windows:
post-review 388600
 
 388600 is the changelist # of perforce.
 
 The script was able generate the diff but failed on logon the
 review
 board server, its url is:
http://b00237d4f5dc7/reviews/vtm/
 
 The error message showing was:
Unable to access
http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/.
 The host path may be invalid
HTTP Error 404: Not Found
 
 I tried to enter the username / password at the prompts, as well as
 putting them into parameters --username and --password, but
 neither way worked. I have no trouble logon with the same account
 on
 the web page.
 
 What could be wrong?
 
 Thanks for the help in advance.
 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---