Re: post-review works from command line, fails from svn hook

2010-02-25 Thread Stodge
I'm using SVN version 1.6.9. On Feb 24, 9:51 pm, Christian Hammond chip...@chipx86.com wrote: Hmm, hard to say. I'm able to do that with svn v1.3.1. Which version are you using? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc.

Re: post-review works from command line, fails from svn hook

2010-02-25 Thread Stodge
Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', 'file:/// srv/svn/fred/@10', 'file:///srv/svn/fred/@11', '', '', ''] It's the three empty strings (last 3 params) that are causing problems. svn diff file:///srv/svn/fred/@10 file:///srv/svn/fred/@11 '' '' '' svn: Target lists to

Re: post-review works from command line, fails from svn hook

2010-02-25 Thread Stodge
This patch might help: --- ORIGINAL-svn-hook-postcommit-review 2010-02-25 08:50:07.0 -0500 +++ svn-hook-postcommit-review 2010-02-25 08:49:41.0 -0500 @@ -216,6 +216,9 @@ # common arguments args = [repository_url, username, password, publish, submitas,

Re: post-review works from command line, fails from svn hook

2010-02-25 Thread Stodge
This might be a better patch: --- ORIGINAL-svn-hook-postcommit-review 2010-02-25 08:50:07.0 -0500 +++ svn-hook-postcommit-review 2010-02-25 09:09:40.0 -0500 @@ -221,6 +221,9 @@ if len(reviewid) == 0: args += [summary, description, bugs] +# Filter out blank

Re: post-review works from command line, fails from svn hook

2010-02-24 Thread Christian Hammond
Hmm, hard to say. I'm able to do that with svn v1.3.1. Which version are you using? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 24, 2010 at 6:01 PM, Stodge sto...@gmail.com wrote: I'm trying