Re: rbtools (v0.7.2) exit code and Jenkins-CI?
seems like these guys are using the Python API to do something similar https://wiki.jenkins-ci.org/display/JENKINS/Jenkins-Reviewbot . On Friday, May 1, 2015 at 9:11:39 AM UTC+10, David Trowbridge wrote: > > We don't have any concrete plans but we do add things as good ideas come > up (time permitting). As I said, it would probably be pretty easy to > implement your own command to do exactly what you want by using rbt's > python API and reusing some of the code in the rbtools modules. > > -David > > On Thu, Apr 30, 2015 at 3:53 PM MoonWalker > wrote: > >> Any plans to expand the set of commands supported by rbt ?. Do you >> recommend a workaround to achieve something similar of what I need? >> >> >> On Friday, May 1, 2015 at 8:48:02 AM UTC+10, David Trowbridge wrote: >> >>> With the built-in commands, no. With the python API that's part of rbt, >>> yes. >>> >>> -David >>> >>> On Thu, Apr 30, 2015 at 3:40 PM MoonWalker >>> wrote: >>> Is it possible to post a comment to a given review by using rbt? On Friday, May 1, 2015 at 8:36:53 AM UTC+10, David Trowbridge wrote: > Given that you seem to have such a specialized need, you may want to > consider implementing your own rbt command using the Python API. > > -David > > On Thu, Apr 30, 2015 at 3:33 PM MoonWalker > wrote: > >> But the -u flag will update the existent review isn't it wont add a >> comment?, Also I need to get some sort of feedback from the rbt tool to >> find out if 1) new review 2) existent review 3) error >> >> >> On Friday, May 1, 2015 at 8:00:51 AM UTC+10, David Trowbridge wrote: >> >>> Perhaps the -u flag will do what you want? >>> >>> -David >>> >>> On Thu, Apr 30, 2015 at 2:58 PM MoonWalker >>> wrote: >>> >> I double check and seems like it does return 0 = OK 1 = fail. This will be enough for one scenario, but not sure how to implement something like this: 1) Post new review: * if this review has been posted already then rbt will return review #. * if any error happen then return error code. * if everything goes well then exit code = 0 2) If review exist then Post a comment using the review number. Basically I want to accomplish this in a single Jenkins job. Tyx for your help -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. >>> >>> For more options, visit https://groups.google.com/d/optout. >>> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google >> Groups "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, >> send an email to reviewboard...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >>> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBComm
Re: rbtools (v0.7.2) exit code and Jenkins-CI?
We don't have any concrete plans but we do add things as good ideas come up (time permitting). As I said, it would probably be pretty easy to implement your own command to do exactly what you want by using rbt's python API and reusing some of the code in the rbtools modules. -David On Thu, Apr 30, 2015 at 3:53 PM MoonWalker wrote: > Any plans to expand the set of commands supported by rbt ?. Do you > recommend a workaround to achieve something similar of what I need? > > > On Friday, May 1, 2015 at 8:48:02 AM UTC+10, David Trowbridge wrote: > >> With the built-in commands, no. With the python API that's part of rbt, >> yes. >> >> -David >> >> On Thu, Apr 30, 2015 at 3:40 PM MoonWalker wrote: >> >>> Is it possible to post a comment to a given review by using rbt? >>> >>> >>> On Friday, May 1, 2015 at 8:36:53 AM UTC+10, David Trowbridge wrote: >>> Given that you seem to have such a specialized need, you may want to consider implementing your own rbt command using the Python API. -David On Thu, Apr 30, 2015 at 3:33 PM MoonWalker wrote: > But the -u flag will update the existent review isn't it wont add a > comment?, Also I need to get some sort of feedback from the rbt tool to > find out if 1) new review 2) existent review 3) error > > > On Friday, May 1, 2015 at 8:00:51 AM UTC+10, David Trowbridge wrote: > >> Perhaps the -u flag will do what you want? >> >> -David >> >> On Thu, Apr 30, 2015 at 2:58 PM MoonWalker >> wrote: >> > I double check and seems like it does return 0 = OK 1 = fail. >>> >>> This will be enough for one scenario, but not sure how to implement >>> something like this: >>> >>> 1) Post new review: >>> * if this review has been posted already then rbt will return review >>> #. >>> * if any error happen then return error code. >>> * if everything goes well then exit code = 0 >>> >>> 2) If review exist then Post a comment using the review number. >>> >>> Basically I want to accomplish this in a single Jenkins job. >>> >>> Tyx for your help >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> >> To unsubscribe from this group and stop receiving emails from it, >>> send an email to reviewboard...@googlegroups.com. >> >> >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to reviewboard...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/opto
Re: rbtools (v0.7.2) exit code and Jenkins-CI?
Any plans to expand the set of commands supported by rbt ?. Do you recommend a workaround to achieve something similar of what I need? On Friday, May 1, 2015 at 8:48:02 AM UTC+10, David Trowbridge wrote: > > With the built-in commands, no. With the python API that's part of rbt, > yes. > > -David > > On Thu, Apr 30, 2015 at 3:40 PM MoonWalker > wrote: > >> Is it possible to post a comment to a given review by using rbt? >> >> >> On Friday, May 1, 2015 at 8:36:53 AM UTC+10, David Trowbridge wrote: >> >>> Given that you seem to have such a specialized need, you may want to >>> consider implementing your own rbt command using the Python API. >>> >>> -David >>> >>> On Thu, Apr 30, 2015 at 3:33 PM MoonWalker >>> wrote: >>> But the -u flag will update the existent review isn't it wont add a comment?, Also I need to get some sort of feedback from the rbt tool to find out if 1) new review 2) existent review 3) error On Friday, May 1, 2015 at 8:00:51 AM UTC+10, David Trowbridge wrote: > Perhaps the -u flag will do what you want? > > -David > > On Thu, Apr 30, 2015 at 2:58 PM MoonWalker > wrote: > I double check and seems like it does return 0 = OK 1 = fail. >> >> This will be enough for one scenario, but not sure how to implement >> something like this: >> >> 1) Post new review: >> * if this review has been posted already then rbt will return review >> #. >> * if any error happen then return error code. >> * if everything goes well then exit code = 0 >> >> 2) If review exist then Post a comment using the review number. >> >> Basically I want to accomplish this in a single Jenkins job. >> >> Tyx for your help >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google >> Groups "reviewboard" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an email to reviewboard...@googlegroups.com. > > >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >>> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rbtools (v0.7.2) exit code and Jenkins-CI?
With the built-in commands, no. With the python API that's part of rbt, yes. -David On Thu, Apr 30, 2015 at 3:40 PM MoonWalker wrote: > Is it possible to post a comment to a given review by using rbt? > > > On Friday, May 1, 2015 at 8:36:53 AM UTC+10, David Trowbridge wrote: > >> Given that you seem to have such a specialized need, you may want to >> consider implementing your own rbt command using the Python API. >> >> -David >> >> On Thu, Apr 30, 2015 at 3:33 PM MoonWalker wrote: >> >>> But the -u flag will update the existent review isn't it wont add a >>> comment?, Also I need to get some sort of feedback from the rbt tool to >>> find out if 1) new review 2) existent review 3) error >>> >>> >>> On Friday, May 1, 2015 at 8:00:51 AM UTC+10, David Trowbridge wrote: >>> Perhaps the -u flag will do what you want? -David On Thu, Apr 30, 2015 at 2:58 PM MoonWalker wrote: >>> I double check and seems like it does return 0 = OK 1 = fail. > > This will be enough for one scenario, but not sure how to implement > something like this: > > 1) Post new review: > * if this review has been posted already then rbt will return review #. > * if any error happen then return error code. > * if everything goes well then exit code = 0 > > 2) If review exist then Post a comment using the review number. > > Basically I want to accomplish this in a single Jenkins job. > > Tyx for your help > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to reviewboard...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rbtools (v0.7.2) exit code and Jenkins-CI?
Is it possible to post a comment to a given review by using rbt? On Friday, May 1, 2015 at 8:36:53 AM UTC+10, David Trowbridge wrote: > > Given that you seem to have such a specialized need, you may want to > consider implementing your own rbt command using the Python API. > > -David > > On Thu, Apr 30, 2015 at 3:33 PM MoonWalker > wrote: > >> But the -u flag will update the existent review isn't it wont add a >> comment?, Also I need to get some sort of feedback from the rbt tool to >> find out if 1) new review 2) existent review 3) error >> >> >> On Friday, May 1, 2015 at 8:00:51 AM UTC+10, David Trowbridge wrote: >> >>> Perhaps the -u flag will do what you want? >>> >>> -David >>> >>> On Thu, Apr 30, 2015 at 2:58 PM MoonWalker >>> wrote: >>> >> I double check and seems like it does return 0 = OK 1 = fail. This will be enough for one scenario, but not sure how to implement something like this: 1) Post new review: * if this review has been posted already then rbt will return review #. * if any error happen then return error code. * if everything goes well then exit code = 0 2) If review exist then Post a comment using the review number. Basically I want to accomplish this in a single Jenkins job. Tyx for your help -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. >>> >>> For more options, visit https://groups.google.com/d/optout. >>> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rbtools (v0.7.2) exit code and Jenkins-CI?
Given that you seem to have such a specialized need, you may want to consider implementing your own rbt command using the Python API. -David On Thu, Apr 30, 2015 at 3:33 PM MoonWalker wrote: > But the -u flag will update the existent review isn't it wont add a > comment?, Also I need to get some sort of feedback from the rbt tool to > find out if 1) new review 2) existent review 3) error > > > On Friday, May 1, 2015 at 8:00:51 AM UTC+10, David Trowbridge wrote: > >> Perhaps the -u flag will do what you want? >> >> -David >> >> On Thu, Apr 30, 2015 at 2:58 PM MoonWalker wrote: >> > I double check and seems like it does return 0 = OK 1 = fail. >>> >>> This will be enough for one scenario, but not sure how to implement >>> something like this: >>> >>> 1) Post new review: >>> * if this review has been posted already then rbt will return review #. >>> * if any error happen then return error code. >>> * if everything goes well then exit code = 0 >>> >>> 2) If review exist then Post a comment using the review number. >>> >>> Basically I want to accomplish this in a single Jenkins job. >>> >>> Tyx for your help >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> >> To unsubscribe from this group and stop receiving emails from it, send an >>> email to reviewboard...@googlegroups.com. >> >> >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rbtools (v0.7.2) exit code and Jenkins-CI?
But the -u flag will update the existent review isn't it wont add a comment?, Also I need to get some sort of feedback from the rbt tool to find out if 1) new review 2) existent review 3) error On Friday, May 1, 2015 at 8:00:51 AM UTC+10, David Trowbridge wrote: > > Perhaps the -u flag will do what you want? > > -David > > On Thu, Apr 30, 2015 at 2:58 PM MoonWalker > wrote: > >> I double check and seems like it does return 0 = OK 1 = fail. >> >> This will be enough for one scenario, but not sure how to implement >> something like this: >> >> 1) Post new review: >> * if this review has been posted already then rbt will return review #. >> * if any error happen then return error code. >> * if everything goes well then exit code = 0 >> >> 2) If review exist then Post a comment using the review number. >> >> Basically I want to accomplish this in a single Jenkins job. >> >> Tyx for your help >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rbtools (v0.7.2) exit code and Jenkins-CI?
Perhaps the -u flag will do what you want? -David On Thu, Apr 30, 2015 at 2:58 PM MoonWalker wrote: > I double check and seems like it does return 0 = OK 1 = fail. > > This will be enough for one scenario, but not sure how to implement > something like this: > > 1) Post new review: > * if this review has been posted already then rbt will return review #. > * if any error happen then return error code. > * if everything goes well then exit code = 0 > > 2) If review exist then Post a comment using the review number. > > Basically I want to accomplish this in a single Jenkins job. > > Tyx for your help > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
