Do you expect your reviewers to read through 34k lines and actually make useful 
comments? Good reviews cover 100-200 lines per hour, so that's a 170-340 hour 
job for someone, or approximately 4-8 weeks of a full-time employee.




Diffs > 1MB pretty much always contain autogenerated code, which IME isn't 
useful to include in your code reviews.




That said, if you insist, the max diff size is configurable in the settings 
(assuming a sufficiently recent version).




-David

-David

On Mon, Nov 11, 2013 at 3:20 AM, Varun Jain <varun.iam.j...@gmail.com>
wrote:

> Hi Team,
> I am trying to post the review for single .thpl file (34k lines) with diff 
> size more than 1MB, I am getting the error saying
> Review Board's max diff size limit is 1 MB.
> Is there any way to get out of this problem?
> Thanks,
> Varun
> -- 
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to