Re: updating another user's request?

[Christian Hammond]

Assuming you're an admin, you should be able to update the review request,
but honestly, updating diffs for another user's review request isn't a
workflow we recommend or test.

What I'd recommend is to create a new review request to replace that one,
and discard the old one with a link to the new.

Christian


On Monday, November 4, 2013, Matthew Woehlke wrote:

 We recently had an employee move on, leaving behind an active review
 request. It needs changes, so I am trying to upload a new diff. However,
 despite giving myself many permissions, it doesn't seem to be working. I
 have an option to upload a new diff for the request, but nothing happens;
 I'm not seeing any errors, but I'm also not getting a new draft.

 Has anyone dealt with this situation before? Is there a trick to making a
 new revision of a review request that is owned by a different user?

 --
 Matthew

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.



-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: updating another user's request?

[Matthew Woehlke]

On 2013-11-04 14:26, Christian Hammond wrote:

Assuming you're an admin, you should be able to update the review request,
but honestly, updating diffs for another user's review request isn't a
workflow we recommend or test.


Okay. FWIW, I'm going to claim it doesn't work :-). (I did end up trying 
as admin also, with the same results... the interface accepts the diff 
but fails to create a draft of the new diff. I didn't see anything in 
the server logs either.)


What I ended up doing is temporarily changing the review owner to myself 
so that I could manipulate it as the owner.


(Then I had an adventure not reloading the DB page, accidentally nuking 
the review changes as a result, and then trying to figure out what 
happened :-). I did fix it eventually...)


Relatedly, this is actually one issue (of very few) we've run into where 
gerrit is better than RB. It's actually not unusual for us to deal with 
co-authored branches that are initially uploaded by one author but 
subsequently modified by a different/additional author, where it is 
desired for the other author(s) to be able to post new diffs to the 
request. It would be nice if RB could support this more readily.



What I'd recommend is to create a new review request to replace that one,
and discard the old one with a link to the new.


I was trying to avoid this as it would lose the history associated 
with the existing review request.


--
Matthew

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups reviewboard group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.