Re:Re: Re: Re: About Error occured when print view diff on User WebUI of ReviewBoard

2009-12-17 Thread qhlonline
Hi,Christian, 
I am not familiar with patch , But when I use patch -v command, It gives info 
like follows:

patch 2.5.4
Copyright 1984-1988 Larry Wall
Copyright 1989-1999 Free Software Foundation, Inc.
..
-

Is it what you asked path version infomation?

Best Regards!
在2009-12-17,Christian Hammond chip...@chipx86.com 写道:
That's on the client, not the server, right?

What version of patch is on the server?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Wed, Dec 16, 2009 at 7:43 PM, qhlonline qhlonl...@163.com wrote:


I am using the TortoiseCVS as CVS client, I am not sure what kind of diff it 
support, But my diff command is using as cvs diff -uN  Can you please 
recommand me some GNU-diff-supported CVS client run on Windows OS? Thanks.

Best Regards!


在2009-12-17,Christian Hammond chip...@chipx86.com 写道:

What version of diff is on the Windows install? It must specifically use GNU 
diff, and not some other diff tool.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Wed, Dec 16, 2009 at 7:27 PM, qhlonline qhlonl...@163.com wrote:

Hi, Christian,
  Now that is the different diff file contents of the same file change:
On Windows:
WWW
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:43:08
@@ -2,6 +2,7 @@
 #include stdlib.h
 int main()
 {
+printf(Begin, Begin!);
 print(Hello World!);
 if(a==5)
 {
@@ -11,4 +12,5 @@
 {
 printf(Hi,sir!);
 }
+printf(Hello, Sir!);
 }

And on Linux:
L
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:50:30
@@ -2,6 +2,7 @@
 #include stdlib.h
 int main()
 {
+printf(Begin, Begin!);
 print(Hello World!);
 if(a==5)
 {
@@ -11,4 +12,5 @@
 {
 printf(Hi,sir!);
 }
-}
\ No newline at end of file
+printf(Hello, Sir!);
+}
LL
There is no much difference. But the linux diff file ends with a warning:  \ 
No newline at end of file and the end Brace} has been viewed as a change: + 
and -; This kind of format diff file works well, The Reviewer can open the 
view diff correctly. But the windows diff file format, which gave no warning 
and view the last brace as unchanged, with this format, The Reviewers clicking 
view diff will report error as in the first message of this topic I have 
pointed. And infect I have never add any new-line to the end of the source code 
file:  neither the original file, nore the chenged files in both Operating 
System.
   And If I had manualy add a blank new line in the changed file in Windows 
local source code file, I will get the same diff file content as that of linux 
said above, And that may slove this problem. But I don't know why. and How to  
fundamentally solve the problem? 

Best Regards!
 


在2009-12-16,Christian Hammond chip...@chipx86.com 写道:

I don't really know what you mean, but I know that many companies using Review 
Board have clients on Linux, Windows and Mac who post to a Review Board server 
on Linux without any problems. I'd have to see some diffs and original source 
files where this fails to have an idea as to what's going wrong.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Tue, Dec 15, 2009 at 7:55 PM, JohnHenry qhlonl...@163.com wrote:
I have viewed the diff file of both Windows and Linux, It seems that
not only they have difference between there NewLine character, There
are some file format difference but I am not sure, Can any one give a
description of there difference?

Best Regards!


On Dec 15, 4:09 pm, JohnHenry qhlonl...@163.com wrote:
 OK, The first problem is that I have Created new ReviewRequest in
 WindowsOS through Web UI while the RB Server is on Linux. When I use
 post-review in linux to create new ReviewRequest , That will be fine.
 But I had not test the windowsOS post-review generated new
 ReviewRequest now.
 But the second problem, How to make Review to the review request
 generated with newly source code( that is the source code has never
 been commited to CVS ) is waiting for suggestion.

 Best Regards!

 On 12月15日, 下午3时36分, JohnHenry qhlonl...@163.com wrote:



  Hi,
 I have tried to post a review request and publish it using one
  User, 

Re:Re: Re: Re: About Error occured when print view diff on User WebUI of ReviewBoard

2009-12-17 Thread qhlonline
Hi, I have tested many cases of post-review, The error report(as follows ) 
happens only when The source file is edited in Windows, Initially commited in 
Windows and and The code Changement is made on windows, This case, When I use 
post-review to commit a reviewrequest, The Reviewer's view diff click will 
cause error :
..

File 
/data1/Johnl/bin/develop_tools/python/python2.5/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/diffutils.py,
 line 129, in patch
(filename, tempdir, patch_output))
Exception: The patch to 'WindowsFile.c' didn't apply cleanly. The temporary 
files have been left in '/tmp/reviewboard.coK02X' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.coK02X/tmpmllp2I
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file 
/tmp/reviewboard.coK02X/tmpmllp2I-new.rej

---
In this case, the diff file format expected is that with /No newline at the 
end of file ,But Windows diff file is in the format without warning like that. 
Can I make some change to RB source file to let it deal the Windows Generated 
diff file like that generated by linux? and Where can I do That (In which 
source file) ?

BestRegards!





在2009-12-17,Christian Hammond chip...@chipx86.com 写道:
That's on the client, not the server, right?

What version of patch is on the server?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Wed, Dec 16, 2009 at 7:43 PM, qhlonline qhlonl...@163.com wrote:


I am using the TortoiseCVS as CVS client, I am not sure what kind of diff it 
support, But my diff command is using as cvs diff -uN  Can you please 
recommand me some GNU-diff-supported CVS client run on Windows OS? Thanks.

Best Regards!


在2009-12-17,Christian Hammond chip...@chipx86.com 写道:

What version of diff is on the Windows install? It must specifically use GNU 
diff, and not some other diff tool.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Wed, Dec 16, 2009 at 7:27 PM, qhlonline qhlonl...@163.com wrote:

Hi, Christian,
  Now that is the different diff file contents of the same file change:
On Windows:
WWW
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:43:08
@@ -2,6 +2,7 @@
 #include stdlib.h
 int main()
 {
+printf(Begin, Begin!);
 print(Hello World!);
 if(a==5)
 {
@@ -11,4 +12,5 @@
 {
 printf(Hi,sir!);
 }
+printf(Hello, Sir!);
 }

And on Linux:
L
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:50:30
@@ -2,6 +2,7 @@
 #include stdlib.h
 int main()
 {
+printf(Begin, Begin!);
 print(Hello World!);
 if(a==5)
 {
@@ -11,4 +12,5 @@
 {
 printf(Hi,sir!);
 }
-}
\ No newline at end of file
+printf(Hello, Sir!);
+}
LL
There is no much difference. But the linux diff file ends with a warning:  \ 
No newline at end of file and the end Brace} has been viewed as a change: + 
and -; This kind of format diff file works well, The Reviewer can open the 
view diff correctly. But the windows diff file format, which gave no warning 
and view the last brace as unchanged, with this format, The Reviewers clicking 
view diff will report error as in the first message of this topic I have 
pointed. And infect I have never add any new-line to the end of the source code 
file:  neither the original file, nore the chenged files in both Operating 
System.
   And If I had manualy add a blank new line in the changed file in Windows 
local source code file, I will get the same diff file content as that of linux 
said above, And that may slove this problem. But I don't know why. and How to  
fundamentally solve the problem? 

Best Regards!
 


在2009-12-16,Christian Hammond chip...@chipx86.com 写道:

I don't really know what you mean, but I know that many companies using Review 
Board have clients on Linux, Windows and Mac who post to a Review Board server 
on Linux without any problems. I'd have to see some diffs and original source 
files where this fails to have an idea as to what's going wrong.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Tue, Dec 15, 2009 at 7:55 PM, JohnHenry qhlonl...@163.com 

Re:Re: Re: Re: About Error occured when print view diff on User WebUI of ReviewBoard

2009-12-17 Thread qhlonline
Hi, Christian,
   I have a problem of ReviewBoard source change. If  I have made some change 
on RB source, And I want see the result the my self added print info . How to 
get them? The ReviewBoard execution is runing with no UI on the server end, So 
I want some help about this.


Best Regards!
在2009-12-17,Christian Hammond chip...@chipx86.com 写道:
That's on the client, not the server, right?

What version of patch is on the server?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Wed, Dec 16, 2009 at 7:43 PM, qhlonline qhlonl...@163.com wrote:


I am using the TortoiseCVS as CVS client, I am not sure what kind of diff it 
support, But my diff command is using as cvs diff -uN  Can you please 
recommand me some GNU-diff-supported CVS client run on Windows OS? Thanks.

Best Regards!


在2009-12-17,Christian Hammond chip...@chipx86.com 写道:

What version of diff is on the Windows install? It must specifically use GNU 
diff, and not some other diff tool.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Wed, Dec 16, 2009 at 7:27 PM, qhlonline qhlonl...@163.com wrote:

Hi, Christian,
  Now that is the different diff file contents of the same file change:
On Windows:
WWW
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:43:08
@@ -2,6 +2,7 @@
 #include stdlib.h
 int main()
 {
+printf(Begin, Begin!);
 print(Hello World!);
 if(a==5)
 {
@@ -11,4 +12,5 @@
 {
 printf(Hi,sir!);
 }
+printf(Hello, Sir!);
 }

And on Linux:
L
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:50:30
@@ -2,6 +2,7 @@
 #include stdlib.h
 int main()
 {
+printf(Begin, Begin!);
 print(Hello World!);
 if(a==5)
 {
@@ -11,4 +12,5 @@
 {
 printf(Hi,sir!);
 }
-}
\ No newline at end of file
+printf(Hello, Sir!);
+}
LL
There is no much difference. But the linux diff file ends with a warning:  \ 
No newline at end of file and the end Brace} has been viewed as a change: + 
and -; This kind of format diff file works well, The Reviewer can open the 
view diff correctly. But the windows diff file format, which gave no warning 
and view the last brace as unchanged, with this format, The Reviewers clicking 
view diff will report error as in the first message of this topic I have 
pointed. And infect I have never add any new-line to the end of the source code 
file:  neither the original file, nore the chenged files in both Operating 
System.
   And If I had manualy add a blank new line in the changed file in Windows 
local source code file, I will get the same diff file content as that of linux 
said above, And that may slove this problem. But I don't know why. and How to  
fundamentally solve the problem? 

Best Regards!
 


在2009-12-16,Christian Hammond chip...@chipx86.com 写道:

I don't really know what you mean, but I know that many companies using Review 
Board have clients on Linux, Windows and Mac who post to a Review Board server 
on Linux without any problems. I'd have to see some diffs and original source 
files where this fails to have an idea as to what's going wrong.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Tue, Dec 15, 2009 at 7:55 PM, JohnHenry qhlonl...@163.com wrote:
I have viewed the diff file of both Windows and Linux, It seems that
not only they have difference between there NewLine character, There
are some file format difference but I am not sure, Can any one give a
description of there difference?

Best Regards!


On Dec 15, 4:09 pm, JohnHenry qhlonl...@163.com wrote:
 OK, The first problem is that I have Created new ReviewRequest in
 WindowsOS through Web UI while the RB Server is on Linux. When I use
 post-review in linux to create new ReviewRequest , That will be fine.
 But I had not test the windowsOS post-review generated new
 ReviewRequest now.
 But the second problem, How to make Review to the review request
 generated with newly source code( that is the source code has never
 been commited to CVS ) is waiting for suggestion.

 Best Regards!

 On 12月15日, 下午3时36分, JohnHenry qhlonl...@163.com wrote:



  Hi,
 I have tried to post a review request and publish it using one
  User, But in the Reviewers' UI, 

Re:Re: Re: Re: About Error occured when print view diff on User WebUI of ReviewBoard

2009-12-17 Thread qhlonline
Hello, Christian,
   I had changed some code on reviewboard, Then I restart the Apache server 
.And when I run the Reviewboard UI,  It said:
---
Review Board is taking a nap
There are several possible reasons:
We're updating it. 
You're trying to look at a really huge diff without collapsing, and it timed 
out (try viewing another diff and going back to collapsed changes; we're 
working on fixing this). 
Our lazy good-for-nothing oompa-loompas stopped pedalling. 
It'll be back soon.
---
Is that means my change has some python systax error? How to debug then? Need 
your suggestion.
Best Regards!



在2009-12-17,Christian Hammond chip...@chipx86.com 写道:
That's on the client, not the server, right?

What version of patch is on the server?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Wed, Dec 16, 2009 at 7:43 PM, qhlonline qhlonl...@163.com wrote:


I am using the TortoiseCVS as CVS client, I am not sure what kind of diff it 
support, But my diff command is using as cvs diff -uN  Can you please 
recommand me some GNU-diff-supported CVS client run on Windows OS? Thanks.

Best Regards!


在2009-12-17,Christian Hammond chip...@chipx86.com 写道:

What version of diff is on the Windows install? It must specifically use GNU 
diff, and not some other diff tool.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Wed, Dec 16, 2009 at 7:27 PM, qhlonline qhlonl...@163.com wrote:

Hi, Christian,
  Now that is the different diff file contents of the same file change:
On Windows:
WWW
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:43:08
@@ -2,6 +2,7 @@
 #include stdlib.h
 int main()
 {
+printf(Begin, Begin!);
 print(Hello World!);
 if(a==5)
 {
@@ -11,4 +12,5 @@
 {
 printf(Hi,sir!);
 }
+printf(Hello, Sir!);
 }

And on Linux:
L
Index: abc.c
===
RCS file: /export/home/cvsroot/test/abc.c,v
retrieving revision 1.1
diff -u -r1.1 abc.c
--- abc.c2009/12/17 02:37:241.1
+++ abc.c2009/12/17 02:50:30
@@ -2,6 +2,7 @@
 #include stdlib.h
 int main()
 {
+printf(Begin, Begin!);
 print(Hello World!);
 if(a==5)
 {
@@ -11,4 +12,5 @@
 {
 printf(Hi,sir!);
 }
-}
\ No newline at end of file
+printf(Hello, Sir!);
+}
LL
There is no much difference. But the linux diff file ends with a warning:  \ 
No newline at end of file and the end Brace} has been viewed as a change: + 
and -; This kind of format diff file works well, The Reviewer can open the 
view diff correctly. But the windows diff file format, which gave no warning 
and view the last brace as unchanged, with this format, The Reviewers clicking 
view diff will report error as in the first message of this topic I have 
pointed. And infect I have never add any new-line to the end of the source code 
file:  neither the original file, nore the chenged files in both Operating 
System.
   And If I had manualy add a blank new line in the changed file in Windows 
local source code file, I will get the same diff file content as that of linux 
said above, And that may slove this problem. But I don't know why. and How to  
fundamentally solve the problem? 

Best Regards!
 


在2009-12-16,Christian Hammond chip...@chipx86.com 写道:

I don't really know what you mean, but I know that many companies using Review 
Board have clients on Linux, Windows and Mac who post to a Review Board server 
on Linux without any problems. I'd have to see some diffs and original source 
files where this fails to have an idea as to what's going wrong.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Tue, Dec 15, 2009 at 7:55 PM, JohnHenry qhlonl...@163.com wrote:
I have viewed the diff file of both Windows and Linux, It seems that
not only they have difference between there NewLine character, There
are some file format difference but I am not sure, Can any one give a
description of there difference?

Best Regards!


On Dec 15, 4:09 pm, JohnHenry qhlonl...@163.com wrote:
 OK, The first problem is that I have Created new ReviewRequest in
 WindowsOS through Web UI while the RB Server is on Linux. When I use
 post-review in linux to create new ReviewRequest , That will be fine.
 But I had not test the windowsOS post-review generated new
 ReviewRequest