Re: RevewBoard 1.5.2 + RBTools-0.3.2-py2.6 + Perforce + Pre-commit Review - '500 Error' when CLN changed after p4 submit
Hi Christian, Thank you for helping. Here are the reproduce procedures of the error we encountered: 1. Run post-review on a chagnelist (e.g. chagnelist = 703920), Review Request URL = http://mydonain.com/reviews/r/100 2. Review the code on ReviewBoard portal (http://mydonain.com/reviews/r/100), e.g. add comments/ship-it..etc. 3. Submit the chagnelist on P4; after submission the chagnelist became 797978 (i.e. 703920 was obsoleted, gone forever on P4 server) 4. Go to http://mydonain.com/reviews/r/100; again on ReviewBoard Portal and the review request cannot be browsed; error showed as below: Something broke! (Error 500) It seems like RB server somehow checks the chagnelist with P4 server each time a review request is browsed (i.e. P4Exception on RB server log said chagnelist not found). After going to RB Portal's 'admin' page and changed the chagnelist of that particular request from 703920 (old) to 797978 (new); the review request could be browsed again. Thank you very much for helping. -polo On Mon, Jun 27, 2011 at 4:52 PM, Christian Hammond chip...@chipx86.comwrote: Hi, So I'm trying to figure out your scenario a bit more clearly. Maybe some background on how we use change numbers will help answer your question. The change number listed on a review request is there for your information only, for the most part. The only time we make use of it is during creation or updating when explicitly told by post-review to update based on a change number. It will query the server using that and update the description, testing done, etc. It won't attempt to use that changenum otherwise. So I can see the error you're seeing if you follow this repro case: 1) Run post-review on a changenum 2) Commit that change 3) Re-run post-review with the original changenum Is that sort of what's happening? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Jun 21, 2011 at 5:15 AM, fogy fogyw...@gmail.com wrote: Hi everyone, We have RevewBoard 1.5.2 working with Perforce. On client side we use RBTools-0.3.2-py2.6 to do pre-commit review. We can post review request and all comments/updates on RB portal works just fineuntil the changelist was submitted to P4. The problem is that when we submit the changelist to p4 the changelist number altered at P4 (e.g. from 703920 to 797978); that means the original changelist number listed on the review request of ReviewBoard (e.g. 703920) was no longer exist on P4 server. We then have problem viewing the review request - Something broke! (Error 500) was showed when we tried to browse the review request link. After searching on server log we found below exception: - P4Exception: [P4#run] Warnings during command execution( p4 describe - s 703920 ) [Warning]: 703920 - no such changelist - This wasn't happening before we updated the version from 1.0.5.1 to 1.5.2 and add our LDAP to RB server. Did anyone have similar problem before? Thanks in advance. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RevewBoard 1.5.2 + RBTools-0.3.2-py2.6 + Perforce + Pre-commit Review - '500 Error' when CLN changed after p4 submit
Hi, So I'm trying to figure out your scenario a bit more clearly. Maybe some background on how we use change numbers will help answer your question. The change number listed on a review request is there for your information only, for the most part. The only time we make use of it is during creation or updating when explicitly told by post-review to update based on a change number. It will query the server using that and update the description, testing done, etc. It won't attempt to use that changenum otherwise. So I can see the error you're seeing if you follow this repro case: 1) Run post-review on a changenum 2) Commit that change 3) Re-run post-review with the original changenum Is that sort of what's happening? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Jun 21, 2011 at 5:15 AM, fogy fogyw...@gmail.com wrote: Hi everyone, We have RevewBoard 1.5.2 working with Perforce. On client side we use RBTools-0.3.2-py2.6 to do pre-commit review. We can post review request and all comments/updates on RB portal works just fineuntil the changelist was submitted to P4. The problem is that when we submit the changelist to p4 the changelist number altered at P4 (e.g. from 703920 to 797978); that means the original changelist number listed on the review request of ReviewBoard (e.g. 703920) was no longer exist on P4 server. We then have problem viewing the review request - Something broke! (Error 500) was showed when we tried to browse the review request link. After searching on server log we found below exception: - P4Exception: [P4#run] Warnings during command execution( p4 describe - s 703920 ) [Warning]: 703920 - no such changelist - This wasn't happening before we updated the version from 1.0.5.1 to 1.5.2 and add our LDAP to RB server. Did anyone have similar problem before? Thanks in advance. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RevewBoard 1.5.2 + RBTools-0.3.2-py2.6 + Perforce + Pre-commit Review - '500 Error' when CLN changed after p4 submit
Hi folks, Is there any setting in ReviewBoard to 'treat WARNING as ERROR'? I'd like to try to turn it off if there is a such setting because the server log was indeed 'WARNING' instead of 'ERROR' so i guess RB can tolerate P4 changelist alteration? Thanks, -fogy- On 6月21日, 下午8時15分, fogy fogyw...@gmail.com wrote: Hi everyone, We have RevewBoard 1.5.2 working with Perforce. On client side we use RBTools-0.3.2-py2.6 to do pre-commit review. We can post review request and all comments/updates on RB portal works just fineuntil the changelist was submitted to P4. The problem is that when we submit the changelist to p4 the changelist number altered at P4 (e.g. from 703920 to 797978); that means the original changelist number listed on the review request of ReviewBoard (e.g. 703920) was no longer exist on P4 server. We then have problem viewing the review request - Something broke! (Error 500) was showed when we tried to browse the review request link. After searching on server log we found below exception: - P4Exception: [P4#run] Warnings during command execution( p4 describe - s 703920 ) [Warning]: 703920 - no such changelist - This wasn't happening before we updated the version from 1.0.5.1 to 1.5.2 and add our LDAP to RB server. Did anyone have similar problem before? Thanks in advance. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RevewBoard 1.5.2 + RBTools-0.3.2-py2.6 + Perforce + Pre-commit Review - '500 Error' when CLN changed after p4 submit
Hi everyone, We have RevewBoard 1.5.2 working with Perforce. On client side we use RBTools-0.3.2-py2.6 to do pre-commit review. We can post review request and all comments/updates on RB portal works just fineuntil the changelist was submitted to P4. The problem is that when we submit the changelist to p4 the changelist number altered at P4 (e.g. from 703920 to 797978); that means the original changelist number listed on the review request of ReviewBoard (e.g. 703920) was no longer exist on P4 server. We then have problem viewing the review request - Something broke! (Error 500) was showed when we tried to browse the review request link. After searching on server log we found below exception: - P4Exception: [P4#run] Warnings during command execution( p4 describe - s 703920 ) [Warning]: 703920 - no such changelist - This wasn't happening before we updated the version from 1.0.5.1 to 1.5.2 and add our LDAP to RB server. Did anyone have similar problem before? Thanks in advance. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
