Re: Reviewboard 1.6.5 problem

2012-05-21 Thread Christian Hammond
Hi Florian, After the review, I assume you made some changes that were either left in the index or committed to another commit, right? You must make sure that the diff is going to cover changes made since an upstream revision (such as origin/master..HEAD), rather than just what's in the index or i

Reviewboard 1.6.5 problem

2012-05-21 Thread Florian Leibert
Hi, I created a diff (the current revision and some previous version), uploaded the diff while creating a new review request. Then, I committed my revision locally. Later after a review, i went ahead and updated the diff via the web ui, i.e. locally i did a git diff --full- index > foo.diff. Upload