Re: Trophy causing problems
Any review request which is a number followed by zeroes (100, 2000,
3) gets a trophy.
Any palindrome gets a fish trophy.
-David
On Mon, Jan 19, 2009 at 4:23 PM, Martin wrote:
>
> Hi Christian,
>
> thanks so much!
> I'll update our server first thing in the morning.
>
> How else do you get a trophy?
> That was so neat to see that the st ID got a trophy :)
>
> Thanks,
> Martin
>
> On Jan 16, 5:43 pm, Christian Hammond wrote:
>> Hi Martin.
>>
>> There's a patch up to fix this, which I'm going to commit today. If someone
>> can upgrade the server today or tomorrow, once it goes in, then this problem
>> will be taken care of. Sorry about the inconvenience :(
>>
>> Christian
>>
>> --
>> Christian Hammond - chip...@chipx86.com
>> VMware, Inc.
>>
>> On Fri, Jan 16, 2009 at 5:56 AM, Martin wrote:
>>
>> > Hi,
>> > a colleague of mine recently created the st code review request
>> > which gave him a nice looking trophy! Really neat easter egg. I just
>> > updated my reviewboard to svn trunk and that trophy seems to cause
>> > some trouble now. We no longer can view that reviewrequest.
>>
>> > Please help :)
>>
>> > Environment:
>>
>> > Request Method: GET
>> > Request URL:http://codereview.ykf.navtech.corp/reviewboard/r//
>> > Django Version: 1.0.2 final
>> > Python Version: 2.4.3
>> > Installed Applications:
>> > ['django.contrib.admin',
>> > 'django.contrib.auth',
>> > 'django.contrib.contenttypes',
>> > 'django.contrib.markup',
>> > 'django.contrib.sites',
>> > 'django.contrib.sessions',
>> > 'djblets.datagrid',
>> > 'djblets.feedview',
>> > 'djblets.siteconfig',
>> > 'djblets.util',
>> > 'djblets.webapi',
>> > 'reviewboard.accounts',
>> > 'reviewboard.admin',
>> > 'reviewboard.changedescs',
>> > 'reviewboard.diffviewer',
>> > 'reviewboard.iphone',
>> > 'reviewboard.reports',
>> > 'reviewboard.reviews',
>> > 'reviewboard.scmtools',
>> > 'reviewboard.webapi',
>> > 'django_evolution']
>> > Installed Middleware:
>> > ('django.middleware.common.CommonMiddleware',
>> > 'django.middleware.doc.XViewMiddleware',
>> > 'django.middleware.locale.LocaleMiddleware',
>> > 'django.contrib.sessions.middleware.SessionMiddleware',
>> > 'django.contrib.auth.middleware.AuthenticationMiddleware',
>> > 'djblets.siteconfig.middleware.SettingsMiddleware',
>> > 'reviewboard.admin.middleware.LoadSettingsMiddleware',
>> > 'djblets.log.middleware.LoggingMiddleware',
>> > 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
>>
>> > Template error:
>> > In template /var/www/reviewboard/templates/reviews/trophy_box.html,
>> > error at line 9
>> > Caught an exception while rendering: u'review_request.id'
>> > 1 : {% load djblets_deco %}
>>
>> > 2 : {% load djblets_utils %}
>>
>> > 3 : {% load i18n %}
>>
>> > 4 : {% load reviewtags %}
>>
>> > 5 :
>>
>> > 6 : {% ifneatnumber review_request.id %}
>>
>> > 7 : {% box "yay" %}
>>
>> > 8 : > > alt="" />
>>
>> > 9 : {% blocktrans with review_request.submitter|
>> > user_displayname as submitter %} {{submitter}} got review request #
>> > {{review_request.id}}!{% endblocktrans %}
>>
>> > 10 : {% endbox %}
>>
>> > 11 : {% endifneatnumber %}
>>
>> > 12 :
>>
>> > 13 :
>>
>> > Traceback:
>> > File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py"
>> > in get_response
>> > 86. response = callback(request, *callback_args,
>> > **callback_kwargs)
>> > File "/var/www/reviewboard/accounts/decorators.py" in _check
>> > 27. return view_func(*args, **kwargs)
>> > File "/usr/lib/python2.4/site-packages/django/views/decorators/
>> > cache.py" in _cache_controlled
>> > 30. response = viewfunc(request, *args, **kw)
>> > File "/var/www/reviewboard/reviews/views.py" in review_detail
>> > 175. return render_to_response(template_name, RequestContext
>> > (request, {
>> > File "/usr/lib/python2.4/site-packages/django/shortcuts/__init__.py"
>> > in render_to_response
>> > 18. return HttpResponse(loader.render_to_string(*args,
>> > **kwargs), **httpresponse_kwargs)
>> > File "/usr/lib/python2.4/site-packages/django/template/loader.py" in
>> > render_to_string
>> > 107. return t.render(context_instance)
>> > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
>> > render
>> > 176. return self.nodelist.render(context)
>> > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
>> > render
>> > 768. bits.append(self.render_node(node, context))
>> > File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
>> > render_node
>> > 71. result = node.render(context)
>> > File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py"
>> > in render
>> > 97. return compiled_parent.render(context)
>> > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
>> > render
>> > 176. return self.nodelist.render(context)
>> > File "/usr/lib/python2.4/site-pack
Re: Trophy causing problems
Hi Christian,
thanks so much!
I'll update our server first thing in the morning.
How else do you get a trophy?
That was so neat to see that the st ID got a trophy :)
Thanks,
Martin
On Jan 16, 5:43 pm, Christian Hammond wrote:
> Hi Martin.
>
> There's a patch up to fix this, which I'm going to commit today. If someone
> can upgrade the server today or tomorrow, once it goes in, then this problem
> will be taken care of. Sorry about the inconvenience :(
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> VMware, Inc.
>
> On Fri, Jan 16, 2009 at 5:56 AM, Martin wrote:
>
> > Hi,
> > a colleague of mine recently created the st code review request
> > which gave him a nice looking trophy! Really neat easter egg. I just
> > updated my reviewboard to svn trunk and that trophy seems to cause
> > some trouble now. We no longer can view that reviewrequest.
>
> > Please help :)
>
> > Environment:
>
> > Request Method: GET
> > Request URL:http://codereview.ykf.navtech.corp/reviewboard/r//
> > Django Version: 1.0.2 final
> > Python Version: 2.4.3
> > Installed Applications:
> > ['django.contrib.admin',
> > 'django.contrib.auth',
> > 'django.contrib.contenttypes',
> > 'django.contrib.markup',
> > 'django.contrib.sites',
> > 'django.contrib.sessions',
> > 'djblets.datagrid',
> > 'djblets.feedview',
> > 'djblets.siteconfig',
> > 'djblets.util',
> > 'djblets.webapi',
> > 'reviewboard.accounts',
> > 'reviewboard.admin',
> > 'reviewboard.changedescs',
> > 'reviewboard.diffviewer',
> > 'reviewboard.iphone',
> > 'reviewboard.reports',
> > 'reviewboard.reviews',
> > 'reviewboard.scmtools',
> > 'reviewboard.webapi',
> > 'django_evolution']
> > Installed Middleware:
> > ('django.middleware.common.CommonMiddleware',
> > 'django.middleware.doc.XViewMiddleware',
> > 'django.middleware.locale.LocaleMiddleware',
> > 'django.contrib.sessions.middleware.SessionMiddleware',
> > 'django.contrib.auth.middleware.AuthenticationMiddleware',
> > 'djblets.siteconfig.middleware.SettingsMiddleware',
> > 'reviewboard.admin.middleware.LoadSettingsMiddleware',
> > 'djblets.log.middleware.LoggingMiddleware',
> > 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
>
> > Template error:
> > In template /var/www/reviewboard/templates/reviews/trophy_box.html,
> > error at line 9
> > Caught an exception while rendering: u'review_request.id'
> > 1 : {% load djblets_deco %}
>
> > 2 : {% load djblets_utils %}
>
> > 3 : {% load i18n %}
>
> > 4 : {% load reviewtags %}
>
> > 5 :
>
> > 6 : {% ifneatnumber review_request.id %}
>
> > 7 : {% box "yay" %}
>
> > 8 : > alt="" />
>
> > 9 : {% blocktrans with review_request.submitter|
> > user_displayname as submitter %} {{submitter}} got review request #
> > {{review_request.id}}!{% endblocktrans %}
>
> > 10 : {% endbox %}
>
> > 11 : {% endifneatnumber %}
>
> > 12 :
>
> > 13 :
>
> > Traceback:
> > File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py"
> > in get_response
> > 86. response = callback(request, *callback_args,
> > **callback_kwargs)
> > File "/var/www/reviewboard/accounts/decorators.py" in _check
> > 27. return view_func(*args, **kwargs)
> > File "/usr/lib/python2.4/site-packages/django/views/decorators/
> > cache.py" in _cache_controlled
> > 30. response = viewfunc(request, *args, **kw)
> > File "/var/www/reviewboard/reviews/views.py" in review_detail
> > 175. return render_to_response(template_name, RequestContext
> > (request, {
> > File "/usr/lib/python2.4/site-packages/django/shortcuts/__init__.py"
> > in render_to_response
> > 18. return HttpResponse(loader.render_to_string(*args,
> > **kwargs), **httpresponse_kwargs)
> > File "/usr/lib/python2.4/site-packages/django/template/loader.py" in
> > render_to_string
> > 107. return t.render(context_instance)
> > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
> > render
> > 176. return self.nodelist.render(context)
> > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
> > render
> > 768. bits.append(self.render_node(node, context))
> > File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
> > render_node
> > 71. result = node.render(context)
> > File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py"
> > in render
> > 97. return compiled_parent.render(context)
> > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
> > render
> > 176. return self.nodelist.render(context)
> > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
> > render
> > 768. bits.append(self.render_node(node, context))
> > File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
> > render_node
> > 71. result = node.render(context)
> > File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py"
>
Re: Trophy causing problems
Hi Martin.
There's a patch up to fix this, which I'm going to commit today. If someone
can upgrade the server today or tomorrow, once it goes in, then this problem
will be taken care of. Sorry about the inconvenience :(
Christian
--
Christian Hammond - chip...@chipx86.com
VMware, Inc.
On Fri, Jan 16, 2009 at 5:56 AM, Martin wrote:
>
> Hi,
> a colleague of mine recently created the st code review request
> which gave him a nice looking trophy! Really neat easter egg. I just
> updated my reviewboard to svn trunk and that trophy seems to cause
> some trouble now. We no longer can view that reviewrequest.
>
> Please help :)
>
>
> Environment:
>
> Request Method: GET
> Request URL: http://codereview.ykf.navtech.corp/reviewboard/r//
> Django Version: 1.0.2 final
> Python Version: 2.4.3
> Installed Applications:
> ['django.contrib.admin',
> 'django.contrib.auth',
> 'django.contrib.contenttypes',
> 'django.contrib.markup',
> 'django.contrib.sites',
> 'django.contrib.sessions',
> 'djblets.datagrid',
> 'djblets.feedview',
> 'djblets.siteconfig',
> 'djblets.util',
> 'djblets.webapi',
> 'reviewboard.accounts',
> 'reviewboard.admin',
> 'reviewboard.changedescs',
> 'reviewboard.diffviewer',
> 'reviewboard.iphone',
> 'reviewboard.reports',
> 'reviewboard.reviews',
> 'reviewboard.scmtools',
> 'reviewboard.webapi',
> 'django_evolution']
> Installed Middleware:
> ('django.middleware.common.CommonMiddleware',
> 'django.middleware.doc.XViewMiddleware',
> 'django.middleware.locale.LocaleMiddleware',
> 'django.contrib.sessions.middleware.SessionMiddleware',
> 'django.contrib.auth.middleware.AuthenticationMiddleware',
> 'djblets.siteconfig.middleware.SettingsMiddleware',
> 'reviewboard.admin.middleware.LoadSettingsMiddleware',
> 'djblets.log.middleware.LoggingMiddleware',
> 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
>
>
> Template error:
> In template /var/www/reviewboard/templates/reviews/trophy_box.html,
> error at line 9
> Caught an exception while rendering: u'review_request.id'
> 1 : {% load djblets_deco %}
>
>
> 2 : {% load djblets_utils %}
>
>
> 3 : {% load i18n %}
>
>
> 4 : {% load reviewtags %}
>
>
> 5 :
>
>
> 6 : {% ifneatnumber review_request.id %}
>
>
> 7 : {% box "yay" %}
>
>
> 8 : alt="" />
>
>
> 9 : {% blocktrans with review_request.submitter|
> user_displayname as submitter %} {{submitter}} got review request #
> {{review_request.id}}!{% endblocktrans %}
>
>
> 10 : {% endbox %}
>
>
> 11 : {% endifneatnumber %}
>
>
> 12 :
>
>
> 13 :
>
> Traceback:
> File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py"
> in get_response
> 86. response = callback(request, *callback_args,
> **callback_kwargs)
> File "/var/www/reviewboard/accounts/decorators.py" in _check
> 27. return view_func(*args, **kwargs)
> File "/usr/lib/python2.4/site-packages/django/views/decorators/
> cache.py" in _cache_controlled
> 30. response = viewfunc(request, *args, **kw)
> File "/var/www/reviewboard/reviews/views.py" in review_detail
> 175. return render_to_response(template_name, RequestContext
> (request, {
> File "/usr/lib/python2.4/site-packages/django/shortcuts/__init__.py"
> in render_to_response
> 18. return HttpResponse(loader.render_to_string(*args,
> **kwargs), **httpresponse_kwargs)
> File "/usr/lib/python2.4/site-packages/django/template/loader.py" in
> render_to_string
> 107. return t.render(context_instance)
> File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
> render
> 176. return self.nodelist.render(context)
> File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
> render
> 768. bits.append(self.render_node(node, context))
> File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
> render_node
> 71. result = node.render(context)
> File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py"
> in render
> 97. return compiled_parent.render(context)
> File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
> render
> 176. return self.nodelist.render(context)
> File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
> render
> 768. bits.append(self.render_node(node, context))
> File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
> render_node
> 71. result = node.render(context)
> File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py"
> in render
> 24. result = self.nodelist.render(context)
> File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
> render
> 768. bits.append(self.render_node(node, context))
> File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
> render_node
> 71. result = node.render(context)
> File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py"
> in render
>
Trophy causing problems
Hi,
a colleague of mine recently created the st code review request
which gave him a nice looking trophy! Really neat easter egg. I just
updated my reviewboard to svn trunk and that trophy seems to cause
some trouble now. We no longer can view that reviewrequest.
Please help :)
Environment:
Request Method: GET
Request URL: http://codereview.ykf.navtech.corp/reviewboard/r//
Django Version: 1.0.2 final
Python Version: 2.4.3
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.iphone',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.webapi',
'django_evolution']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
Template error:
In template /var/www/reviewboard/templates/reviews/trophy_box.html,
error at line 9
Caught an exception while rendering: u'review_request.id'
1 : {% load djblets_deco %}
2 : {% load djblets_utils %}
3 : {% load i18n %}
4 : {% load reviewtags %}
5 :
6 : {% ifneatnumber review_request.id %}
7 : {% box "yay" %}
8 :
9 : {% blocktrans with review_request.submitter|
user_displayname as submitter %} {{submitter}} got review request #
{{review_request.id}}!{% endblocktrans %}
10 : {% endbox %}
11 : {% endifneatnumber %}
12 :
13 :
Traceback:
File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py"
in get_response
86. response = callback(request, *callback_args,
**callback_kwargs)
File "/var/www/reviewboard/accounts/decorators.py" in _check
27. return view_func(*args, **kwargs)
File "/usr/lib/python2.4/site-packages/django/views/decorators/
cache.py" in _cache_controlled
30. response = viewfunc(request, *args, **kw)
File "/var/www/reviewboard/reviews/views.py" in review_detail
175. return render_to_response(template_name, RequestContext
(request, {
File "/usr/lib/python2.4/site-packages/django/shortcuts/__init__.py"
in render_to_response
18. return HttpResponse(loader.render_to_string(*args,
**kwargs), **httpresponse_kwargs)
File "/usr/lib/python2.4/site-packages/django/template/loader.py" in
render_to_string
107. return t.render(context_instance)
File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
render
176. return self.nodelist.render(context)
File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
render
768. bits.append(self.render_node(node, context))
File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
render_node
71. result = node.render(context)
File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py"
in render
97. return compiled_parent.render(context)
File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
render
176. return self.nodelist.render(context)
File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
render
768. bits.append(self.render_node(node, context))
File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
render_node
71. result = node.render(context)
File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py"
in render
24. result = self.nodelist.render(context)
File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
render
768. bits.append(self.render_node(node, context))
File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
render_node
71. result = node.render(context)
File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py"
in render
111. return self.template.render(context)
File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
render
176. return self.nodelist.render(context)
File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in
render
768. bits.append(self.render_node(node, context))
File "/usr/lib/python2.4/site-packages/django/template/debug.py" in
render_node
71. result = node.render(context)
File "/var/www/reviewboard/djblets/util/decorators.py" in render
150. return self.tag_func(context, self.nodel
