Re: Unable to use New Review Request to create requests with parent diffs
I've used NSIS in the past and I really don't like it: I've found it can lead to fragile setup packages. You may be able to use the free Visual Studio 2013 Express with WiX after installing Update 2 to avoid having to purchase a copy. To build the installer, you'd just run msbuild /m /p:Configuration=Release contrib\installer\windows\rbtools.sln -- Bruce On Thu, Jun 26, 2014 at 2:05 AM, Christian Hammond christ...@beanbaginc.com wrote: I looked into the Windows installer. I love the idea of getting one in, but at the moment, neither of us have Visual Studio, so we need to figure out if we want that as a dependency or if we want to evaluate something else (like NSIS). There’s also the matter of integrating this with our build system, which is another challenge to figure out. I’m going on vacation starting tomorrow, so I won’t be able to look into it any further until I’m back next week. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
I looked into the Windows installer. I love the idea of getting one in, but at the moment, neither of us have Visual Studio, so we need to figure out if we want that as a dependency or if we want to evaluate something else (like NSIS). There’s also the matter of integrating this with our build system, which is another challenge to figure out. I’m going on vacation starting tomorrow, so I won’t be able to look into it any further until I’m back next week. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 4:15:14 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Thanks! I've started committing .reviewboardrc files to each repo. I was slightly worried about the server changing, but it's simple enough to add a CNAME so things don't break. Is there anything I can do to help get the Windows installer patch committed and not forgotten about (presuming it's not already on someone's todo list)? I'm guessing most people working on Review Board are Linux developers and so the combination of Visual Studio projects and WiX code could be rather off-putting! -- Bruce On Fri, Jun 20, 2014 at 1:27 PM, Christian Hammond christ...@beanbaginc.com wrote: Right. We have a .reviewboardrc with REPOSITORY, REVIEWBOARD_URL, BRANCH, and (in some cases), TRACKING_BRANCH set for each repository we use with Review Board. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Thanks! I've started committing .reviewboardrc files to each repo. I was slightly worried about the server changing, but it's simple enough to add a CNAME so things don't break. Is there anything I can do to help get the Windows installer patch committed and not forgotten about (presuming it's not already on someone's todo list)? I'm guessing most people working on Review Board are Linux developers and so the combination of Visual Studio projects and WiX code could be rather off-putting! -- Bruce On Fri, Jun 20, 2014 at 1:27 PM, Christian Hammond christ...@beanbaginc.com wrote: Right. We have a .reviewboardrc with REPOSITORY, REVIEWBOARD_URL, BRANCH, and (in some cases), TRACKING_BRANCH set for each repository we use with Review Board. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Am I correct in thinking that a good practice would be to have users enter the reviewboard.url setting in their mercurial.ini/.hgrc files and have a .reviewboardrc file with just a REPOSITORY line committed to the repository, to avoid RBTools having to search for a matching repo in RB each time? This would avoid having individual developers running 'rbt setup-repo'. -- Bruce On Tue, Jun 17, 2014 at 4:35 PM, Bruce Cran bruce.c...@gmail.com wrote: I agree, http 500 isn't at all useful: I think on my setup I was always seeing an error saying there were no matching repositories found. Christian's mention of Mirror Path was the hint I needed to look up the documentation - from there I realised that entering the ssh:// URL that developers use (Review Board accesses repos using a local path) would let setup-repo start working. -- Bruce On Tue, Jun 17, 2014 at 2:55 PM, Sara Rayburn sararayb...@gmail.com wrote: Nowhere does that documentation refer to the fact that setup-repo will often fail with less than useful errors. I think that the error should be more useful (error 500 is not super helpful for the person trying to run the setup command) and that the docs should mention that setup-repo is only for the basic case, and explicitly state that you should custom configure in more unusual cases. I mean, we figured it out, so the info is there, I just think it could be clearer. Anyway, it seems to be working for me on all of my projects, and it's working for all of the window's developers. A couple of our programmers are still having problems, but I'm not sure if that's bugs or user error. If they aren't able to resolve their issues I'll post again with details. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
On 06/20/2014 03:08 PM, Bruce Cran wrote: Am I correct in thinking that a good practice would be to have users enter the reviewboard.url setting in their mercurial.ini/.hgrc files and have a .reviewboardrc file with just a REPOSITORY line committed to the repository, to avoid RBTools having to search for a matching repo in RB each time? This would avoid having individual developers running 'rbt setup-repo'. It's probably best to just have both the URL and repository entries in the .reviewboardrc committed to the master repo. For example, in the openlmi-providers project, we have[1]: REVIEWBOARD_URL = 'https://reviewboard-openlmi.rhcloud.com' REPOSITORY = 'openlmi-providers' [1] https://git.fedorahosted.org/cgit/openlmi-providers.git/tree/.reviewboardrc -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have the hg svn extension installed or because the default path for our repo (ssh://) does not match the path we use for reviewboard (we keep a local clone /data_local/hg-repo/foo). If you are interested in further details, I can post debug output. Sara On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond christ...@beanbaginc.com wrote: What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit
Re: Unable to use New Review Request to create requests with parent diffs
Yeah, I've found that setup-repo doesn't work for us either. For now I always use both --server and --repository, though I should just do the setup manually. With RBTools 0.6.1, setup-repo asks about 3 repos (whether they're the one I want to use) but they're all wrong. -- Bruce On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn sararayb...@gmail.com wrote: Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have the hg svn extension installed or because the default path for our repo (ssh://) does not match the path we use for reviewboard (we keep a local clone /data_local/hg-repo/foo). If you are interested in further details, I can post debug output. Sara On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond christ...@beanbaginc.com wrote: What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board
Re: Unable to use New Review Request to create requests with parent diffs
What type of repository is it? It’d be really helpful to have the Path and Mirror Path fields from the desired Repository entry, and have the URL you use locally to check out the repository, so that we can figure out what’s going wrong. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote: Yeah, I've found that setup-repo doesn't work for us either. For now I always use both --server and --repository, though I should just do the setup manually. With RBTools 0.6.1, setup-repo asks about 3 repos (whether they're the one I want to use) but they're all wrong. -- Bruce On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn sararayb...@gmail.com wrote: Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have the hg svn extension installed or because the default path for our repo (ssh://) does not match the path we use for reviewboard (we keep a local clone /data_local/hg-repo/foo). If you are interested in further details, I can post debug output. Sara On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond christ...@beanbaginc.com wrote: What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To
Re: Unable to use New Review Request to create requests with parent diffs
Hi Christian, All of our repos are mercurial repos. An example Path would be /data_local/hg-repository/foo. The mirror path is unused and unconfigured in all cases. We clone from ssh://devel.ourserver.com//devel/src/hg-repository/foo On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond christ...@beanbaginc.com wrote: What type of repository is it? It’d be really helpful to have the Path and Mirror Path fields from the desired Repository entry, and have the URL you use locally to check out the repository, so that we can figure out what’s going wrong. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote: Yeah, I've found that setup-repo doesn't work for us either. For now I always use both --server and --repository, though I should just do the setup manually. With RBTools 0.6.1, setup-repo asks about 3 repos (whether they're the one I want to use) but they're all wrong. -- Bruce On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn sararayb...@gmail.com wrote: Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have the hg svn extension installed or because the default path for our repo (ssh://) does not match the path we use for reviewboard (we keep a local clone /data_local/hg-repo/foo). If you are interested in further details, I can post debug output. Sara On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond christ...@beanbaginc.com wrote: What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails
Re: Unable to use New Review Request to create requests with parent diffs
Hi Sara, Okay, that’s why. ‘rbt setup-repo’ is really intended for the typical case where the paths more or less match up. If your Path or Mirror Path looked like the ssh:// URL, they would have been found. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 17, 2014 at 12:28:30 PM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi Christian, All of our repos are mercurial repos. An example Path would be /data_local/hg-repository/foo. The mirror path is unused and unconfigured in all cases. We clone from ssh://devel.ourserver.com//devel/src/hg-repository/foo On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond christ...@beanbaginc.com wrote: What type of repository is it? It’d be really helpful to have the Path and Mirror Path fields from the desired Repository entry, and have the URL you use locally to check out the repository, so that we can figure out what’s going wrong. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote: Yeah, I've found that setup-repo doesn't work for us either. For now I always use both --server and --repository, though I should just do the setup manually. With RBTools 0.6.1, setup-repo asks about 3 repos (whether they're the one I want to use) but they're all wrong. -- Bruce On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn sararayb...@gmail.com wrote: Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have the hg svn extension installed or because the default path for our repo (ssh://) does not match the path we use for reviewboard (we keep a local clone /data_local/hg-repo/foo). If you are interested in further details, I can post debug output. Sara On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond christ...@beanbaginc.com wrote: What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at
Re: Unable to use New Review Request to create requests with parent diffs
That makes sense. It would be nice to see a section in the RB Tools setup documentation about what to do if the setup-repo command fails. I'm not worried about it on our end. On Tue, Jun 17, 2014 at 2:42 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Sara, Okay, that’s why. ‘rbt setup-repo’ is really intended for the typical case where the paths more or less match up. If your Path or Mirror Path looked like the ssh:// URL, they would have been found. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 17, 2014 at 12:28:30 PM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi Christian, All of our repos are mercurial repos. An example Path would be /data_local/hg-repository/foo. The mirror path is unused and unconfigured in all cases. We clone from ssh://devel.ourserver.com//devel/src/hg-repository/foo On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond christ...@beanbaginc.com wrote: What type of repository is it? It’d be really helpful to have the Path and Mirror Path fields from the desired Repository entry, and have the URL you use locally to check out the repository, so that we can figure out what’s going wrong. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 17, 2014 at 9:41:10 AM, Bruce Cran (bruce.c...@gmail.com) wrote: Yeah, I've found that setup-repo doesn't work for us either. For now I always use both --server and --repository, though I should just do the setup manually. With RBTools 0.6.1, setup-repo asks about 3 repos (whether they're the one I want to use) but they're all wrong. -- Bruce On Tue, Jun 17, 2014 at 9:36 AM, Sara Rayburn sararayb...@gmail.com wrote: Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have the hg svn extension installed or because the default path for our repo (ssh://) does not match the path we use for reviewboard (we keep a local clone /data_local/hg-repo/foo). If you are interested in further details, I can post debug output. Sara On Mon, Jun 16, 2014 at 11:32 PM, Christian Hammond christ...@beanbaginc.com wrote: What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You
Re: Unable to use New Review Request to create requests with parent diffs
Isn't this covered in http://www.reviewboard.org/docs/rbtools/0.6/rbt/configuration/ ? -- Bruce On Tue, Jun 17, 2014 at 1:49 PM, Sara Rayburn sararayb...@gmail.com wrote: That makes sense. It would be nice to see a section in the RB Tools setup documentation about what to do if the setup-repo command fails. I'm not worried about it on our end. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Hi Bruce, Nowhere does that documentation refer to the fact that setup-repo will often fail with less than useful errors. I think that the error should be more useful (error 500 is not super helpful for the person trying to run the setup command) and that the docs should mention that setup-repo is only for the basic case, and explicitly state that you should custom configure in more unusual cases. I mean, we figured it out, so the info is there, I just think it could be clearer. Anyway, it seems to be working for me on all of my projects, and it's working for all of the window's developers. A couple of our programmers are still having problems, but I'm not sure if that's bugs or user error. If they aren't able to resolve their issues I'll post again with details. Sara On Tue, Jun 17, 2014 at 3:42 PM, Bruce Cran bruce.c...@gmail.com wrote: Isn't this covered in http://www.reviewboard.org/docs/rbtools/0.6/rbt/configuration/ ? -- Bruce On Tue, Jun 17, 2014 at 1:49 PM, Sara Rayburn sararayb...@gmail.com wrote: That makes sense. It would be nice to see a section in the RB Tools setup documentation about what to do if the setup-repo command fails. I'm not worried about it on our end. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
I agree, http 500 isn't at all useful: I think on my setup I was always seeing an error saying there were no matching repositories found. Christian's mention of Mirror Path was the hint I needed to look up the documentation - from there I realised that entering the ssh:// URL that developers use (Review Board accesses repos using a local path) would let setup-repo start working. -- Bruce On Tue, Jun 17, 2014 at 2:55 PM, Sara Rayburn sararayb...@gmail.com wrote: Nowhere does that documentation refer to the fact that setup-repo will often fail with less than useful errors. I think that the error should be more useful (error 500 is not super helpful for the person trying to run the setup command) and that the docs should mention that setup-repo is only for the basic case, and explicitly state that you should custom configure in more unusual cases. I mean, we figured it out, so the info is there, I just think it could be clearer. Anyway, it seems to be working for me on all of my projects, and it's working for all of the window's developers. A couple of our programmers are still having problems, but I'm not sure if that's bugs or user error. If they aren't able to resolve their issues I'll post again with details. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
What’s going wrong with the configuration? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com wrote: Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Sara Rayburn (337) 322-5573 sararayb...@gmail.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
I've put together an RBTools installer for Windows for testing that adds only the rbt command to the environment (i.e. it doesn't pollute %PATH% with python.exe etc.). It's available from http://bluestop.org/rbtools/RBTools-0.6.1.exe - I'd welcome any feedback. It _should_ work on Windows XP and newer, but so far I've only tested it on Windows 8.1. -- Bruce On Fri, Jun 13, 2014 at 6:09 PM, David Trowbridge trowb...@gmail.com wrote: We've been wanting to do something like that for some time. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 3:30:47 PM, Bruce Cran (bruce.c...@gmail.com) wrote: I've put together an RBTools installer for Windows for testing that adds only the rbt command to the environment (i.e. it doesn't pollute %PATH% with python.exe etc.). It's available from http://bluestop.org/rbtools/RBTools-0.6.1.exe - I'd welcome any feedback. It _should_ work on Windows XP and newer, but so far I've only tested it on Windows 8.1. -- Bruce On Fri, Jun 13, 2014 at 6:09 PM, David Trowbridge trowb...@gmail.com wrote: We've been wanting to do something like that for some time. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 14, 2014 at 5:59:31 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.? -- Bruce On Sat, Jun 14, 2014 at 6:43 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Hi David, The biggest problem with RB Tools for our windows users is that it requires Python 2.7, and they are running Python 3 for other services. They've tried having both installed with no success. I think it would be a good decision to restore parent diff support to the New Review Request page. For our workflow, parent diffs are the norm, not a complex case. Thanks, Sara On Thursday, June 12, 2014 7:44:39 PM UTC-5, David Trowbridge wrote: Sara, Is the reluctance just that installing python stuff on Windows is hard, or are there other concerns? It might be nice to add parent diff support to the New Review Request page, but we'd need to do some redesign to fit it in with the new workflow, which is really designed to handle basic cases very quickly, and defer complex cases to rbtools. -David On Thu, Jun 12, 2014 at 8:40 AM, Sara Rayburn sarar...@gmail.com javascript: wrote: Most of our users use hg postreview to create review requests, but our windows users prefer to use the site's New Review Request upload tool. In RB 1.7.x, there was an option to upload both a diff and a parent diff. This is no longer an option. Is there still a way to use the web tool to create reviews with parent diffs? The windows developers in our group would prefer not to install RB Tools and all of its dependencies. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
It sounds like there might be a need for a standalone RBTools package for Windows, created using something like cx_freeze? -- Bruce On Fri, Jun 13, 2014 at 7:37 AM, Sara Rayburn sararayb...@gmail.com wrote: Hi David, The biggest problem with RB Tools for our windows users is that it requires Python 2.7, and they are running Python 3 for other services. They've tried having both installed with no success. I think it would be a good decision to restore parent diff support to the New Review Request page. For our workflow, parent diffs are the norm, not a complex case. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
We've been wanting to do something like that for some time. -David On Jun 13, 2014, at 7:22 AM, Bruce Cran bruce.c...@gmail.com wrote: It sounds like there might be a need for a standalone RBTools package for Windows, created using something like cx_freeze? -- Bruce On Fri, Jun 13, 2014 at 7:37 AM, Sara Rayburn sararayb...@gmail.com wrote: Hi David, The biggest problem with RB Tools for our windows users is that it requires Python 2.7, and they are running Python 3 for other services. They've tried having both installed with no success. I think it would be a good decision to restore parent diff support to the New Review Request page. For our workflow, parent diffs are the norm, not a complex case. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Unable to use New Review Request to create requests with parent diffs
Most of our users use hg postreview to create review requests, but our windows users prefer to use the site's New Review Request upload tool. In RB 1.7.x, there was an option to upload both a diff and a parent diff. This is no longer an option. Is there still a way to use the web tool to create reviews with parent diffs? The windows developers in our group would prefer not to install RB Tools and all of its dependencies. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
Sara, Is the reluctance just that installing python stuff on Windows is hard, or are there other concerns? It might be nice to add parent diff support to the New Review Request page, but we'd need to do some redesign to fit it in with the new workflow, which is really designed to handle basic cases very quickly, and defer complex cases to rbtools. -David On Thu, Jun 12, 2014 at 8:40 AM, Sara Rayburn sararayb...@gmail.com wrote: Most of our users use hg postreview to create review requests, but our windows users prefer to use the site's New Review Request upload tool. In RB 1.7.x, there was an option to upload both a diff and a parent diff. This is no longer an option. Is there still a way to use the web tool to create reviews with parent diffs? The windows developers in our group would prefer not to install RB Tools and all of its dependencies. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
