Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Updates: Status: ThirdParty Comment #28 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Until RhodeCode supports the necessary APIs, there's nothing we can do here. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #27 on issue 2445 by dotheb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Update: - 'Such revision does not exist for this repository' originated in me having a patch based on a first tested migration repo, which was recreated under the same name. - the rhodecode won't grant access to the /raw/ URLswith http-Auth-basic, but just web based cookie auth. - since I don't have access to the rhode code, plus the connection isn't fast enough anyways, I work with local clones which do polling. - while the URLs generated work well with rhode code work well in the browser (so if you use cookies everything is ok) it seems to break connection to traditional hg repositories. In general, is there a cheap way for reviewboard to keep its own clone of hg repositories in general? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #25 on issue 2445 by dotheb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 So it seems as if the patch from #16 doesn't apply anymore since the 'hg-history' case was added. I've edited it so it applies cleanly to 1.7.20 so it generates queries this url: https://myrhodecode/hg/repo_URL/raw/5aa4fa3e1a60/path/to/rawfile.txt but when I browse rhode code, and try to get the latest version of this file in raw, it looks like that: https://myrhodecode/hg/repo_URL/raw/13a98ef355224d626c3bf3dbe0e5f1545052a230/path/to/rawfile.txt The request to the short (wrong) key results in the same 404 reply with the login dialog as everybody else experienced so far. Any hints where this hash is generated? and why its using a wrong one? Attachments: rb_hg_api_key_1.7.20.patch 3.6 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #26 on issue 2445 by dotheb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Oh, I have to correct myself. The reply actualy is: 'Such revision does not exist for this repository' -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #24 on issue 2445 by kiran...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Is there any solution available for this issue. I am facing a similar kind of issue. I am on Review Board 1.7.6. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
I have a workaround that'll go into 1.7.8, but I'm really confused how the original problem is occurring. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Wed, May 29, 2013 at 10:46 AM, Kristin Thomas xtintho...@gmail.comwrote: On Tuesday, May 28, 2013 12:16:37 PM UTC-6, Matthew Woehlke wrote: Um... this seems familiar. Have you upgraded through a number of RB versions? Is the user having trouble either notably older, newer, or had a long period of inactivity? It was a fairly new install of RB from scratch. Something to try: have the user go into their account settings and change the value of their 'always open an issue' option. (They can immediately change it back, just as long as they apply the change with the opposite value to force it to be rewritten.) Yeah, we did that and it corrected the issue. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Some more info, when this is not working, the page source has the following: var gOpenAnIssue = ; instead of: var gOpenAnIssue = true; On Friday, April 19, 2013 9:37:07 PM UTC-6, Jonathan Wilson wrote: Hi, For some reason I am unable to view the diffs for multiple files on Reviewboard v1.7.6. I can only see the diff for the first file. The rest of the file diffs are stuck loading forever (with the little circular animated loading icon) I've tried with Internet Explorer 8, 9, Google Chrome and firefox and I get the same behavior. I even tried clearing my internet cache but that doesn't seem to help. Does anyone have any idea what is causing this? Thanks, -JW -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Hi, We just ran across this issue on a recent installation ourselves; one single user out of 18 reported this behaviour. While tracking this down, I spotted a seemingly unrelated issue where gOpenAnIssue wasn't being set despite the user's account settings saying that it was. Getting my colleague to reset the Open An Issue setting on his account fixed his ability to view more than one diffed file. This appears to be related to the fact that his account was created manually through the admin pages rather than being auto-created through login. Will need to do some testing of that idea, though. Ken On Tuesday, April 23, 2013 7:16:04 PM UTC-6, Jonathan Wilson wrote: Hi Christian, Sorry for the late reply, I tried view a diff with the Chrome console and no error messages were displayed. I only received the following messages while clicking on the initial review request link: Uncaught SyntaxError: Unexpected token ; /r/593/:40 Uncaught ReferenceError: gReviewRequestId is not defined reviews.min.js:112 Uncaught TypeError: Object #Object has no method 'setFileAttachmentComments' rb-server.myreviewboard.org:415 I have 2 other colleagues who have the same issue, but the majority of my colleagues have no issues viewing multiple diffs. -JW On Monday, April 22, 2013 2:33:58 PM UTC-4, Christian Hammond wrote: On Mon, Apr 22, 2013 at 8:57 AM, Matthew Woehlke mwoehlk...@gmail.comwrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. It very well might be the server. I stated on the browser side because generally, if there's a server-side error, we should be showing it. We load the diffs dynamically, so if there's a browser-side script error, we may fail to either load or render (or show the error). Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
On 2013-05-28 13:22, Kristin Thomas wrote: Some more info, when this is not working, the page source has the following: var gOpenAnIssue = ; instead of: var gOpenAnIssue = true; Um... this seems familiar. Have you upgraded through a number of RB versions? Is the user having trouble either notably older, newer, or had a long period of inactivity? Something to try: have the user go into their account settings and change the value of their 'always open an issue' option. (They can immediately change it back, just as long as they apply the change with the opposite value to force it to be rewritten.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
The two issues are related. I have absolutely no idea how the user's profile entry is ending up with that value set to.. null? Or something. Actually, for any user hitting this, I'd love to get an SQL dump of their accounts_profile table entry, if you can find it, before they fix it with the double-toggle workaround. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On May 28, 2013, at 7:29 AM, Kristin Thomas xtintho...@gmail.com wrote: Was there a resolution to this issue? We are experiencing a similar problem. We have 16 users with no problem and one user that cannot load any diffs (in IE, Chrome, or Firefox). Same error as mentioned previously: [08:21:52.611] SyntaxError: syntax error @ http://reviewboard.companyname.com/r/87/diff/#:40 [08:21:52.809] ReferenceError: gReviewRequestId is not defined @ http://reviewboard.companyname.com/static/rb/js/reviews.min.89914309c82b.js:112 [08:21:52.837] TypeError: RB.setFileAttachmentComments is not a function @ http://reviewboard.companyname.com/r/87/diff/#:414 I'll attach the log. Any help would be greatly appreciated. Kristin Thomas On Tuesday, April 23, 2013 7:16:04 PM UTC-6, Jonathan Wilson wrote: Hi Christian, Sorry for the late reply, I tried view a diff with the Chrome console and no error messages were displayed. I only received the following messages while clicking on the initial review request link: Uncaught SyntaxError: Unexpected token ; /r/593/:40 Uncaught ReferenceError: gReviewRequestId is not defined reviews.min.js:112 Uncaught TypeError: Object #Object has no method 'setFileAttachmentComments' rb-server.myreviewboard.org:415 I have 2 other colleagues who have the same issue, but the majority of my colleagues have no issues viewing multiple diffs. -JW On Monday, April 22, 2013 2:33:58 PM UTC-4, Christian Hammond wrote: On Mon, Apr 22, 2013 at 8:57 AM, Matthew Woehlke mwoehlk...@gmail.com wrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. It very well might be the server. I stated on the browser side because generally, if there's a server-side error, we should be showing it. We load the diffs dynamically, so if there's a browser-side script error, we may fail to either load or render (or show the error). Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com errors.txt -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Hi Christian, Sorry for the late reply, I tried view a diff with the Chrome console and no error messages were displayed. I only received the following messages while clicking on the initial review request link: Uncaught SyntaxError: Unexpected token ; /r/593/:40 Uncaught ReferenceError: gReviewRequestId is not defined reviews.min.js:112 Uncaught TypeError: Object #Object has no method 'setFileAttachmentComments' rb-server.myreviewboard.org:415 I have 2 other colleagues who have the same issue, but the majority of my colleagues have no issues viewing multiple diffs. -JW On Monday, April 22, 2013 2:33:58 PM UTC-4, Christian Hammond wrote: On Mon, Apr 22, 2013 at 8:57 AM, Matthew Woehlke mwoehlk...@gmail.comjavascript: wrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. It very well might be the server. I stated on the browser side because generally, if there's a server-side error, we should be showing it. We load the diffs dynamically, so if there's a browser-side script error, we may fail to either load or render (or show the error). Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Hi Matthew, Yes, my reviewboard server is able to generate diffs without any problems. I also mentioned to Christian, that I have 2 other colleagues that have the same issue as me. However the majority of my colleague can view multiple diffs without any problems. -JW On Monday, April 22, 2013 11:57:56 AM UTC-4, Matthew Woehlke wrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
On Mon, Apr 22, 2013 at 8:57 AM, Matthew Woehlke mwoehlke.fl...@gmail.comwrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. It very well might be the server. I stated on the browser side because generally, if there's a server-side error, we should be showing it. We load the diffs dynamically, so if there's a browser-side script error, we may fail to either load or render (or show the error). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Unable to view diff for multiple files.
Hi, For some reason I am unable to view the diffs for multiple files on Reviewboard v1.7.6. I can only see the diff for the first file. The rest of the file diffs are stuck loading forever (with the little circular animated loading icon) I've tried with Internet Explorer 8, 9, Google Chrome and firefox and I get the same behavior. I even tried clearing my internet cache but that doesn't seem to help. Does anyone have any idea what is causing this? Thanks, -JW -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Fri, Apr 19, 2013 at 8:37 PM, Jonathan Wilson jwil...@gmail.com wrote: Hi, For some reason I am unable to view the diffs for multiple files on Reviewboard v1.7.6. I can only see the diff for the first file. The rest of the file diffs are stuck loading forever (with the little circular animated loading icon) I've tried with Internet Explorer 8, 9, Google Chrome and firefox and I get the same behavior. I even tried clearing my internet cache but that doesn't seem to help. Does anyone have any idea what is causing this? Thanks, -JW -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #22 on issue 2445 by rapid7...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Not sure if it's in rhodecode upstream, but a good point. I'll check, though Marcin Kuzminski may have some questions. I'll direct him here. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #20 on issue 2445 by rapid7...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 We've been using this patch since 1.6.12 and again on 1.6.15. I will check, but did it make it into 1.7.1? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #21 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Is the rc_files_api_access.patch change in rhodecode upstream? I'm not comfortable including this in reviewboard until it works with all rhodecode repositories without making people patch their copy. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Updates: Status: New Comment #18 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #17 on issue 2445 by vairavan...@ciinow.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Awesome! Thank you so much Mike. I'm going to try your patch now! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #16 on issue 2445 by mike@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 i have done some work-around to use the api-key when accessing rhodecode (1.3.6) hosted hg repo 1. apply attached patches, rc_ for rhodecode and rb_ for reviewboard 2. modify production.ini of installed rhodecode instance to turn off both container_auth and proxypass_auth now i could setup a rhodecode repo as custom hg repo with raw_file_url as repo url/raw/revision/filename?api_key=api-key and it's working ^_^ Attachments: rb_hg_api_key.patch 3.5 KB rc_files_api_access.patch 706 bytes -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #12 on issue 2445 by mike@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 i think the problem is caused by some sort of errors of authentication, thus rhodecode redirect the request to the login page which is exactly the content of the temporary file. however, in recent rhodecode version, an api-key is added, so the solution might be getting raw files with api-key. i am not familiar with python, not to mention the reviewboard itself, but from the form of repository creation, i think maybe we could add api-key option for custom type of repository, or add Rhodecode as a hosting service with field of username and password replaced with api-key. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #13 on issue 2445 by mike@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 forgot to mention: just add api-key=api-key to GET parameter to access without login and by default, rhodecode turns off accessing files via api-key, so rhodecode itself has to be modified too. more information could be found at http://bit.ly/Molott and complete api document is at http://bit.ly/MolDom btw, according to the log of apache, the initial raw file url requested from rb is indeed wrong, but the second try is correct: rhodecode url/raw/revision id/path to file -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #14 on issue 2445 by vairavan...@ciinow.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi Mike, Thank you so much for the pointer. I will try it out today and will update this issue. This is of great help! Thanks again, Vairav. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #15 on issue 2445 by mike@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 i am glad to help, too ^_^ as i have mentioned that i am not familiar with reviewboard and that i have no clue of modifying how rb is accessing rhodecode. my intention is to at least provide some observation to draw some attention here and hoping that someone could come out with a solution. so i am looking forward to your progress, too :) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Unable to view diff
Hi Chris, On first glance, it looks like the p4 binary isn't executable. Can you check the permissions of this? I've seen similar issues crop up, so I'll add some better logging and error handling for hopefully the next patch release to help diagnose these issues. Christian On Mar 8, 2012, at 23:33, Chris Baron topher.ba...@gmail.com wrote: Hi review board users, I just upgraded from version 1.0.1 to 1.6.3. Most things are going smoothly. However, when I try to view a diff : Traceback (most recent call last): File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/views.py, line 151, in view_diff interdiffset, highlighting, True) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 1071, in get_diff_files large_data=True) File /usr/local/lib/python2.7/site-packages/Djblets-0.6.15- py2.7.egg/djblets/util/misc.py, line 157, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 1070, in lambda enable_syntax_highlighting)), File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 551, in get_chunks old = get_original_file(filediff) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 364, in get_original_file large_data=True)[0] File /usr/local/lib/python2.7/site-packages/Djblets-0.6.15- py2.7.egg/djblets/util/misc.py, line 157, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 363, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 342, in fetch_file data = tool.get_file(file, revision) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 306, in get_file return self.client.get_file(path, revision) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 224, in get_file return self._run_worker(lambda: self._get_file(path, revision)) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 154, in _run_worker result = worker() File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 224, in lambda return self._run_worker(lambda: self._get_file(path, revision)) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 201, in _get_file stderr=subprocess.PIPE) File /usr/lib64/python2.7/subprocess.py, line 672, in __init__ errread, errwrite) File /usr/lib64/python2.7/subprocess.py, line 1201, in _execute_child raise child_exception OSError: [Errno 13] Permission denied Any suggestions? Thanks in advance. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Unable to view diff
Hi review board users, I just upgraded from version 1.0.1 to 1.6.3. Most things are going smoothly. However, when I try to view a diff : Traceback (most recent call last): File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/views.py, line 151, in view_diff interdiffset, highlighting, True) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 1071, in get_diff_files large_data=True) File /usr/local/lib/python2.7/site-packages/Djblets-0.6.15- py2.7.egg/djblets/util/misc.py, line 157, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 1070, in lambda enable_syntax_highlighting)), File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 551, in get_chunks old = get_original_file(filediff) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 364, in get_original_file large_data=True)[0] File /usr/local/lib/python2.7/site-packages/Djblets-0.6.15- py2.7.egg/djblets/util/misc.py, line 157, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 363, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 342, in fetch_file data = tool.get_file(file, revision) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 306, in get_file return self.client.get_file(path, revision) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 224, in get_file return self._run_worker(lambda: self._get_file(path, revision)) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 154, in _run_worker result = worker() File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 224, in lambda return self._run_worker(lambda: self._get_file(path, revision)) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/scmtools/perforce.py, line 201, in _get_file stderr=subprocess.PIPE) File /usr/lib64/python2.7/subprocess.py, line 672, in __init__ errread, errwrite) File /usr/lib64/python2.7/subprocess.py, line 1201, in _execute_child raise child_exception OSError: [Errno 13] Permission denied Any suggestions? Thanks in advance. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #11 on issue 2445 by mikael.a...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 I think I'm having the same issue. When trying to patch file A I get the same message saying that patch failed. When looking at the temp files I see that the file ReviewBoard is trying to patch is an old version of A. Exception for the changeset up for review, both local and master repositories share the same state. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #10 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi Trowb, Sorry for the very late response. I was trying to figure out on how to get the raw file url, but unable to do so. The only thing that I was able to narrow down was that, Rhodecode, when authenticated gives the proper url. If you can advice me on how to go about getting the Raw file url, it would be great! Thanks, Vairav -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #9 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Your raw file url is wrong. You need to figure out how to get the contents of files at specific revisions from RhodeCode. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #8 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi, sorry to bump on the issue, but just wanted to check to see if there are any possible solutions. Thanks again, Vairav -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #6 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi Trowb, I found something very interesting today. When I opened up another past review, and clicked on 'View Diff', it showed me the same error (and it was reviewboard.5q4R0F with the file tmpShBACU, etc.) So when I opened up the file 'tmpShBACU', it was very identical to some other review that which I had submitted and had no relation to it. Later when I logged into RhodeCode manually, I saw the source of the first landing page, i.e. RhodeCode's index page, and surprisingly, the contents of the file are nothing but the index page of RhodeCode. Could you please let me know on why this is happening? Or what has to be done? I can confirm that all the reviews that produced the reject files, has the same index page of RhodeCode. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #7 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 The tmpShBACU file for your reference is attached with this post. Attachments: tmpShBACU 6.4 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #4 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi, just to update, I was looking through the settings in reviewboard to see if the paths are correct, but when I open the older reviews that I had added during the old setup, i.e. Reviewboard + hgweb.cgi, when I downloaded the diffs, they are having the proper paths on the top of the file. Similarly, when I did the same for the newer reviews that I had added with the new setup, i.e. Reviewboard + Rhodecode, similarly, the paths are all correct and they are looking normal. Is it something to do with the authentication portion of the Reviewboard with Rhodecode? I did enter the username and password similar to the way its done for Bitbucket repositories in the 'Repo' section of the Admin Panel. Please advice. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #5 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 If the contents of the file are what you expect, it's not an authentication problem. Are you sure the line endings match between the file and the patch? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? Reviewboard version: 1.6.3 Repository: Mercurial Repository with the latest RhodeCode for managing the repositories. OS: Ubuntu 11.04 What's the URL of the page containing the problem? Its an internal Reviewboard site, so not accessible from outside the LAN. What steps will reproduce the problem? 1. Replace hgweb.cgi with RhodeCode for managing mercurial repositories 2. Created user 'reviewboard' with password 'reviewpass' and added the credentials to Repositories in the Admin Panel. 3. Post Review works, but when trying to View Diff I'm getting the output as stated below. What is the expected output? What do you see instead? [code] The patch to 'index.xhtml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.uV5elT' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.uV5elT/tmplXUpmn Hunk #1 FAILED at 148. Hunk #2 FAILED at 160. Hunk #3 FAILED at 188. Hunk #4 FAILED at 203. Hunk #5 FAILED at 218. Hunk #6 FAILED at 263. Hunk #7 FAILED at 398. Hunk #8 FAILED at 409. Hunk #9 FAILED at 429. 9 out of 9 hunks FAILED -- saving rejects to file /tmp/reviewboard.uV5elT/ tmplXUpmn-new.rej Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/views.py, line 151, in view_diff interdiffset, highlighting, True) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 1071, in get_diff_files large_data=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.6.15- py2.7.egg/djblets/util/misc.py, line 157, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 1070, in lambda enable_syntax_highlighting)), File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 551, in get_chunks old = get_original_file(filediff) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 368, in get_original_file data = patch(filediff.parent_diff, data, filediff.source_file) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.3- py2.7.egg/reviewboard/diffviewer/diffutils.py, line 242, in patch (filename, tempdir, patch_output)) Exception: The patch to 'index.xhtml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.uV5elT' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.uV5elT/tmplXUpmn Hunk #1 FAILED at 148. Hunk #2 FAILED at 160. Hunk #3 FAILED at 188. Hunk #4 FAILED at 203. Hunk #5 FAILED at 218. Hunk #6 FAILED at 263. Hunk #7 FAILED at 398. Hunk #8 FAILED at 409. Hunk #9 FAILED at 429. 9 out of 9 hunks FAILED -- saving rejects to file /tmp/ reviewboard.uV5elT/tmplXUpmn-new.rej [/code] What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Updates: Status: NeedInfo Comment #1 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 It looks like the contents of the raw file that RhodeCode is giving you is bogus. Can you look at /tmp/reviewboard.uV5elT/tmplXUpmn and see what's in it? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #2 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi trowb, I saw the contents of the file tmplXUpmn and tempXUpmn-new, and found that both the files are identical. Also, the file tmplXUpmn has my index.xhtml content. Then I compared two other files which are present in the same directory, which are: 1. index.xhtml.diff 2. tmplXUpmn-new.rej When comparing both these files I found that index.xhtml.diff had this extra online as the first line in the file and the paths in the 2nd and 3rd lines were different too: [code] diff -r 4020b8bf5e12 -r cd26cce649a2 develop/src/modules/controller/src/main/webapp/index.xhtml --- a/develop/src/modules/controller/src/main/webapp/index.xhtml Fri Dec 16 16:07:19 2011 -0800 +++ b/develop/src/modules/controller/src/main/webapp/index.xhtml Tue Dec 20 15:03:31 2011 -0800 [/code] Whereas in tmplXUpmn-new.rej I'm having the following lines: [code] --- index.xhtml Fri Dec 16 16:07:19 2011 -0800 +++ index.xhtml Tue Dec 20 15:03:31 2011 -0800 [/code] I'm not sure on why the paths are different in both these files. Please let me know if you need any more information. I'm not sure on what to look out for in those file and any guidances would be really helpful. Regards, Vairav -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #3 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Also to add, I'm using mercurial-reviewboard plugin with my mercurial to do the 'hg postreview -o revision no.' to post it to the reviewboard. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1855 in reviewboard: unable to view diff
Updates: Status: Incomplete Comment #4 on issue 1855 by trowbrds: unable to view diff http://code.google.com/p/reviewboard/issues/detail?id=1855 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1855 in reviewboard: unable to view diff
Updates: Status: NeedInfo Comment #2 on issue 1855 by trowbrds: unable to view diff http://code.google.com/p/reviewboard/issues/detail?id=1855 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1855 in reviewboard: unable to view diff
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1855 by vaibhav.rokade: unable to view diff http://code.google.com/p/reviewboard/issues/detail?id=1855 please find the error message in the attached file : rtest.txt *NOTE: Do not post confidential information in this bug report.* What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. Attachments: rtest.txt 2.1 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1855 in reviewboard: unable to view diff
Comment #1 on issue 1855 by trowbrds: unable to view diff http://code.google.com/p/reviewboard/issues/detail?id=1855 What's happening is that the patch doesn't apply cleanly. What SCM are you using? How did you create your patch? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1160 in reviewboard: Unable to view diff for a git repository
Updates: Status: Fixed Comment #2 on issue 1160 by trowbrds: Unable to view diff for a git repository http://code.google.com/p/reviewboard/issues/detail?id=1160 Fixed in SVN r2061. Thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1160 in reviewboard: Unable to view diff for a git repository
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1160 by eallik: Unable to view diff for a git repository http://code.google.com/p/reviewboard/issues/detail?id=1160 I've set up a git repository, uploaded a diff that I'd like to review, but getting: Traceback (most recent call last): File /usr/lib/python2.5/site-packages/ReviewBoard-1.0rc2.1- py2.5.egg/reviewboard/diffviewer/views.py, line 152, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0rc2.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 620, in get_diff_files large_data=True) File /usr/lib/python2.5/site-packages/Djblets-0.5rc1.1-py2.5.egg/djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.5/site-packages/ReviewBoard-1.0rc2.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 619, in lambda enable_syntax_highlighting), File /usr/lib/python2.5/site-packages/ReviewBoard-1.0rc2.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 341, in get_chunks old = get_original_file(filediff) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0rc2.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 248, in get_original_file large_data=True)[0] File /usr/lib/python2.5/site-packages/Djblets-0.5rc1.1-py2.5.egg/djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.5/site-packages/ReviewBoard-1.0rc2.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 247, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File /usr/lib/python2.5/site-packages/ReviewBoard-1.0rc2.1- py2.5.egg/reviewboard/diffviewer/diffutils.py, line 227, in fetch_file data = tool.get_file(file, revision) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0rc2.1- py2.5.egg/reviewboard/scmtools/git.py, line 32, in get_file return self.client.cat_file(self._resolve_head(revision, path)) File /usr/lib/python2.5/site-packages/ReviewBoard-1.0rc2.1- py2.5.egg/reviewboard/scmtools/git.py, line 195, in cat_file raise SCMError(errmsg) SCMError: fatal: Not a git repository: '/path/to/repository/' But /path/to/repository is a perfectly valid Git repository. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
