Re: Unicode and Subversion

2014-05-04 Thread Stefan Bohne
Here you go, David. 2014-04-29 10:12:58,425 - DEBUG - - DiffParser.parse: Beginning parse of diff, size = 429 2014-04-29 10:12:58,442 - DEBUG - - DiffParser.parse: Finished parsing diff. 2014-04-29 10:12:58,445 - ERROR - None - stbohne - /api/review-requests/2194/diffs/ - Error uploading new

Re: Unicode and Subversion

2014-05-03 Thread David Trowbridge
Stefan, This has improved significantly in the 2.0 RCs, but we should probably still try to fix it in the 1.7.x series. Can you see if you can get a traceback for the UnicodeDecodeError? -David On Wed, Apr 30, 2014 at 2:52 AM, Stefan Bohne < stefan.bo...@sentec-elektronik.de> wrote: > Review B

Re: Unicode and Subversion

2014-04-30 Thread Stefan Bohne
Review Board 1.7.21 Am Dienstag, 29. April 2014 22:02:37 UTC+2 schrieb David Trowbridge: > > What version of Review Board are you using? > > -David > > > On Tue, Apr 29, 2014 at 3:22 AM, Stefan Bohne < > stefan...@sentec-elektronik.de > wrote: > >> Thanks, David. That fixed it. But now reviewboa

Re: Unicode and Subversion

2014-04-29 Thread David Trowbridge
What version of Review Board are you using? -David On Tue, Apr 29, 2014 at 3:22 AM, Stefan Bohne < stefan.bo...@sentec-elektronik.de> wrote: > Thanks, David. That fixed it. But now reviewboard itself seems to stumble > over unicode paths. > > $ rbt post --repository-url=http://svn/svn/main/ --

Re: Unicode and Subversion

2014-04-29 Thread Stefan Bohne
Thanks, David. That fixed it. But now reviewboard itself seems to stumble over unicode paths. $ rbt post --repository-url=http://svn/svn/main/ --username=stbohne --password=XXX -d --server=http://reviews/ 8792 >>> RBTools 0.6 >>> Python 2.7.5+ (default, Feb 27 2014, 19:39:55) [GCC 4.8.1] >>> R

Re: Unicode and Subversion

2014-04-28 Thread David Trowbridge
I believe that this is because we remove locale configuration, since svn likes to localize some of the control strings in the diffs. Could you test a prospective code change for this? In rbtools/util/process.py, there are two lines: env['LC_ALL'] = 'C' env['LANGUAGE'] = 'C' Can you change 'C' to

Unicode and Subversion

2014-04-28 Thread Stefan Bohne
Hello, I'm having problems posting a review request from a subversion repository with rbt post that contains non-ascii file names. It seems that rbt post executes svn diff with a non-unicode locale and that makes svn fail. The same svn command works when typed on the command line. But it coul