Re: Uploading new diff that contains a new file

2012-05-01 Thread Darren Burke
Hi Christian,
Thanks for the reply. I have now actually been able to upload new
files with no problems. It turns out that the way I was generating the
diff was causing the problem!

I am not using post-review because I wanted to do some custom steps
when people were submitting reviews. By using my own script I can
ensure that what needs to be included in each review is included.

Cheers,
Darren

On Apr 30, 7:24 pm, Christian Hammond chip...@chipx86.com wrote:
 Hi Darren,

 I'd recommend looking at our post-review tool and what it does for diffs.
 You'll need to copy its logic for this. Though, I'm curious why you're not
 just using post-review?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

 On Mon, Apr 30, 2012 at 4:22 AM, Darren Burke darren_bu...@yahoo.comwrote:







  Hi,
  I use clearcase to manage my code and want to upload a diff file to
  reviewboard that contains a new file. I use my own script to create
  new reviews and upload diff files but when I try to upload a diff that
  contains a new file I get the error The file was not found in the
  repository. Anyone know how to overcome this problem?

  I use the HTTP POST method to upload my diff files and this works fine
  for files that already exist in the repository so the problem is
  uniquely related to new files.

  What does reviewboard look for in the diff file to allow new files to
  be included? I guess I could hack the file to include this info to
  support my script.
  Thanks,
  Darren

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Uploading new diff that contains a new file

2012-04-30 Thread Darren Burke
Hi,
I use clearcase to manage my code and want to upload a diff file to
reviewboard that contains a new file. I use my own script to create
new reviews and upload diff files but when I try to upload a diff that
contains a new file I get the error The file was not found in the
repository. Anyone know how to overcome this problem?

I use the HTTP POST method to upload my diff files and this works fine
for files that already exist in the repository so the problem is
uniquely related to new files.

What does reviewboard look for in the diff file to allow new files to
be included? I guess I could hack the file to include this info to
support my script.
Thanks,
Darren

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Uploading new diff that contains a new file

2012-04-30 Thread Christian Hammond
Hi Darren,

I'd recommend looking at our post-review tool and what it does for diffs.
You'll need to copy its logic for this. Though, I'm curious why you're not
just using post-review?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Apr 30, 2012 at 4:22 AM, Darren Burke darren_bu...@yahoo.comwrote:

 Hi,
 I use clearcase to manage my code and want to upload a diff file to
 reviewboard that contains a new file. I use my own script to create
 new reviews and upload diff files but when I try to upload a diff that
 contains a new file I get the error The file was not found in the
 repository. Anyone know how to overcome this problem?

 I use the HTTP POST method to upload my diff files and this works fine
 for files that already exist in the repository so the problem is
 uniquely related to new files.

 What does reviewboard look for in the diff file to allow new files to
 be included? I guess I could hack the file to include this info to
 support my script.
 Thanks,
 Darren

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en