Re: Why does RB allow the review owner to Fix/Drop issues?

2014-08-01 Thread Stephen

Sorry, yes I can see that I have the option now in RB 2.0 for my issues. 
I guess I must of been looking at issues from someone else, apologies.

Stephen.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Why does RB allow the review owner to Fix/Drop issues?

2014-07-31 Thread Stephen

I've never really understood why RB chooses to allow only the review owner 
to fix/drop issues on a review.
I always thought it was the originator of the comment/issue that is best 
placed to decide the issue has been truly fixed or agrees for it to be 
dropped.

Can someone enlighten me? :-)

Stephen.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Why does RB allow the review owner to Fix/Drop issues?

2014-07-31 Thread Matthew Woehlke
On 2014-07-31 09:40, Stephen wrote:
 I've never really understood why RB chooses to allow only the review owner 
 to fix/drop issues on a review.
 I always thought it was the originator of the comment/issue that is best 
 placed to decide the issue has been truly fixed or agrees for it to be 
 dropped.
 
 Can someone enlighten me? :-)

I think the idea is, reviewer reports issue, submitter either addresses
issue or explains why it isn't an issue, and updates the issue
accordingly. (In bug tracking workflows, resolved is usually set by
the developer, not the reporter. Similar idea here.)

That said, are you using 2.x? Because this is reportedly addressed. See
http://code.google.com/p/reviewboard/issues/detail?id=2713.

-- 
Matthew

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Why does RB allow the review owner to Fix/Drop issues?

2014-07-31 Thread Christian Hammond
Right, the reviewer can toggle the issue status starting in 2.0.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On July 31, 2014 at 8:52:45 AM, Matthew Woehlke (mwoehlke.fl...@gmail.com) 
wrote:

On 2014-07-31 09:40, Stephen wrote:  
 I've never really understood why RB chooses to allow only the review owner  
 to fix/drop issues on a review.  
 I always thought it was the originator of the comment/issue that is best  
 placed to decide the issue has been truly fixed or agrees for it to be  
 dropped.  
  
 Can someone enlighten me? :-)  

I think the idea is, reviewer reports issue, submitter either addresses  
issue or explains why it isn't an issue, and updates the issue  
accordingly. (In bug tracking workflows, resolved is usually set by  
the developer, not the reporter. Similar idea here.)  

That said, are you using 2.x? Because this is reportedly addressed. See  
http://code.google.com/p/reviewboard/issues/detail?id=2713.  

--  
Matthew  

--  
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/  
---  
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/  
---  
Happy user? Let us know at http://www.reviewboard.org/users/  
---  
You received this message because you are subscribed to the Google Groups 
reviewboard group.  
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.  
For more options, visit https://groups.google.com/d/optout.  

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.