Re: how does post-review know if files changed?
Yea. I do not know about the web API, I'll have to look into that.
On Jun 9, 2012 2:02 AM, Dado Feigenblatt d...@dado.org wrote:
Hi Ryan, thanks for the reply.
Unfortunately my server doesn't understand that request.
I'm running ReviewBoard 1.6.3.
I see you don't have '/api/' in your URL.
Are you intentionally not using the api, or is this the older method of
interfacing with the server?
I tried the api method
/api/review-requests/{review_**request_id}/diffs/{diff_**revision}/
but it doesn't contain the actual text of diff.
Eventually I got your example to work after I removed '/reviews/' from the
url
http://example.review.com/r/9/**diff/raw/http://example.review.com/r/9/diff/raw/
But that returns a plain unicode string of the diff instead of json or xml.
Definitely better than nothing and I might end up using that, but I just
want to make sure there's no blessed api method for getting the actual
text of the diffs.
Thanks,
Dado
On Fri, 8 Jun 2012 00:47:43 -0700 (PDT), Ryan Raasch
ryan.raa...@gmail.com wrote:
On Friday, June 8, 2012 1:41:32 AM UTC+2, dado wrote: When updating a
review, post-review will tell you if the file changed
since it was last submitted for review.
How does it know that? Does RB save diffs for each request update?
As far as I can tell, it doesn't. Post-review generates a diff based
on the local
changes. It then posts this diff to the server. Which maintains
versions of the diff.
There are not diffs of diffs, only versions.
If so, how can I retrieve them via the web api?
Just use curl or wget with
http://example.review.com/**reviews/r/9/diff/raw/http://example.review.com/reviews/r/9/diff/raw/
Thanks,
Dado
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/**donate/ http://www.reviewboard.org/donate/[1]
Happy user? Let us know at
http://www.reviewboard.org/**users/http://www.reviewboard.org/users/[2]
-~--~~~~--**~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscribe@**googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/**group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en[3]
Links:
--
[1] http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/
[2] http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
[3]
http://groups.google.com/**group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/**donate/ http://www.reviewboard.org/donate/
Happy user? Let us know at
http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
-~--~~~~--**~~--~--~---
To unsubscribe from this group, send email to reviewboard+unsubscribe@**
googlegroups.com reviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/**
group/reviewboard?hl=en http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: how does post-review know if files changed?
On Friday, June 8, 2012 1:41:32 AM UTC+2, dado wrote: When updating a review, post-review will tell you if the file changed since it was last submitted for review. How does it know that? Does RB save diffs for each request update? As far as I can tell, it doesn't. Post-review generates a diff based on the local changes. It then posts this diff to the server. Which maintains versions of the diff. There are not diffs of diffs, only versions. If so, how can I retrieve them via the web api? Just use curl or wget with http://example.review.com/reviews/r/9/diff/raw/ Thanks, Dado -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: how does post-review know if files changed?
On Friday, June 8, 2012 1:41:32 AM UTC+2, dado wrote: When updating a review, post-review will tell you if the file changed since it was last submitted for review. Actually it can tell you the difference between two diffs. How does it know that? Does RB save diffs for each request update? If so, how can I retrieve them via the web api? Thanks, Dado -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: how does post-review know if files changed?
Hi Ryan, thanks for the reply.
Unfortunately my server doesn't understand that request.
I'm running ReviewBoard 1.6.3.
I see you don't have '/api/' in your URL.
Are you intentionally not using the api, or is this the older method of
interfacing with the server?
I tried the api method
/api/review-requests/{review_request_id}/diffs/{diff_revision}/
but it doesn't contain the actual text of diff.
Eventually I got your example to work after I removed '/reviews/' from
the url
http://example.review.com/r/9/diff/raw/
But that returns a plain unicode string of the diff instead of json or
xml.
Definitely better than nothing and I might end up using that, but I
just want to make sure there's no blessed api method for getting the
actual text of the diffs.
Thanks,
Dado
On Fri, 8 Jun 2012 00:47:43 -0700 (PDT), Ryan Raasch
ryan.raa...@gmail.com wrote:
On Friday, June 8, 2012 1:41:32 AM UTC+2, dado wrote: When updating a
review, post-review will tell you if the file changed
since it was last submitted for review.
How does it know that? Does RB save diffs for each request update?
As far as I can tell, it doesn't. Post-review generates a diff based
on the local
changes. It then posts this diff to the server. Which maintains
versions of the diff.
There are not diffs of diffs, only versions.
If so, how can I retrieve them via the web api?
Just use curl or wget with
http://example.review.com/reviews/r/9/diff/raw/
Thanks,
Dado
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/ [1]
Happy user? Let us know at http://www.reviewboard.org/users/ [2]
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en [3]
Links:
--
[1] http://www.reviewboard.org/donate/
[2] http://www.reviewboard.org/users/
[3] http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
how does post-review know if files changed?
When updating a review, post-review will tell you if the file changed since it was last submitted for review. How does it know that? Does RB save diffs for each request update? If so, how can I retrieve them via the web api? Thanks, Dado -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
