Re: how to review code files that are not in repository yet
Christian, Where should I look into for this? is it postreview.py? thanks, Deniz On Sep 25, 3:17 pm, Christian Hammond chip...@chipx86.com wrote: You being Deniz, not Chris, unless Chris wants to take this on too. :) Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Sep 25, 2009 at 3:17 PM, Christian Hammond chip...@chipx86.comwrote: Yeah, sounds like a bug in the CVS support. If you can figure out what's causing it and contribute a fix, that would help. I won't be able to look at it for a little while. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Sep 25, 2009 at 3:16 PM, Chris Clark chris.cl...@ingres.comwrote: Maybe this is a CVS specific issue? I know add file/diffs works for svn (and my SCM backend which I've added support for to ReviewBoard but it is a closed source SCM). Maybe take a look the diff processors for CVS and SVN? See if you spot anything, my best guess is that cvs error below is not being recorded to stdout in a form that reviewboard diff processor can recognize. Chris Deniz wrote: Thank you, Christian. I tried cvs add but then I got the following result: cvs diff: file_name is a new entry, no comparison available I am trying review board for facilitating our code review practice. We have a primitive mechanism around cvs and bugzilla for post-commit reviews but we do not have anything for facilitating pre-commit reviews. I would especially like to be able to create review request with a code file without diff. It looks like it may be possible to write a repository class for review board to allow that. On the other hand, I have tried to post-review tool as well but I could not get it work. I am getting the following error: Error creating review request: The repository path specified is not in the list of known repositories (code 206) I put the following line into .reviewboardrc file: REVIEWBOARD_URL = http://16.87.52.66:8080/; And, review-board repository settings are as follows: Hosting Service: Custom Repository Type: CVS Path: cvs:/var/cvs Mirror Path: Username: my_cvs_username Password: my_cvs_password I have seen couple email threads discussing the same issue and your responses to them; but somehow I still could not get this work. Thanks again, Deniz On Sep 25, 12:41 pm, Christian Hammond chip...@chipx86.com wrote: You just need to cvs add these files and then generate a diff. This model (pre-commit reviews) are actually the model we had in mind when writing Review Board. We highly recommend using post-review for diff generation and uploading. It will make life much easier. You can get this by: easy_install -U RBTools See the docs on the website for usage instructions. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Sep 25, 2009 at 9:36 AM, Deniz denizde...@gmail.com wrote: Is there any way to create review request for code files that are not added into CVS repository yet? I would like to be able to send review requests for classes that I am writing first time and not yet added into CVS. thanks, Deniz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: how to review code files that are not in repository yet
Yep. You'll want to look at the CVSClient class, specifically the diff code. It's not too big and is hopefully mostly obvious (in terms of how the commands are constructed and all). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Sep 29, 2009 at 4:32 PM, Deniz denizde...@gmail.com wrote: Christian, Where should I look into for this? is it postreview.py? thanks, Deniz On Sep 25, 3:17 pm, Christian Hammond chip...@chipx86.com wrote: You being Deniz, not Chris, unless Chris wants to take this on too. :) Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Sep 25, 2009 at 3:17 PM, Christian Hammond chip...@chipx86.com wrote: Yeah, sounds like a bug in the CVS support. If you can figure out what's causing it and contribute a fix, that would help. I won't be able to look at it for a little while. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Sep 25, 2009 at 3:16 PM, Chris Clark chris.cl...@ingres.com wrote: Maybe this is a CVS specific issue? I know add file/diffs works for svn (and my SCM backend which I've added support for to ReviewBoard but it is a closed source SCM). Maybe take a look the diff processors for CVS and SVN? See if you spot anything, my best guess is that cvs error below is not being recorded to stdout in a form that reviewboard diff processor can recognize. Chris Deniz wrote: Thank you, Christian. I tried cvs add but then I got the following result: cvs diff: file_name is a new entry, no comparison available I am trying review board for facilitating our code review practice. We have a primitive mechanism around cvs and bugzilla for post-commit reviews but we do not have anything for facilitating pre-commit reviews. I would especially like to be able to create review request with a code file without diff. It looks like it may be possible to write a repository class for review board to allow that. On the other hand, I have tried to post-review tool as well but I could not get it work. I am getting the following error: Error creating review request: The repository path specified is not in the list of known repositories (code 206) I put the following line into .reviewboardrc file: REVIEWBOARD_URL = http://16.87.52.66:8080/; And, review-board repository settings are as follows: Hosting Service: Custom Repository Type: CVS Path: cvs:/var/cvs Mirror Path: Username: my_cvs_username Password: my_cvs_password I have seen couple email threads discussing the same issue and your responses to them; but somehow I still could not get this work. Thanks again, Deniz On Sep 25, 12:41 pm, Christian Hammond chip...@chipx86.com wrote: You just need to cvs add these files and then generate a diff. This model (pre-commit reviews) are actually the model we had in mind when writing Review Board. We highly recommend using post-review for diff generation and uploading. It will make life much easier. You can get this by: easy_install -U RBTools See the docs on the website for usage instructions. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Sep 25, 2009 at 9:36 AM, Deniz denizde...@gmail.com wrote: Is there any way to create review request for code files that are not added into CVS repository yet? I would like to be able to send review requests for classes that I am writing first time and not yet added into CVS. thanks, Deniz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
how to review code files that are not in repository yet
Is there any way to create review request for code files that are not added into CVS repository yet? I would like to be able to send review requests for classes that I am writing first time and not yet added into CVS. thanks, Deniz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: how to review code files that are not in repository yet
You just need to cvs add these files and then generate a diff. This model (pre-commit reviews) are actually the model we had in mind when writing Review Board. We highly recommend using post-review for diff generation and uploading. It will make life much easier. You can get this by: easy_install -U RBTools See the docs on the website for usage instructions. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Sep 25, 2009 at 9:36 AM, Deniz denizde...@gmail.com wrote: Is there any way to create review request for code files that are not added into CVS repository yet? I would like to be able to send review requests for classes that I am writing first time and not yet added into CVS. thanks, Deniz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: how to review code files that are not in repository yet
Thank you, Christian. I tried cvs add but then I got the following result: cvs diff: file_name is a new entry, no comparison available I am trying review board for facilitating our code review practice. We have a primitive mechanism around cvs and bugzilla for post-commit reviews but we do not have anything for facilitating pre-commit reviews. I would especially like to be able to create review request with a code file without diff. It looks like it may be possible to write a repository class for review board to allow that. On the other hand, I have tried to post-review tool as well but I could not get it work. I am getting the following error: Error creating review request: The repository path specified is not in the list of known repositories (code 206) I put the following line into .reviewboardrc file: REVIEWBOARD_URL = http://16.87.52.66:8080/; And, review-board repository settings are as follows: Hosting Service: Custom Repository Type: CVS Path: cvs:/var/cvs Mirror Path: Username: my_cvs_username Password: my_cvs_password I have seen couple email threads discussing the same issue and your responses to them; but somehow I still could not get this work. Thanks again, Deniz On Sep 25, 12:41 pm, Christian Hammond chip...@chipx86.com wrote: You just need to cvs add these files and then generate a diff. This model (pre-commit reviews) are actually the model we had in mind when writing Review Board. We highly recommend using post-review for diff generation and uploading. It will make life much easier. You can get this by: easy_install -U RBTools See the docs on the website for usage instructions. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Sep 25, 2009 at 9:36 AM, Deniz denizde...@gmail.com wrote: Is there any way to create review request for code files that are not added into CVS repository yet? I would like to be able to send review requests for classes that I am writing first time and not yet added into CVS. thanks, Deniz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: how to review code files that are not in repository yet
Yeah, sounds like a bug in the CVS support. If you can figure out what's causing it and contribute a fix, that would help. I won't be able to look at it for a little while. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Sep 25, 2009 at 3:16 PM, Chris Clark chris.cl...@ingres.com wrote: Maybe this is a CVS specific issue? I know add file/diffs works for svn (and my SCM backend which I've added support for to ReviewBoard but it is a closed source SCM). Maybe take a look the diff processors for CVS and SVN? See if you spot anything, my best guess is that cvs error below is not being recorded to stdout in a form that reviewboard diff processor can recognize. Chris Deniz wrote: Thank you, Christian. I tried cvs add but then I got the following result: cvs diff: file_name is a new entry, no comparison available I am trying review board for facilitating our code review practice. We have a primitive mechanism around cvs and bugzilla for post-commit reviews but we do not have anything for facilitating pre-commit reviews. I would especially like to be able to create review request with a code file without diff. It looks like it may be possible to write a repository class for review board to allow that. On the other hand, I have tried to post-review tool as well but I could not get it work. I am getting the following error: Error creating review request: The repository path specified is not in the list of known repositories (code 206) I put the following line into .reviewboardrc file: REVIEWBOARD_URL = http://16.87.52.66:8080/; And, review-board repository settings are as follows: Hosting Service: Custom Repository Type: CVS Path: cvs:/var/cvs Mirror Path: Username: my_cvs_username Password: my_cvs_password I have seen couple email threads discussing the same issue and your responses to them; but somehow I still could not get this work. Thanks again, Deniz On Sep 25, 12:41 pm, Christian Hammond chip...@chipx86.com wrote: You just need to cvs add these files and then generate a diff. This model (pre-commit reviews) are actually the model we had in mind when writing Review Board. We highly recommend using post-review for diff generation and uploading. It will make life much easier. You can get this by: easy_install -U RBTools See the docs on the website for usage instructions. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Sep 25, 2009 at 9:36 AM, Deniz denizde...@gmail.com wrote: Is there any way to create review request for code files that are not added into CVS repository yet? I would like to be able to send review requests for classes that I am writing first time and not yet added into CVS. thanks, Deniz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: how to review code files that are not in repository yet
You being Deniz, not Chris, unless Chris wants to take this on too. :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Sep 25, 2009 at 3:17 PM, Christian Hammond chip...@chipx86.comwrote: Yeah, sounds like a bug in the CVS support. If you can figure out what's causing it and contribute a fix, that would help. I won't be able to look at it for a little while. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Sep 25, 2009 at 3:16 PM, Chris Clark chris.cl...@ingres.comwrote: Maybe this is a CVS specific issue? I know add file/diffs works for svn (and my SCM backend which I've added support for to ReviewBoard but it is a closed source SCM). Maybe take a look the diff processors for CVS and SVN? See if you spot anything, my best guess is that cvs error below is not being recorded to stdout in a form that reviewboard diff processor can recognize. Chris Deniz wrote: Thank you, Christian. I tried cvs add but then I got the following result: cvs diff: file_name is a new entry, no comparison available I am trying review board for facilitating our code review practice. We have a primitive mechanism around cvs and bugzilla for post-commit reviews but we do not have anything for facilitating pre-commit reviews. I would especially like to be able to create review request with a code file without diff. It looks like it may be possible to write a repository class for review board to allow that. On the other hand, I have tried to post-review tool as well but I could not get it work. I am getting the following error: Error creating review request: The repository path specified is not in the list of known repositories (code 206) I put the following line into .reviewboardrc file: REVIEWBOARD_URL = http://16.87.52.66:8080/; And, review-board repository settings are as follows: Hosting Service: Custom Repository Type: CVS Path: cvs:/var/cvs Mirror Path: Username: my_cvs_username Password: my_cvs_password I have seen couple email threads discussing the same issue and your responses to them; but somehow I still could not get this work. Thanks again, Deniz On Sep 25, 12:41 pm, Christian Hammond chip...@chipx86.com wrote: You just need to cvs add these files and then generate a diff. This model (pre-commit reviews) are actually the model we had in mind when writing Review Board. We highly recommend using post-review for diff generation and uploading. It will make life much easier. You can get this by: easy_install -U RBTools See the docs on the website for usage instructions. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Sep 25, 2009 at 9:36 AM, Deniz denizde...@gmail.com wrote: Is there any way to create review request for code files that are not added into CVS repository yet? I would like to be able to send review requests for classes that I am writing first time and not yet added into CVS. thanks, Deniz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
