Re: open issue without code comment?
Sounds good, Christian. Thanks as always! On Saturday, August 15, 2015 at 7:09:45 PM UTC-4, Christian Hammond wrote: Hi Griffin, We have all the basic work done for this sort of feature, but we're holding off until 2.6 to land it. The reason is that we don't have a UI yet that we're happy with, and need to spend time really making that solid. Since we're just about to release the 2.5 release candidate, it's just too late to make this happen for 2.5. 2.6 is a highly-focused release, and my hope is that we'll begin the beta testing cycle by the end of the year. It will focus on general comments, further UI polish, and better support for integrating with other services (like Slack or automated code analysis services). Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Sat, Aug 15, 2015 at 12:00 PM, Griffin Myers griffin...@gmail.com javascript: wrote: I thought I would reopen this old thread to see if any innovations that I'm not aware of have occurred on this front or if others in the community have come up with new creative ways to address this problem. I've reached the conclusion that some folks really use the issue list as a crutch and have a tendency to overlook or forget about non-issue comments. Thus I've gotten to the point where I almost always open an issue for every comment I make, even if it is something that I view more as a question and not necessarily issue worthy, just so it will catch the submitter's eye. This is fine for files that are included in the diff, but where there are more global problems I find that I have no option but to discuss these in either the review header or footer section, and there is not a way to flag these as issues. I'd say about half the time things I bring up in the header/footer don't end up getting addressed until I bring them up a second time. I'd love to be able to open up arbitrary/unbound issue(s), or even just generally flag the the header/footer as containing an issue, but short of that it might be helpful if there was a little bit more of a visual delineation between the review header and the first comment (perhaps RB 2.5 will help with this, but I'm not using that in a production environment yet) . Has anyone else found good ways to ensure that problems called out in header/footer comments are not ignored? Thanks, Griffin On Friday, December 7, 2012 at 2:55:36 PM UTC-5, Christian Hammond wrote: Hi Matthew, There's no support for that today. This is less an issue thing and more a comment thing. We tie issues to comments, and comments to some part of a file/diff. The exception being that you can leave a general summary comment on a review, but that works differently internally and making it work in such a way where multiple issues could be filed would be a rather large change. I'm not sure what the best solution would be for your needs right now. Any solution would involve conceiving of and implementing a new design. Christian On Dec 7, 2012, at 11:52 AM, Matthew Woehlke mwoehlk...@gmail.com wrote: Is it possible to create an issue for a review request without it being associated with a code comment? (I don't see a way, but want to check if I'm missing something before filing an enhancement request.) The use case I am thinking of is that I go to test a patch and discover that it has e.g. introduced a behavioral regression, but don't know what specific code is the culprit. I think it makes sense for tracking purposes to be able to open an issue describing the problem, rather than just a review stating that a problem exists. Thanks, -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ ---
Re: open issue without code comment?
Hi Griffin, We have all the basic work done for this sort of feature, but we're holding off until 2.6 to land it. The reason is that we don't have a UI yet that we're happy with, and need to spend time really making that solid. Since we're just about to release the 2.5 release candidate, it's just too late to make this happen for 2.5. 2.6 is a highly-focused release, and my hope is that we'll begin the beta testing cycle by the end of the year. It will focus on general comments, further UI polish, and better support for integrating with other services (like Slack or automated code analysis services). Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Sat, Aug 15, 2015 at 12:00 PM, Griffin Myers griffin.k.my...@gmail.com wrote: I thought I would reopen this old thread to see if any innovations that I'm not aware of have occurred on this front or if others in the community have come up with new creative ways to address this problem. I've reached the conclusion that some folks really use the issue list as a crutch and have a tendency to overlook or forget about non-issue comments. Thus I've gotten to the point where I almost always open an issue for every comment I make, even if it is something that I view more as a question and not necessarily issue worthy, just so it will catch the submitter's eye. This is fine for files that are included in the diff, but where there are more global problems I find that I have no option but to discuss these in either the review header or footer section, and there is not a way to flag these as issues. I'd say about half the time things I bring up in the header/footer don't end up getting addressed until I bring them up a second time. I'd love to be able to open up arbitrary/unbound issue(s), or even just generally flag the the header/footer as containing an issue, but short of that it might be helpful if there was a little bit more of a visual delineation between the review header and the first comment (perhaps RB 2.5 will help with this, but I'm not using that in a production environment yet) . Has anyone else found good ways to ensure that problems called out in header/footer comments are not ignored? Thanks, Griffin On Friday, December 7, 2012 at 2:55:36 PM UTC-5, Christian Hammond wrote: Hi Matthew, There's no support for that today. This is less an issue thing and more a comment thing. We tie issues to comments, and comments to some part of a file/diff. The exception being that you can leave a general summary comment on a review, but that works differently internally and making it work in such a way where multiple issues could be filed would be a rather large change. I'm not sure what the best solution would be for your needs right now. Any solution would involve conceiving of and implementing a new design. Christian On Dec 7, 2012, at 11:52 AM, Matthew Woehlke mwoehlk...@gmail.com wrote: Is it possible to create an issue for a review request without it being associated with a code comment? (I don't see a way, but want to check if I'm missing something before filing an enhancement request.) The use case I am thinking of is that I go to test a patch and discover that it has e.g. introduced a behavioral regression, but don't know what specific code is the culprit. I think it makes sense for tracking purposes to be able to open an issue describing the problem, rather than just a review stating that a problem exists. Thanks, -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more
open issue without code comment?
Is it possible to create an issue for a review request without it being associated with a code comment? (I don't see a way, but want to check if I'm missing something before filing an enhancement request.) The use case I am thinking of is that I go to test a patch and discover that it has e.g. introduced a behavioral regression, but don't know what specific code is the culprit. I think it makes sense for tracking purposes to be able to open an issue describing the problem, rather than just a review stating that a problem exists. Thanks, -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: open issue without code comment?
Hi Matthew, There's no support for that today. This is less an issue thing and more a comment thing. We tie issues to comments, and comments to some part of a file/diff. The exception being that you can leave a general summary comment on a review, but that works differently internally and making it work in such a way where multiple issues could be filed would be a rather large change. I'm not sure what the best solution would be for your needs right now. Any solution would involve conceiving of and implementing a new design. Christian On Dec 7, 2012, at 11:52 AM, Matthew Woehlke mwoehlke.fl...@gmail.com wrote: Is it possible to create an issue for a review request without it being associated with a code comment? (I don't see a way, but want to check if I'm missing something before filing an enhancement request.) The use case I am thinking of is that I go to test a patch and discover that it has e.g. introduced a behavioral regression, but don't know what specific code is the culprit. I think it makes sense for tracking purposes to be able to open an issue describing the problem, rather than just a review stating that a problem exists. Thanks, -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: open issue without code comment?
On 2012-12-07 14:55, Christian Hammond wrote: On Dec 7, 2012, at 11:52 AM, Matthew Woehlke wrote: Is it possible to create an issue for a review request without it being associated with a code comment? (I don't see a way, but want to check if I'm missing something before filing an enhancement request.) There's no support for that today. This is less an issue thing and more a comment thing. We tie issues to comments, and comments to some part of a file/diff. The exception being that you can leave a general summary comment on a review, but that works differently internally and making it work in such a way where multiple issues could be filed would be a rather large change. Thanks; I opened http://code.google.com/p/reviewboard/issues/detail?id=2817. As a work-around, I suppose one can pick some random code on which to comment. However, it would be good if this could be added at some point. (We're looking at possibly replacing gerrit with RB, and this is sort of a missing-in-RB feature.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
