Hi all, since upgrading to ReviewBoard 1.7.11 (and then 1.7.12), review requests created by post-review and rbt post contain no actual data. The submitter (I'm using --submit-as) and repo are correct but summary, description, diff etc are all missing.
The debug output from rbt post indicates nothing went wrong: DEBUG:root:Making HTTP GET request to http://reviews.company/api/ DEBUG:root:Making HTTP GET request to http://reviews.company/api/info/ DEBUG:root:Running: svn diff --diff-cmd=diff -r 10602:10603 DEBUG:root:Running: svn info src/filename DEBUG:root:Making HTTP GET request to http://reviews.company/api/review-requests/ DEBUG:root:Making HTTP POST request to http://reviews.company/api/review-requests/ DEBUG:root:Making HTTP GET request to http://reviews.company/api/review-requests/188/diffs/ DEBUG:root:Making HTTP POST request to http://reviews.company/api/review-requests/188/diffs/ DEBUG:root:Making HTTP GET request to http://reviews.company/api/review-requests/188/draft/ DEBUG:root:Making HTTP PUT request to http://reviews.company/api/review-requests/188/draft/ Review request #188 posted. Running that svn diff command manually does give me the correct diff. On the server (Fedora 19) side, I don't really get anything useful: 192.168.1.43 reviews. - [07/Aug/2013:17:36:02 +0200] "GET /api/ HTTP/1.1" 200 5856 "-" "RBTools/0.5" 192.168.1.43 reviews. - [07/Aug/2013:17:36:02 +0200] "GET /api/info/ HTTP/1.1" 200 389 "-" "RBTools/0.5" 192.168.1.43 reviews. - [07/Aug/2013:17:36:02 +0200] "GET /api/review-requests/ HTTP/1.1" 200 16552 "-" "RBTools/0.5" 192.168.1.43 reviews. - [07/Aug/2013:17:36:02 +0200] "POST /api/review-requests/ HTTP/1.1" 201 1633 "-" "RBTools/0.5" 192.168.1.43 reviews. - [07/Aug/2013:17:36:02 +0200] "GET /api/review-requests/188/diffs/ HTTP/1.1" 200 255 "-" "RBTools/0.5" 192.168.1.43 reviews. - [07/Aug/2013:17:36:02 +0200] "POST /api/review-requests/188/diffs/ HTTP/1.1" 201 523 "-" "RBTools/0.5" 192.168.1.43 reviews. - [07/Aug/2013:17:36:02 +0200] "GET /api/review-requests/188/draft/ HTTP/1.1" 200 954 "-" "RBTools/0.5" 192.168.1.43 reviews. - [07/Aug/2013:17:36:02 +0200] "PUT /api/review-requests/188/draft/ HTTP/1.1" 200 1156 "-" "RBTools/0.5" 17:36:02 DEBUG - DiffParser.parse: Finished parsing diff. 17:36:02 DEBUG - DiffParser.parse: Beginning parse of diff, size = 2042 There is an earlier error from about the time this started, when somebody checked in something rather large, probably creating a branch (post-review is running from an svn post-commit hook): Aug 7 14:13:28 SWdev1 lighttpd: DEBUG:root:DiffParser.parse: Beginning parse of diff, size = 17436854 Aug 7 14:15:17 SWdev1 lighttpd: DEBUG:root:DiffParser.parse: Finished parsing diff. Aug 7 14:15:17 SWdev1 lighttpd: ERROR:root:Error uploading new diff: (2006, 'MySQL server has gone away') Aug 7 14:15:17 SWdev1 lighttpd: Traceback (most recent call last): Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/reviewboard/webapi/resources.py", line 2026, in create Aug 7 14:15:17 SWdev1 lighttpd: if not review_request.is_mutable_by(request.user): Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/reviewboard/reviews/forms.py", line 308, in create Aug 7 14:15:17 SWdev1 lighttpd: history) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/forms.py", line 158, in create Aug 7 14:15:17 SWdev1 lighttpd: status=status) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/django/db/models/base.py", line 363, in __init__ Aug 7 14:15:17 SWdev1 lighttpd: setattr(self, prop, kwargs.pop(prop)) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/models.py", line 95, in _set_diff Aug 7 14:15:17 SWdev1 lighttpd: binary_hash=hashkey, defaults={'binary': diff}) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/managers.py", line 20, in get_or_create Aug 7 14:15:17 SWdev1 lighttpd: return super(FileDiffDataManager, self).get_or_create(*args, **kwargs) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/django/db/models/manager.py", line 134, in get_or_create Aug 7 14:15:17 SWdev1 lighttpd: return self.get_query_set().get_or_create(**kwargs) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/django/db/models/query.py", line 452, in get_or_create Aug 7 14:15:17 SWdev1 lighttpd: obj.save(force_insert=True, using=self.db) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/django/db/models/base.py", line 463, in save Aug 7 14:15:17 SWdev1 lighttpd: self.save_base(using=using, force_insert=force_insert, force_update=force_update) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/django/db/models/base.py", line 551, in save_base Aug 7 14:15:17 SWdev1 lighttpd: result = manager._insert([self], fields=fields, return_id=update_pk, using=using, raw=raw) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/django/db/models/manager.py", line 203, in _insert Aug 7 14:15:17 SWdev1 lighttpd: return insert_query(self.model, objs, fields, **kwargs) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/django/db/models/query.py", line 1593, in insert_query Aug 7 14:15:17 SWdev1 lighttpd: return query.get_compiler(using=using).execute_sql(return_id) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 912, in execute_sql Aug 7 14:15:17 SWdev1 lighttpd: cursor.execute(sql, params) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/django/db/backends/mysql/base.py", line 114, in execute Aug 7 14:15:17 SWdev1 lighttpd: return self.cursor.execute(query, args) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/MySQLdb/cursors.py", line 174, in execute Aug 7 14:15:17 SWdev1 lighttpd: self.errorhandler(self, exc, value) Aug 7 14:15:17 SWdev1 lighttpd: File "/usr/lib/python2.7/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler Aug 7 14:15:17 SWdev1 lighttpd: raise errorclass, errorvalue Aug 7 14:15:17 SWdev1 lighttpd: DatabaseError: (2006, 'MySQL server has gone away') Any ideas or suggestions of where to look next? thanks, Steven. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
