Re: post-review and git: create reviews for already committed code
On Wednesday 09 September 2009 20:25:45 Dan Savilonis wrote: The currently released version of post-review is limited to very basic git functionality. You can't specify an arbitrary revision range. You can try my updated version here and see how it works: http://github.com/djs/rbtools/tree/postreview-git It didn't work but I fixed it. You can find the working code inside my git repository [1], I would be glad if you pull the fixes into your repo. Cheers Flavio [1] http://github.com/flavio/rbtools --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review and git: create reviews for already committed code
On Tuesday 15 September 2009 12:11:00 Christian Hammond wrote: Please submit code changes up on http://reviews.review-board.org/. I have selected RBTools as repository but I get this error message when I try to upload the diff: The file 'rbtools/postreview.py' (r2e2518f) could not be found in the repository Since in the beginning my git repository was a fork of Dan Savilonis' one, I decide to fork the official repository [1]. What should I do? Cheers Flavio [1] http://github.com/flavio/rbtools --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review and git: create reviews for already committed code
You'll need the nightly of RBTools (instructions below), or generate a diff manually with `git diff --full-index`. To get the nightly: easy_install -f http://downloads.review-board.org/nightlies -U RBTools Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Sep 15, 2009 at 3:40 AM, Flavio Castelli flavio.caste...@gmail.comwrote: On Tuesday 15 September 2009 12:11:00 Christian Hammond wrote: Please submit code changes up on http://reviews.review-board.org/. I have selected RBTools as repository but I get this error message when I try to upload the diff: The file 'rbtools/postreview.py' (r2e2518f) could not be found in the repository Since in the beginning my git repository was a fork of Dan Savilonis' one, I decide to fork the official repository [1]. What should I do? Cheers Flavio [1] http://github.com/flavio/rbtools --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
