review with diff size greater than 1MB

2013-11-11 Thread Varun Jain
Hi Team, I am trying to post the review for single .thpl file (34k lines) with diff size more than 1MB, I am getting the error saying Review Board's max diff size limit is 1 MB. Is there any way to get out of this problem? Thanks, Varun -- Get the Review Board Power Pack at

Re: review with diff size greater than 1MB

2013-11-11 Thread David Trowbridge
Do you expect your reviewers to read through 34k lines and actually make useful comments? Good reviews cover 100-200 lines per hour, so that's a 170-340 hour job for someone, or approximately 4-8 weeks of a full-time employee. Diffs 1MB pretty much always contain autogenerated code, which