Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

2016-05-17 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47514/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-15951

Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source

2016-05-17 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47513/ --- Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and

Re: Review Request 47508: AMBARI-16721 - Host Filters : 'Alerts' value for 'HOST STATUS' filter is absent

2016-05-17 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47508/#review133698 --- Ship it! Ship It! - Zhe (Joe) Wang On May 18, 2016, 1:31

Re: Review Request 47506: AMBARI-16720. Update calculation logic for LLAP configs. AMBARI-16722. Change 'Number of LLAP Daemons', 'In-Memory Cache per Daemon', 'Maximum CPUs per Daemon' to be a 'Text

2016-05-17 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47506/#review133692 --- Ship it! We have gone through the code change in person. -

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-05-17 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47428/ --- (Updated May 18, 2016, 3:09 a.m.) Review request for Ambari and Robert Levas.

Re: Review Request 47506: AMBARI-16720. Update calculation logic for LLAP configs. AMBARI-16722. Change 'Number of LLAP Daemons', 'In-Memory Cache per Daemon', 'Maximum CPUs per Daemon' to be a 'Text

2016-05-17 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47506/ --- (Updated May 18, 2016, 1:57 a.m.) Review request for Ambari, Alejandro

Review Request 47506: AMBARI-16720. Update calculation logic for LLAP configs. AMBARI-16722. Change 'Number of LLAP Daemons', 'In-Memory Cache per Daemon', 'Maximum CPUs per Daemon' to be a 'Text Box'

2016-05-17 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47506/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Nate Cole
> On May 17, 2016, 2:23 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml, > > line 166 > > > > > > Does the group name have to be unique now or is this

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

2016-05-17 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47438/#review133662 --- Ship it! Ship It! - Sumit Mohanty On May 17, 2016, 12:51

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

2016-05-17 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47438/#review133661 --- Ship it! Ship It! - Aravindan Vijayan On May 17, 2016,

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

2016-05-17 Thread Sid Wagle
> On May 17, 2016, 1:52 a.m., Sid Wagle wrote: > > Just realized I am missing UpgradeCatalog changes, will add subsequent > > patch. No need for upgrade steps since the Catalog deletes all standard deviation alerts which get added back on server restart. - Sid

Re: Review Request 47455: AMBARI-16702 Zeppelin cluster deployment fails due to unavailability of zeppelin service check script

2016-05-17 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47455/#review133636 ---

Re: Review Request 47456: Takeover config merge should handle AMS hbase configs

2016-05-17 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47456/#review133634 ---

Re: Review Request 47456: Takeover config merge should handle AMS hbase configs

2016-05-17 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47456/#review133631 ---

Re: Review Request 47434: Remove unused parameters from hawq-site.xml

2016-05-17 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47434/#review133630 --- Ship it! Ship It! - Matt On May 16, 2016, 5:14 p.m.,

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Tim Thorpe
> On May 17, 2016, 5:39 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java, > > line 829 > > > > > > What about RestartGrouping, ColocatedGrouping,

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Tim Thorpe
> On May 17, 2016, 2:30 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java, > > lines 822-831 > > > > > > Visitor or abstract method? Added the

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-05-17 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47428/ --- (Updated May 17, 2016, 7:58 p.m.) Review request for Ambari and Robert Levas.

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

2016-05-17 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46738/#review133610 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 13, 2016, 7:09

Review Request 47488: Ambari copies jdbc driver jar into hadoop/lib and haoop-yarn/lib

2016-05-17 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47488/ --- Review request for Ambari, Andrew Onischuk, Mugdha Varadkar, and Sumit Mohanty.

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Tim Thorpe
> On May 17, 2016, 6:23 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java, > > line 485 > > > > > > May want to check that upgradeFile is not null

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Tim Thorpe
> On May 17, 2016, 6:33 a.m., Jayush Luniya wrote: > > Can you add unit test coverage? > > Jayush Luniya wrote: > We should have unit tests in particular to validate incorrectly authored > service upgrade packs. What happens if we add a circular dependency (example: > KAFKA is marked with

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Tim Thorpe
> On May 17, 2016, 6:23 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml, > > line 166 > > > > > > Does the group name have to be unique now or is this

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45169/#review133587 ---

Review Request 47480: AMBARI-16714: Pull 'Groups' txt shown on Alert details filters from the messages.js file

2016-05-17 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47480/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-16714

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Jayush Luniya
> On May 17, 2016, 5:39 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java, > > line 844 > > > > > > The after tag is overloaded. Meaning it could mean insert

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45169/#review133556 ---

Re: Review Request 47452: Do not use implicit routing by default in solr-client

2016-05-17 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47452/#review133578 --- Ship it! Ship It! - Robert Nettleton On May 17, 2016, 1:29

Re: Review Request 47439: Enabling/Disabling interactive query should sustain browser refreshes

2016-05-17 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47439/#review133575 --- Ship it! Ship It! - Zhe (Joe) Wang On May 17, 2016, 12:57

Re: Review Request 47467: Hive View does not work with multi-bytes characters

2016-05-17 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47467/ --- (Updated May 17, 2016, 3:27 p.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 47465: hostname start to have localhost value in ambari-agent.ini file after upgrade from 2.2.0.0 to 2.4.0.0

2016-05-17 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47465/#review133546 --- Ship it! Ship It! - Dmitro Lisnichenko On May 17, 2016,

Review Request 47460: Explain script on pig views encountered an IOExecption

2016-05-17 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47460/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45169/#review133533 ---

Re: Review Request 47456: Takeover config merge should handle AMS hbase configs

2016-05-17 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47456/ --- (Updated May 17, 2016, 2:16 p.m.) Review request for Ambari and Vitalyi

Re: Review Request 47457: Hive Service check is failed after Upgrade to 2.4.0.0 :[ core.exceptions.Fail / "error":"No user found]

2016-05-17 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47457/#review133540 --- Ship it! Ship It! - Vitalyi Brodetskyi On Травень 17, 2016,

Review Request 47457: Hive Service check is failed after Upgrade to 2.4.0.0 :[ core.exceptions.Fail / "error":"No user found]

2016-05-17 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47457/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-16705

Re: Review Request 47306: Ambari Admin Privilege required for Pig and Hive View. 403 error received when opening Pig View by a non-admin user

2016-05-17 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47306/#review133539 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 12, 2016, 1:29

Review Request 47456: Takeover config merge should handle AMS hbase configs

2016-05-17 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47456/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-16703

Review Request 47455: AMBARI-16702 Zeppelin cluster deployment fails due to unavailability of zeppelin service check script

2016-05-17 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47455/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Rohit Choudhary,

Re: Review Request 45810: zeppelin_log_dir change leads to fail for different Zeppelin Notebook service actions

2016-05-17 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45810/#review133536 --- Ship it! - Renjith Kamath On April 6, 2016, 1:10 p.m., Sagar

Re: Review Request 47452: Do not use implicit routing by default in solr-client

2016-05-17 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47452/ --- (Updated May 17, 2016, 1:29 p.m.) Review request for Ambari, Don Bosco Durai,

Re: Review Request 47427: Atlas Server script error during upgrade.

2016-05-17 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47427/#review133528 --- Ship it! Ship It! - Robert Levas On May 16, 2016, 5:53

Re: Review Request 47397: Consistent logsearch/logfeeder property names

2016-05-17 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47397/ --- (Updated May 17, 2016, 12:28 p.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 47449: All HBase-HA deployment fail with 'Caught exception getting JMX metrics' in ambari server log

2016-05-17 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47449/#review133525 --- Ship it! Ship It! - Dmitro Lisnichenko On May 17, 2016,

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Tim Thorpe
> On May 17, 2016, 6:41 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java, > > line 685 > > > > > > UGM? This was just for testing purposes. I'll remove

Re: Review Request 47417: Replace '*' to hdp version in lzo packages

2016-05-17 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47417/ --- (Updated Травень 17, 2016, 10:24 до полудня) Review request for Ambari,

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-17 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/ --- (Updated May 17, 2016, 10:10 a.m.) Review request for Ambari, Alejandro

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-17 Thread Nitiraj Rathore
> On May 16, 2016, 4:48 p.m., Ajit Kumar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 320 > > > > > > Is maxId == 0 valid? yes it is valid. the id of

Re: Review Request 47297: Extend logging for ActionQueue's retry logic

2016-05-17 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47297/ --- (Updated máj. 17, 2016, 7:31 de) Review request for Ambari, Balázs Bence Sári,

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Jayush Luniya
> On May 17, 2016, 6:33 a.m., Jayush Luniya wrote: > > Can you add unit test coverage? We should have unit tests in particular to validate incorrectly authored service upgrade packs. What happens if we add a circular dependency (example: KAFKA is marked with KNOX and KNOX is marked with

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-17 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45169/#review133501 ---