Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/#review151429 --- Ship it! Ship It! - Robert Levas On Oct. 4, 2016, 6:40

Review Request 52535: Advanced storm-atlas-application.properties panel is not opened by default upon filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52535/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi Wang,

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 3, 2016, 1:17 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java, > > lines 955-960 > > > > > > roles may be set today, but in the future

Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/ --- (Updated Жов. 4, 2016, 10:40 після полудня) Review request for Ambari,

Re: Review Request 52528: Custom logsearch property should override default value

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52528/#review151415 --- Ship it! Ship It! - Oliver Szabo On Oct. 4, 2016, 9:19

Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/ --- Review request for Ambari, Alejandro Fernandez, Robert Levas, Sumit Mohanty,

Re: Review Request 52340: Refactor solr layer in logsearch

> On Oct. 4, 2016, 9:36 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractConverterAware.java, > > line 42 > > > > > > A cast like

Review Request 52529: Fix typo in the logsearch input config of Falcon

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52529/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and

Re: Review Request 52340: Refactor solr layer in logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/#review151225 --- Fix it, then Ship it! The patch looks fine to me.

Review Request 52528: Custom logsearch property should override default value

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52528/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 52500: AMBARI-18520: Ambari usernames should not be converted to lowercase before storing in the DB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52500/#review151385 --- Ship it! Ship It! - Robert Levas On Oct. 4, 2016, 4:14

Re: Review Request 52500: AMBARI-18520: Ambari usernames should not be converted to lowercase before storing in the DB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52500/#review151383 --- Ship it! Ship It! - Sumit Mohanty On Oct. 4, 2016, 8:14

Re: Review Request 52500: AMBARI-18520: Ambari usernames should not be converted to lowercase before storing in the DB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52500/#review151379 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 4, 2016,

Re: Review Request 52500: AMBARI-18520: Ambari usernames should not be converted to lowercase before storing in the DB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52500/ --- (Updated Oct. 4, 2016, 1:14 p.m.) Review request for Ambari, Mahadev Konar,

Re: Review Request 52513: Kafka widget update needs UpgradeCatalog handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52513/#review151378 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 4, 2016,

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Oct. 4, 2016, 7:18 p.m., Alexandr Antonenko wrote: > > UI changes are looking good, but you need also aprove from java developer Thank you Alex - Anita --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151374 --- Ship it! UI changes are looking good, but you need also aprove

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151367 --- Ship it! Ship It! - Di Li On Oct. 3, 2016, 11:25 p.m.,

Re: Review Request 52455: Ambari UI changes to support PAM authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/#review151355 --- Ship it! Ship It! - Alexandr Antonenko On Oct. 4, 2016,

Re: Review Request 52455: Ambari UI changes to support PAM authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/ --- (Updated Oct. 4, 2016, 4:38 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52455: Ambari UI changes to support PAM authentication

> On Oct. 3, 2016, 2:34 p.m., Alexandr Antonenko wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/index.html, line 162 > > > > > > I don't see this newly created file in diff files list. You were able >

Re: Review Request 52456: Modify HTTP headers to follow best security practices

> On Oct. 3, 2016, 9:10 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2234 > > > > > > "... for Ambari View requests." Thank you

Re: Review Request 52456: Modify HTTP headers to follow best security practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/ --- (Updated Oct. 4, 2016, 4:45 p.m.) Review request for Ambari, Di Li, Robert

Re: Review Request 52289: Regression: krb5JAASLogin.conf is not updated during secure BP install

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52289/#review151347 --- Ship it! Ship It! - Sandor Magyari On Oct. 3, 2016, 2:44

Review Request 52517: Ambari breaks sudo and user access if Ambari Agent misconfigured

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52517/ --- Review request for Ambari, Nate Cole and Vitalyi Brodetskyi. Bugs:

Re: Review Request 52455: Ambari UI changes to support PAM authentication

> On Oct. 3, 2016, 2:34 p.m., Alexandr Antonenko wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/index.html, line 162 > > > > > > I don't see this newly created file in diff files list. You were able >

Re: Review Request 52512: Use "enabled" suffix instead of "enable" for auth properties (LogSearch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52512/#review151334 --- Ship it! Ship It! - Robert Nettleton On Oct. 4, 2016, 1:17

Review Request 52513: Kafka widget update needs UpgradeCatalog handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52513/ --- Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.

Re: Review Request 52500: AMBARI-18520: Ambari usernames should not be converted to lowercase before storing in the DB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52500/#review151330 --- Ship it! Ship It! - Robert Levas On Oct. 3, 2016, 11:14

Re: Review Request 52512: Use "enabled" suffix instead of "enable" for auth properties (LogSearch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52512/#review151329 --- Ship it! Ship It! - Miklos Gergely On Oct. 4, 2016, 1:17

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 3, 2016, 4:17 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java, > > lines 955-960 > > > > > > roles may be set today, but in the future

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

> On Oct. 3, 2016, 4:17 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java, > > lines 64-70 > > > > > > Is both `ldapGroup` and `groupType` necessary...

Re: Review Request 52512: Use "enabled" suffix instead of "enable" for auth properties (LogSearch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52512/ --- (Updated Oct. 4, 2016, 1:17 p.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 52455: Ambari UI changes to support PAM authentication

> On Oct. 3, 2016, 2:34 p.m., Alexandr Antonenko wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/index.html, line 162 > > > > > > I don't see this newly created file in diff files list. You were able >

Re: Review Request 52512: Use "enabled" suffix instead of "enable" for auth properties (LogSearch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52512/ --- (Updated Oct. 4, 2016, 1:12 p.m.) Review request for Ambari, Miklos Gergely,

Review Request 52512: Use "enabled" suffix instead of "enable" for auth properties (LogSearch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52512/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, and

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/ --- (Updated Жов. 4, 2016, 12:43 після полудня) Review request for Ambari, Jaimin

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

> On Oct. 3, 2016, 10:57 p.m., Yusaku Sako wrote: > > When you say "local testing done", what did that entail? > > Also, did you explicitly build all the contrib/views modules with the > > change? Added the details. Thank you. - Zhe (Joe)

Re: Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52419/#review151315 --- Ship it! Ship It! - Laszlo Puskas On Oct. 4, 2016, 9:33

Re: Review Request 52496: AMBARI-18518 : Sinks should not try to read collector hosts from Zk if AMS is in embedded mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52496/#review151314 --- Ship it! Ship It! - Dmytro Sen On Окт. 3, 2016, 10:56 п.п.,

Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52504/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley,