Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

2016-10-05 Thread Mugdha Varadkar
> On Oct. 5, 2016, 5:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java, > > line 171 > > > > > > You can set this to

Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

2016-10-05 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52504/ --- (Updated Oct. 6, 2016, 5:57 a.m.) Review request for Ambari, Alejandro

Review Request 52586: AMBARI-18540: Unit test cases required for verifying Ambari username case sensitivity

2016-10-05 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52586/ --- Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Robert Levas,

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

2016-10-05 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review151604 --- Ship it! Ship It! - Richard Zang On Oct. 4, 2016, 12:51

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-05 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- (Updated Oct. 5, 2016, 11:51 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-05 Thread Amarnath reddy pappu
> On Oct. 5, 2016, 11:45 p.m., Alejandro Fernandez wrote: > > ambari-server/conf/unix/ambari.properties, line 78 > > > > > > What is the content of this log? > > > > Please add a branch and Jira to the code

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-05 Thread Amarnath reddy pappu
> On Oct. 5, 2016, 11:45 p.m., Alejandro Fernandez wrote: > > ambari-server/conf/unix/ambari.properties, line 78 > > > > > > What is the content of this log? > > > > Please add a branch and Jira to the code

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/#review151593 --- ambari-server/conf/unix/ambari.properties (line 78)

Review Request 52583: Request/access log feature in Ambari-server

2016-10-05 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and

Re: Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

2016-10-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52566/#review151554 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 5, 2016,

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

2016-10-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/#review151553 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 4, 2016,

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/#review151552 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 5, 2016,

Re: Review Request 52535: Advanced storm-atlas-application.properties panel is not opened by default upon filtering

2016-10-05 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52535/#review151551 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 4, 2016, 11:46

Re: Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

2016-10-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52566/ --- (Updated Oct. 5, 2016, 4:17 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52551: Update Mirosoft R version in mpack

2016-10-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52551/#review151549 --- Ship it! Ship It! - Jayush Luniya On Oct. 5, 2016, 12:31

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-10-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/#review151547 --- Ship it! Ship It! - Jayush Luniya On Sept. 30, 2016, 12:39

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

2016-10-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/#review151548 --- Ship it! Ship It! - Jayush Luniya On Oct. 4, 2016, 12:43

Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

2016-10-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52566/ --- Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-05 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/#review151543 --- Ship it! Ship It! - Robert Levas On Oct. 5, 2016, 12:38

Re: Review Request 52562: ADDENDUM. Categorize unit tests so can run mvn test -P $PROFILE

2016-10-05 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52562/#review151538 --- Ship it! Ship It! - Aravindan Vijayan On Oct. 5, 2016, 6:12

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-05 Thread Vitalyi Brodetskyi
> On Жов. 5, 2016, 5:30 після полудня, Alejandro Fernandez wrote: > > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 39 > > > > > > Fundamenetally, if we can't create varchar longer than 1000

Review Request 52562: ADDENDUM. Categorize unit tests so can run mvn test -P $PROFILE

2016-10-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52562/ --- Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.

Re: Review Request 52482: Optimize ClustersDeadlockTest

2016-10-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52482/#review151522 --- Ship it! Ship It! - Jonathan Hurley On Oct. 5, 2016, 7:26

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-05 Thread Alejandro Fernandez
> On Oct. 5, 2016, 5:30 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 39 > > > > > > Fundamenetally, if we can't create varchar longer than 1000 bytes > >

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/#review151520 --- ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql

Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

2016-10-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52504/#review151518 --- Fix it, then Ship it!

Re: Review Request 52532: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/ --- (Updated Жов. 5, 2016, 4:38 після полудня) Review request for Ambari,

Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

2016-10-05 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/#review151507 --- That happened to the change to the `blueprint_setting` table?

Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

2016-10-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/ --- (Updated Жов. 5, 2016, 3:28 після полудня) Review request for Ambari,

Re: Review Request 52554: AMBARI-18527 HostCleanup.py to be able to resolve wildcards in a dir or file path to a list of dirs and files

2016-10-05 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52554/#review151506 --- Ship it! Ship It! - Tim Thorpe On Oct. 5, 2016, 2:46 p.m.,

Review Request 52555: AMBARI-18535 Ambari is not picking up the latest repo for HDP-2.4

2016-10-05 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52555/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel

Review Request 52554: AMBARI-18527 HostCleanup.py to be able to resolve wildcards in a dir or file path to a list of dirs and files

2016-10-05 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52554/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-18527

Re: Review Request 52340: Refactor solr layer in logsearch

2016-10-05 Thread Oliver Szabo
> On Oct. 4, 2016, 9:36 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractConverterAware.java, > > line 42 > > > > > > A cast like

Review Request 52553: Fix regression issues for logsearch refactor

2016-10-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52553/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs:

Re: Review Request 52551: Update Mirosoft R version in mpack

2016-10-05 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52551/#review151497 --- Ship it! Ship It! - Attila Doroszlai On Oct. 5, 2016, 2:31

Review Request 52551: Update Mirosoft R version in mpack

2016-10-05 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52551/ --- Review request for Ambari, Attila Doroszlai, Jayush Luniya, and Sebastian

Re: Review Request 52482: Optimize ClustersDeadlockTest

2016-10-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52482/ --- (Updated Oct. 5, 2016, 11:26 a.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

2016-10-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52532/#review151487 --- Please test changes with different default encodings for MySQL.

Re: Review Request 52549: Components can't be started because of failed webhdfs request

2016-10-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52549/#review151484 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 5, 2016,

Review Request 52549: Components can't be started because of failed webhdfs request

2016-10-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52549/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18536