Re: Review Request 52601: Kerberos server actions should not timeout in minutes as specified in configuration

2016-10-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52601/#review151752 --- Ship it! Ship It! - Sid Wagle On Oct. 6, 2016, 2:36 p.m.,

Re: Review Request 52528: Custom logsearch property should override default value

2016-10-06 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52528/ --- (Updated Oct. 6, 2016, 11:47 p.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 51583: Add ability to add custom grok filters and custom grok patterns with Ambari

2016-10-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51583/#review151733 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 6, 2016,

Re: Review Request 52602: BP format does not generate property oozie.service.JPAService.jdbc.url

2016-10-06 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52602/ --- (Updated Жов. 6, 2016, 8:48 після полудня) Review request for Ambari,

Re: Review Request 52586: AMBARI-18540: Unit test cases required for verifying Ambari username case sensitivity

2016-10-06 Thread Nahappan Somasundaram
> On Oct. 6, 2016, 10:35 a.m., Alejandro Fernandez wrote: > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java, > > line 215 > > > > > > Can we combine some

Re: Review Request 52551: Update Mirosoft R version in mpack

2016-10-06 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52551/#review151686 --- Ship it! Ship It! - Sebastian Toader On Oct. 5, 2016, 2:31

Re: Review Request 52586: AMBARI-18540: Unit test cases required for verifying Ambari username case sensitivity

2016-10-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52586/#review151683 --- Fix it, then Ship it!

Re: Review Request 52517: Ambari breaks sudo and user access if Ambari Agent misconfigured

2016-10-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52517/ --- (Updated Oct. 6, 2016, 7:58 p.m.) Review request for Ambari, Nate Cole and

Re: Review Request 52586: AMBARI-18540: Unit test cases required for verifying Ambari username case sensitivity

2016-10-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52586/#review151678 --- Ship it! Ship It! - Sumit Mohanty On Oct. 6, 2016, 12:28

Re: Review Request 52607: oozie server start fails post upgrade to Ambari 2.4.1

2016-10-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52607/#review151671 --- Ship it! Ship It! - Dmytro Sen On Окт. 6, 2016, 4:18 п.п.,

Re: Review Request 52607: oozie server start fails post upgrade to Ambari 2.4.1

2016-10-06 Thread Victor Galgo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52607/#review151669 --- Ship it! Ship It! - Victor Galgo On Oct. 6, 2016, 4:18

Review Request 52607: oozie server start fails post upgrade to Ambari 2.4.1

2016-10-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52607/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18549

Re: Review Request 52606: No validation errors recieved for empty or removed hadoop.proxyuser.* properties

2016-10-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52606/#review151665 --- Ship it! Ship It! - Dmytro Sen On Окт. 6, 2016, 3:53 п.п.,

Re: Review Request 52517: Ambari breaks sudo and user access if Ambari Agent misconfigured

2016-10-06 Thread Dmitro Lisnichenko
> On Oct. 6, 2016, 5:45 p.m., Nate Cole wrote: > > ambari-agent/conf/unix/ambari-agent, lines 45-48 > > > > > > readlink -m can return an empty string as well Regarding readlink -m: property_name=${1:?} will fail if

Re: Review Request 52517: Ambari breaks sudo and user access if Ambari Agent misconfigured

2016-10-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52517/ --- (Updated Oct. 6, 2016, 6:52 p.m.) Review request for Ambari, Nate Cole and

Review Request 52606: No validation errors recieved for empty or removed hadoop.proxyuser.* properties

2016-10-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52606/ --- Review request for Ambari and Andrew Onischuk. Bugs: AMBARI-18547

Re: Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

2016-10-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52566/#review151654 --- Fix it, then Ship it!

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52583/#review151651 --- ambari-server/conf/unix/ambari.properties (line 78)

Re: Review Request 52517: Ambari breaks sudo and user access if Ambari Agent misconfigured

2016-10-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52517/#review151650 --- ambari-agent/conf/unix/ambari-agent (lines 45 - 48)

Re: Review Request 52601: Kerberos server actions should not timeout in minutes as specified in configuration

2016-10-06 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52601/ --- (Updated Oct. 6, 2016, 10:36 a.m.) Review request for Ambari, Sumit Mohanty

Re: Review Request 52601: Kerberos server actions should not timeout in minutes as specified in configuration

2016-10-06 Thread Robert Levas
> On Oct. 6, 2016, 10:11 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, > > line 144 > > > > > > Should this be outside as an Ambari Server

Re: Review Request 52601: Kerberos server actions should not timeout in minutes as specified in configuration

2016-10-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52601/#review151648 ---

Review Request 52602: BP format does not generate property oozie.service.JPAService.jdbc.url

2016-10-06 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52602/ --- Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, and

Review Request 52601: Kerberos server actions should not timeout in minutes as specified in configuration

2016-10-06 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52601/ --- Review request for Ambari, Sumit Mohanty and Sid Wagle. Bugs: AMBARI-18545

Re: Review Request 52483: Write unittests for configs.py

2016-10-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52483/#review151634 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 3, 2016,