Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

2017-05-19 Thread Sangeeta Ravindran
> On May 19, 2017, 2:56 p.m., Di Li wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > > Lines 150 (patched) > > > > > > nitpicking: remove console.log line. Hi Di, I have

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

2017-05-19 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59382/ --- (Updated May 19, 2017, 9:16 p.m.) Review request for Ambari, Alexandr

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

2017-05-19 Thread Sangeeta Ravindran
> On May 19, 2017, 8:23 a.m., Alexandr Antonenko wrote: > > Ship It! Thanks Alexandr. I also made on additional change to set the editableDisplayName to also be set based on the number of digits in the version. - Sangeeta --- This is

Re: Review Request 59312: Log Search use POJOs for input configuration

2017-05-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59312/#review175570 ---

Review Request 59418: Add ability to sink Raw metrics to external system via Http

2017-05-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59418/ --- Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.

Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

2017-05-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59232/#review175568 --- Ship it! Ship It! - Robert Nettleton On May 19, 2017, 4:36

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

2017-05-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59396/ --- (Updated May 19, 2017, 8:08 p.m.) Review request for Ambari, Laszlo Puskas,

Re: Review Request 59416: AMBARI-21068 : Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

2017-05-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59416/#review175565 --- Ship it! Ship It! - Sid Wagle On May 19, 2017, 7:57 p.m.,

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

2017-05-19 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59396/#review175564 --- Ship it! Ship It! - Miklos Gergely On May 19, 2017, 12:52

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

2017-05-19 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59396/#review175563 ---

Review Request 59416: AMBARI-21068 : Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

2017-05-19 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59416/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 59312: Log Search use POJOs for input configuration

2017-05-19 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59312/ --- (Updated May 19, 2017, 7:31 p.m.) Review request for Ambari, Oliver Szabo and

Re: Review Request 59401: Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

2017-05-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59401/#review175541 --- Can we make this property optional so that ambari upgrade does

Re: Review Request 59401: Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

2017-05-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59401/#review175532 --- Ship it! Ship It! - Sid Wagle On May 19, 2017, 3:36 p.m.,

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

2017-05-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59396/#review175529 --- Ship it! Ship It! - Robert Nettleton On May 19, 2017, 12:52

Review Request 59411: Cleanup temporary files needed for downloading client configurations response.

2017-05-19 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59411/ --- Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, and

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

2017-05-19 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59373/#review175527 --- Ship it! Ship It! - Sangeeta Ravindran On May 19, 2017,

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

2017-05-19 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59373/ --- (Updated May 19, 2017, 5:01 p.m.) Review request for Ambari, Alexandr

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

2017-05-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59373/#review175524 --- Ship it! Ship It! - Robert Nettleton On May 18, 2017, 6:27

Re: Review Request 59364: AMBARI-21053 Reverting Beacon stack advisor recommendation

2017-05-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59364/#review175516 --- Ship it! Ship It! - Jayush Luniya On May 18, 2017, 3:03

Re: Review Request 59401: Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

2017-05-19 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59401/ --- (Updated Май 19, 2017, 3:36 п.п.) Review request for Ambari, Aravindan

Re: Review Request 59151: Workflow Designer View: Provide sorting of workflows on dashboard

2017-05-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59151/#review175504 --- Ship it! Ship It! - Di Li On May 10, 2017, 6:33 p.m., Anita

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

2017-05-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59382/#review175503 ---

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

2017-05-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59373/#review175502 --- ambari-web/test/controllers/wizard/step8_test.js Line 2346

Re: Review Request 59400: Storm XML File has Invalid Characters Causing Exceptions on Server Startup

2017-05-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59400/#review175500 --- Ship it! Ship It! - Nate Cole On May 19, 2017, 10:22 a.m.,

Review Request 59400: Storm XML File has Invalid Characters Causing Exceptions on Server Startup

2017-05-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59400/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-21074

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

2017-05-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/#review175494 --- Ship it! Ship It! - Oliver Szabo On May 19, 2017, 9:41

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

2017-05-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59396/ --- (Updated May 19, 2017, 12:52 p.m.) Review request for Ambari, Laszlo Puskas,

Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

2017-05-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59396/ --- Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton,

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

2017-05-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/#review175492 --- Ship it! Ship It! - Sebastian Toader On May 19, 2017, 11:41

Review Request 59394: Race condition: webhdfs call mkdir /tmp/druid-indexing before /tmp making tmp not writable.

2017-05-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59394/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-21070

Re: Review Request 59367: Run execution commands sent to /user/commands

2017-05-19 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59367/#review175483 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 18,

Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger

2017-05-19 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/ --- (Updated May 19, 2017, 9:41 a.m.) Review request for Ambari, Attila Doroszlai,

Review Request 59391: Integrate RequestService resource and it's subresources with swagger

2017-05-19 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/ --- Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

2017-05-19 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59373/#review175476 --- Ship it! Ship It! - Alexandr Antonenko On May 18, 2017,

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

2017-05-19 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59382/#review175475 --- Ship it! Ship It! - Alexandr Antonenko On May 19, 2017,