Re: Review Request 61709: Ambari should expose whether a service is able to rolling-restart instead of hard coding service name

2017-08-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61709/#review183449 --- Ship it! Ship It! - Jayush Luniya On Aug. 17, 2017, 7:22

Re: Review Request 61786: AMBARI-21768. Spark History Server uses wrong log dir

2017-08-21 Thread Attila Doroszlai
> On Aug. 21, 2017, 10:59 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml > > Lines 380-381 (patched) > > > > > > I thought that we went through

Review Request 61803: zeppelin proxy user settings are not configured in core-site.xml on upgraded cluster from Ambari 2.4.2

2017-08-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61803/ --- Review request for Ambari, Balázs Bence Sári, Eugene Chekanskiy, Jonathan

Re: Review Request 61786: AMBARI-21768. Spark History Server uses wrong log dir

2017-08-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61786/#review183388 ---

Re: Review Request 61787: zeppelin principal and livy.superusers property do not match on upgraded cluster from Ambari 2.4.2 -and HDP 2.5.5

2017-08-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61787/#review183387 --- Ship it! Ship It! - Jonathan Hurley On Aug. 21, 2017, 12:34

Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value

2017-08-21 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61582/#review183386 --- Ship it! Ship It! - Myroslav Papirkovskyy On Сер. 21, 2017,

Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value

2017-08-21 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61582/ --- (Updated Сер. 21, 2017, 8:48 після полудня) Review request for Ambari,

Re: Review Request 61792: Spark1 Shuffle Property Is Removed Incorrectly on a Stack Upgrade

2017-08-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61792/#review183384 --- Ship it! Ship It! - Robert Levas On Aug. 21, 2017, 4:20

Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value

2017-08-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61582/#review183382 ---

Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value

2017-08-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61582/#review183381 --- Ship it! Ship It! - Sid Wagle On Aug. 21, 2017, 8:01 p.m.,

Review Request 61792: Spark1 Shuffle Property Is Removed Incorrectly on a Stack Upgrade

2017-08-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61792/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-21770

Re: Review Request 61786: AMBARI-21768. Spark History Server uses wrong log dir

2017-08-21 Thread Attila Doroszlai
> On Aug. 21, 2017, 8:28 p.m., Bikas Saha wrote: > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml > > Lines 380 (patched) > > > > > > This does not seem right because the log

Re: Review Request 61786: AMBARI-21768. Spark History Server uses wrong log dir

2017-08-21 Thread Attila Doroszlai
> On Aug. 21, 2017, 7:09 p.m., Di Li wrote: > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml > > Lines 379 (patched) > > > > > > Spark2 config in IOP 4.2.5 also has these

Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value

2017-08-21 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61582/ --- (Updated Сер. 21, 2017, 8:01 після полудня) Review request for Ambari,

Re: Review Request 61787: zeppelin principal and livy.superusers property do not match on upgraded cluster from Ambari 2.4.2 -and HDP 2.5.5

2017-08-21 Thread Robert Levas
> On Aug. 21, 2017, 3:48 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java > > Lines 187-189 (patched) > > > > > > How could this be null? You are

Re: Review Request 61787: zeppelin principal and livy.superusers property do not match on upgraded cluster from Ambari 2.4.2 -and HDP 2.5.5

2017-08-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61787/#review183373 --- Ship it!

Re: Review Request 61786: AMBARI-21768. Spark History Server uses wrong log dir

2017-08-21 Thread Bikas Saha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61786/#review183361 ---

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-21 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/#review183359 --- Ship it! Ship It! - Balázs Bence Sári On Aug. 17, 2017,

Re: Review Request 61784: (preview) Service and Patch Upgrade Catalog Changes for 2.6 - patch for trunk

2017-08-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61784/#review183356 --- Ship it! Ship It! - Nate Cole On Aug. 21, 2017, 10:35 a.m.,

Re: Review Request 61785: When Matching New VDFs for Parent Repos only Consider STANDARD Types

2017-08-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61785/#review183355 --- Ship it! Ship It! - Nate Cole On Aug. 21, 2017, 11:54 a.m.,

Re: Review Request 61786: AMBARI-21768. Spark History Server uses wrong log dir

2017-08-21 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61786/#review183349 ---

Re: Review Request 61744: Allow for keytab regeneration to be filtered for hosts

2017-08-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61744/#review183348 --- Ship it! Ship It! - Robert Levas On Aug. 21, 2017, 12:31

Review Request 61787: zeppelin principal and livy.superusers property do not match on upgraded cluster from Ambari 2.4.2 -and HDP 2.5.5

2017-08-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61787/ --- Review request for Ambari, Bikas Saha, Balázs Bence Sári, Eugene Chekanskiy,

Re: Review Request 61744: Allow for keytab regeneration to be filtered for hosts

2017-08-21 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61744/ --- (Updated Aug. 21, 2017, 4:31 p.m.) Review request for Ambari, Robert Levas and

Re: Review Request 61786: AMBARI-21768. Spark History Server uses wrong log dir

2017-08-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61786/#review183346 --- Ship it! No 4.2.5 chnaged needed? - Sid Wagle On Aug. 21,

Review Request 61786: AMBARI-21768. Spark History Server uses wrong log dir

2017-08-21 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61786/ --- Review request for Ambari, Bikas Saha, Di Li, Jonathan Hurley, Sumit Mohanty,

Review Request 61785: When Matching New VDFs for Parent Repos only Consider STANDARD Types

2017-08-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61785/ --- Review request for Ambari, Dmytro Grinenko and Nate Cole. Bugs: AMBARI-21766

Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value

2017-08-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61582/#review183344 --- Ship it! Can you please add comments about how this fixes the

Review Request 61784: (preview) Service and Patch Upgrade Catalog Changes for 2.6 - patch for trunk

2017-08-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61784/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-21728

Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value

2017-08-21 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61582/ --- (Updated Сер. 21, 2017, 2:18 після полудня) Review request for Ambari,

Re: Review Request 61781: Cache hashes should not be reset after restart ; some ambari-server restart fixes

2017-08-21 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61781/ --- (Updated Aug. 21, 2017, 1:23 p.m.) Review request for Ambari, Alejandro

Review Request 61781: Cache hashes should not be reset after restart ; some ambari-server restart fixes

2017-08-21 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61781/ --- Review request for Ambari, Alejandro Fernandez, Dmytro Sen, and Sid Wagle.

Re: Review Request 61707: Pre-configure services when Kerberos is enabled to reduce number of core service restarts when services are added

2017-08-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61707/#review183327 --- Ship it!

Re: Review Request 61746: Prevent New Clusters from Being Provisioned With PATCH/MAINT Repos

2017-08-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61746/#review183326 --- Ship it! Ship It! - Robert Levas On Aug. 18, 2017, 9:23

Re: Review Request 61746: Prevent New Clusters from Being Provisioned With PATCH/MAINT Repos

2017-08-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61746/#review183325 --- Ship it! Ship It! - Nate Cole On Aug. 18, 2017, 9:23 p.m.,

Re: Review Request 61746: Prevent New Clusters from Being Provisioned With PATCH/MAINT Repos

2017-08-21 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61746/#review183324 --- Ship it! Ship It! - Dmytro Grinenko On Aug. 19, 2017, 1:23

Re: Review Request 61707: Pre-configure services when Kerberos is enabled to reduce number of core service restarts when services are added

2017-08-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61707/#review183323 --- Fix it, then Ship it! ```HDP/2.6/kerberos_preconfigure.json```

Re: Review Request 61743: Use latest-vdf for default when version is unspecified

2017-08-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61743/#review183316 --- Ship it! Ship It! - Sebastian Toader On Aug. 18, 2017, 6:03

Re: Review Request 61746: Prevent New Clusters from Being Provisioned With PATCH/MAINT Repos

2017-08-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61746/#review183315 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 19, 2017,

Re: Review Request 61501: Prevent users from authenticating if they exceed a configured number of login failures

2017-08-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61501/#review183313 --- Ship it! Ship It! - Robert Levas On Aug. 11, 2017, 3:32

Re: Review Request 61501: Prevent users from authenticating if they exceed a configured number of login failures

2017-08-21 Thread Robert Levas
> On Aug. 10, 2017, 2:26 p.m., Robert Levas wrote: > > Would it have been possble to add the lockout logic in > > `org.apache.ambari.server.security.authentication.AmbariAuthenticationEventHandlerImpl#onSuccessfulAuthentication`? > > I am not sure if chaning the _success_ to a _failure_ is

Re: Review Request 61205: Users randomly getting "HDFS020 Could not write file" exceptions while running query from Hive View

2017-08-21 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61205/ --- (Updated Aug. 21, 2017, 8:28 a.m.) Review request for Ambari, Gaurav Nagar,

Re: Review Request 61501: Prevent users from authenticating if they exceed a configured number of login failures

2017-08-21 Thread Attila Magyar
> On Aug. 10, 2017, 6:26 p.m., Robert Levas wrote: > > Would it have been possble to add the lockout logic in > > `org.apache.ambari.server.security.authentication.AmbariAuthenticationEventHandlerImpl#onSuccessfulAuthentication`? > > I am not sure if chaning the _success_ to a _failure_ is