Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-12-01 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63847/#review192606 --- Ship it! Ship It! - Yusaku Sako On Dec. 1, 2017, 11:16 p.m.,

Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-12-01 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63847/ --- (Updated Dec. 1, 2017, 11:16 p.m.) Review request for Ambari, Ishan Bhatt, Jaim

Re: Review Request 64261: Update LDAP Authentication process to work with improved user management facility

2017-12-01 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64261/ --- (Updated Dec. 1, 2017, 4:53 p.m.) Review request for Ambari, Attila Magyar, Bal

Review Request 64261: Update LDAP Authentication process to work with improved user management facility

2017-12-01 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64261/ --- Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy,

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-01 Thread Sid Wagle
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user > denie

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-01 Thread Nate Cole
> On Nov. 30, 2017, 4:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user > denie

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Jason Golieb
> On Dec. 1, 2017, 11:05 a.m., Andrii Tkach wrote: > > ambari-web/app/routes/installer.js > > Lines 291 (patched) > > > > > > Could you elaborate on your problem, cause Ember upgrade requires a > > huge change in th

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Jason Golieb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64225/ --- (Updated Dec. 1, 2017, 4:28 p.m.) Review request for Ambari, Alexandr Antonenko

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Andrii Tkach
> On Dec. 1, 2017, 11:05 a.m., Andrii Tkach wrote: > > ambari-web/app/routes/installer.js > > Lines 291 (patched) > > > > > > Could you elaborate on your problem, cause Ember upgrade requires a > > huge change in th

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Jason Golieb
> On Dec. 1, 2017, 11:05 a.m., Andrii Tkach wrote: > > ambari-web/app/routes/installer.js > > Lines 291 (patched) > > > > > > Could you elaborate on your problem, cause Ember upgrade requires a > > huge change in th

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64215/#review192480 --- Ship it! Ship It! - Robert Levas On Dec. 1, 2017, 5:09 a.m.,

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-01 Thread Andrew Onischuk
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user > denie

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-12-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64223/#review192471 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 30, 2017, 11:

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-01 Thread Andrew Onischuk
> On Nov. 30, 2017, 7:12 p.m., Sid Wagle wrote: > > Can you provide some notes on the manual testing effort on this? I did happy scenario. Also I did the one described in jira. Meaning: 1. Deny the license install Ambari 2. Check that gpl repos are not written to agent filesystem 3. Accept the l

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64225/#review192466 --- ambari-web/app/routes/installer.js Lines 291 (patched)

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64215/#review192460 --- Ship it! Ship It! - Attila Magyar On Dec. 1, 2017, 10:09 a.m

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

2017-12-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63516/ --- (Updated Dec. 1, 2017, 12:34 p.m.) Review request for Ambari, Jonathan Hurley a

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Sandor Molnar
> On Dec. 1, 2017, 9:03 a.m., Attila Magyar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > > Line 1454 (original), 1453 (patched) > > > > > > Do we s

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Sandor Molnar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64215/ --- (Updated Dec. 1, 2017, 10:09 a.m.) Review request for Ambari, Attila Magyar, Eu

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64215/#review192453 --- ambari-server/src/main/java/org/apache/ambari/server/controller/A

Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Sandor Molnar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64215/ --- Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.