Re: Review Request 57248: Visual explain is not routing to visual explain tab

2017-03-02 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57248/#review167699 --- Ship it! Ship It! - Abhishek Kumar On March 2, 2017, 6:08

Re: Review Request 57100: Select operators should not appear before fetch

2017-03-02 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57100/#review167658 --- Ship it! Ship It! - Abhishek Kumar On Feb. 27, 2017, 7:29

Re: Review Request 57100: Select operators should not appear before fetch

2017-02-28 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57100/#review167032 --- Ship it! Ship It! - Abhishek Kumar On Feb. 27, 2017, 7:29

Re: Review Request 56965: Hive 2: "insert udf" opens empty drop down

2017-02-22 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56965/#review166472 --- Ship it! Ship It! - Abhishek Kumar On Feb. 23, 2017, 3:40

Re: Review Request 56925: Hive2: Visual Explain - Eliminate "limit -1"

2017-02-22 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56925/#review166364 --- Ship it! Ship It! - Abhishek Kumar On Feb. 22, 2017, 2:12

Re: Review Request 56922: Hive2: Query in query editor is getting modified while navigating across different tabs

2017-02-21 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56922/#review166331 --- Ship it! Ship It! - Abhishek Kumar On Feb. 22, 2017, 7:24

Re: Review Request 56884: Hive 2: Visual Explain - Remove children in the JSON dump

2017-02-21 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56884/#review166171 --- Ship it! Ship It! - Abhishek Kumar On Feb. 21, 2017, 1:09

Re: Review Request 56884: Hive2: Visual Explain -Layout glitches of overlapping edges

2017-02-21 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56884/#review166160 --- Ship it! Ship It! - Abhishek Kumar On Feb. 21, 2017, 1:05

Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order

2017-02-20 Thread Abhishek Kumar
-build.js d53cdac Diff: https://reviews.apache.org/r/56756/diff/ Testing --- Manually Tested Thanks, Abhishek Kumar

Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order

2017-02-17 Thread Abhishek Kumar
/app/utils/hive-explainer/transformer.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/bower.json 9fa7076 contrib/views/hive20/src/main/resources/ui/ember-cli-build.js d53cdac Diff: https://reviews.apache.org/r/56756/diff/ Testing --- Manually Tested Thanks, Abhishek Kumar

Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order

2017-02-16 Thread Abhishek Kumar
/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js PRE-CREATION Diff: https://reviews.apache.org/r/56756/diff/ Testing --- Manually Tested Thanks, Abhishek Kumar

Re: Review Request 56572: Hive2. Visual Explain -Show additional info when you click on a box, i.e. can drill down to get more info on operators.

2017-02-11 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56572/#review165242 --- Ship it! - Abhishek Kumar On Feb. 11, 2017, 10:26 a.m

Re: Review Request 56483: HiveView2.0: DB panel shows up on Query result full screen

2017-02-11 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56483/#review165241 --- Ship it! - Abhishek Kumar On Feb. 11, 2017, 10:43 a.m

Re: Review Request 56542: Hive View 2.0 - deleting a saved query is buggy

2017-02-11 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56542/#review165240 --- Ship it! - Abhishek Kumar On Feb. 10, 2017, 12:27 p.m

Re: Review Request 55836: Hive View 2.0: Editor should be stretchable by dragging

2017-02-09 Thread Abhishek Kumar
iff: https://reviews.apache.org/r/55836/diff/ Testing --- manually tested. Thanks, Abhishek Kumar

Review Request 55839: Hive View 2.0: Code hints for query editor are not working

2017-01-23 Thread Abhishek Kumar
/resources/ui/app/components/query-editor.js 27d43d5 contrib/views/hive20/src/main/resources/ui/ember-cli-build.js e41c8e8 Diff: https://reviews.apache.org/r/55839/diff/ Testing --- Manually tested Thanks, Abhishek Kumar

Re: Review Request 55837: Hive View 2.0: Incorrect behaviour on select of database

2017-01-23 Thread Abhishek Kumar
g (updated) --- Manually tested Thanks, Abhishek Kumar

Review Request 55837: Hive View 2.0: Incorrect behaviour on select of database

2017-01-23 Thread Abhishek Kumar
o selected database 2. Hide tables related to unselected database and show tables for the selected one. Diffs - contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 950e4f3 Diff: https://reviews.apache.org/r/55837/diff/ Testing --- Thanks, Abhishek Kumar

Review Request 55836: Hive View 2.0: Editor should be stretchable by dragging

2017-01-23 Thread Abhishek Kumar
lly tested. Thanks, Abhishek Kumar