Re: Review Request 53602: Ambari can autoformat NameNode in a production cluster

2016-11-09 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53602/#review155428 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 9, 2016, 2

Re: Review Request 53575: Upgrade from 2.4.2 to 2.5 fails with DB consistency check

2016-11-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53575/#review155311 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 8, 2016, 6

Re: Review Request 53480: Add a cluster version directly as INSTALLED

2016-11-07 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53480/#review155116 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 4, 2016, 9

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-11-07 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review155115 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 7, 2016, 11

Review Request 53476: Rolling Upgrade From HDP 2.5.x to 2.5.y Doesn't hdp-select ZKFC

2016-11-04 Thread Dmitro Lisnichenko
'group': 'hadoop', 'cd_access': 'a'} 2016-11-02 18:38:21,547 - XmlConfig['ssl-client.xml'] {'owner': 'hdfs', 'group': 'hadoop', 'conf_dir': '/usr/hdp/2.5.2.0-67/hadoop/conf/secure', 'configuration_attributes': {}, 'configurations': ...} 2016-11-02 18:38:21,555 - Generating config: /usr/hdp/2.5.2.0-67/hadoop/conf/secure/ssl-client.xml 2016-11-02 18:38:21,555 - File['/usr/hdp/2.5.2.0-67/hadoop/conf/secure/ssl-client.xml'] {'owner': 'hdfs', 'content': InlineTemplate(...), 'group': 'hadoop', 'mode': None, 'encoding': 'UTF-8'} 2016-11-02 18:38:21,560 - XmlConfig['ssl-server.xml'] {'owner': 'hdfs', 'group': 'hadoop', 'conf_dir': '/usr/hdp/2.5.2.0-67/hadoop/conf', 'configuration_attributes': {}, 'configurations': ...} 2016-11-02 18:38:21,565 - Generating config: /usr/hdp/2.5.2.0-67/hadoop/conf/ssl-server.xml 2016-11-02 18:38:21,565 - File['/usr/hdp/2.5.2.0-67/hadoop/conf/ssl-server.xml'] {'owner': 'hdfs', 'content': InlineTemplate(...), 'group': 'hadoop', 'mode': None, 'encoding': 'UTF-8'} 2016-11-02 18:38:21,574 - XmlConfig['hdfs-site.xml'] {'owner': 'hdfs', 'group': 'hadoop', 'conf_dir': '/usr/hdp/2.5.2.0-67/hadoop/conf', 'configuration_attributes': {'final': {'dfs.datanode.failed.volumes.tolerated': 'true', 'dfs.datanode.data.dir': 'true', 'dfs.namenode.name.dir': 'true', 'dfs.support.append': 'true', 'dfs.webhdfs.enabled': 'true'}}, 'configurations': ...} 2016-11-02 18:38:21,583 - Generating config: /usr/hdp/2.5.2.0-67/hadoop/conf/hdfs-site.xml 2016-11-02 18:38:21,583 - File['/usr/hdp/2.5.2.0-67/hadoop/conf/hdfs-site.xml'] {'owner': 'hdfs', 'content': InlineTemplate(...), 'group': 'hadoop', 'mode': None, 'encoding': 'UTF-8'} 2016-11-02 18:38:21,627 - XmlConfig['core-site.xml'] {'group': 'hadoop', 'conf_dir': '/usr/hdp/2.5.2.0-67/hadoop/conf', 'mode': 0644, 'configuration_attributes': {'final': {'fs.defaultFS': 'true'}}, 'owner': 'hdfs', 'configurations': ...} 2016-11-02 18:38:21,633 - Generating config: /usr/hdp/2.5.2.0-67/hadoop/conf/core-site.xml 2016-11-02 18:38:21,633 - File['/usr/hdp/2.5.2.0-67/hadoop/conf/core-site.xml'] {'owner': 'hdfs', 'content': InlineTemplate(...), 'group': 'hadoop', 'mode': 0644, 'encoding': 'UTF-8'} 2016-11-02 18:38:21,651 - File['/usr/hdp/2.5.2.0-67/hadoop/conf/slaves'] {'content': Template('slaves.j2'), 'owner': 'hdfs'} 2016-11-02 18:38:21,652 - Directory['/var/run/hadoop'] {'owner': 'hdfs', 'group': 'hadoop', 'mode': 0755} 2016-11-02 18:38:21,652 - Changing owner for /var/run/hadoop from 0 to hdfs 2016-11-02 18:38:21,652 - Changing group for /var/run/hadoop from 0 to hadoop 2016-11-02 18:38:21,653 - Directory['/var/run/hadoop'] {'owner': 'hdfs', 'group': 'hadoop', 'mode': 0755} 2016-11-02 18:38:21,653 - Directory['/var/run/hadoop/hdfs'] {'owner': 'hdfs', 'group': 'hadoop', 'create_parents': True} 2016-11-02 18:38:21,654 - Directory['/var/log/hadoop/hdfs'] {'owner': 'hdfs', 'group': 'hadoop', 'create_parents': True} 2016-11-02 18:38:21,654 - File['/var/run/hadoop/hdfs/hadoop-hdfs-zkfc.pid'] {'action': ['delete'], 'not_if': 'ambari-sudo.sh -H -E test -f /var/run/hadoop/hdfs/hadoop-hdfs-zkfc.pid && ambari-sudo.sh -H -E pgrep -F /var/run/hadoop/hdfs/hadoop-hdfs-zkfc.pid'} 2016-11-02 18:38:21,661 - Execute['ambari-sudo.sh su hdfs -l -s /bin/bash -c 'ulimit -c unlimited ; /usr/hdp/2.5.2.0-67/hadoop/sbin/hadoop-daemon.sh --config /usr/hdp/2.5.2.0-67/hadoop/conf start zkfc''] {'environment': {'HADOOP_LIBEXEC_DIR': '/usr/hdp/2.5.2.0-67/hadoop/libexec'}, 'not_if': 'ambari-sudo.sh -H -E test -f /var/run/hadoop/hdfs/hadoop-hdfs-zkfc.pid && ambari-sudo.sh -H -E pgrep -F /var/run/hadoop/hdfs/hadoop-hdfs-zkfc.pid'} 2016-11-02 18:38:25,735 - Component has started with pid(s): 17307 {noformat} Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 9dfe666 Diff: https://reviews.apache.org/r/53476/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 53476: Rolling Upgrade From HDP 2.5.x to 2.5.y Doesn't hdp-select ZKFC

2016-11-04 Thread Dmitro Lisnichenko
/package/scripts/zkfc_slave.py <https://reviews.apache.org/r/53476/#comment224704> reason: method was not properly intended (static method vs instance method). That was not a syntax error due to fallback logic at script.py - Dmitro Lisnichenko On Nov. 4, 2016, 5:22 p.m.,

Re: Review Request 53433: Add orchestration for HOST_ORDERED upgrades

2016-11-04 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53433/#review154873 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 3, 2016, 8

Review Request 53430: HDP Upgrade fails when the cluster size is large

2016-11-03 Thread Dmitro Lisnichenko
don't have to deal with this issue again. Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py db52ee1 Diff: https://reviews.apache.org/r/53430/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-03 Thread Dmitro Lisnichenko
> On Nov. 2, 2016, 8:23 p.m., Dmitro Lisnichenko wrote: > > I see the upgrade pack for new upgrade type. Is downgrade possible? Is host > > order reversed during downgrade? > > Jonathan Hurley wrote: > Downgrades are possible, yes. Nothing is going to be "rever

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Dmitro Lisnichenko
possible? Is host order reversed during downgrade? - Dmitro Lisnichenko On Nov. 2, 2016, 8:09 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53263: During cluster install, Components get timed out icon while starting

2016-10-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53263/#review154128 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 28, 2016, 5

Re: Review Request 53220: Move HIVE, PIG, SPARK, SPARK2, SLIDER, SQOOP, ACCUMULO, FALCON, KNOX, , MAHOUT, TEZ role command orders from stack to service definitions

2016-10-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53220/#review154020 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 27, 2016, 2

Re: Review Request 53222: Move HDFS, HBASE YARN, GANGLIA, OOZIE RCO from stack to service level

2016-10-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53222/#review154018 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 27, 2016, 2

Re: Review Request 53221: Move ZOOKEEPER, KAFKA, STORM, RANGER, RANGER_KMS, AMS, KERBEROS role command orders from stack to service definition

2016-10-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53221/#review154019 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 27, 2016, 2

Re: Review Request 53225: Python UT fail on trunk

2016-10-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53225/#review154008 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 27, 2016, 4

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

2016-10-26 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53194/#review153895 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 26, 2016, 8

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

2016-10-26 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53194/#review153893 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 26, 2016, 7

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

2016-10-26 Thread Dmitro Lisnichenko
<https://reviews.apache.org/r/53194/#comment223415> is it secure? Is any user able to interrupt process and execute arbitrary python code from console? - Dmitro Lisnichenko On Oct. 26, 2016, 7:25 p.m., Andrew Onischuk

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-26 Thread Dmitro Lisnichenko
/ Testing --- few runs on live cluster mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-25 Thread Dmitro Lisnichenko
, Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-25 Thread Dmitro Lisnichenko
unit tests are being added Thanks, Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-25 Thread Dmitro Lisnichenko
/StackUpgradeFinishListenerTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java d22622e Diff: https://reviews.apache.org/r/53066/diff/ Testing (updated) --- few runs on live cluster mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 53142: Webhcat server start failed during EU with BindException

2016-10-25 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53142/#review153782 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 24, 2016, 8

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-24 Thread Dmitro Lisnichenko
/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml a3e4a64 Diff: https://reviews.apache.org/r/53066/diff/ Testing (updated) --- few runs on live cluster unit tests are being added Thanks, Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-24 Thread Dmitro Lisnichenko
-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml a3e4a64 Diff: https://reviews.apache.org/r/53066/diff/ Testing --- few runs on live cluster Thanks, Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-24 Thread Dmitro Lisnichenko
/stack_features.json dbde58b ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml a3e4a64 Diff: https://reviews.apache.org/r/53066/diff/ Testing --- few runs on live cluster Thanks, Dmitro Lisnichenko

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-24 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153697 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 24, 2016, 6

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-24 Thread Dmitro Lisnichenko
79) <https://reviews.apache.org/r/52420/#comment223114> typo - Dmitro Lisnichenko On Oct. 24, 2016, 6:18 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 53090: Storm becomes stopped by itself after upgrade from 2.2.1.0 to 2.4.1.0

2016-10-21 Thread Dmitro Lisnichenko
erver/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml e3e632b Diff: https://reviews.apache.org/r/53090/diff/ Testing --- Finishing test on live cluster mvn clean test Thanks, Dmitro Lisnichenko

Review Request 53090: Storm becomes stopped by itself after upgrade from 2.2.1.0 to 2.4.1.0

2016-10-21 Thread Dmitro Lisnichenko
s/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml a54c830 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml e3e632b Diff: https://reviews.apache.org/r/53090/diff/ Testing --- Finishing test on live cluster mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko
> On Oct. 20, 2016, 7:25 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java, > > line 127 > > <https://reviews.apache.org/r/53066/diff/1/?file=1542361#file1542361line127> > >

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko
cluster Thanks, Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko
/listeners/upgrade/StackVersionListener.java (line 127) <https://reviews.apache.org/r/53066/#comment222715> ComponentInfo refers to previous stack version during upgrade (and was never reloaded before this patch) - Dmitro Lisnichenko On Oct. 20, 2016, 7:24 p.m., Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko
runs on live cluster Thanks, Dmitro Lisnichenko

Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko
-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py aa0ab0f ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml a3e4a64 Diff: https://reviews.apache.org/r/53066/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 52979: NPE when a non-existent host is provided as part of the host filter

2016-10-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52979/#review153403 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016, 6

Re: Review Request 53051: Move LOGSEARCH role command order to common-services/LOGSEARCH

2016-10-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53051/#review153368 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016, 12

Re: Review Request 53052: Move ATLAS role command order to common-services/ATLAS

2016-10-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53052/#review153369 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016, 12

Re: Review Request 53054: Move AMBARI_INFRA role command order to common-services/AMBARI_INFRA

2016-10-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53054/#review153370 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016, 12

Re: Review Request 53050: Move ZEPPELIN role command order to common-services/ZEPPELIN

2016-10-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53050/#review153367 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 20, 2016, 12

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153069 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 18, 2016, 3

Re: Review Request 52979: NPE when a non-existent host is provided as part of the host filter

2016-10-18 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52979/#review153064 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 18, 2016, 10

Re: Review Request 52928: Give a reasonable error message when oozie service_check fails due to nodocs docker option

2016-10-17 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52928/#review152864 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 17, 2016, 3

Re: Review Request 52826: Increase forkCount for Ambari Server Unit Tests

2016-10-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52826/#review152527 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 13, 2016, 7

Re: Review Request 52517: Ambari breaks sudo and user access if Ambari Agent misconfigured

2016-10-06 Thread Dmitro Lisnichenko
ni) echo $value } {code} Diffs - ambari-agent/conf/unix/ambari-agent ccb0b7a Diff: https://reviews.apache.org/r/52517/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 52517: Ambari breaks sudo and user access if Ambari Agent misconfigured

2016-10-06 Thread Dmitro Lisnichenko
s - Dmitro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52517/#review151650 --- On Oct. 6, 2016, 6:52 p.m., Dmitro Lisnichenko

Re: Review Request 52517: Ambari breaks sudo and user access if Ambari Agent misconfigured

2016-10-06 Thread Dmitro Lisnichenko
int \$2}" /etc/ambari-agent/conf/ambari-agent.ini) echo $value } {code} Diffs (updated) - ambari-agent/conf/unix/ambari-agent ccb0b7a Diff: https://reviews.apache.org/r/52517/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Review Request 52606: No validation errors recieved for empty or removed hadoop.proxyuser.* properties

2016-10-06 Thread Dmitro Lisnichenko
, Dmitro Lisnichenko

Re: Review Request 52483: Write unittests for configs.py

2016-10-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52483/#review151634 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 3, 2016, 4

Review Request 52517: Ambari breaks sudo and user access if Ambari Agent misconfigured

2016-10-04 Thread Dmitro Lisnichenko
--- ambari-agent/conf/unix/ambari-agent ccb0b7a Diff: https://reviews.apache.org/r/52517/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

2016-10-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52457/#review151160 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 1, 2016, 2

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review151158 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 3, 2016, 12

Re: Review Request 52218: Fix ambari-server python test TestAmbariServer.py

2016-09-23 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52218/#review150173 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 23, 2016, 3

Re: Review Request 52124: Provide script to delete an old HDP stack version

2016-09-23 Thread Dmitro Lisnichenko
/custom_actions/_TestRemoveHDPVersion.py PRE-CREATION ambari-server/src/test/python/custom_actions/configs/remove_previous_stacks.json PRE-CREATION Diff: https://reviews.apache.org/r/52124/diff/ Testing --- Works on Centos Added unit tests Thanks, Dmitro Lisnichenko

Re: Review Request 52124: Provide script to delete an old HDP stack version

2016-09-23 Thread Dmitro Lisnichenko
/custom_actions/_TestRemoveHDPVersion.py PRE-CREATION ambari-server/src/test/python/custom_actions/configs/remove_previous_stacks.json PRE-CREATION Diff: https://reviews.apache.org/r/52124/diff/ Testing (updated) --- Works on Centos Added unit tests Thanks, Dmitro Lisnichenko

Re: Review Request 52159: SmartSense error during host assignment

2016-09-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52159/#review149992 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 22, 2016, 3

Re: Review Request 52160: Review necessity of xmllint and remove libxml2-utils package from Oozie manifest

2016-09-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52160/#review149991 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 22, 2016, 3

Re: Review Request 52158: On restarting service using APIs in Ambari, Ambari still says that service needs to be restarted on the UI

2016-09-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52158/#review149990 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 22, 2016, 3

Re: Review Request 52136: Add granular flags for sysprepped clusters to copy tarballs, Oozie share lib, fast jar, and create users

2016-09-22 Thread Dmitro Lisnichenko
t false is somewhat counter-intuitive - Dmitro Lisnichenko On Sept. 22, 2016, 12:53 a.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 52114: Atlas service check never fails

2016-09-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52114/#review149967 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 21, 2016

Review Request 52124: Provide script to delete an old HDP stack version

2016-09-21 Thread Dmitro Lisnichenko
/resources/custom_action_definitions/system_action_definitions.xml bc1c271 ambari-server/src/main/resources/custom_actions/scripts/remove_hdp_version.py PRE-CREATION Diff: https://reviews.apache.org/r/52124/diff/ Testing --- Works on Centos Adding unit tests Thanks, Dmitro Lisnichenko

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Dmitro Lisnichenko
/controller/test/BufferedThreadPoolExecutorCompletionServiceTest.java (line 34) <https://reviews.apache.org/r/52044/#comment217316> lol - Dmitro Lisnichenko On Sept. 20, 2016, 11:59 a.m., Vitalyi Brodetskyi wrote: > > -

Re: Review Request 52035: Improve agent logging to add more relevant message

2016-09-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52035/#review149471 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 19, 2016, 4

Re: Review Request 51961: Prerequisite checks should only check services that are getting upgraded

2016-09-19 Thread Dmitro Lisnichenko
/checks/ServicesNamenodeTruncateCheckTest.java (line 91) <https://reviews.apache.org/r/51961/#comment217079> todo seems to be not required here - Dmitro Lisnichenko On Sept. 16, 2016, 8:25 p.m., Nate Cole wrote: > > ---

Re: Review Request 51910: Update version-builder to include unique element

2016-09-15 Thread Dmitro Lisnichenko
test Thanks, Dmitro Lisnichenko

Review Request 51910: Update version-builder to include unique element

2016-09-15 Thread Dmitro Lisnichenko
/version-builder/example.py b9cdf56 contrib/version-builder/example.sh bc76fd0 contrib/version-builder/version_builder.py 2c07b0c Diff: https://reviews.apache.org/r/51910/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 51908: Analyze and Optimize Ambari Server Unit Tests - Group 3

2016-09-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51908/#review149046 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 15, 2016, 1

Re: Review Request 51903: [PREVIEW] Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-15 Thread Dmitro Lisnichenko
he same here and in other places - Dmitro Lisnichenko On Sept. 15, 2016, 4:57 a.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 51837: Make Execute timeout to be able to kill process trees which doesn't respond to SIGTERM

2016-09-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51837/#review148668 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 13, 2016

Re: Review Request 51806: ambari-agent check for unset variables (AMBARI-18317)

2016-09-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51806/#review148502 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 12, 2016, 4

Re: Review Request 51426: Journal node restart failing on RU from dergM10 to erie on Wire Encrypted cluster

2016-09-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51426/#review148478 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 25, 2016, 12

Review Request 51762: Declare URL uniqueness in repoinfo.xml

2016-09-09 Thread Dmitro Lisnichenko
ambari-server/src/test/resources/version_definition_test_all_services.xml 7557f7a Diff: https://reviews.apache.org/r/51762/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 51745: Setting fetch_nonlocal_groups to false Can Prevent Services From Starting

2016-09-09 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51745/#review148315 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 8, 2016, 11

Re: Review Request 51659: Ambari cannot install HDP from mirror list

2016-09-08 Thread Dmitro Lisnichenko
/upgrade/UpgradeCatalog200Test.java dcac986 Diff: https://reviews.apache.org/r/51659/diff/ Testing --- preview of patch (works on live cluster) Thanks, Dmitro Lisnichenko

Re: Review Request 51727: Need to validate behaviour and show warn message for user after hcat user was removed

2016-09-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51727/#review148179 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 8, 2016, 4

Re: Review Request 51530: Provide Notes On Service Config Changes During Ambari Upgrade

2016-09-07 Thread Dmitro Lisnichenko
) running unit tests Thanks, Dmitro Lisnichenko

Re: Review Request 51659: Ambari cannot install HDP from mirror list

2016-09-07 Thread Dmitro Lisnichenko
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51659/#review147878 --- On Sept. 6, 2016, 8:23 p.m., Dmitro Lisnichenko wrote: > >

Review Request 51659: Ambari cannot install HDP from mirror list

2016-09-06 Thread Dmitro Lisnichenko
/ Testing --- preview of patch (works on live cluster) Thanks, Dmitro Lisnichenko

Re: Review Request 51648: Ambari server start should log the class path being used

2016-09-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51648/#review147811 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 6, 2016, 1

Re: Review Request 51601: (2.5.0 fix) Ambari server upgrade script deletes all .pyc files

2016-09-05 Thread Dmitro Lisnichenko
ine, lets see if we can use a safer strategy such as changing the CWD and then deleting files. Diffs - ambari-agent/conf/unix/install-helper.sh 3614659 ambari-server/conf/unix/install-helper.sh 369a56a Diff: https://reviews.apache.org/r/51601/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Review Request 51601: (2.5.0 fix) Ambari server upgrade script deletes all .pyc files

2016-09-02 Thread Dmitro Lisnichenko
r strategy such as changing the CWD and then deleting files. Diffs - ambari-agent/conf/unix/install-helper.sh 3614659 ambari-server/conf/unix/install-helper.sh 369a56a Diff: https://reviews.apache.org/r/51601/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 51600: WebHCat service check should not depend on Pig

2016-09-02 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51600/#review147661 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 2, 2016, 5

Re: Review Request 51572: Ambari Server Start/Stop fails on Centos 7.1+

2016-09-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51572/#review147550 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 1, 2016, 12

Re: Review Request 51524: Hive service check failed

2016-08-31 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51524/#review147446 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 30, 2016, 4

Re: Review Request 51522: Add logging to differentiate between ambari-server start/restart commands vs. other commands

2016-08-31 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51522/#review147426 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 30, 2016, 8

Re: Review Request 51556: Processes children are not killed on timeout

2016-08-31 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51556/#review147425 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 31, 2016, 2

Re: Review Request 51557: status commands get all the *-env files irrespective of a service exists or not

2016-08-31 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51557/#review147424 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 31, 2016, 3

Review Request 51530: Provide Notes On Service Config Changes During Ambari Upgrade

2016-08-30 Thread Dmitro Lisnichenko
Diff: https://reviews.apache.org/r/51530/diff/ Testing --- checked on live cluster (attached screenshot to jira) running unit tests Thanks, Dmitro Lisnichenko

Review Request 51527: Ambari server upgrade script deletes all .pyc files

2016-08-30 Thread Dmitro Lisnichenko
and deletes ALL pyc files from the ambari server machine. Diffs - ambari-server/conf/unix/install-helper.sh 07c5e50 Diff: https://reviews.apache.org/r/51527/diff/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 51522: Add logging to differentiate between ambari-server start/restart commands vs. other commands

2016-08-30 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51522/#review147292 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 30, 2016, 3

Re: Review Request 51330: Certain configuration files cannot be modified through Ambari api.

2016-08-23 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51330/#review146527 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 23, 2016, 4

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-23 Thread Dmitro Lisnichenko
https://reviews.apache.org/r/51296/diff/ Testing (updated) --- on live cluster unit test run Thanks, Dmitro Lisnichenko

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Dmitro Lisnichenko
/ComponentInfo.java (line 53) <https://reviews.apache.org/r/51296/#comment212801> main fix is to remove default value - Dmitro Lisnichenko On Aug. 22, 2016, 9:25 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automati

Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Dmitro Lisnichenko
unit test run in progress Thanks, Dmitro Lisnichenko

Re: Review Request 51288: Restarting services with stale configs failed while starting oozie server

2016-08-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51288/#review146351 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 22, 2016, 5

Re: Review Request 51241: RU: Storm components were stopped during RU and can not be started

2016-08-22 Thread Dmitro Lisnichenko
-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 98e5038 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml e886301 Diff: https://reviews.apache.org/r/51241/diff/ Testing --- As of now, testing on live cluster Thanks, Dmitro Lisnichenko

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

2016-08-19 Thread Dmitro Lisnichenko
write new value). Extracted a separate method - Dmitro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/#review146182 ----------

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

2016-08-19 Thread Dmitro Lisnichenko
tacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 98e5038 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml e886301 Diff: https://reviews.apache.org/r/51241/diff/ Testing --- As of now, testing on live cluster Thanks, Dmitro Lisnichenko

Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

2016-08-19 Thread Dmitro Lisnichenko
upgrades/upgrade-2.5.xml e886301 Diff: https://reviews.apache.org/r/51241/diff/ Testing --- As of now, testing on live cluster Thanks, Dmitro Lisnichenko

Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

2016-08-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/#review146178 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 18, 2016, 10

<    1   2   3   4   5   6   7   8   >