Review Request 58416: Need to show decision conditions for decision node in Flow Graph tab

2017-04-13 Thread Madhan Reddy
-details.js e74c873 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 0c5257e Diff: https://reviews.apache.org/r/58416/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 58384: Coordinator Actions(workflows) are empty even when workflows are executed.

2017-04-12 Thread Madhan Reddy
, Madhan Reddy

Review Request 58341: Issue while adding custom job.properties

2017-04-11 Thread Madhan Reddy
efe8385 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs e3d49ec Diff: https://reviews.apache.org/r/58341/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 58230: Zooming workflows should happen more smoothly

2017-04-06 Thread Madhan Reddy
: https://reviews.apache.org/r/58230/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 58205: Centering workflows for zoom breaks when multiple tabs exists

2017-04-05 Thread Madhan Reddy
, Madhan Reddy

Review Request 58204: User should be able to visualize inherited properties while submitting the workflow

2017-04-05 Thread Madhan Reddy
/services/workflow-manager-configs-test.js PRE-CREATION Diff: https://reviews.apache.org/r/58204/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 58170: The Zoom feature in WFM, hides the WF completely either with Maximum and Min

2017-04-04 Thread Madhan Reddy
-renderer.js bfe59e2 Diff: https://reviews.apache.org/r/58170/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 58168: Need to auto populate the workflow parameters if its already defined in the global space

2017-04-04 Thread Madhan Reddy
/components/job-config.js e9c7c15 Diff: https://reviews.apache.org/r/58168/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 58135: Workflow should retain job.properties in submission modal window

2017-04-04 Thread Madhan Reddy
/r/58135/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 58138: Need to improve the grouping of the nodes available in transition section of WFM

2017-04-04 Thread Madhan Reddy
/src/main/resources/ui/app/templates/components/transition-config.hbs 83fe96c Diff: https://reviews.apache.org/r/58138/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 58134: Bad user experience in workflow credential creation

2017-04-04 Thread Madhan Reddy
Diff: https://reviews.apache.org/r/58134/diff/2/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 58139: Coordinator and bundle should retain job.properties in submission modal window

2017-04-04 Thread Madhan Reddy
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 0e35d0e Diff: https://reviews.apache.org/r/58139/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 58139: Coordinator and bundle should retain job.properties in submission modal window

2017-04-03 Thread Madhan Reddy
/resources/ui/app/templates/components/coord-config.hbs 0e35d0e Diff: https://reviews.apache.org/r/58139/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 58138: Need to improve the grouping of the nodes available in transition section of WFM

2017-04-03 Thread Madhan Reddy
/components/transition-config.hbs 83fe96c Diff: https://reviews.apache.org/r/58138/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 58134: Bad user experience in workflow credential creation

2017-04-03 Thread Madhan Reddy
-credentials.hbs 464221f Diff: https://reviews.apache.org/r/58134/diff/2/ Changes: https://reviews.apache.org/r/58134/diff/1-2/ Testing --- Manual Thanks, Madhan Reddy

Review Request 58135: Workflow should retain job.properties in submission modal window

2017-04-03 Thread Madhan Reddy
--- Manual Thanks, Madhan Reddy

Review Request 58134: Bad user experience in workflow credential creation

2017-04-03 Thread Madhan Reddy
/r/58134/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 57841: Make home directory check as optional in wfmanager view

2017-03-23 Thread Madhan Reddy
/resources/ui/app/routes/index.js 316ec0e Diff: https://reviews.apache.org/r/57841/diff/2/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 57841: Make home directory check as optional in wfmanager view

2017-03-23 Thread Madhan Reddy
/main/resources/ui/app/routes/index.js 316ec0e Diff: https://reviews.apache.org/r/57841/diff/2/ Changes: https://reviews.apache.org/r/57841/diff/1-2/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57841: Make home directory check as optional in wfmanager view

2017-03-22 Thread Madhan Reddy
: https://reviews.apache.org/r/57841/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57682: Workflow manager is only showing 10 actions for a workflow in dashboard

2017-03-16 Thread Madhan Reddy
/main/resources/ui/app/templates/components/workflow-job-details.hbs dd972b9 Diff: https://reviews.apache.org/r/57682/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57636: Need to improve log viewing on workflow manager

2017-03-15 Thread Madhan Reddy
://reviews.apache.org/r/57636/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57552: AMBARI-20413. The Zoom feature in WFM, hides the WF completely either with Maximum and Min

2017-03-13 Thread Madhan Reddy
/cytoscape-flow-renderer.js bfe59e2 Diff: https://reviews.apache.org/r/57552/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures

2017-03-10 Thread Madhan Reddy
Diff: https://reviews.apache.org/r/57505/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57445: AMBARI-20359. Not able to import workflow with fs action node

2017-03-08 Thread Madhan Reddy
://reviews.apache.org/r/57445/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path

2017-03-08 Thread Madhan Reddy
--- Manual Thanks, Madhan Reddy

Review Request 57414: AMBARI-20337. Need to show timer while loading coordinator name while bundle creation

2017-03-08 Thread Madhan Reddy
/57414/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path

2017-03-07 Thread Madhan Reddy
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 0b9adda Diff: https://reviews.apache.org/r/57412/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57289: AMBARI-20301. Ember should take node version specific to wfmanager

2017-03-03 Thread Madhan Reddy
--- Manual Thanks, Madhan Reddy

Review Request 57283: AMBARI-20295. Workflow manager view is not loading

2017-03-03 Thread Madhan Reddy
: https://reviews.apache.org/r/57283/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57267: AMBARI-20247. Show full error while importing the workflow from encrypted file

2017-03-02 Thread Madhan Reddy
/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java e1a5808 Diff: https://reviews.apache.org/r/57267/diff/1/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57029: AMBARI-20167. importing from workflow from the coordinator setup hangs

2017-02-24 Thread Madhan Reddy
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 7db5ce2 Diff: https://reviews.apache.org/r/57029/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 57027: AMBARI-20142. Job Link URL not working

2017-02-24 Thread Madhan Reddy
b5565c8 contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 309c281 contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-action-test.js PRE-CREATION Diff: https://reviews.apache.org/r/57027/diff/ Testing --- Manual Thanks, Madhan

Review Request 56979: AMBARI-20050. Issue while importing workflow with insufficient permissions

2017-02-23 Thread Madhan Reddy
-test.js PRE-CREATION Diff: https://reviews.apache.org/r/56979/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 56843: AMBARI-20077. Server Error when trying to save and not overwrite

2017-02-20 Thread Madhan Reddy
26e72d5 Diff: https://reviews.apache.org/r/56843/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 56598: AMBARI-19985. Workflow Manager Styling changes

2017-02-13 Thread Madhan Reddy
://reviews.apache.org/r/56598/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 56539: AMBARI-19956. Workflow Manager Flow Graph should show line transition to decision path and error node.

2017-02-10 Thread Madhan Reddy
/components/job-details.js 6507c49 Diff: https://reviews.apache.org/r/56539/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 56440: AMBARI-19920. Workfow Manger- Issue in flow graph active transitions in case of decision and fork.

2017-02-08 Thread Madhan Reddy
d0c5d11 contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js e410262 Diff: https://reviews.apache.org/r/56440/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 56207: AMBARI-19843. Publish asset has issues when different users logins

2017-02-02 Thread Madhan Reddy
/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java af86810 Diff: https://reviews.apache.org/r/56207/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 56168: AMBARI-19819. Styling changes and spelling fixes

2017-02-01 Thread Madhan Reddy
/r/56168/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 56068: AMBARI-19772. Job XML tag is not coming as part of FS action node

2017-01-29 Thread Madhan Reddy
://reviews.apache.org/r/56068/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 55840: AMBARI-19674. Asset Manager import and validation issues

2017-01-23 Thread Madhan Reddy
Thanks, Madhan Reddy

Review Request 55757: AMBARI-19647. Issue while submitting workflow as its not able to register as a project

2017-01-20 Thread Madhan Reddy
/views/wfmanager/src/main/resources/view.xml f2f520d Diff: https://reviews.apache.org/r/55757/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 55614: AMBARI-19581. Need to show proper error message in scenarios of failures with asset import

2017-01-17 Thread Madhan Reddy
/app/templates/components/asset-manager.hbs 0fa86b0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 80af968 Diff: https://reviews.apache.org/r/55614/diff/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 55418: AMBARI-19454. Label changes and missing fields for action nodes

2017-01-11 Thread Madhan Reddy
-action.hbs 52bdad5 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs ab2ebb2 Diff: https://reviews.apache.org/r/55418/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 55418: AMBARI-19454. Label changes and missing fields for action nodes

2017-01-11 Thread Madhan Reddy
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 52bdad5 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs ab2ebb2 Diff: https://reviews.apache.org/r/55418/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 55405: AMBARI-19453. Dashboard should display appropriate message if workflow data fetching api fails

2017-01-10 Thread Madhan Reddy
Thanks, Madhan Reddy

Review Request 55203: AMBARI-19380. Workflow Draft Save-Not working

2017-01-05 Thread Madhan Reddy
/components/flow-designer.hbs 6e1b054 Diff: https://reviews.apache.org/r/55203/diff/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 55133: AMBARI-19306: User is not able to validate/submit the workflow after browsing workflow path

2017-01-03 Thread Madhan Reddy
://reviews.apache.org/r/55133/diff/ Testing --- Manual Thanks, Madhan Reddy

Re: Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

2017-01-03 Thread Madhan Reddy
trib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java f98df0d Diff: https://reviews.apache.org/r/55130/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 55133: AMBARI-19306: User is not able to validate/submit the workflow after browsing workflow path

2017-01-03 Thread Madhan Reddy
/ Testing --- Manual Thanks, Madhan Reddy

Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

2017-01-03 Thread Madhan Reddy
ache/oozie/ambari/view/WorkflowFilesService.java f98df0d Diff: https://reviews.apache.org/r/55130/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 55014: AMBARI-19292: Asset Manager/Asset Upload/Asset import from DB

2016-12-23 Thread Madhan Reddy
-manager-test.js PRE-CREATION Diff: https://reviews.apache.org/r/55014/diff/ Testing --- Manual Thanks, Madhan Reddy

Review Request 55012: AMBARI-19291: User should be shown proper error message in file browser page

2016-12-23 Thread Madhan Reddy
/55012/diff/ Testing --- Manual Thanks, Madhan Reddy