Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/ --- (Updated June 7, 2016, 2:53 a.m.) Review request for Ambari, Alexander

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/#review136343 --- Ship it! Ship It! - Tim Thorpe On June 6, 2016, 6:40 p.m.,

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/#review136342 --- Ship it! Ship It! - Alejandro Fernandez On June 6, 2016,

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Lav Jain
> On June 6, 2016, 12:43 p.m., Tim Thorpe wrote: > > ambari-server/src/main/resources/stacks/service_advisor.py, line 67 > > > > > > I originally had implemented the service advisor like this. I had > > modified it

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/#review136240 ---

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-05 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/ --- (Updated June 5, 2016, 10:18 p.m.) Review request for Ambari, Alexander

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-03 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/ --- (Updated June 3, 2016, 9:26 p.m.) Review request for Ambari, Alexander