Re: Review Request 54958: Single API to download all client configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review160256 --- Ship it! Ship It! - Sid Wagle On Dec. 27, 2016, 4:16 p.m.,

Re: Review Request 54958: Single API to download all client configs

> On Dec. 27, 2016, 4:57 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 572 > > > > > > Do you depend on order of

Re: Review Request 54958: Single API to download all client configs

> On Dec. 27, 2016, 4:57 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 572 > > > > > > Do you depend on order of

Re: Review Request 54958: Single API to download all client configs

> On Dec. 27, 2016, 4:52 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2784 > > > > > > Minor nit but it is hard to understand what

Re: Review Request 54958: Single API to download all client configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review160172 ---

Re: Review Request 54958: Single API to download all client configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review160170 ---

Re: Review Request 54958: Single API to download all client configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review160087 --- Fix it, then Ship it!

Re: Review Request 54958: Single API to download all client configs

> On Dec. 22, 2016, 3:59 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java, > > line 299 > > > > > > Would rather use new File(parent, child)

Re: Review Request 54958: Single API to download all client configs

> On Dec. 22, 2016, 5:32 a.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 250 > > > > > > Suggestion friendlier naming

Re: Review Request 54958: Single API to download all client configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/ --- (Updated Dec. 23, 2016, 12:57 a.m.) Review request for Ambari, Jonathan

Re: Review Request 54958: Single API to download all client configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/ --- (Updated Dec. 23, 2016, 12:55 a.m.) Review request for Ambari, Jonathan

Re: Review Request 54958: Single API to download all client configs

> On Dec. 22, 2016, 12:32 a.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 240 > > > > > > Shouldn't this just log and

Re: Review Request 54958: Single API to download all client configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review159970 ---

Re: Review Request 54958: Single API to download all client configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review159924 ---