Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review126138 --- Ship it! Ship It! - Nate Cole On March 30, 2016, 11:20

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Sebastian Toader
> On March 29, 2016, 6:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 134-139 > > > > > > I don't see these being cleared

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/ --- (Updated márc. 30, 2016, 3:20 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
> On márc. 29, 2016, 4:58 du, Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java, > > line 65 > > > > > > Can these be bound by annotation? It would make it

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
> On márc. 29, 2016, 4:33 du, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 134-139 > > > > > > I don't see these being cleared

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
> On márc. 8, 2016, 5:05 du, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 801-816 > > > > > > A problem with this approach is

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/ --- (Updated márc. 30, 2016, 12:44 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review125890 ---

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review122532 --- This patch is way too big. It should have been split into