Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

> On May 13, 2016, 10:24 p.m., Richard Zang wrote: > > Ship It! > > Keta Patel wrote: > Thank you Richard! > Could you please help me push in the changes. Thank you Richard! Committed to Trunk: https://github.com/apache/ambari/commit/e306c393d05ea3d6c28f004a4528f522b5e771cf

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

> On May 13, 2016, 10:24 p.m., Richard Zang wrote: > > Ship It! Thank you Richard! Could you please help me push in the changes. - Keta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/#review133219 --- Ship it! Ship It! - Richard Zang On May 13, 2016, 5:29

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

> On May 12, 2016, 9:33 p.m., Richard Zang wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js, > > line 189 > > > > > > Please move hard-coded texts like

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 13, 2016, 5:29 p.m.) Review request for Ambari, Di Li and Richard

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/#review132985 ---

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 12, 2016, 7:57 p.m.) Review request for Ambari, Di Li and Richard

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

> On May 10, 2016, 10:28 p.m., Richard Zang wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js, > > line 181 > > > > > > loadUser() needs to be called

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 11, 2016, 10:08 p.m.) Review request for Ambari, Di Li and

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 11, 2016, 10:08 p.m.) Review request for Ambari, Di Li and

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

> On May 10, 2016, 10:28 p.m., Richard Zang wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js, > > line 162 > > > > > > effectivePrivilegeFromGroups has

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

> On May 10, 2016, 10:31 p.m., Richard Zang wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js, > > line 165 > > > > > > if user change permission to

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/#review132558 ---

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/#review132555 ---

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 10, 2016, 7:49 p.m.) Review request for Ambari, Di Li and Richard

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

> On May 9, 2016, 9:42 p.m., Richard Zang wrote: > > File Attachment: AMBARI-15552-May-05.patch - AMBARI-15552-May-05.patch > > > > > > Coding style needs to be fixed(many places). Also, could you please > > attach the latest patch to JIRA

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 10, 2016, 7:48 p.m.) Review request for Ambari, Di Li and Richard

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/#review132335 --- File Attachment: AMBARI-15552-May-05.patch -

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

> On May 5, 2016, 12:57 a.m., Richard Zang wrote: > > After applying the patch. > > Created a group "mygroup", assigned role "Cluster User" to this group. > > Created user "aaa", "bbb", "ccc" and assigned all users to "mygroup" > > Changed user "aaa"'s role to Cluster Administrator. (Success) >

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

> On May 5, 2016, 12:57 a.m., Richard Zang wrote: > > After applying the patch. > > Created a group "mygroup", assigned role "Cluster User" to this group. > > Created user "aaa", "bbb", "ccc" and assigned all users to "mygroup" > > Changed user "aaa"'s role to Cluster Administrator. (Success) >

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 5, 2016, 5:59 p.m.) Review request for Ambari, Di Li and Richard

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/#review131336 ---

Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- Review request for Ambari, Di Li and Richard Zang. Bugs: AMBARI-15552