Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

2016-05-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/#review133070 --- Ship it! Ship It! - Robert Levas On May 9, 2016, 5:56 a.m.,

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

2016-05-12 Thread Gautam Borad
> On May 13, 2016, 4 a.m., Mahadev Konar wrote: > > Please add unit tests in a new jira asap! Thanks Mahadev. Create https://issues.apache.org/jira/browse/AMBARI-16650 for the unit test cases. Thanks. - Gautam --- This is an

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

2016-05-12 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/#review133026 --- Ship it! Please add unit tests in a new jira asap! - Mahadev

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

2016-05-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/#review132286 --- There should be python tests to cover the new code paths. - Nate