Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review138862 --- Ship it! Ship It! - Jayush Luniya On June 20, 2016, 4:18

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review138682 --- Ship it! Pushed to trunk, commit

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-20 Thread Tim Thorpe
> On June 15, 2016, 8:21 p.m., Alejandro Fernandez wrote: > > Tim, let me know if you want me to commit this to trunk. Can you commit the latest patch that fixes the UpgradeCatalog240Test issue both to trunk and 2.4? Thanks - Tim ---

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-17 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated June 17, 2016, 12:26 p.m.) Review request for Ambari, Alexander

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review137828 --- Ship it! Tim, let me know if you want me to commit this to

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-15 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated June 15, 2016, 2:08 p.m.) Review request for Ambari, Alexander

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-14 Thread Alejandro Fernandez
> On June 3, 2016, 9:46 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 32 > > > > > > Let's be consistent with the name, UQ_* > > Tim Thorpe wrote: > Just

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-14 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated June 14, 2016, 9:09 p.m.) Review request for Ambari, Alexander

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-14 Thread Tim Thorpe
> On June 3, 2016, 9:46 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 32 > > > > > > Let's be consistent with the name, UQ_* Just noting that the code was

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-14 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated June 14, 2016, 7:05 p.m.) Review request for Ambari, Alexander

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-14 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated June 14, 2016, 5:47 p.m.) Review request for Ambari, Alexander

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review136105 --- This is a fairly big patch and I'm surprised more people haven't

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Tim Thorpe
> On June 3, 2016, 6:29 p.m., Alejandro Fernandez wrote: > > A lof of files have changed, please give me 24 hours to go over this. Thank > > you The patch really hasn't changed all that much in the past week or so. I did add the Upgrade240 changes to add the 2 new DB tables when upgrading to

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review136089 --- A lof of files have changed, please give me 24 hours to go over

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated June 3, 2016, 4:54 p.m.) Review request for Ambari, Alexander

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-05-27 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated May 27, 2016, 3:21 p.m.) Review request for Ambari, Alexander

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-05-27 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated May 27, 2016, 2:25 p.m.) Review request for Ambari, Alexander

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-05-27 Thread Tim Thorpe
> On May 23, 2016, 10:49 a.m., Alexander Denissov wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Extension.java, > > line 305 > > > > > > a lot of commented out code here I

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-05-23 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review134330 ---