----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47669/ -----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jayush Luniya. Bugs: AMBARI-16362 https://issues.apache.org/jira/browse/AMBARI-16362 Repository: ambari Description ------- Several import check_process_status were missed in previous cleanUp commits Diffs ----- ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py c045a91 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py 8735b2d ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_monitor.py 26f96c7 ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_server.py 246b1d9 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py f63886e ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 3376ac9 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 3421053 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 091997e ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 08cb722 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_server.py 7fe02ab Diff: https://reviews.apache.org/r/47669/diff/ Testing ------- Thanks to Alejandro comment on AMBARI-16362, several import check_process_status missing were found. Traceback (most recent call last): File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py", line 151, in <module> SNameNode().execute() File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 254, in execute method(env) File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 665, in restart self.status(env) File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py", line 61, in status snamenode(action="status") File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk return fn(*args, **kwargs) File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py", line 52, in snamenode check_process_status(status_params.snamenode_pid_file) NameError: global name 'check_process_status' is not defined It was not captured on the UTs, fresh installation and service_check tests Thanks, Juanjo Marron